78089 2012-02-08 01:39:13 -0800 Remove [CustomHeader] from CanvasPixelArray and rename [CustomHeader] to [JSCustomHeader] 2012-02-08 15:15:06 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 77393 1 haraken haraken abarth darin japhet ojan webkit.review.bot oldest_to_newest 551887 0 haraken 2012-02-08 01:39:13 -0800 We can remove [CustomHeader] from CanvasPixelArray.idl, since CanvasPixelArrayCustom.h does not exist. (The reason why missing CanvasPixelArrayCustom.h has not caused build failure is that [CustomHeader] has been JSC-specific and JSC has not enabled CanvasPixelArray.) Also, we can rename [CustomHeader] to [JSCustomHeader], since whether a given class should have custom header or not will depend on JavaScript bindings. 551888 1 126027 haraken 2012-02-08 01:41:59 -0800 Created attachment 126027 Patch 552531 2 126027 webkit.review.bot 2012-02-08 15:15:01 -0800 Comment on attachment 126027 Patch Clearing flags on attachment: 126027 Committed r107137: <http://trac.webkit.org/changeset/107137> 552532 3 webkit.review.bot 2012-02-08 15:15:06 -0800 All reviewed patches have been landed. Closing bug. 126027 2012-02-08 01:41:59 -0800 2012-02-08 15:15:01 -0800 Patch bug-78089-20120208184158.patch text/plain 3730 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3MDUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2MzZmE3OGFhNjIyMTQx Nzg4YTBjZGQxNmNjYjRhZTFkYzEwMDk0MC4uYTQ4YmI3Mjg4MWJiYTg5YzRhNzJhOGViYTA3MDQw OTM1N2NjNGE3NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI1IEBACiAyMDEyLTAyLTA4ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBSZW1vdmUgW0N1c3Rv bUhlYWRlcl0gZnJvbSBDYW52YXNQaXhlbEFycmF5IGFuZCByZW5hbWUgW0N1c3RvbUhlYWRlcl0g dG8gW0pTQ3VzdG9tSGVhZGVyXQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NzgwODkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBUaGlzIHBhdGNoIHJlbW92ZXMgW0N1c3RvbUhlYWRlcl0gZnJvbSBDYW52YXNQ aXhlbEFycmF5LmlkbCwgc2luY2UgQ2FudmFzUGl4ZWxBcnJheUN1c3RvbS5oCisgICAgICAgIGRv ZXMgbm90IGV4aXN0LiAoVGhlIHJlYXNvbiB3aHkgbWlzc2luZyBDYW52YXNQaXhlbEFycmF5Q3Vz dG9tLmggaGFzIG5vdCBjYXVzZWQgYnVpbGQgZmFpbHVyZQorICAgICAgICBpcyB0aGF0IFtDdXN0 b21IZWFkZXJdIGhhcyBiZWVuIEpTQy1zcGVjaWZpYyBhbmQgSlNDIGhhcyBub3QgZW5hYmxlZCBD YW52YXNQaXhlbEFycmF5LikKKyAgICAgICAgQWxzbywgdGhpcyBwYXRjaCByZW5hbWVzIFtDdXN0 b21IZWFkZXJdIHRvIFtKU0N1c3RvbUhlYWRlcl0sIHNpbmNlIHdoZXRoZXIgYSBnaXZlbiBjbGFz cworICAgICAgICBzaG91bGQgaGF2ZSBjdXN0b20gaGVhZGVyIG9yIG5vdCB3aWxsIGRlcGVuZCBv biBKYXZhU2NyaXB0IGJpbmRpbmdzLgorCisgICAgICAgIE5vIHRlc3RzLiBObyBjaGFuZ2UgaW4g YmVoYXZpb3IuCisKKyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5w bToKKyAgICAgICAgKEdlbmVyYXRlSGVhZGVyKToKKyAgICAgICAgKiBkb20vTm9kZS5pZGw6Cisg ICAgICAgICogaHRtbC9jYW52YXMvQ2FudmFzUGl4ZWxBcnJheS5pZGw6CisKKzIwMTItMDItMDgg IEtlbnRhcm8gSGFyYSAgPGhhcmFrZW5AY2hyb21pdW0ub3JnPgorCiAgICAgICAgIFJlbmFtZSBb RGVsZWdhdGluZ1B1dEZ1bmN0aW9uXSBJREwgdG8gW0N1c3RvbU5hbWVkU2V0dGVyXSBJREwKICAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc3OTYzCiAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpT LnBtIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG0K aW5kZXggNTA1MmYxM2I3ZWJhOWE2OWZlYTNmNDk4Y2FjZDkxNmM0ZWQ0ZmNmYy4uNTQ5OTI0Njll MzI5MDM2OGVkMzU1ZTljNDE2ZWQ5MmY3MzI1ZGJjMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG0KKysrIGIvU291cmNlL1dlYkNv cmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG0KQEAgLTc0OSw5ICs3NDksOSBA QCBzdWIgR2VuZXJhdGVIZWFkZXIKICAgICAjIFByb3RvdHlwZQogICAgIHB1c2goQGhlYWRlckNv bnRlbnQsICIgICAgc3RhdGljIEpTQzo6SlNPYmplY3QqIGNyZWF0ZVByb3RvdHlwZShKU0M6OkV4 ZWNTdGF0ZSosIEpTQzo6SlNHbG9iYWxPYmplY3QqKTtcbiIpIHVubGVzcyAoJGRhdGFOb2RlLT5l eHRlbmRlZEF0dHJpYnV0ZXMtPnsiRXh0ZW5kc0RPTUdsb2JhbE9iamVjdCJ9KTsKIAotICAgICRo ZWFkZXJUcmFpbGluZ0luY2x1ZGVzeyIke2NsYXNzTmFtZX1DdXN0b20uaCJ9ID0gMSBpZiAkZGF0 YU5vZGUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJDdXN0b21IZWFkZXIifTsKKyAgICAkaGVhZGVy VHJhaWxpbmdJbmNsdWRlc3siJHtjbGFzc05hbWV9Q3VzdG9tLmgifSA9IDEgaWYgJGRhdGFOb2Rl LT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsiSlNDdXN0b21IZWFkZXIifTsKIAotICAgICRpbXBsSW5j bHVkZXN7IiR7Y2xhc3NOYW1lfUN1c3RvbS5oIn0gPSAxIGlmICEkZGF0YU5vZGUtPmV4dGVuZGVk QXR0cmlidXRlcy0+eyJDdXN0b21IZWFkZXIifSAmJiAoJGRhdGFOb2RlLT5leHRlbmRlZEF0dHJp YnV0ZXMtPnsiQ3VzdG9tUHV0RnVuY3Rpb24ifSB8fCAkZGF0YU5vZGUtPmV4dGVuZGVkQXR0cmli dXRlcy0+eyJDdXN0b21OYW1lZFNldHRlciJ9KTsKKyAgICAkaW1wbEluY2x1ZGVzeyIke2NsYXNz TmFtZX1DdXN0b20uaCJ9ID0gMSBpZiAhJGRhdGFOb2RlLT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsi SlNDdXN0b21IZWFkZXIifSAmJiAoJGRhdGFOb2RlLT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsiQ3Vz dG9tUHV0RnVuY3Rpb24ifSB8fCAkZGF0YU5vZGUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJDdXN0 b21OYW1lZFNldHRlciJ9KTsKIAogICAgIG15ICRoYXNHZXR0ZXIgPSAkbnVtQXR0cmlidXRlcyA+ IDAKICAgICAgICAgICAgICAgICAgfHwgISRkYXRhTm9kZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57 Ik9taXRDb25zdHJ1Y3RvciJ9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vTm9kZS5p ZGwgYi9Tb3VyY2UvV2ViQ29yZS9kb20vTm9kZS5pZGwKaW5kZXggNjIxYjRlYjMwNDQ5YmE0ZDZh MGQ5N2Q2ZWEwMzZmNThjNzg0MTIzNy4uYjY3YmU2OGI0NWQ2YTViNWRkODliYTZiMWQwMGI3N2Nh Zjk0NTUyNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL05vZGUuaWRsCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2RvbS9Ob2RlLmlkbApAQCAtMjEsNyArMjEsNyBAQAogbW9kdWxlIGNvcmUg ewogCiAgICAgaW50ZXJmYWNlIFsKLSAgICAgICAgQ3VzdG9tSGVhZGVyLAorICAgICAgICBKU0N1 c3RvbUhlYWRlciwKICAgICAgICAgSlNDdXN0b21NYXJrRnVuY3Rpb24sCiAgICAgICAgIEpTQ3Vz dG9tUHVzaEV2ZW50SGFuZGxlclNjb3BlLAogICAgICAgICBKU0N1c3RvbUlzUmVhY2hhYmxlLApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvQ2FudmFzUGl4ZWxBcnJheS5p ZGwgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNQaXhlbEFycmF5LmlkbAppbmRl eCAzMTliZDJkNDgzMTNmZTM4OGQ0MTYyNmRmM2NhNzEwZjQwNTIzNjMxLi5iNmU0YTJlNTAyYmZm OGMyOTg5YjUzZTgzOWI1MmU3YWM0YmEwMWMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9o dG1sL2NhbnZhcy9DYW52YXNQaXhlbEFycmF5LmlkbAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1s L2NhbnZhcy9DYW52YXNQaXhlbEFycmF5LmlkbApAQCAtMzAsNyArMzAsNiBAQCBtb2R1bGUgaHRt bCB7CiAjaWYgIWRlZmluZWQoTEFOR1VBR0VfSkFWQVNDUklQVCkgfHwgIUxBTkdVQUdFX0pBVkFT Q1JJUFQgfHwgZGVmaW5lZChWOF9CSU5ESU5HKSAmJiBWOF9CSU5ESU5HCiAgICAgaW50ZXJmYWNl IFsKICAgICAgICAgT21pdENvbnN0cnVjdG9yLAotICAgICAgICBDdXN0b21IZWFkZXIsCiAgICAg ICAgIEhhc051bWVyaWNJbmRleEdldHRlciwKICAgICAgICAgQ3VzdG9tSW5kZXhlZFNldHRlcgog ICAgIF0gQ2FudmFzUGl4ZWxBcnJheSB7Cg==