78087 2012-02-08 01:26:57 -0800 Enable the 'resolution' media query by default 2022-05-26 09:52:13 -0700 1 1 1 Unclassified WebKit CSS WebKit Nightly Build All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=100137 BrowserCompat, InRadar P2 Normal --- 99077 100231 100382 229776 229777 236734 93304 16832 1 simon.fraser gsnedders adele alexander.shalamov ap astorino.design bfulgham commit-queue dino eoconnor eric gsnedders jicheu kenneth matthew.wade nicolas rik sh4.seo simon.fraser spamfaenger syoichi vertigoback webkit-bug-importer webkit zalan oldest_to_newest 551881 0 simon.fraser 2012-02-08 01:26:57 -0800 Need to implement http://dev.w3.org/csswg/css3-mediaqueries/#resolution0 See FIXME in MediaQueryEvaluator.cpp: FIXME: following media features are not implemented: color_index, scan, resolution 551883 1 simon.fraser 2012-02-08 01:28:11 -0800 This should do the right thing when printing too (report printer output resolution). 551889 2 simon.fraser 2012-02-08 01:43:21 -0800 Also need to match what other browsers do when pageScale changes. 552365 3 webkit-bug-importer 2012-02-08 12:03:32 -0800 <rdar://problem/10829378> 604002 4 eric 2012-04-17 07:14:09 -0700 If you want a quick initial test, http://meyerweb.com/eric/css/tests/mq-valueless.html includes valueless, iPhone 4S value (I think), and min/max queries. See test 11. If not, no harm done. 658694 5 eoconnor 2012-06-27 10:20:59 -0700 General comment: It's not clear to me why we would implement the resolution media query, considering how broken it is. Eric, that isn't the correct iPhone 4S value per the spec, because the CSS dpi unit is "physical pixels per CSS inch" and a CSS inch is 96 CSS pixels. So "resolution: 192dpi" should match on an iPhone 4S. 659164 6 sh4.seo 2012-06-27 21:46:32 -0700 How does this relate to bug 85262? 659176 7 simon.fraser 2012-06-27 21:59:37 -0700 (In reply to comment #6) > How does this relate to bug 85262? That is about a new CSS property based on the resolution of image resources. This is about a media query based on screen resolution. 748751 8 adele 2012-10-23 10:01:19 -0700 Should we dupe this to https://bugs.webkit.org/show_bug.cgi?id=99077? 748757 9 kenneth 2012-10-23 10:05:06 -0700 (In reply to comment #8) > Should we dupe this to https://bugs.webkit.org/show_bug.cgi?id=99077? It still need some special handling when printing as smfr pointed out, but maybe that is another bug 749565 10 kenneth 2012-10-24 05:12:04 -0700 (In reply to comment #2) > Also need to match what other browsers do when pageScale changes. According to https://bugzilla.mozilla.org/show_bug.cgi?id=662061 zooming ( and I assume pageScale) should not affect the resolution values. It currently does in Firefox 16, at least full page zoom, though not text size zoom. 926889 11 simon.fraser 2013-09-09 14:04:01 -0700 Support for the 'resolution' media query was added behind ENABLE(RESOLUTION_MEDIA_QUERY) via bug 99077. 1055467 12 vertigoback 2014-12-13 20:26:10 -0800 Are there any plans to enable it by default any time soon? Once dppx support lands in IE (it's currently in preview built) all other major browser have added full support. http://dabblet.com/gist/7166616 https://status.modern.ie/dppxunitfortheresolutionmediaquery?term=dppx 1130708 13 webkit 2015-10-05 12:39:13 -0700 MS Edge has shipped this (see http://caniuse.com/#feat=css-media-resolution ), so now only WebKit doesn't support this. 1674317 14 astorino.design 2020-07-23 12:22:19 -0700 This bug was filed 8 years ago, even IE 9 supports this important media query. What happened here? 😕 1786974 15 bfulgham 2021-08-24 15:43:36 -0700 (In reply to Mattia Astorino from comment #14) > This bug was filed 8 years ago, even IE 9 supports this important media > query. What happened here? 😕 The media query has existed in WebKit since 2012. It looks like some details specific to printing were not completed @Mattia: What issues have you had when you used the 'resolution' media query in Webkit? Were you attempting printing? 1787022 16 bfulgham 2021-08-24 17:22:26 -0700 (In reply to Brent Fulgham from comment #15) > (In reply to Mattia Astorino from comment #14) > > This bug was filed 8 years ago, even IE 9 supports this important media > > query. What happened here? 😕 > > The media query has existed in WebKit since 2012. It looks like some details > specific to printing were not completed > > @Mattia: What issues have you had when you used the 'resolution' media query > in Webkit? Were you attempting printing? I see - it's present but apparently not enabled by default? I'm trying to see what the correct state of this flag should be. 1787103 17 gsnedders 2021-08-25 00:35:19 -0700 (In reply to Brent Fulgham from comment #16) > (In reply to Brent Fulgham from comment #15) > > (In reply to Mattia Astorino from comment #14) > > > This bug was filed 8 years ago, even IE 9 supports this important media > > > query. What happened here? 😕 > > > > The media query has existed in WebKit since 2012. It looks like some details > > specific to printing were not completed > > > > @Mattia: What issues have you had when you used the 'resolution' media query > > in Webkit? Were you attempting printing? > > I see - it's present but apparently not enabled by default? I'm trying to > see what the correct state of this flag should be. Correct; ENABLE_RESOLUTION_MEDIA_QUERY is not defined for any current port, as far as I can tell (and that's likely been the case since the Blink fork). It doesn't look like there's anything too likely to have bitrotted or is missing there, at least. (In reply to Theresa O'Connor from comment #5) > General comment: It's not clear to me why we would implement the resolution > media query, considering how broken it is. The thread starting at https://lists.w3.org/Archives/Public/www-style/2012Apr/0674.html is about this brokenness, and summarised in Maciej's response in https://lists.w3.org/Archives/Public/www-style/2012Apr/0747.html: > For comparison, device-pixel-ratio was first implemented as a vendor extension in 2006[1] and exists (prefixed) in at least WebKit, Presto and Gecko. So I wondered why device-pixel-ratio counts as "add[ing] anything new" but the [first defined in late 2011/early 2012] dppx unit does not. I don't follow closely, so maybe there is some reason for diverging from content and implementations here. Regardless, while it might be the case that resolution: [n]dppx (and the other <resolution> units, aside from dppx, are confusing) is redundant with -webkit-device-pixel-ratio: n (which is itself now standardised in https://compat.spec.whatwg.org/#css-media-queries-webkit-device-pixel-ratio), I think it's pretty clear the ship here has sailed. 1822795 18 446755 gsnedders 2021-12-10 10:33:48 -0800 Created attachment 446755 Patch 1822959 19 ews-feeder 2021-12-10 13:57:34 -0800 Committed r286874 (245104@main): <https://commits.webkit.org/245104@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 446755. 1842531 20 commit-queue 2022-02-16 14:37:49 -0800 Re-opened since this is blocked by bug 236734 1843370 21 gsnedders 2022-02-18 05:50:02 -0800 bug 236804 reverted the revert; this shouldn't have been reverted on trunk for that breakage 1871754 22 matthew.wade 2022-05-25 09:58:28 -0700 I'm having trouble understanding the recent commits / reverts on this. Is there an intent to *enable* the 'resolution' media query by default in Webkit (Safari)? Or when we say "that ship has sailed," are we saying that Safari will continue to *not* support the 'resolution' media query in lieu of the '-webkit-device-pixel-ratio' feature? 1871780 23 gsnedders 2022-05-25 11:03:28 -0700 (In reply to matthew.wade from comment #22) > I'm having trouble understanding the recent commits / reverts on this. > > Is there an intent to *enable* the 'resolution' media query by default in > Webkit (Safari)? > > Or when we say "that ship has sailed," are we saying that Safari will > continue to *not* support the 'resolution' media query in lieu of the > '-webkit-device-pixel-ratio' feature? It is enabled by default, and has been on trunk since December. It was disabled on one Safari release branch (and, inadvertently also on trunk briefly) due to site breakage caused by enabling it (mostly sites using `@media not all and (min-resolution:.001dpcm)` to specifically target WebKit, which inevitably stops matching with support for the resolution feature). As for Safari, Apple does not comment on future releases. 1872028 24 matthew.wade 2022-05-26 09:52:13 -0700 (In reply to Sam Sneddon [:gsnedders] from comment #23) > (In reply to matthew.wade from comment #22) > > I'm having trouble understanding the recent commits / reverts on this. > > > > Is there an intent to *enable* the 'resolution' media query by default in > > Webkit (Safari)? > > > > Or when we say "that ship has sailed," are we saying that Safari will > > continue to *not* support the 'resolution' media query in lieu of the > > '-webkit-device-pixel-ratio' feature? > > It is enabled by default, and has been on trunk since December. It was > disabled on one Safari release branch (and, inadvertently also on trunk > briefly) due to site breakage caused by enabling it (mostly sites using > `@media not all and (min-resolution:.001dpcm)` to specifically target > WebKit, which inevitably stops matching with support for the resolution > feature). > > As for Safari, Apple does not comment on future releases. Thanks, this is very helpful! Also, you practically read my mind with the `@media not all and (min-resolution: .001dpcm)` hack, I was essentially asking how "safe" that is to continue using as a way to detect Safari. Based on all this, my guess is the answer is basically "it still works in the latest Safari, but could stop working at any time." I didn't realize the split between Webkit and how Apple uses it in Safari releases, so thanks for that context as well. 446755 2021-12-10 10:33:48 -0800 2021-12-10 13:57:40 -0800 Patch bug-78087-20211210183346.patch text/plain 1497 gsnedders U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2ODU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDc0NTdlMTkzOGE0YWMwMjJkM2VmZDBh OTllYTFhYjY5ZjkyYTYwNWEuLjNkNGNlM2ViNjJlZTMxZmM2N2Q4NTAyYmQyMDE3ZWEzZGYyYTdi N2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMjEtMTItMTAgIFNhbSBTbmVkZG9uICA8Z3NuZWRk ZXJzQGFwcGxlLmNvbT4KKworICAgICAgICBFbmFibGUgdGhlICdyZXNvbHV0aW9uJyBtZWRpYSBx dWVyeSBieSBkZWZhdWx0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD03ODA4NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogU2NyaXB0cy9QcmVmZXJlbmNlcy9XZWJQcmVmZXJlbmNlc0V4cGVyaW1lbnRhbC55 YW1sOgorCiAyMDIxLTEyLTEwICBLZWl0aCBNaWxsZXIgIDxrZWl0aF9taWxsZXJAYXBwbGUuY29t PgogCiAgICAgICAgIFJlZHVjZSBtYXhpbXVtIG1tYXAgc2l6ZSBmb3IgU3RydWN0dXJlIHJlZ2lv bnMgdG8gaGVscCBwbGFjYXRlIGlvcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi9TY3JpcHRzL1By ZWZlcmVuY2VzL1dlYlByZWZlcmVuY2VzRXhwZXJpbWVudGFsLnlhbWwgYi9Tb3VyY2UvV1RGL1Nj cmlwdHMvUHJlZmVyZW5jZXMvV2ViUHJlZmVyZW5jZXNFeHBlcmltZW50YWwueWFtbAppbmRleCA5 ZTI3NGExYTQ2Y2NjMTY0MmFmM2JmMzNhYjExZDg2YTEzMTExODE0Li45Yzc5ZmY3NTMxMmMwOWE0 YzRiZGFmYzQzZGUwYmI5MjIzNTY0Y2ZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL1NjcmlwdHMv UHJlZmVyZW5jZXMvV2ViUHJlZmVyZW5jZXNFeHBlcmltZW50YWwueWFtbAorKysgYi9Tb3VyY2Uv V1RGL1NjcmlwdHMvUHJlZmVyZW5jZXMvV2ViUHJlZmVyZW5jZXNFeHBlcmltZW50YWwueWFtbApA QCAtMTIxMywxMSArMTIxMywxMSBAQCBSZXNvbHV0aW9uTWVkaWFGZWF0dXJlRW5hYmxlZDoKICAg aHVtYW5SZWFkYWJsZURlc2NyaXB0aW9uOiAiRW5hYmxlIHJlc29sdXRpb24gbWVkaWEgZmVhdHVy ZSBzdXBwb3J0IgogICBkZWZhdWx0VmFsdWU6CiAgICAgV2ViS2l0TGVnYWN5OgotICAgICAgZGVm YXVsdDogZmFsc2UKKyAgICAgIGRlZmF1bHQ6IHRydWUKICAgICBXZWJLaXQ6Ci0gICAgICBkZWZh dWx0OiBmYWxzZQorICAgICAgZGVmYXVsdDogdHJ1ZQogICAgIFdlYkNvcmU6Ci0gICAgICBkZWZh dWx0OiBmYWxzZQorICAgICAgZGVmYXVsdDogdHJ1ZQogCiAjIEZJWE1FOiBJcyB0aGlzIGltcGxl bWVudGVkIGZvciBXZWJLaXRMZWdhY3k/IElmIG5vdCwgdGhpcyBzaG91bGQgYmUgZXhjbHVkZWQg ZnJvbSBXZWJLaXRMZWdhY3kgZW50aXJlbHkuCiAjIEZJWE1FOiBUaGlzIHNob3VsZCBoYXZlIGl0 J3Mgb3duIEVOQUJMRS4K