78068 2012-02-07 18:56:32 -0800 REGRESSION(r106668-r106889): Chromium page cycler tests (Intl2) performance regressions 2012-02-09 09:59:27 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa webkit-unassigned cmarcelo davidbarr jchaffraix kling koivisto ossy tonyg oldest_to_newest 551690 0 rniwa 2012-02-07 18:56:32 -0800 Chromium page cycler Intl2 tests regressed in http://src.chromium.org/viewvc/chrome?view=rev&revision=120693 (second bump): http://build.chromium.org/f/chromium/perf/xp-release-dual-core/intl2/report.html?history=150&rev=-1 The WebKit regression range is: http://trac.webkit.org/log/?rev=106889&stop_rev=106668&verbose=on 551705 1 125986 kling 2012-02-07 19:17:12 -0800 Created attachment 125986 Government cover-up of regression in r106756 551712 2 125986 kling 2012-02-07 19:26:25 -0800 Comment on attachment 125986 Government cover-up of regression in r106756 Clearing flags on attachment: 125986 Committed r107029: <http://trac.webkit.org/changeset/107029> 551842 3 126020 rniwa 2012-02-07 23:50:50 -0800 Created attachment 126020 Instrument result on mac Here's instrument result in the case this patch didn't fix the regression. 551859 4 ossy 2012-02-08 00:45:44 -0800 (In reply to comment #2) > (From update of attachment 125986 [details]) > Clearing flags on attachment: 125986 > > Committed r107029: <http://trac.webkit.org/changeset/107029> It broke 5 tests on GTK, Qt and SL and maybe on other platforms too: --- /home/webkitbuildbot/slaves/release32bit-NRWT/buildslave/qt-linux-32-release-NRWT/build/layout-test-results/fast/dom/HTMLElement/set-false-expected.txt +++ /home/webkitbuildbot/slaves/release32bit-NRWT/buildslave/qt-linux-32-release-NRWT/build/layout-test-results/fast/dom/HTMLElement/set-false-actual.txt @@ -8,8 +8,8 @@ PASS document.getElementById("div1").isContentEditable is false PASS window.getComputedStyle(div1, "").getPropertyValue("-webkit-user-modify") is "read-only" PASS document.getElementById("p2").contentEditable is "false" -PASS document.getElementById("p2").isContentEditable is false -PASS window.getComputedStyle(p2, "").getPropertyValue("-webkit-user-modify") is "read-only" +FAIL document.getElementById("p2").isContentEditable should be false. Was true. +FAIL window.getComputedStyle(p2, "").getPropertyValue("-webkit-user-modify") should be read-only. Was read-write. PASS successfullyParsed is true TEST COMPLETE --- /home/webkitbuildbot/slaves/release32bit-NRWT/buildslave/qt-linux-32-release-NRWT/build/layout-test-results/fast/dom/HTMLElement/set-true-expected.txt +++ /home/webkitbuildbot/slaves/release32bit-NRWT/buildslave/qt-linux-32-release-NRWT/build/layout-test-results/fast/dom/HTMLElement/set-true-actual.txt @@ -5,13 +5,13 @@ PASS document.getElementById("div1").getAttribute("contentEditable") is "true" PASS document.getElementById("div1").contentEditable is "true" -PASS document.getElementById("div1").isContentEditable is true +FAIL document.getElementById("div1").isContentEditable should be true. Was false. FIXME: setContentEditable with true/false/inherit string is not working properly. https://bugs.webkit.org/show_bug.cgi?id=52058 -PASS window.getComputedStyle(div1, "").getPropertyValue("-webkit-user-modify") is "read-write" +FAIL window.getComputedStyle(div1, "").getPropertyValue("-webkit-user-modify") should be read-write. Was read-only. PASS document.getElementById("p2").getAttribute("contentEditable") is "true" PASS document.getElementById("p2").contentEditable is "true" -PASS document.getElementById("p2").isContentEditable is true -PASS window.getComputedStyle(p2, "").getPropertyValue("-webkit-user-modify") is "read-write" +FAIL document.getElementById("p2").isContentEditable should be true. Was false. +FAIL window.getComputedStyle(p2, "").getPropertyValue("-webkit-user-modify") should be read-write. Was read-only. PASS successfullyParsed is true TEST COMPLETE --- /home/webkitbuildbot/slaves/release32bit-NRWT/buildslave/qt-linux-32-release-NRWT/build/layout-test-results/fast/dom/HTMLElement/set-value-caseinsensitive-expected.txt +++ /home/webkitbuildbot/slaves/release32bit-NRWT/buildslave/qt-linux-32-release-NRWT/build/layout-test-results/fast/dom/HTMLElement/set-value-caseinsensitive-actual.txt @@ -5,9 +5,9 @@ PASS document.getElementById("div1").getAttribute("contentEditable") is "true" PASS document.getElementById("div1").contentEditable is "true" -PASS document.getElementById("div1").isContentEditable is true +FAIL document.getElementById("div1").isContentEditable should be true. Was false. FIXME: isContentEditable is not working properly. Related to https://bugs.webkit.org/show_bug.cgi?id=52058 -PASS window.getComputedStyle(div1, "").getPropertyValue("-webkit-user-modify") is "read-write" +FAIL window.getComputedStyle(div1, "").getPropertyValue("-webkit-user-modify") should be read-write. Was read-only. PASS document.getElementById("p1").getAttribute("contentEditable") is "false" PASS document.getElementById("p1").contentEditable is "false" PASS document.getElementById("p1").isContentEditable is false @@ -19,11 +19,11 @@ PASS document.getElementById("div3").hasAttribute("contentEditable") is true PASS document.getElementById("div3").contentEditable is "plaintext-only" PASS document.getElementById("div3").isContentEditable is true -PASS window.getComputedStyle(div3, "").getPropertyValue("-webkit-user-modify") is "read-write-plaintext-only" +FAIL window.getComputedStyle(div3, "").getPropertyValue("-webkit-user-modify") should be read-write-plaintext-only. Was read-write. PASS document.getElementById("p3").hasAttribute("contentEditable") is false PASS document.getElementById("p3").contentEditable is "inherit" PASS document.getElementById("p3").isContentEditable is true -PASS window.getComputedStyle(p3, "").getPropertyValue("-webkit-user-modify") is "read-write-plaintext-only" +FAIL window.getComputedStyle(p3, "").getPropertyValue("-webkit-user-modify") should be read-write-plaintext-only. Was read-write. PASS successfullyParsed is true TEST COMPLETE --- /home/webkitbuildbot/slaves/release32bit-NRWT/buildslave/qt-linux-32-release-NRWT/build/layout-test-results/fast/html/hidden-attr-expected.txt +++ /home/webkitbuildbot/slaves/release32bit-NRWT/buildslave/qt-linux-32-release-NRWT/build/layout-test-results/fast/html/hidden-attr-actual.txt @@ -16,7 +16,7 @@ PASS getComputedStyle(test3, false).display is "block" PASS getComputedStyle(test4, false).display is "block" test4.setAttribute("hidden", "") -PASS getComputedStyle(test4, false).display is "none" +FAIL getComputedStyle(test4, false).display should be none. Was block. PASS successfullyParsed is true @@ -25,3 +25,4 @@ a +b --- /home/webkitbuildbot/slaves/release32bit-NRWT/buildslave/qt-linux-32-release-NRWT/build/layout-test-results/fast/forms/input-align-image-expected.txt +++ /home/webkitbuildbot/slaves/release32bit-NRWT/buildslave/qt-linux-32-release-NRWT/build/layout-test-results/fast/forms/input-align-image-actual.txt @@ -7,15 +7,16 @@ RenderText {#text} at (0,0) size 650x21 text run at (0,0) width 650: "The following 4 images should be all be rendered exactly the same, aligned to the right side." RenderImage {INPUT} at (767,37) size 17x19 - RenderBlock (anonymous) at (0,37) size 784x126 + RenderBlock (anonymous) at (0,37) size 784x129 RenderBR {BR} at (0,0) size 0x21 RenderBR {BR} at (0,21) size 0x21 RenderImage {INPUT} at (767,42) size 17x19 RenderBR {BR} at (0,42) size 0x21 RenderBR {BR} at (0,63) size 0x21 - RenderImage {INPUT} at (767,84) size 17x19 - RenderText {#text} at (0,0) size 0x0 - RenderBR {BR} at (0,84) size 0x21 - RenderBR {BR} at (0,105) size 0x21 - RenderBlock {DIV} at (0,163) size 784x0 + RenderImage {INPUT} at (0,84) size 17x19 + RenderText {#text} at (17,87) size 4x21 + text run at (17,87) width 4: " " + RenderBR {BR} at (0,0) size 0x0 + RenderBR {BR} at (0,108) size 0x21 + RenderBlock {DIV} at (0,166) size 784x0 RenderImage {INPUT} at (767,0) size 17x19 551863 5 rniwa 2012-02-08 00:54:28 -0800 That's because void setProperty(const CSSProperty&, CSSProperty* slot = 0); doesn't call setNeedsStyleRecalc unlike every other setProperty :( What a disaster but what a confusing behavior difference. I don't understand why this particular version has to behave differently. 551954 6 kling 2012-02-08 03:04:02 -0800 Committed r107061: <http://trac.webkit.org/changeset/107061> 553244 7 jchaffraix 2012-02-09 09:59:27 -0800 For the record, we are still not back to our baseline after the patch. The government managed to cover up half of the regression though! See 78070 that has more information about that. 125986 2012-02-07 19:17:12 -0800 2012-02-07 19:26:25 -0800 Government cover-up of regression in r106756 bug-78068.diff text/plain 1740 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkNmNjYWM2Li5lY2FkMjZjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTItMDItMDcgIEFuZHJlYXMgS2xpbmcgIDxhd2Vzb21la2xpbmdAYXBwbGUuY29tPgor CisgICAgICAgIFJFR1JFU1NJT04ocjEwNjY2OC1yMTA2ODg5KTogQ2hyb21pdW0gcGFnZSBjeWNs ZXIgdGVzdHMgKEludGwyKSBwZXJmb3JtYW5jZSByZWdyZXNzaW9ucy4KKyAgICAgICAgPGh0dHA6 Ly93ZWJraXQub3JnL2IvNzgwNjg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQ3JlYXRlIENTU19JREVOVCB2YWx1ZXMgZm9yIGF0dHJpYnV0ZSBzdHls ZXMgaW4gdGhlIGRvY3VtZW50J3MgQ1NTVmFsdWVQb29sLgorICAgICAgICBUaGlzIHJlZ3Jlc3Nl ZCBpbiByMTA2NzU2IGFuZCBJIHN1c3BlY3QgaXQnbGwgZml4IHVwIHRoZSBjeWNsZXIgcmVncmVz c2lvbi4KKworICAgICAgICAqIGRvbS9TdHlsZWRFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlN0eWxlZEVsZW1lbnQ6OmFkZENTU1Byb3BlcnR5KToKKwogMjAxMi0wMi0wNiAgSWx5YSBU aWtob25vdnNreSAgPGxvaXNsb0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZC4g V2ViIEluc3BlY3RvcjogcmVuYW1lIEFydGlmaWNpYWwgdG8gU3ludGhldGljIGFjY29yZGluZyB0 byB2OCBwYXRjaCByMTA2MTQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vU3R5bGVk RWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vU3R5bGVkRWxlbWVudC5jcHAKaW5kZXgg OTVjMmYxOC4uMjY5ZjNiZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL1N0eWxlZEVs ZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9TdHlsZWRFbGVtZW50LmNwcApAQCAt MjksNiArMjksNyBAQAogI2luY2x1ZGUgIkNTU1N0eWxlU2VsZWN0b3IuaCIKICNpbmNsdWRlICJD U1NTdHlsZVNoZWV0LmgiCiAjaW5jbHVkZSAiQ1NTVmFsdWVLZXl3b3Jkcy5oIgorI2luY2x1ZGUg IkNTU1ZhbHVlUG9vbC5oIgogI2luY2x1ZGUgIkNvbG9yLmgiCiAjaW5jbHVkZSAiQ2xhc3NMaXN0 LmgiCiAjaW5jbHVkZSAiQ29udGVudFNlY3VyaXR5UG9saWN5LmgiCkBAIC0xNDIsOSArMTQzLDkg QEAgdm9pZCBTdHlsZWRFbGVtZW50OjphZGRDU1NQcm9wZXJ0eShpbnQgaWQsIGNvbnN0IFN0cmlu ZyAmdmFsdWUpCiAgICAgICAgIHJlbW92ZUNTU1Byb3BlcnR5KGlkKTsKIH0KIAotdm9pZCBTdHls ZWRFbGVtZW50OjphZGRDU1NQcm9wZXJ0eShpbnQgaWQsIGludCB2YWx1ZSkKK3ZvaWQgU3R5bGVk RWxlbWVudDo6YWRkQ1NTUHJvcGVydHkoaW50IHByb3BlcnR5SUQsIGludCBpZGVudGlmaWVyKQog ewotICAgIGVuc3VyZUF0dHJpYnV0ZVN0eWxlKCktPnNldFByb3BlcnR5KGlkLCB2YWx1ZSk7Cisg ICAgZW5zdXJlQXR0cmlidXRlU3R5bGUoKS0+c2V0UHJvcGVydHkoQ1NTUHJvcGVydHkocHJvcGVy dHlJRCwgZG9jdW1lbnQoKS0+Y3NzVmFsdWVQb29sKCktPmNyZWF0ZUlkZW50aWZpZXJWYWx1ZShp ZGVudGlmaWVyKSkpOwogfQogCiB2b2lkIFN0eWxlZEVsZW1lbnQ6OmFkZENTU0ltYWdlUHJvcGVy dHkoaW50IGlkLCBjb25zdCBTdHJpbmcmIHVybCkK 126020 2012-02-07 23:50:50 -0800 2012-02-07 23:50:50 -0800 Instrument result on mac intl2mac.trace.zip application/octet-stream 0 rniwa