78061 2012-02-07 17:37:19 -0800 Plumb through webGLErrorsToConsoleEnable in WebSettings 2012-02-07 21:34:29 -0800 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 gman gman fishd kbr webkit.review.bot oldest_to_newest 551603 0 gman 2012-02-07 17:37:19 -0800 Plum through webGLErrorsToConsoleEnable in WebSettings 551608 1 125966 gman 2012-02-07 17:38:19 -0800 Created attachment 125966 Patch 551613 2 webkit.review.bot 2012-02-07 17:42:47 -0800 Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API. 551647 3 125966 kbr 2012-02-07 18:11:17 -0800 Comment on attachment 125966 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125966&action=review Looks fine to me. I can't imagine this being contentious and fishd's on vacation so I'm r+'ing it. > Source/WebKit/chromium/ChangeLog:3 > + Plum through webGLErrorsToConsoleEnable in WebSettings Minor nit: plum -> plumb everywhere. 551650 4 125973 gman 2012-02-07 18:16:11 -0800 Created attachment 125973 Patch 551651 5 125973 kbr 2012-02-07 18:17:32 -0800 Comment on attachment 125973 Patch Looks good. r=me again 551771 6 125973 webkit.review.bot 2012-02-07 21:34:25 -0800 Comment on attachment 125973 Patch Clearing flags on attachment: 125973 Committed r107037: <http://trac.webkit.org/changeset/107037> 551772 7 webkit.review.bot 2012-02-07 21:34:29 -0800 All reviewed patches have been landed. Closing bug. 125966 2012-02-07 17:38:19 -0800 2012-02-07 18:16:07 -0800 Patch bug-78061-20120207173818.patch text/plain 2998 gman U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3MDE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDhjYjhjNzZhOGMxMjg5YTk1YmZmZWViNGY0ZWQ1ZGY1MDc0NDdhOGUuLjkwYTBkNTY2ZjkwZWYw N2ZhNDE1OTA3MjMzNGZlMDlkODdiZTQzMjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTItMDItMDcgIEdyZWdnIFRhdmFyZXMgIDxnbWFuQGdvb2dsZS5j b20+CisKKyAgICAgICAgUGx1bSB0aHJvdWdoIHdlYkdMRXJyb3JzVG9Db25zb2xlRW5hYmxlIGlu IFdlYlNldHRpbmdzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD03ODA2MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogcHVibGljL1dlYlNldHRpbmdzLmg6CisgICAgICAgICogc3JjL1dlYlNldHRpbmdzSW1w bC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlNldHRpbmdzSW1wbDo6c2V0V2ViR0xFcnJvcnNU b0NvbnNvbGVFbmFibGVkKToKKyAgICAgICAgKFdlYktpdCk6CisgICAgICAgICogc3JjL1dlYlNl dHRpbmdzSW1wbC5oOgorICAgICAgICAoV2ViU2V0dGluZ3NJbXBsKToKKwogMjAxMi0wMi0wNyAg RGF2aWQgUmV2ZW1hbiAgPHJldmVtYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtDaHJvbWl1 bV0gUkVHUkVTU0lPTihyMTAxODU0KTogQ2F1c2luZyBsYXJnZSBhbW91bnRzIG9mIHVubmVjZXNz YXJ5IHJlcGFpbnRpbmcuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1Ymxp Yy9XZWJTZXR0aW5ncy5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViU2V0dGlu Z3MuaAppbmRleCBiNWRhNGU2YmE2NzhmZTI5ZDhhOGQ1OTk3ZDUxMmQ1NjI2YzhjYTliLi4yNWFj MDc1MjM5Njc4N2I2YWNhZDQzMWMzYjcxNjc2YWQyMDBmNDg2IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJTZXR0aW5ncy5oCisrKyBiL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vcHVibGljL1dlYlNldHRpbmdzLmgKQEAgLTk4LDYgKzk4LDcgQEAgcHVibGljOgog ICAgIHZpcnR1YWwgdm9pZCBzZXRFeHBlcmltZW50YWxXZWJHTEVuYWJsZWQoYm9vbCkgPSAwOwog ICAgIHZpcnR1YWwgdm9pZCBzZXRPcGVuR0xNdWx0aXNhbXBsaW5nRW5hYmxlZChib29sKSA9IDA7 CiAgICAgdmlydHVhbCB2b2lkIHNldFByaXZpbGVnZWRXZWJHTEV4dGVuc2lvbnNFbmFibGVkKGJv b2wpID0gMDsKKyAgICB2aXJ0dWFsIHZvaWQgc2V0V2ViR0xFcnJvcnNUb0NvbnNvbGVFbmFibGVk KGJvb2wpID0gMDsKICAgICB2aXJ0dWFsIHZvaWQgc2V0U2hvd0RlYnVnQm9yZGVycyhib29sKSA9 IDA7CiAgICAgdmlydHVhbCB2b2lkIHNldFNob3dGUFNDb3VudGVyKGJvb2wpID0gMDsKICAgICB2 aXJ0dWFsIGJvb2wgc2hvd0ZQU0NvdW50ZXIoKSBjb25zdCA9IDA7CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJTZXR0aW5nc0ltcGwuY3BwIGIvU291cmNlL1dlYktp dC9jaHJvbWl1bS9zcmMvV2ViU2V0dGluZ3NJbXBsLmNwcAppbmRleCAyNzIzY2E3OGJmNDcyZjVk NTdlZDQ2Y2UxZTZiZTgxNDA0MzNkYzJmLi4xMWU5YzMzN2IwN2EyMjBmMGJmMjE4ZWU2NTVjMDJm MTNkZDE2YjJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJTZXR0 aW5nc0ltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlNldHRpbmdz SW1wbC5jcHAKQEAgLTI5OCw2ICsyOTgsMTEgQEAgdm9pZCBXZWJTZXR0aW5nc0ltcGw6OnNldFBy aXZpbGVnZWRXZWJHTEV4dGVuc2lvbnNFbmFibGVkKGJvb2wgZW5hYmxlZCkKICAgICBtX3NldHRp bmdzLT5zZXRQcml2aWxlZ2VkV2ViR0xFeHRlbnNpb25zRW5hYmxlZChlbmFibGVkKTsKIH0KIAor dm9pZCBXZWJTZXR0aW5nc0ltcGw6OnNldFdlYkdMRXJyb3JzVG9Db25zb2xlRW5hYmxlZChib29s IGVuYWJsZWQpCit7CisgICAgbV9zZXR0aW5ncy0+c2V0V2ViR0xFcnJvcnNUb0NvbnNvbGVFbmFi bGVkKGVuYWJsZWQpOworfQorCiB2b2lkIFdlYlNldHRpbmdzSW1wbDo6c2V0U2hvd0RlYnVnQm9y ZGVycyhib29sIHNob3cpCiB7CiAgICAgbV9zZXR0aW5ncy0+c2V0U2hvd0RlYnVnQm9yZGVycyhz aG93KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlNldHRpbmdz SW1wbC5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViU2V0dGluZ3NJbXBsLmgKaW5k ZXggNjNhMDBhMDk5OWUzMmQwOTRjYzc4NWRhNThmNWY1NWFmYTJhMGE0My4uNDVlNjJkYjZmYmUy MGNjNTdjMGYxN2U4NTg3YTZmYjA5ZjY1MTNlOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9j aHJvbWl1bS9zcmMvV2ViU2V0dGluZ3NJbXBsLmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1 bS9zcmMvV2ViU2V0dGluZ3NJbXBsLmgKQEAgLTkwLDYgKzkwLDcgQEAgcHVibGljOgogICAgIHZp cnR1YWwgdm9pZCBzZXRFeHBlcmltZW50YWxXZWJHTEVuYWJsZWQoYm9vbCk7CiAgICAgdmlydHVh bCB2b2lkIHNldE9wZW5HTE11bHRpc2FtcGxpbmdFbmFibGVkKGJvb2wpOwogICAgIHZpcnR1YWwg dm9pZCBzZXRQcml2aWxlZ2VkV2ViR0xFeHRlbnNpb25zRW5hYmxlZChib29sKTsKKyAgICB2aXJ0 dWFsIHZvaWQgc2V0V2ViR0xFcnJvcnNUb0NvbnNvbGVFbmFibGVkKGJvb2wpOwogICAgIHZpcnR1 YWwgdm9pZCBzZXRTaG93RGVidWdCb3JkZXJzKGJvb2wpOwogICAgIHZpcnR1YWwgdm9pZCBzZXRT aG93RlBTQ291bnRlcihib29sKTsKICAgICB2aXJ0dWFsIGJvb2wgc2hvd0ZQU0NvdW50ZXIoKSBj b25zdCB7IHJldHVybiBtX3Nob3dGUFNDb3VudGVyOyB9Cg== 125973 2012-02-07 18:16:11 -0800 2012-02-07 21:34:25 -0800 Patch bug-78061-20120207181610.patch text/plain 2999 gman U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3MDE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDhjYjhjNzZhOGMxMjg5YTk1YmZmZWViNGY0ZWQ1ZGY1MDc0NDdhOGUuLjA0MzZhZGU3YWRmZWRh OWNjNWIwNDE2MDc1OWM2OWE4NmNhNjk0ZWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTItMDItMDcgIEdyZWdnIFRhdmFyZXMgIDxnbWFuQGdvb2dsZS5j b20+CisKKyAgICAgICAgUGx1bWIgdGhyb3VnaCB3ZWJHTEVycm9yc1RvQ29uc29sZUVuYWJsZSBp biBXZWJTZXR0aW5ncworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NzgwNjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIHB1YmxpYy9XZWJTZXR0aW5ncy5oOgorICAgICAgICAqIHNyYy9XZWJTZXR0aW5nc0lt cGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJTZXR0aW5nc0ltcGw6OnNldFdlYkdMRXJyb3Jz VG9Db25zb2xlRW5hYmxlZCk6CisgICAgICAgIChXZWJLaXQpOgorICAgICAgICAqIHNyYy9XZWJT ZXR0aW5nc0ltcGwuaDoKKyAgICAgICAgKFdlYlNldHRpbmdzSW1wbCk6CisKIDIwMTItMDItMDcg IERhdmlkIFJldmVtYW4gIDxyZXZlbWFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbQ2hyb21p dW1dIFJFR1JFU1NJT04ocjEwMTg1NCk6IENhdXNpbmcgbGFyZ2UgYW1vdW50cyBvZiB1bm5lY2Vz c2FyeSByZXBhaW50aW5nLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJs aWMvV2ViU2V0dGluZ3MuaCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlNldHRp bmdzLmgKaW5kZXggYjVkYTRlNmJhNjc4ZmUyOWQ4YThkNTk5N2Q1MTJkNTYyNmM4Y2E5Yi4uMjVh YzA3NTIzOTY3ODdiNmFjYWQ0MzFjM2I3MTY3NmFkMjAwZjQ4NiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViU2V0dGluZ3MuaAorKysgYi9Tb3VyY2UvV2ViS2l0 L2Nocm9taXVtL3B1YmxpYy9XZWJTZXR0aW5ncy5oCkBAIC05OCw2ICs5OCw3IEBAIHB1YmxpYzoK ICAgICB2aXJ0dWFsIHZvaWQgc2V0RXhwZXJpbWVudGFsV2ViR0xFbmFibGVkKGJvb2wpID0gMDsK ICAgICB2aXJ0dWFsIHZvaWQgc2V0T3BlbkdMTXVsdGlzYW1wbGluZ0VuYWJsZWQoYm9vbCkgPSAw OwogICAgIHZpcnR1YWwgdm9pZCBzZXRQcml2aWxlZ2VkV2ViR0xFeHRlbnNpb25zRW5hYmxlZChi b29sKSA9IDA7CisgICAgdmlydHVhbCB2b2lkIHNldFdlYkdMRXJyb3JzVG9Db25zb2xlRW5hYmxl ZChib29sKSA9IDA7CiAgICAgdmlydHVhbCB2b2lkIHNldFNob3dEZWJ1Z0JvcmRlcnMoYm9vbCkg PSAwOwogICAgIHZpcnR1YWwgdm9pZCBzZXRTaG93RlBTQ291bnRlcihib29sKSA9IDA7CiAgICAg dmlydHVhbCBib29sIHNob3dGUFNDb3VudGVyKCkgY29uc3QgPSAwOwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViU2V0dGluZ3NJbXBsLmNwcCBiL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vc3JjL1dlYlNldHRpbmdzSW1wbC5jcHAKaW5kZXggMjcyM2NhNzhiZjQ3MmY1 ZDU3ZWQ0NmNlMWU2YmU4MTQwNDMzZGMyZi4uMTFlOWMzMzdiMDdhMjIwZjBiZjIxOGVlNjU1YzAy ZjEzZGQxNmIyYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViU2V0 dGluZ3NJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJTZXR0aW5n c0ltcGwuY3BwCkBAIC0yOTgsNiArMjk4LDExIEBAIHZvaWQgV2ViU2V0dGluZ3NJbXBsOjpzZXRQ cml2aWxlZ2VkV2ViR0xFeHRlbnNpb25zRW5hYmxlZChib29sIGVuYWJsZWQpCiAgICAgbV9zZXR0 aW5ncy0+c2V0UHJpdmlsZWdlZFdlYkdMRXh0ZW5zaW9uc0VuYWJsZWQoZW5hYmxlZCk7CiB9CiAK K3ZvaWQgV2ViU2V0dGluZ3NJbXBsOjpzZXRXZWJHTEVycm9yc1RvQ29uc29sZUVuYWJsZWQoYm9v bCBlbmFibGVkKQoreworICAgIG1fc2V0dGluZ3MtPnNldFdlYkdMRXJyb3JzVG9Db25zb2xlRW5h YmxlZChlbmFibGVkKTsKK30KKwogdm9pZCBXZWJTZXR0aW5nc0ltcGw6OnNldFNob3dEZWJ1Z0Jv cmRlcnMoYm9vbCBzaG93KQogewogICAgIG1fc2V0dGluZ3MtPnNldFNob3dEZWJ1Z0JvcmRlcnMo c2hvdyk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJTZXR0aW5n c0ltcGwuaCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlNldHRpbmdzSW1wbC5oCmlu ZGV4IDYzYTAwYTA5OTllMzJkMDk0Y2M3ODVkYTU4ZjVmNTVhZmEyYTBhNDMuLjQ1ZTYyZGI2ZmJl MjBjYzU3YzBmMTdlODU4N2E2ZmIwOWY2NTEzZTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vc3JjL1dlYlNldHRpbmdzSW1wbC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vc3JjL1dlYlNldHRpbmdzSW1wbC5oCkBAIC05MCw2ICs5MCw3IEBAIHB1YmxpYzoKICAgICB2 aXJ0dWFsIHZvaWQgc2V0RXhwZXJpbWVudGFsV2ViR0xFbmFibGVkKGJvb2wpOwogICAgIHZpcnR1 YWwgdm9pZCBzZXRPcGVuR0xNdWx0aXNhbXBsaW5nRW5hYmxlZChib29sKTsKICAgICB2aXJ0dWFs IHZvaWQgc2V0UHJpdmlsZWdlZFdlYkdMRXh0ZW5zaW9uc0VuYWJsZWQoYm9vbCk7CisgICAgdmly dHVhbCB2b2lkIHNldFdlYkdMRXJyb3JzVG9Db25zb2xlRW5hYmxlZChib29sKTsKICAgICB2aXJ0 dWFsIHZvaWQgc2V0U2hvd0RlYnVnQm9yZGVycyhib29sKTsKICAgICB2aXJ0dWFsIHZvaWQgc2V0 U2hvd0ZQU0NvdW50ZXIoYm9vbCk7CiAgICAgdmlydHVhbCBib29sIHNob3dGUFNDb3VudGVyKCkg Y29uc3QgeyByZXR1cm4gbV9zaG93RlBTQ291bnRlcjsgfQo=