78059 2012-02-07 17:21:33 -0800 [GTK] Ignore [Custom] attributes in CodeGeneratorGObject.pm 2012-02-07 20:14:23 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 haraken haraken abarth japhet mrobinson pf webkit.review.bot oldest_to_newest 551588 0 haraken 2012-02-07 17:21:33 -0800 CodeGeneratorGObject.pm does not support custom attributes. We can skip generating code for attributes with [Custom]. The change would make sense since CodeGeneratorGObject.pm already skips attributes with [CustomGetter] or [CustomSetter]. 551593 1 125961 haraken 2012-02-07 17:28:09 -0800 Created attachment 125961 Patch 551729 2 125961 webkit.review.bot 2012-02-07 20:14:18 -0800 Comment on attachment 125961 Patch Clearing flags on attachment: 125961 Committed r107034: <http://trac.webkit.org/changeset/107034> 551730 3 webkit.review.bot 2012-02-07 20:14:23 -0800 All reviewed patches have been landed. Closing bug. 125961 2012-02-07 17:28:09 -0800 2012-02-07 20:14:18 -0800 Patch bug-78059-20120208102807.patch text/plain 2634 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3MDE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDQ4NzgzZmM0NTAwMmM4 ZmEzMjQzY2FkZTE1NTI2Yjc3YTg1YWI3Ny4uMGI0MDg5ZWZhNzQwNjg2ODk5OTJhOTExYzQyY2Jk MTc0MzYzMzBjOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTAyLTA3ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbR1RLXSBJZ25vcmUg W0N1c3RvbV0gYXR0cmlidXRlcyBpbiBDb2RlR2VuZXJhdG9yR09iamVjdC5wbQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzgwNTkKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDb2RlR2VuZXJhdG9yR09iamVj dC5wbSBkb2VzIG5vdCBzdXBwb3J0IGN1c3RvbSBhdHRyaWJ1dGVzLgorICAgICAgICBXZSBjYW4g c2tpcCBnZW5lcmF0aW5nIGNvZGUgZm9yIGF0dHJpYnV0ZXMgd2l0aCBbQ3VzdG9tXS4KKyAgICAg ICAgVGhlIGNoYW5nZSB3b3VsZCBtYWtlIHNlbnNlLCBzaW5jZSBDb2RlR2VuZXJhdG9yR09iamVj dC5wbSBhbHJlYWR5CisgICAgICAgIHNraXBzIGF0dHJpYnV0ZXMgd2l0aCBbQ3VzdG9tR2V0dGVy XSBvciBbQ3VzdG9tU2V0dGVyXS4KKworICAgICAgICBUZXN0OiBiaW5kaW5ncy9zY3JpcHRzL3Rl c3QvVGVzdE9iai5pZGwKKworICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRv ckdPYmplY3QucG06CisgICAgICAgIChTa2lwQXR0cmlidXRlKToKKyAgICAgICAgKiBiaW5kaW5n cy9zY3JpcHRzL3Rlc3QvR09iamVjdC9XZWJLaXRET01UZXN0T2JqLmNwcDoKKwogMjAxMi0wMi0w NyAgRGF2aWQgUmV2ZW1hbiAgPHJldmVtYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtDaHJv bWl1bV0gUkVHUkVTU0lPTihyMTAxODU0KTogQ2F1c2luZyBsYXJnZSBhbW91bnRzIG9mIHVubmVj ZXNzYXJ5IHJlcGFpbnRpbmcuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9z Y3JpcHRzL0NvZGVHZW5lcmF0b3JHT2JqZWN0LnBtIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv c2NyaXB0cy9Db2RlR2VuZXJhdG9yR09iamVjdC5wbQppbmRleCA1ZDI2NDE0ZWE4NGU0MzRjOGFk YTA4MDcyZDkxY2FmZTg0NzEwZTI4Li42ZWRmZDBjODA1YzliZDRhODA5N2EzZjYyYzE0ZDVlN2Q3 Y2U0YmRmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVH ZW5lcmF0b3JHT2JqZWN0LnBtCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMv Q29kZUdlbmVyYXRvckdPYmplY3QucG0KQEAgLTE1Miw5ICsxNTIsMTAgQEAgc3ViIEdldENvcmVP YmplY3QgewogCiBzdWIgU2tpcEF0dHJpYnV0ZSB7CiAgICAgbXkgJGF0dHJpYnV0ZSA9IHNoaWZ0 OwotICAgIAotICAgIGlmICgkYXR0cmlidXRlLT5zaWduYXR1cmUtPmV4dGVuZGVkQXR0cmlidXRl cy0+eyJDdXN0b21HZXR0ZXIifSB8fAotICAgICAgICAkYXR0cmlidXRlLT5zaWduYXR1cmUtPmV4 dGVuZGVkQXR0cmlidXRlcy0+eyJDdXN0b21TZXR0ZXIifSkgeworCisgICAgaWYgKCRhdHRyaWJ1 dGUtPnNpZ25hdHVyZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IkN1c3RvbSJ9CisgICAgICAgIHx8 ICRhdHRyaWJ1dGUtPnNpZ25hdHVyZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IkN1c3RvbUdldHRl ciJ9CisgICAgICAgIHx8ICRhdHRyaWJ1dGUtPnNpZ25hdHVyZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVz LT57IkN1c3RvbVNldHRlciJ9KSB7CiAgICAgICAgIHJldHVybiAxOwogICAgIH0KIApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0dPYmplY3QvV2ViS2l0 RE9NVGVzdE9iai5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvR09i amVjdC9XZWJLaXRET01UZXN0T2JqLmNwcAppbmRleCA2M2EzN2I2N2JiMDVlMzdiYTczYjM3ODdi YzhmODQxYjM5ZTI1Y2Y2Li41ZjlmOTVmNDRmMzhhYjY2MmY4ZDcyMDdiZTM4YTkxYWU2YzAwODk2 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvR09iamVj dC9XZWJLaXRET01UZXN0T2JqLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3Jp cHRzL3Rlc3QvR09iamVjdC9XZWJLaXRET01UZXN0T2JqLmNwcApAQCAtMTQwNiw3ICsxNDA2LDYg QEAgZW51bSB7CiAgICAgUFJPUF9BVFRSX1dJVEhfU0VUVEVSX0VYQ0VQVElPTiwKICAgICBQUk9Q X1NUUklOR19BVFRSX1dJVEhfR0VUVEVSX0VYQ0VQVElPTiwKICAgICBQUk9QX1NUUklOR19BVFRS X1dJVEhfU0VUVEVSX0VYQ0VQVElPTiwKLSAgICBQUk9QX0NVU1RPTV9BVFRSLAogICAgIFBST1Bf V0lUSF9TQ1JJUFRfU1RBVEVfQVRUUklCVVRFLAogICAgIFBST1BfV0lUSF9TQ1JJUFRfRVhFQ1VU SU9OX0NPTlRFWFRfQVRUUklCVVRFLAogICAgIFBST1BfV0lUSF9TQ1JJUFRfU1RBVEVfQVRUUklC VVRFX1JBSVNFUywK