78057 2012-02-07 16:51:01 -0800 Fix the caculation of preDelayFrames in DynamicsCompressorKernel 2012-02-08 20:34:58 -0800 1 1 1 Unclassified WebKit Web Audio 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rgbbones rgbbones crogers dbates kbr webkit.review.bot oldest_to_newest 551557 0 rgbbones 2012-02-07 16:51:01 -0800 Fix the caculation of preDelayFrames in DynamicsCompressorKernel 551565 1 125957 rgbbones 2012-02-07 16:58:15 -0800 Created attachment 125957 Patch 551573 2 rgbbones 2012-02-07 17:04:00 -0800 Hi Chris Without this patch, the DynamicsCompressorNode actually don't have any predelay applied for the compressor since the preDelayFrames will always be 0. Please help to take a review ;) 551576 3 rgbbones 2012-02-07 17:06:55 -0800 (In reply to comment #2) > Hi Chris > > Without this patch, the DynamicsCompressorNode actually don't have any predelay applied for the compressor since the preDelayFrames will always be 0. Please help to take a review ;) oh, though preDelayFrames will always be 0, due to the fact that the read is done before write, the actual preDelayFrame applied is 1024 not 0 552754 4 125957 crogers 2012-02-08 19:01:05 -0800 Comment on attachment 125957 Patch Wow - good catch! That was really a bad one... 552806 5 125957 webkit.review.bot 2012-02-08 20:34:54 -0800 Comment on attachment 125957 Patch Clearing flags on attachment: 125957 Committed r107172: <http://trac.webkit.org/changeset/107172> 552807 6 webkit.review.bot 2012-02-08 20:34:58 -0800 All reviewed patches have been landed. Closing bug. 125957 2012-02-07 16:58:15 -0800 2012-02-08 20:34:54 -0800 Patch bug-78057-20120208090255.patch text/plain 1641 rgbbones U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2OTkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDc4NjkxZjc5ZjcwNjM2 Yjk0ODU2YWI3OGJhZThiODhiODMzNTYxMC4uZTU2MzNiZGFlZjM0YzU4ZDlmMDQ0YjBkMGEzYmVj OTNjZWZlN2EyMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTAyLTA3ICBSYXlt b25kIExpdSAgPHJheW1vbmQubGl1QGludGVsLmNvbT4KKworICAgICAgICBGaXggdGhlIGNhY3Vs YXRpb24gb2YgcHJlRGVsYXlGcmFtZXMgaW4gRHluYW1pY3NDb21wcmVzc29yS2VybmVsCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03ODA1NworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBy ZXF1aXJlZC4KKworICAgICAgICAqIHBsYXRmb3JtL2F1ZGlvL0R5bmFtaWNzQ29tcHJlc3Nvcktl cm5lbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEeW5hbWljc0NvbXByZXNzb3JLZXJuZWw6OnNl dFByZURlbGF5VGltZSk6CisKIDIwMTItMDItMDcgIEphbWVzIFJvYmluc29uICA8amFtZXNyQGNo cm9taXVtLm9yZz4KIAogICAgICAgICBbY2hyb21pdW1dIEFsbG93IHJldGFpbmluZyB0ZXh0dXJl IGFjcm9zcyBmcmFtZXMgaW4gY29tcG9zaXRlZCB2aWRlbyBwbGF5YmFjayBhbmQgY29ycmVjdGx5 IGhhbmRsZSBsb3N0IGNvbnRleHQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2F1ZGlvL0R5bmFtaWNzQ29tcHJlc3Nvcktlcm5lbC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9hdWRpby9EeW5hbWljc0NvbXByZXNzb3JLZXJuZWwuY3BwCmluZGV4IGE3YTRjMTIxMjc1 MjAyZWNmM2JhYjJlMTVlMDVmY2M0YjRhZGEwZjkuLmEzMjJhMzMwMjU5NjBjODljYjZiZTA2YzI1 Yjg3NzM3NmRhOWUzNmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlv L0R5bmFtaWNzQ29tcHJlc3Nvcktlcm5lbC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vYXVkaW8vRHluYW1pY3NDb21wcmVzc29yS2VybmVsLmNwcApAQCAtNjksNyArNjksNyBAQCBE eW5hbWljc0NvbXByZXNzb3JLZXJuZWw6OkR5bmFtaWNzQ29tcHJlc3Nvcktlcm5lbChmbG9hdCBz YW1wbGVSYXRlKQogdm9pZCBEeW5hbWljc0NvbXByZXNzb3JLZXJuZWw6OnNldFByZURlbGF5VGlt ZShmbG9hdCBwcmVEZWxheVRpbWUpCiB7CiAgICAgLy8gUmUtY29uZmlndXJlIGxvb2stYWhlYWQg c2VjdGlvbiBwcmUtZGVsYXkgaWYgZGVsYXkgdGltZSBoYXMgY2hhbmdlZC4KLSAgICB1bnNpZ25l ZCBwcmVEZWxheUZyYW1lcyA9IHByZURlbGF5VGltZSAvIHNhbXBsZVJhdGUoKTsKKyAgICB1bnNp Z25lZCBwcmVEZWxheUZyYW1lcyA9IHByZURlbGF5VGltZSAqIHNhbXBsZVJhdGUoKTsKICAgICBp ZiAocHJlRGVsYXlGcmFtZXMgPiBNYXhQcmVEZWxheUZyYW1lcyAtIDEpCiAgICAgICAgIHByZURl bGF5RnJhbWVzID0gTWF4UHJlRGVsYXlGcmFtZXMgLSAxOwogICAgICAgICAK