78033 2012-02-07 13:50:41 -0800 Properly detect top level frames when propogating compositing 2012-02-07 18:48:12 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 enne enne cmarrin enne jamesr simon.fraser vangelis webkit.review.bot oldest_to_newest 551337 0 enne 2012-02-07 13:50:41 -0800 Properly detect top level frames when propogating compositing 551420 1 125934 enne 2012-02-07 14:51:44 -0800 Created attachment 125934 Patch 551429 2 enne 2012-02-07 14:57:36 -0800 This patch is intended to fix http://code.google.com/p/chromium/issues/detail?id=111643. A frame gets created from an <embed> video, but because enclosingFrameElement() returns 0, RenderLayerCompositor thinks it's the top-level frame, which is why only that frame ends up getting drawn in Chromium. This bug could also be fixed by adding yet another conditional to check for the embedTag to the enclosingFrameElement function, but I figured I'd just solve this more generally, rather than explicitly enumerating all tags that could create a frame. 551479 3 125934 eric 2012-02-07 15:40:36 -0800 Comment on attachment 125934 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125934&action=review > Source/WebCore/ChangeLog:10 > + There's no need to enumerate all tag names when searching for a > + top-level frame. If a render view's document has a frame, then that > + frame is not the top-level one. This statement is not immediately obvious to me. Can you clarify? 551504 4 enne 2012-02-07 15:56:34 -0800 (In reply to comment #3) > (From update of attachment 125934 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=125934&action=review > > > Source/WebCore/ChangeLog:10 > > + There's no need to enumerate all tag names when searching for a > > + top-level frame. If a render view's document has a frame, then that > > + frame is not the top-level one. > > This statement is not immediately obvious to me. Can you clarify? In this specific bug instance, there's a top-level Document and a child PluginDocument. I'm trying to say that the tag of the owning element for that child document is not relevant to whether or not that child document is that top-level document. Perhaps it would have been clearer to say "If a render view's document has an _owning element_, ...". 551599 5 125934 jamesr 2012-02-07 17:31:45 -0800 Comment on attachment 125934 Patch R=me. Document.h says: // Returns the owning element in the parent document. // Returns 0 if this is the top level document. HTMLFrameOwnerElement* ownerElement() const; and no other code does this tag-matching. 551677 6 125934 webkit.review.bot 2012-02-07 18:48:08 -0800 Comment on attachment 125934 Patch Clearing flags on attachment: 125934 Committed r107024: <http://trac.webkit.org/changeset/107024> 551678 7 webkit.review.bot 2012-02-07 18:48:12 -0800 All reviewed patches have been landed. Closing bug. 125934 2012-02-07 14:51:44 -0800 2012-02-07 18:48:08 -0800 Patch bug-78033-20120207145143.patch text/plain 3342 enne U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2OTkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2RjZTA1YTU4N2M5NTM0 ZDBjYjJkNzcxZTkwNzAwM2IzNjg5MTYxNC4uNWJlZDE4Y2ZjMDkyOWUzMzgzNTFmMjRjOWU2MDc1 YjkwYWYxMWQ3YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTAyLTA3ICBBZHJp ZW5uZSBXYWxrZXIgIDxlbm5lQGdvb2dsZS5jb20+CisKKyAgICAgICAgUHJvcGVybHkgZGV0ZWN0 IHRvcCBsZXZlbCBmcmFtZXMgd2hlbiBwcm9wb2dhdGluZyBjb21wb3NpdGluZworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzgwMzMKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGVyZSdzIG5vIG5lZWQgdG8g ZW51bWVyYXRlIGFsbCB0YWcgbmFtZXMgd2hlbiBzZWFyY2hpbmcgZm9yIGEKKyAgICAgICAgdG9w LWxldmVsIGZyYW1lLiBJZiBhIHJlbmRlciB2aWV3J3MgZG9jdW1lbnQgaGFzIGEgZnJhbWUsIHRo ZW4gdGhhdAorICAgICAgICBmcmFtZSBpcyBub3QgdGhlIHRvcC1sZXZlbCBvbmUuCisKKyAgICAg ICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlJlbmRlckxheWVyQ29tcG9zaXRvcjo6c2hvdWxkUHJvcGFnYXRlQ29tcG9zaXRpbmdUb0Vu Y2xvc2luZ0ZyYW1lKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9y Lmg6CisgICAgICAgIChSZW5kZXJMYXllckNvbXBvc2l0b3IpOgorCiAyMDEyLTAyLTA3ICBNYXR0 aGV3IERlbGFuZXkgIDxtZGVsYW5leUBhcHBsZS5jb20+CiAKICAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc3OTEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuY3BwCmluZGV4IDdkYzA3NGNlY2VjMjVm ODcxOTI0OTA1ZjZkMTZmOGU3NTFjYTNhYzUuLjk5ZDNmNzExOTVkYWYzMjU5OTBjY2JmY2JmYTRk YWVhZGVmODQ5OWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJM YXllckNvbXBvc2l0b3IuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJM YXllckNvbXBvc2l0b3IuY3BwCkBAIC0xMjYxLDcgKzEyNjEsNyBAQCBib29sIFJlbmRlckxheWVy Q29tcG9zaXRvcjo6c2hvdWxkUHJvcGFnYXRlQ29tcG9zaXRpbmdUb0VuY2xvc2luZ0ZyYW1lKCkg Y29uc3QKICAgICAvLyBQYXJlbnQgZG9jdW1lbnQgY29udGVudCBuZWVkcyB0byBiZSBhYmxlIHRv IHJlbmRlciBvbiB0b3Agb2YgYSBjb21wb3NpdGVkIGZyYW1lLCBzbyBjb3JyZWN0IGJlaGF2aW9y CiAgICAgLy8gaXMgdG8gaGF2ZSB0aGUgcGFyZW50IGRvY3VtZW50IGJlY29tZSBjb21wb3NpdGVk IHRvby4gSG93ZXZlciwgdGhpcyBjYW4gY2F1c2UgcHJvYmxlbXMgb24gcGxhdGZvcm1zIHRoYXQK ICAgICAvLyB1c2UgbmF0aXZlIHZpZXdzIGZvciBmcmFtZXMgKGxpa2UgTWFjKSwgc28gZGlzYWJs ZSB0aGF0IGJlaGF2aW9yIG9uIHRob3NlIHBsYXRmb3JtcyBmb3Igbm93LgotICAgIEhUTUxGcmFt ZU93bmVyRWxlbWVudCogb3duZXJFbGVtZW50ID0gZW5jbG9zaW5nRnJhbWVFbGVtZW50KCk7Cisg ICAgSFRNTEZyYW1lT3duZXJFbGVtZW50KiBvd25lckVsZW1lbnQgPSBtX3JlbmRlclZpZXctPmRv Y3VtZW50KCktPm93bmVyRWxlbWVudCgpOwogICAgIFJlbmRlck9iamVjdCogcmVuZGVyZXIgPSBv d25lckVsZW1lbnQgPyBvd25lckVsZW1lbnQtPnJlbmRlcmVyKCkgOiAwOwogCiAgICAgLy8gSWYg d2UgYXJlIHRoZSB0b3AtbGV2ZWwgZnJhbWUsIGRvbid0IHByb3BhZ2F0ZS4KQEAgLTEyOTIsMTQg KzEyOTIsNiBAQCBib29sIFJlbmRlckxheWVyQ29tcG9zaXRvcjo6c2hvdWxkUHJvcGFnYXRlQ29t cG9zaXRpbmdUb0VuY2xvc2luZ0ZyYW1lKCkgY29uc3QKICAgICByZXR1cm4gZmFsc2U7CiB9CiAK LUhUTUxGcmFtZU93bmVyRWxlbWVudCogUmVuZGVyTGF5ZXJDb21wb3NpdG9yOjplbmNsb3NpbmdG cmFtZUVsZW1lbnQoKSBjb25zdAotewotICAgIGlmIChIVE1MRnJhbWVPd25lckVsZW1lbnQqIG93 bmVyRWxlbWVudCA9IG1fcmVuZGVyVmlldy0+ZG9jdW1lbnQoKS0+b3duZXJFbGVtZW50KCkpCi0g ICAgICAgIHJldHVybiAob3duZXJFbGVtZW50LT5oYXNUYWdOYW1lKGlmcmFtZVRhZykgfHwgb3du ZXJFbGVtZW50LT5oYXNUYWdOYW1lKGZyYW1lVGFnKSB8fCBvd25lckVsZW1lbnQtPmhhc1RhZ05h bWUob2JqZWN0VGFnKSkgPyBvd25lckVsZW1lbnQgOiAwOwotCi0gICAgcmV0dXJuIDA7Ci19Ci0K IGJvb2wgUmVuZGVyTGF5ZXJDb21wb3NpdG9yOjpuZWVkc1RvQmVDb21wb3NpdGVkKGNvbnN0IFJl bmRlckxheWVyKiBsYXllcikgY29uc3QKIHsKICAgICBpZiAoIWNhbkJlQ29tcG9zaXRlZChsYXll cikpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21w b3NpdG9yLmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9y LmgKaW5kZXggMTY3ZDVhODc1Nzc2YmJhNmEyMGY0NDBmNWYxZDE0YzBiZTkyMmI4Mi4uZWI2MTlk NjY0ZGRlMzVkZGI1N2NiODU5NzdlYTk5ZGVhZGU0NTFlMCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5oCisrKyBiL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuaApAQCAtMTc4LDggKzE3OCw2IEBA IHB1YmxpYzoKICAgICBzdGF0aWMgYm9vbCBhbGxvd3NJbmRlcGVuZGVudGx5Q29tcG9zaXRlZEZy YW1lcyhjb25zdCBGcmFtZVZpZXcqKTsKICAgICBib29sIHNob3VsZFByb3BhZ2F0ZUNvbXBvc2l0 aW5nVG9FbmNsb3NpbmdGcmFtZSgpIGNvbnN0OwogCi0gICAgSFRNTEZyYW1lT3duZXJFbGVtZW50 KiBlbmNsb3NpbmdGcmFtZUVsZW1lbnQoKSBjb25zdDsKLQogICAgIHN0YXRpYyBSZW5kZXJMYXll ckNvbXBvc2l0b3IqIGZyYW1lQ29udGVudHNDb21wb3NpdG9yKFJlbmRlclBhcnQqKTsKICAgICAv LyBSZXR1cm4gdHJ1ZSBpZiB0aGUgbGF5ZXJzIGNoYW5nZWQuCiAgICAgc3RhdGljIGJvb2wgcGFy ZW50RnJhbWVDb250ZW50TGF5ZXJzKFJlbmRlclBhcnQqKTsK