78021 2012-02-07 12:56:11 -0800 layoutTestController.display() is flaky for SVG tests 2012-02-17 03:07:32 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 77736 1 zimmermann zimmermann aroben oldest_to_newest 551263 0 zimmermann 2012-02-07 12:56:11 -0800 layoutTestController.display() is flaky for SVG tests. Reduction: new-run-webkit-tests --tolerance 0 -p --child-processes=1 svg/W3C-SVG-1.1(-SE)/any-test.svg svg/filters/animate-fill.svg There's a hack in DRT to produce 480x360 expected.pngs for any test starting with "svg/W3C-SVG-1.1" - the resizing of the web view is done when dump()ing the render tree - _after_ layoutTestController.display() was called and the repaint test executed. This makes the grey overlay vanish again. The first test that tests repainting, running right after a svg/W3C-SVG-1.1/xxxx test case will fill. Uploading a simple fix for Mac DRT soon. 551272 1 125906 zimmermann 2012-02-07 13:02:28 -0800 Created attachment 125906 Patch for mac 551278 2 125906 mitz 2012-02-07 13:05:59 -0800 Comment on attachment 125906 Patch for mac View in context: https://bugs.webkit.org/attachment.cgi?id=125906&action=review > Tools/ChangeLog:11 > + hack that forces 480x3600 instead of 800x600 pixel test dumps for any test starting with Typo: 3600 551322 3 zimmermann 2012-02-07 13:38:13 -0800 Committed r106983: <http://trac.webkit.org/changeset/106983> 551366 4 aroben 2012-02-07 14:13:27 -0800 I believe DRT/win has extremely similar code. Any chance you'll fix that implementation too? 552987 5 zimmermann 2012-02-09 02:39:44 -0800 (In reply to comment #4) > I believe DRT/win has extremely similar code. Any chance you'll fix that implementation too? Reopning this bug as reminder. I've checked DRT code for all platforms (efl/gtk/cr/..) - those ports all resize the view before running the test, so they don't suffer from the problem, so really only win/ is left to fix. Will upload a patch soon. 553036 6 126275 zimmermann 2012-02-09 03:55:40 -0800 Created attachment 126275 Patch for win 553043 7 126275 webkit-ews 2012-02-09 04:14:30 -0800 Comment on attachment 126275 Patch for win Attachment 126275 did not pass qt-ews (qt): Output: http://queues.webkit.org/results/11473188 553052 8 zimmermann 2012-02-09 04:26:49 -0800 The Qt build failure is unrelated. 553227 9 126275 aroben 2012-02-09 09:31:32 -0800 Comment on attachment 126275 Patch for win View in context: https://bugs.webkit.org/attachment.cgi?id=126275&action=review > Tools/DumpRenderTree/win/DumpRenderTree.cpp:726 > + ::InvalidateRect(webViewWindow, 0, TRUE); > + ::SendMessage(webViewWindow, WM_PAINT, 0, 0); Why do we need to do this even for dumpAsText tests? 554161 10 125906 eric 2012-02-10 10:20:40 -0800 Comment on attachment 125906 Patch for mac Cleared Dan Bernstein's review+ from obsolete attachment 125906 so that this bug does not appear in http://webkit.org/pending-commit. 554725 11 zimmermann 2012-02-11 15:54:29 -0800 (In reply to comment #9) > Why do we need to do this even for dumpAsText tests? Not sure, I just refactored it - it's as it used to be. It looks suspicious though - I don't have a win machine to test though. To stay on the safe-side we could leave it as-is, but I don't know if it works, I couldn't try it. 558090 12 zimmermann 2012-02-16 04:58:43 -0800 Anyone? 559083 13 126275 zimmermann 2012-02-17 03:07:22 -0800 Comment on attachment 126275 Patch for win Clearing flags on attachment: 126275 Committed r108054: <http://trac.webkit.org/changeset/108054> 559084 14 zimmermann 2012-02-17 03:07:32 -0800 All reviewed patches have been landed. Closing bug. 125906 2012-02-07 13:02:28 -0800 2012-02-10 10:20:40 -0800 Patch for mac bug-78021-20120207220226.patch text/plain 2377 zimmermann U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2OTc4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZjljNzVlZjI1NTk4ZmNjMWRlNWZiODE2OTZjYmI5ODg2 ZDgxODc3NC4uNjIzMzIwYWFjMDFlZmUwMmFjMGI0MjY1OWMzMjI5MTI1ZDA4N2RkOSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIx IEBACisyMDEyLTAyLTA3ICBOaWtvbGFzIFppbW1lcm1hbm4gIDxuemltbWVybWFubkByaW0uY29t PgorCisgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLmRpc3BsYXkoKSBpcyBmbGFreSBmb3Ig U1ZHIHRlc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD03ODAyMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEZpeCByYWNlIGNvbmRpdGlvbiBpbiByZXBhaW50IHJlY3QgdHJhY2tpbmcuIFdoZW4gcnVubmlu ZyBhIHRlc3QgdXNpbmcgdGhlIHJlcGFpbnQuanMKKyAgICAgICAgaGFybmVzcyByaWdodCBhZnRl ciBhIHRlc3Qgc3RhcnRpbmcgd2l0aCAic3ZnL1czQy1TVkctMS4xIiB0aGUgcmVwYWludCB0ZXN0 IHdpbGwgZmFpbCwKKyAgICAgICAgdGhlIGdyYXkgb3ZlcmxheSBpc24ndCBjb250YWluZWQgaW4g dGhlIHBpeGVsIGR1bXAgYW55bW9yZS4gVGhpcyBpcyBiZWNhdXNlIG9mIGEgc3BlY2lmaWMKKyAg ICAgICAgaGFjayB0aGF0IGZvcmNlcyA0ODB4MzYwMCBpbnN0ZWFkIG9mIDgwMHg2MDAgcGl4ZWwg dGVzdCBkdW1wcyBmb3IgYW55IHRlc3Qgc3RhcnRpbmcgd2l0aAorICAgICAgICBzdmcvVzNDLVNW Ry0xLjEuIFRoZSByZXNpemluZyBvZiB0aGUgd2ViIHZpZXcgd2FzIGRvbmUgd2hlbiBkdW1waW5n IHRoZSByZW5kZXIgdHJlZSwgYWZ0ZXIKKyAgICAgICAgdGhlIHJlcGFpbnQgdGVzdCBhbHJlYWR5 IHJ1biwgdGh1cyBpbnZhbGlkYXRpbmcgdGhlIHByZXZpb3VzbHkgdHJhY2tlZCByZXBhaW50IHJl Y3RzLgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvbWFjL0R1bXBSZW5kZXJUcmVlLm1tOgor ICAgICAgICAoZHVtcCk6CisgICAgICAgIChydW5UZXN0KToKKwogMjAxMi0wMi0wNyAgSGFucyBX ZW5uYm9yZyAgPGhhbnNAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIENocm9taXVtOiByZW1vdmUg V2ViU3BlZWNoSW5wdXRSZXN1bHQ6OnNldApkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRy ZWUvbWFjL0R1bXBSZW5kZXJUcmVlLm1tIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvbWFjL0R1bXBS ZW5kZXJUcmVlLm1tCmluZGV4IGI3MzVhOTY1YjFiZTBlZWQ3NmZmOWRmNjQ4NDQ4MjI4NWI3Mzgz ZDIuLjMwMTJhNzBkODhiNDE2MzI0M2VlOGFmMWM1NGFiMWUwZjY0MjExMjggMTAwNjQ0Ci0tLSBh L1Rvb2xzL0R1bXBSZW5kZXJUcmVlL21hYy9EdW1wUmVuZGVyVHJlZS5tbQorKysgYi9Ub29scy9E dW1wUmVuZGVyVHJlZS9tYWMvRHVtcFJlbmRlclRyZWUubW0KQEAgLTExNDYsMTAgKzExNDYsOCBA QCB2b2lkIGR1bXAoKQogICAgICAgICAgICAgV2ViQXJjaGl2ZSAqd2ViQXJjaGl2ZSA9IFtbbWFp bkZyYW1lIGRhdGFTb3VyY2VdIHdlYkFyY2hpdmVdOwogICAgICAgICAgICAgcmVzdWx0U3RyaW5n ID0gSGFyZEF1dG9yZWxlYXNlKGNyZWF0ZVhNTFN0cmluZ0Zyb21XZWJBcmNoaXZlRGF0YSgoQ0ZE YXRhUmVmKVt3ZWJBcmNoaXZlIGRhdGFdKSk7CiAgICAgICAgICAgICByZXN1bHRNaW1lVHlwZSA9 IEAiYXBwbGljYXRpb24veC13ZWJhcmNoaXZlIjsKLSAgICAgICAgfSBlbHNlIHsKLSAgICAgICAg ICAgIHNpemVXZWJWaWV3Rm9yQ3VycmVudFRlc3QoKTsKKyAgICAgICAgfSBlbHNlCiAgICAgICAg ICAgICByZXN1bHRTdHJpbmcgPSBbbWFpbkZyYW1lIHJlbmRlclRyZWVBc0V4dGVybmFsUmVwcmVz ZW50YXRpb25Gb3JQcmludGluZzpnTGF5b3V0VGVzdENvbnRyb2xsZXItPmlzUHJpbnRpbmcoKV07 Ci0gICAgICAgIH0KIAogICAgICAgICBpZiAocmVzdWx0U3RyaW5nICYmICFyZXN1bHREYXRhKQog ICAgICAgICAgICAgcmVzdWx0RGF0YSA9IFtyZXN1bHRTdHJpbmcgZGF0YVVzaW5nRW5jb2Rpbmc6 TlNVVEY4U3RyaW5nRW5jb2RpbmddOwpAQCAtMTMwMyw2ICsxMzAxLDcgQEAgc3RhdGljIHZvaWQg cnVuVGVzdChjb25zdCBzdHJpbmcmIHRlc3RQYXRoT3JVUkwpCiAgICAgcmVsZWFzZUFuZFplcm8o JmRyYWdnaW5nSW5mbyk7CiAgICAgZG9uZSA9IE5POwogCisgICAgc2l6ZVdlYlZpZXdGb3JDdXJy ZW50VGVzdCgpOwogICAgIGdMYXlvdXRUZXN0Q29udHJvbGxlci0+c2V0SWNvbkRhdGFiYXNlRW5h YmxlZChmYWxzZSk7CiAKICAgICBpZiAoZGlzYWxsb3dlZFVSTHMpCg== 126275 2012-02-09 03:55:40 -0800 2012-02-17 03:07:21 -0800 Patch for win bug-78021-20120209125538.patch text/plain 3428 zimmermann U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3MjEzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTRmYjJkMDYwNmM2OTM4ZmIzZTM1ZTE1OTA0NTk0YmY2 ZTkyYjZkMy4uMDM4MzBjN2M5MTVmMmIyMDJlYjk1ZjA4OTc4M2NkNTEwYzQ5NWZjMSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDEyLTAyLTA5ICBOaWtvbGFzIFppbW1lcm1hbm4gIDxuemltbWVybWFubkByaW0uY29t PgorCisgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLmRpc3BsYXkoKSBpcyBmbGFreSBmb3Ig U1ZHIHRlc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD03ODAyMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEFwcGx5IHRoZSBzYW1lIGZpeCB0byBEUlQvV2luLCBhcyBwcmV2aW91c2x5IGFwcGxpZWQgdG8g RFJUL01hYy4KKyAgICAgICAgU2l6ZSB0aGUgd2ViIHZpZXcgYmVmb3JlIHJ1bm5pbmcgdGhlIHRl c3QsIG5vdCB3aGVuIGR1bXBpbmcuCisgICAgICAgIEFsbCBwbGF0Zm9ybXMgaGFuZGxlIHRoaXMg Y29ycmVjdGx5IG5vdy4KKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL3dpbi9EdW1wUmVuZGVy VHJlZS5jcHA6CisgICAgICAgIChkdW1wKToKKyAgICAgICAgKHNpemVXZWJWaWV3Rm9yQ3VycmVu dFRlc3QpOgorICAgICAgICAocnVuVGVzdCk6CisKIDIwMTItMDItMDkgIFJ5b3N1a2UgTml3YSAg PHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAga2lsbC1vbGQtcHJvY2Vzc2VzIHNob3VsZCBr aWxsIGdjYyBhbmQgY2xhbmcKZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL3dpbi9E dW1wUmVuZGVyVHJlZS5jcHAgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS93aW4vRHVtcFJlbmRlclRy ZWUuY3BwCmluZGV4IDFlYzVjNWU2MDdlZjZkYjc0NGNlZWZkOTZmZGI4NTQzYzljNmFmYWYuLjg4 YzdmZGZkZjljZjBiM2ZmNGYxYmYyOTY0MTU4M2Y5YTIyMWJkY2EgMTAwNjQ0Ci0tLSBhL1Rvb2xz L0R1bXBSZW5kZXJUcmVlL3dpbi9EdW1wUmVuZGVyVHJlZS5jcHAKKysrIGIvVG9vbHMvRHVtcFJl bmRlclRyZWUvd2luL0R1bXBSZW5kZXJUcmVlLmNwcApAQCAtNzIyLDI3ICs3MjIsMTMgQEAgdm9p ZCBkdW1wKCkKICAgICBCU1RSIHJlc3VsdFN0cmluZyA9IDA7CiAKICAgICBpZiAoZHVtcFRyZWUp IHsKKyAgICAgICAgOjpJbnZhbGlkYXRlUmVjdCh3ZWJWaWV3V2luZG93LCAwLCBUUlVFKTsKKyAg ICAgICAgOjpTZW5kTWVzc2FnZSh3ZWJWaWV3V2luZG93LCBXTV9QQUlOVCwgMCwgMCk7CisKICAg ICAgICAgaWYgKDo6Z0xheW91dFRlc3RDb250cm9sbGVyLT5kdW1wQXNUZXh0KCkpIHsKLSAgICAg ICAgICAgIDo6SW52YWxpZGF0ZVJlY3Qod2ViVmlld1dpbmRvdywgMCwgVFJVRSk7Ci0gICAgICAg ICAgICA6OlNlbmRNZXNzYWdlKHdlYlZpZXdXaW5kb3csIFdNX1BBSU5ULCAwLCAwKTsKICAgICAg ICAgICAgIHdzdHJpbmcgcmVzdWx0ID0gZHVtcEZyYW1lc0FzVGV4dChmcmFtZSk7CiAgICAgICAg ICAgICByZXN1bHRTdHJpbmcgPSBTeXNBbGxvY1N0cmluZ0xlbihyZXN1bHQuZGF0YSgpLCByZXN1 bHQuc2l6ZSgpKTsKICAgICAgICAgfSBlbHNlIHsKLSAgICAgICAgICAgIGJvb2wgaXNTVkdXM0NU ZXN0ID0gKGdMYXlvdXRUZXN0Q29udHJvbGxlci0+dGVzdFBhdGhPclVSTCgpLmZpbmQoInN2Z1xc VzNDLVNWRy0xLjEiKSAhPSBzdHJpbmc6Om5wb3MpOwotICAgICAgICAgICAgdW5zaWduZWQgd2lk dGg7Ci0gICAgICAgICAgICB1bnNpZ25lZCBoZWlnaHQ7Ci0gICAgICAgICAgICBpZiAoaXNTVkdX M0NUZXN0KSB7Ci0gICAgICAgICAgICAgICAgd2lkdGggPSA0ODA7Ci0gICAgICAgICAgICAgICAg aGVpZ2h0ID0gMzYwOwotICAgICAgICAgICAgfSBlbHNlIHsKLSAgICAgICAgICAgICAgICB3aWR0 aCA9IExheW91dFRlc3RDb250cm9sbGVyOjptYXhWaWV3V2lkdGg7Ci0gICAgICAgICAgICAgICAg aGVpZ2h0ID0gTGF5b3V0VGVzdENvbnRyb2xsZXI6Om1heFZpZXdIZWlnaHQ7Ci0gICAgICAgICAg ICB9Ci0KLSAgICAgICAgICAgIDo6U2V0V2luZG93UG9zKHdlYlZpZXdXaW5kb3csIDAsIDAsIDAs IHdpZHRoLCBoZWlnaHQsIFNXUF9OT01PVkUpOwotICAgICAgICAgICAgOjpJbnZhbGlkYXRlUmVj dCh3ZWJWaWV3V2luZG93LCAwLCBUUlVFKTsKLSAgICAgICAgICAgIDo6U2VuZE1lc3NhZ2Uod2Vi Vmlld1dpbmRvdywgV01fUEFJTlQsIDAsIDApOwotCiAgICAgICAgICAgICBDT01QdHI8SVdlYkZy YW1lUHJpdmF0ZT4gZnJhbWVQcml2YXRlOwogICAgICAgICAgICAgaWYgKEZBSUxFRChmcmFtZS0+ UXVlcnlJbnRlcmZhY2UoJmZyYW1lUHJpdmF0ZSkpKQogICAgICAgICAgICAgICAgIGdvdG8gZmFp bDsKQEAgLTk0Niw2ICs5MzIsMjIgQEAgc3RhdGljIHZvaWQgcmVzZXRXZWJWaWV3VG9Db25zaXN0 ZW50U3RhdGVCZWZvcmVUZXN0aW5nKCkKICAgICAgICAgZnJhbWVQcml2YXRlLT5jbGVhck9wZW5l cigpOwogfQogCitzdGF0aWMgdm9pZCBzaXplV2ViVmlld0ZvckN1cnJlbnRUZXN0KCkKK3sKKyAg ICBib29sIGlzU1ZHVzNDVGVzdCA9IChnTGF5b3V0VGVzdENvbnRyb2xsZXItPnRlc3RQYXRoT3JV UkwoKS5maW5kKCJzdmdcXFczQy1TVkctMS4xIikgIT0gc3RyaW5nOjpucG9zKTsKKyAgICB1bnNp Z25lZCB3aWR0aDsKKyAgICB1bnNpZ25lZCBoZWlnaHQ7CisgICAgaWYgKGlzU1ZHVzNDVGVzdCkg eworICAgICAgICB3aWR0aCA9IDQ4MDsKKyAgICAgICAgaGVpZ2h0ID0gMzYwOworICAgIH0gZWxz ZSB7CisgICAgICAgIHdpZHRoID0gTGF5b3V0VGVzdENvbnRyb2xsZXI6Om1heFZpZXdXaWR0aDsK KyAgICAgICAgaGVpZ2h0ID0gTGF5b3V0VGVzdENvbnRyb2xsZXI6Om1heFZpZXdIZWlnaHQ7Cisg ICAgfQorCisgICAgOjpTZXRXaW5kb3dQb3Mod2ViVmlld1dpbmRvdywgMCwgMCwgMCwgd2lkdGgs IGhlaWdodCwgU1dQX05PTU9WRSk7Cit9CisKIHN0YXRpYyB2b2lkIHJ1blRlc3QoY29uc3Qgc3Ry aW5nJiB0ZXN0UGF0aE9yVVJMKQogewogICAgIHN0YXRpYyBCU1RSIG1ldGhvZEJTdHIgPSBTeXNB bGxvY1N0cmluZyhURVhUKCJHRVQiKSk7CkBAIC05ODUsNiArOTg3LDcgQEAgc3RhdGljIHZvaWQg cnVuVGVzdChjb25zdCBzdHJpbmcmIHRlc3RQYXRoT3JVUkwpCiAgICAgZG9uZSA9IGZhbHNlOwog ICAgIHRvcExvYWRpbmdGcmFtZSA9IDA7CiAKKyAgICBzaXplV2ViVmlld0ZvckN1cnJlbnRUZXN0 KCk7CiAgICAgZ0xheW91dFRlc3RDb250cm9sbGVyLT5zZXRJY29uRGF0YWJhc2VFbmFibGVkKGZh bHNlKTsKIAogICAgIGlmIChzaG91bGRMb2dGcmFtZUxvYWREZWxlZ2F0ZXMocGF0aE9yVVJMLmNf c3RyKCkpKQo=