78014 2012-02-07 11:54:59 -0800 [chromium] Pepper Plugins don't receive mouse movement information in non-mouse-lock mode. 2012-02-14 00:55:55 -0800 1 1 1 Unclassified WebKit UI Events 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 yzshen yzshen scheib tony webkit.review.bot oldest_to_newest 551201 0 yzshen 2012-02-07 11:54:59 -0800 WebMouseEventBuilder doesn't pass along mouse movement information properly. 551319 1 125916 yzshen 2012-02-07 13:33:08 -0800 Created attachment 125916 Patch 551357 2 scheib 2012-02-07 14:03:39 -0800 LGTM, Though I'm not a reviewer. 551367 3 tony 2012-02-07 14:13:36 -0800 Is it possible to write a test for this? Maybe we have one in chromium? 551390 4 yzshen 2012-02-07 14:20:39 -0800 (In reply to comment #3) > Is it possible to write a test for this? Maybe we have one in chromium? For now, we have a manual test at the chromium side. (I agree that automatic tests are better. :)) 551437 5 tony 2012-02-07 15:07:40 -0800 (In reply to comment #4) > (In reply to comment #3) > > Is it possible to write a test for this? Maybe we have one in chromium? > > For now, we have a manual test at the chromium side. > (I agree that automatic tests are better. :)) Is it possible to write a layout test for this? 551440 6 yzshen 2012-02-07 15:09:52 -0800 (In reply to comment #5) > (In reply to comment #4) > > (In reply to comment #3) > > > Is it possible to write a test for this? Maybe we have one in chromium? > > > > For now, we have a manual test at the chromium side. > > (I agree that automatic tests are better. :)) > > Is it possible to write a layout test for this? I will look into it. Thanks! 551493 7 125916 eric 2012-02-07 15:48:27 -0800 Comment on attachment 125916 Patch How can we test this? 551495 8 125916 eric 2012-02-07 15:49:20 -0800 Comment on attachment 125916 Patch Ah, I see now that test investigation is underway. Marking r- to remove from the queue. Feel free to remark r? if you find testing impossible/impractical (ideally you'd update the changelog to say such). 555606 9 yzshen 2012-02-13 14:28:17 -0800 Hi, Tony and Eric. I took a look and think that it is probably not easy/useful to add a test for this change: - there isn't any test for WebMouseEventBuilder right now; moreover, the movement information added is only used by pepper, and there isn't any test for pepper at the WebKit side. (AFAIK, WebKit doesn't know anything about pepper.) - this change is trivial: it copies two newly-added data fields from MouseEvent to WebMouseEventBuilder during conversion. Please let me know if you think it is okay to commit without a test. (And I will be happy to make changes if you know how to add a test.) 555609 10 tony 2012-02-13 14:33:23 -0800 (In reply to comment #9) > Hi, Tony and Eric. > > I took a look and think that it is probably not easy/useful to add a test for this change: > - there isn't any test for WebMouseEventBuilder right now; moreover, the movement information added is only used by pepper, and there isn't any test for pepper at the WebKit side. (AFAIK, WebKit doesn't know anything about pepper.) > - this change is trivial: it copies two newly-added data fields from MouseEvent to WebMouseEventBuilder during conversion. > > Please let me know if you think it is okay to commit without a test. (And I will be happy to make changes if you know how to add a test.) I think it's fine to land the change without a test. Thanks for looking into why it doesn't make sense. Please put the reason for no layout test in the ChangeLog. 555641 11 126843 yzshen 2012-02-13 14:53:12 -0800 Created attachment 126843 Patch 555644 12 yzshen 2012-02-13 14:54:36 -0800 Thanks, Tony! Uploaded a patch with revised ChangeLog. 555659 13 tony 2012-02-13 15:15:24 -0800 BTW, it doesn't really matter that the change is trivial. One reason to have layout tests is to verify that there are no regressions in the future and even trivial parts of the code base can regress (e.g., when refactoring). 556069 14 126843 webkit.review.bot 2012-02-14 00:55:51 -0800 Comment on attachment 126843 Patch Clearing flags on attachment: 126843 Committed r107684: <http://trac.webkit.org/changeset/107684> 556070 15 webkit.review.bot 2012-02-14 00:55:55 -0800 All reviewed patches have been landed. Closing bug. 125916 2012-02-07 13:33:08 -0800 2012-02-13 14:53:09 -0800 Patch bug-78014-20120207133308.patch text/plain 1620 yzshen U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2MjE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDMzN2MzNzg2ZTVlMWNlMTk3MmNlMmRiY2Y4YjYxNDNiYmFmOGFlMTAuLmFjZjgyNzU2YWIwNWM2 YTdhYWY2ZTExMmI5OGIxNjg1MjZlZGNjMzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTItMDItMDcgIFl1emh1IFNoZW4gIDx5enNoZW5AY2hyb21pdW0u Y29tPgorCisgICAgICAgIFtjaHJvbWl1bV0gUGVwcGVyIHBsdWdpbnMgZG9uJ3QgcmVjZWl2ZSBt b3VzZSBtb3ZlbWVudCBpbmZvcm1hdGlvbiBpbgorICAgICAgICBub24tbW91c2UtbG9jayBtb2Rl LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzgwMTQK KworICAgICAgICBUaGlzIGNoYW5nZSBtYWtlcyBXZWJNb3VzZUV2ZW50QnVpbGRlciBwYXNzIGFs b25nIG1vdXNlIG1vdmVtZW50CisgICAgICAgIGluZm9ybWF0aW9uIHByb3Blcmx5LgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogc3JjL1dlYklucHV0 RXZlbnRDb252ZXJzaW9uLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViTW91c2VFdmVudEJ1aWxk ZXI6OldlYk1vdXNlRXZlbnRCdWlsZGVyKToKKwogMjAxMi0wMS0yOSAgTmljbyBXZWJlciAgPG5p Y29sYXN3ZWJlckBnbXguZGU+CiAKICAgICAgICAgW2Nocm9taXVtL21hY10gRml4IHR3by1maW5n ZXIgc2Nyb2xsaW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJ bnB1dEV2ZW50Q29udmVyc2lvbi5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJ bnB1dEV2ZW50Q29udmVyc2lvbi5jcHAKaW5kZXggZGRkNDczNmFiMGU2NjVmYjU1NjcxZDVjNzE2 ZjVhZjU1ZjA5NjY5Ni4uYzk5M2Q1MDE3YzI3NTg1MDI0NjI0OWY0ZTdkNTY0YzBhNjFmODgzNCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViSW5wdXRFdmVudENvbnZl cnNpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYklucHV0RXZlbnRD b252ZXJzaW9uLmNwcApAQCAtMzg0LDYgKzM4NCwxMCBAQCBXZWJNb3VzZUV2ZW50QnVpbGRlcjo6 V2ViTW91c2VFdmVudEJ1aWxkZXIoY29uc3QgV2lkZ2V0KiB3aWRnZXQsIGNvbnN0IE1vdXNlRXZl bgogICAgIHdpbmRvd1kgPSBwLnkoKTsKICAgICB4ID0gZXZlbnQuYWJzb2x1dGVMb2NhdGlvbigp LngoKSAtIHdpZGdldC0+bG9jYXRpb24oKS54KCk7CiAgICAgeSA9IGV2ZW50LmFic29sdXRlTG9j YXRpb24oKS55KCkgLSB3aWRnZXQtPmxvY2F0aW9uKCkueSgpOworI2lmIEVOQUJMRShQT0lOVEVS X0xPQ0spCisgICAgbW92ZW1lbnRYID0gZXZlbnQud2Via2l0TW92ZW1lbnRYKCk7CisgICAgbW92 ZW1lbnRZID0gZXZlbnQud2Via2l0TW92ZW1lbnRZKCk7CisjZW5kaWYKICAgICBjbGlja0NvdW50 ID0gZXZlbnQuZGV0YWlsKCk7CiB9CiAK 126843 2012-02-13 14:53:12 -0800 2012-02-14 00:55:51 -0800 Patch bug-78014-20120213145312.patch text/plain 1999 yzshen U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3Mzg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDQ3OTM1YTBmYTA0MWNkZGM3NjRkMTJmYmFiN2UwNmEzMDg4NWNjMGUuLmUxN2NmYTExYjY5NTQ3 NmE0ZWZhMDYzNzg4ZGE3ODAxYjdmZmE5ZmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjQgQEAKKzIwMTItMDItMTMgIFl1emh1IFNoZW4gIDx5enNoZW5AY2hyb21pdW0u Y29tPgorCisgICAgICAgIFtjaHJvbWl1bV0gUGVwcGVyIHBsdWdpbnMgZG9uJ3QgcmVjZWl2ZSBt b3VzZSBtb3ZlbWVudCBpbmZvcm1hdGlvbiBpbgorICAgICAgICBub24tbW91c2UtbG9jayBtb2Rl LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzgwMTQK KworICAgICAgICBUaGlzIGNoYW5nZSBtYWtlcyBXZWJNb3VzZUV2ZW50QnVpbGRlciBwYXNzIGFs b25nIG1vdXNlIG1vdmVtZW50CisgICAgICAgIGluZm9ybWF0aW9uIHByb3Blcmx5LgorCisgICAg ICAgIFRoZXJlIGlzbid0IHRlc3QgZm9yIHRoaXMgY2hhbmdlIGJlY2F1c2U6CisgICAgICAgIC0g dGhlIG1vdmVtZW50IGluZm9ybWF0aW9uIGFkZGVkIGlzIG9ubHkgdXNlZCBieSBwZXBwZXIsIGFu ZCB0aGVyZQorICAgICAgICAgIGlzbid0IGFueSB0ZXN0IGZvciBwZXBwZXIgYXQgdGhlIFdlYktp dCBzaWRlLiAoV2ViS2l0IGRvZXNuJ3Qga25vdworICAgICAgICAgIGFib3V0IHBlcHBlci4pCisg ICAgICAgIC0gdGhpcyBjaGFuZ2UgaXMgdHJpdmlhbC4gSXQganVzdCBjb3BpZXMgdHdvIG5ld2x5 LWFkZGVkIGRhdGEgZmllbGRzCisgICAgICAgICAgZnJvbSBNb3VzZUV2ZW50IHRvIFdlYk1vdXNl RXZlbnRCdWlsZGVyIGR1cmluZyBjb252ZXJzaW9uLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogc3JjL1dlYklucHV0RXZlbnRDb252ZXJzaW9uLmNw cDoKKyAgICAgICAgKFdlYktpdDo6V2ViTW91c2VFdmVudEJ1aWxkZXI6OldlYk1vdXNlRXZlbnRC dWlsZGVyKToKKwogMjAxMi0wMi0wOSAgS2VuaWNoaSBJc2hpYmFzaGkgIDxiYXNoaUBjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgQWRkIFdlYlNvY2tldCBleHRlbnNpb24gc3VwcG9ydApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViSW5wdXRFdmVudENvbnZlcnNpb24u Y3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViSW5wdXRFdmVudENvbnZlcnNpb24u Y3BwCmluZGV4IDY0YmEzMTE3MGNlOWNmNTlhZTVjZDBjODUyM2VjMjI1NThlODI4YTMuLjVjZjBj Y2FlY2FhNDM2OGRmOGNjNGNhNTNlMTQyOGVmYzA5ZTgwMmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vc3JjL1dlYklucHV0RXZlbnRDb252ZXJzaW9uLmNwcAorKysgYi9Tb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJbnB1dEV2ZW50Q29udmVyc2lvbi5jcHAKQEAgLTM4 OSw2ICszODksMTAgQEAgV2ViTW91c2VFdmVudEJ1aWxkZXI6OldlYk1vdXNlRXZlbnRCdWlsZGVy KGNvbnN0IFdpZGdldCogd2lkZ2V0LCBjb25zdCBNb3VzZUV2ZW4KICAgICB3aW5kb3dZID0gcC55 KCk7CiAgICAgeCA9IGV2ZW50LmFic29sdXRlTG9jYXRpb24oKS54KCkgLSB3aWRnZXQtPmxvY2F0 aW9uKCkueCgpOwogICAgIHkgPSBldmVudC5hYnNvbHV0ZUxvY2F0aW9uKCkueSgpIC0gd2lkZ2V0 LT5sb2NhdGlvbigpLnkoKTsKKyNpZiBFTkFCTEUoUE9JTlRFUl9MT0NLKQorICAgIG1vdmVtZW50 WCA9IGV2ZW50LndlYmtpdE1vdmVtZW50WCgpOworICAgIG1vdmVtZW50WSA9IGV2ZW50LndlYmtp dE1vdmVtZW50WSgpOworI2VuZGlmCiAgICAgY2xpY2tDb3VudCA9IGV2ZW50LmRldGFpbCgpOwog fQogCg==