78000 2012-02-07 10:32:35 -0800 Remove redundant checks in CanvasRenderingContext2D.cpp 2012-02-07 12:04:28 -0800 1 1 1 Unclassified WebKit Canvas 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mdelaney7 mdelaney7 cmarrin mdelaney7 mitz simon.fraser oldest_to_newest 551104 0 mdelaney7 2012-02-07 10:32:35 -0800 Remove redundant checks in CRC2D.cpp 551110 1 125874 mdelaney7 2012-02-07 10:35:47 -0800 Created attachment 125874 Patch 551149 2 125874 simon.fraser 2012-02-07 11:17:35 -0800 Comment on attachment 125874 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125874&action=review > Source/WebCore/ChangeLog:3 > + Remove redundant checks in CRC2D.cpp I read CRC2D.cpp and assumed it was about cyclic redundancy checks. Please don't abbreviate. 551209 3 mdelaney7 2012-02-07 12:00:00 -0800 > I read CRC2D.cpp and assumed it was about cyclic redundancy checks. Please don't abbreviate. But the name is sooooo long! :-P 551217 4 mdelaney7 2012-02-07 12:04:28 -0800 Committed r106973: <http://trac.webkit.org/changeset/106973> 125874 2012-02-07 10:35:47 -0800 2012-02-07 11:17:35 -0800 Patch bug-78000-20120207103545.patch text/plain 3695 mdelaney7 SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwNjk1OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTAyLTA3ICBNYXR0aGV3 IERlbGFuZXkgIDxtZGVsYW5leUBhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIHJlZHVuZGFu dCBjaGVja3MgaW4gQ1JDMkQuY3BwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD03ODAwMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkNhbnZhc1JlbmRlcmluZ0NvbnRleHQyRDo6c2V0U2hhZG93Q29s b3IpOgorICAgICAgICAoV2ViQ29yZTo6Q2FudmFzUmVuZGVyaW5nQ29udGV4dDJEOjpzZXRTaGFk b3cpOgorICAgICAgICAoV2ViQ29yZTo6Q2FudmFzUmVuZGVyaW5nQ29udGV4dDJEOjpkcmF3SW1h Z2UpOgorCiAyMDEyLTAyLTA3ICBQZXRlciBSeWJpbiAgPHBldGVyLnJ5YmluQGdtYWlsLmNvbT4K IAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBDb2RlR2VuZXJhdG9ySW5zcGVjdG9yLnB5OiBleHRl bmQgQXJyYXkgdmFsaWRhdG9yIGZ1bmN0aW9uYWxpdHkKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2h0 bWwvY2FudmFzL0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyRC5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcAkocmV2 aXNpb24gMTA2ODY0KQorKysgU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVy aW5nQ29udGV4dDJELmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDk2LDcgKzQ5Niw2IEBAIHZvaWQg Q2FudmFzUmVuZGVyaW5nQ29udGV4dDJEOjpzZXRTaGFkb3cKIHsKICAgICBpZiAoIXBhcnNlQ29s b3JPckN1cnJlbnRDb2xvcihzdGF0ZSgpLm1fc2hhZG93Q29sb3IsIGNvbG9yLCBjYW52YXMoKSkp CiAgICAgICAgIHJldHVybjsKLQogICAgIGFwcGx5U2hhZG93KCk7CiB9CiAKQEAgLTExNDUsMTEg KzExNDQsNiBAQCB2b2lkIENhbnZhc1JlbmRlcmluZ0NvbnRleHQyRDo6c2V0U2hhZG93CiAgICAg c3RhdGUoKS5tX3NoYWRvd09mZnNldCA9IEZsb2F0U2l6ZSh3aWR0aCwgaGVpZ2h0KTsKICAgICBz dGF0ZSgpLm1fc2hhZG93Qmx1ciA9IGJsdXI7CiAgICAgc3RhdGUoKS5tX3NoYWRvd0NvbG9yID0g bWFrZVJHQkEzMkZyb21GbG9hdHMoZ3JheUxldmVsLCBncmF5TGV2ZWwsIGdyYXlMZXZlbCwgMS4w Zik7Ci0KLSAgICBHcmFwaGljc0NvbnRleHQqIGMgPSBkcmF3aW5nQ29udGV4dCgpOwotICAgIGlm ICghYykKLSAgICAgICAgcmV0dXJuOwotCiAgICAgYXBwbHlTaGFkb3coKTsKIH0KIApAQCAtMTE2 MywxMSArMTE1Nyw2IEBAIHZvaWQgQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJEOjpzZXRTaGFkb3cK ICAgICBzdGF0ZSgpLm1fc2hhZG93Q29sb3IgPSBjb2xvcldpdGhPdmVycmlkZUFscGhhKHJnYmEs IGFscGhhKTsKICAgICBzdGF0ZSgpLm1fc2hhZG93T2Zmc2V0ID0gRmxvYXRTaXplKHdpZHRoLCBo ZWlnaHQpOwogICAgIHN0YXRlKCkubV9zaGFkb3dCbHVyID0gYmx1cjsKLQotICAgIEdyYXBoaWNz Q29udGV4dCogYyA9IGRyYXdpbmdDb250ZXh0KCk7Ci0gICAgaWYgKCFjKQotICAgICAgICByZXR1 cm47Ci0KICAgICBhcHBseVNoYWRvdygpOwogfQogCkBAIC0xMTc2LDExICsxMTY1LDYgQEAgdm9p ZCBDYW52YXNSZW5kZXJpbmdDb250ZXh0MkQ6OnNldFNoYWRvdwogICAgIHN0YXRlKCkubV9zaGFk b3dPZmZzZXQgPSBGbG9hdFNpemUod2lkdGgsIGhlaWdodCk7CiAgICAgc3RhdGUoKS5tX3NoYWRv d0JsdXIgPSBibHVyOwogICAgIHN0YXRlKCkubV9zaGFkb3dDb2xvciA9IG1ha2VSR0JBMzJGcm9t RmxvYXRzKGdyYXlMZXZlbCwgZ3JheUxldmVsLCBncmF5TGV2ZWwsIGFscGhhKTsKLQotICAgIEdy YXBoaWNzQ29udGV4dCogYyA9IGRyYXdpbmdDb250ZXh0KCk7Ci0gICAgaWYgKCFjKQotICAgICAg ICByZXR1cm47Ci0KICAgICBhcHBseVNoYWRvdygpOwogfQogCkBAIC0xMTg5LDExICsxMTczLDYg QEAgdm9pZCBDYW52YXNSZW5kZXJpbmdDb250ZXh0MkQ6OnNldFNoYWRvdwogICAgIHN0YXRlKCku bV9zaGFkb3dPZmZzZXQgPSBGbG9hdFNpemUod2lkdGgsIGhlaWdodCk7CiAgICAgc3RhdGUoKS5t X3NoYWRvd0JsdXIgPSBibHVyOwogICAgIHN0YXRlKCkubV9zaGFkb3dDb2xvciA9IG1ha2VSR0JB MzJGcm9tRmxvYXRzKHIsIGcsIGIsIGEpOwotCi0gICAgR3JhcGhpY3NDb250ZXh0KiBjID0gZHJh d2luZ0NvbnRleHQoKTsKLSAgICBpZiAoIWMpCi0gICAgICAgIHJldHVybjsKLQogICAgIGFwcGx5 U2hhZG93KCk7CiB9CiAKQEAgLTEyOTQsMTAgKzEyNzMsNiBAQCB2b2lkIENhbnZhc1JlbmRlcmlu Z0NvbnRleHQyRDo6ZHJhd0ltYWdlCiAgICAgZmxvYXQgc3gsIGZsb2F0IHN5LCBmbG9hdCBzdywg ZmxvYXQgc2gsCiAgICAgZmxvYXQgZHgsIGZsb2F0IGR5LCBmbG9hdCBkdywgZmxvYXQgZGgsIEV4 Y2VwdGlvbkNvZGUmIGVjKQogewotICAgIGlmICghaW1hZ2UpIHsKLSAgICAgICAgZWMgPSBUWVBF X01JU01BVENIX0VSUjsKLSAgICAgICAgcmV0dXJuOwotICAgIH0KICAgICBkcmF3SW1hZ2UoaW1h Z2UsIEZsb2F0UmVjdChzeCwgc3ksIHN3LCBzaCksIEZsb2F0UmVjdChkeCwgZHksIGR3LCBkaCks IGVjKTsKIH0KIApAQCAtMTM2NiwyMSArMTM0MSwxMiBAQCB2b2lkIENhbnZhc1JlbmRlcmluZ0Nv bnRleHQyRDo6ZHJhd0ltYWdlCiAKIHZvaWQgQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJEOjpkcmF3 SW1hZ2UoSFRNTENhbnZhc0VsZW1lbnQqIHNvdXJjZUNhbnZhcywgZmxvYXQgeCwgZmxvYXQgeSwg RXhjZXB0aW9uQ29kZSYgZWMpCiB7Ci0gICAgaWYgKCFzb3VyY2VDYW52YXMpIHsKLSAgICAgICAg ZWMgPSBUWVBFX01JU01BVENIX0VSUjsKLSAgICAgICAgcmV0dXJuOwotICAgIH0KLQogICAgIGRy YXdJbWFnZShzb3VyY2VDYW52YXMsIDAsIDAsIHNvdXJjZUNhbnZhcy0+d2lkdGgoKSwgc291cmNl Q2FudmFzLT5oZWlnaHQoKSwgeCwgeSwgc291cmNlQ2FudmFzLT53aWR0aCgpLCBzb3VyY2VDYW52 YXMtPmhlaWdodCgpLCBlYyk7CiB9CiAKIHZvaWQgQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJEOjpk cmF3SW1hZ2UoSFRNTENhbnZhc0VsZW1lbnQqIHNvdXJjZUNhbnZhcywKICAgICBmbG9hdCB4LCBm bG9hdCB5LCBmbG9hdCB3aWR0aCwgZmxvYXQgaGVpZ2h0LCBFeGNlcHRpb25Db2RlJiBlYykKIHsK LSAgICBpZiAoIXNvdXJjZUNhbnZhcykgewotICAgICAgICBlYyA9IFRZUEVfTUlTTUFUQ0hfRVJS OwotICAgICAgICByZXR1cm47Ci0gICAgfQogICAgIGRyYXdJbWFnZShzb3VyY2VDYW52YXMsIEZs b2F0UmVjdCgwLCAwLCBzb3VyY2VDYW52YXMtPndpZHRoKCksIHNvdXJjZUNhbnZhcy0+aGVpZ2h0 KCkpLCBGbG9hdFJlY3QoeCwgeSwgd2lkdGgsIGhlaWdodCksIGVjKTsKIH0KIAo=