77970 2012-02-07 04:58:42 -0800 Remove the [ReplaceableConstructor] IDL attribute 2021-08-04 17:16:08 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 149412 P2 Normal --- 77393 1 haraken haraken abarth ashvayka darin eric japhet sam webkit.review.bot oldest_to_newest 550870 0 haraken 2012-02-07 04:58:42 -0800 It would make sense to replace the [ReplaceableConstructor] attribute with "DOMWindow" for the following reasons: - The [ReplaceableConstructor] attribute is used by JSC's DOMWindow.idl only. - CodeGeneratorJS.pm supports the [ReplaceableConstructor] attribute for DOMWindow.idl only (If we use [RepaceableConstructor] in other IDL files, then CodeGeneratorJS.pm dies). - DOMWindow is already handled specially here and there in code generators. 550872 1 125820 haraken 2012-02-07 05:01:51 -0800 Created attachment 125820 Patch 551507 2 125820 eric 2012-02-07 16:00:00 -0800 Comment on attachment 125820 Patch Seems reasonable. 551512 3 125820 haraken 2012-02-07 16:02:24 -0800 Comment on attachment 125820 Patch Eric: Thanks for review. In bug 77966, we have been discussing how hard-coded "DOMWindow" in code generators should be removed. Let me commit the patch after that discussion. 1782102 4 ashvayka 2021-08-04 17:16:08 -0700 [ReplaceableConstructor] was removed in r190085, as part of %Interface%.prototype.constructor attributes fix. *** This bug has been marked as a duplicate of bug 149412 *** 125820 2012-02-07 05:01:51 -0800 2012-02-07 16:02:24 -0800 Patch bug-77970-20120207220150.patch text/plain 4417 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2OTE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDZkYjJmNGQ1ZGIwYmZh MjZlNDA3NTA1OGIzMzY1N2U3NGIxOTBmZS4uZTc4MTAxYmUxN2EzNWZmYzRiMmFiZTc1MTU2MjUw M2VjODE5NDI0NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEyLTAyLTA3ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZW1vdmUgdGhlIFtS ZXBsYWNlYWJsZUNvbnN0cnVjdG9yXSBJREwgYXR0cmlidXRlCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03Nzk3MAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgcGF0Y2ggcmVwbGFjZXMgdGhlIFtSZXBs YWNlYWJsZUNvbnN0cnVjdG9yXSBhdHRyaWJ1dGUgd2l0aAorICAgICAgICAiRE9NV2luZG93IiBm b3IgdGhlIGZvbGxvd2luZyByZWFzb25zOgorCisgICAgICAgIC0gQ29kZUdlbmVyYXRvckpTLnBt IHN1cHBvcnRzIHRoZSBbUmVwbGFjZWFibGVDb25zdHJ1Y3Rvcl0gYXR0cmlidXRlIGZvcgorICAg ICAgICBET01XaW5kb3cuaWRsIG9ubHkgKElmIHdlIHVzZSBbUmVwYWNlYWJsZUNvbnN0cnVjdG9y XSBpbiBvdGhlciBJREwgZmlsZXMsCisgICAgICAgIHRoZW4gQ29kZUdlbmVyYXRvckpTLnBtIGRp ZXMpLgorICAgICAgICAtIERPTVdpbmRvdyBpcyBhbHJlYWR5IGhhbmRsZWQgc3BlY2lhbGx5IGhl cmUgYW5kIHRoZXJlIGluIGNvZGUgZ2VuZXJhdG9ycy4KKworICAgICAgICBObyB0ZXN0cy4gTm8g Y2hhbmdlIGluIGJlaGF2aW9yLgorCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2Vu ZXJhdG9ySlMucG06CisgICAgICAgIChHZW5lcmF0ZUhlYWRlcik6CisgICAgICAgIChHZW5lcmF0 ZUF0dHJpYnV0ZXNIYXNoVGFibGUpOgorICAgICAgICAoR2VuZXJhdGVJbXBsZW1lbnRhdGlvbik6 CisgICAgICAgICogcGFnZS9ET01XaW5kb3cuaWRsOgorCiAyMDEyLTAyLTA3ICBTaGVyaWZmIEJv dCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBy b2xsaW5nIG91dCByMTA2OTEyLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv c2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG0gYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3Jp cHRzL0NvZGVHZW5lcmF0b3JKUy5wbQppbmRleCA5MzNlMjQ1Zjg0M2VkNzNlNTMyZmJiYTQ5ODMz NThmMjQwYjI5NmNiLi5iZTliNTQyMTBiYWI0MGZhNTc3Zjk1ODIwOTI3NWZkZTBjYmQ5MjllIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JK Uy5wbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JK Uy5wbQpAQCAtMTEwMCw3ICsxMTAwLDcgQEAgc3ViIEdlbmVyYXRlSGVhZGVyCiAgICAgICAgICAg ICBwdXNoKEBoZWFkZXJDb250ZW50LCAiSlNDOjpKU1ZhbHVlICR7Z2V0dGVyfShKU0M6OkV4ZWNT dGF0ZSosIEpTQzo6SlNWYWx1ZSwgY29uc3QgSlNDOjpJZGVudGlmaWVyJik7XG4iKTsKICAgICAg ICAgfQogCi0gICAgICAgIGlmICgkZGF0YU5vZGUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJSZXBs YWNlYWJsZUNvbnN0cnVjdG9yIn0pIHsKKyAgICAgICAgaWYgKCRpbnRlcmZhY2VOYW1lIGVxICJE T01XaW5kb3ciKSB7CiAgICAgICAgICAgICBteSAkY29uc3RydWN0b3JGdW5jdGlvbk5hbWUgPSAi c2V0SlMiIC4gJGludGVyZmFjZU5hbWUgLiAiQ29uc3RydWN0b3IiOwogICAgICAgICAgICAgcHVz aChAaGVhZGVyQ29udGVudCwgInZvaWQgJHtjb25zdHJ1Y3RvckZ1bmN0aW9uTmFtZX0oSlNDOjpF eGVjU3RhdGUqLCBKU0M6OkpTT2JqZWN0KiwgSlNDOjpKU1ZhbHVlKTtcbiIpOwogICAgICAgICB9 CkBAIC0xMTg4LDExICsxMTg4LDExIEBAIHN1YiBHZW5lcmF0ZUF0dHJpYnV0ZXNIYXNoVGFibGUo JCQpCiAgICAgICAgIHB1c2goQGhhc2hLZXlzLCAiY29uc3RydWN0b3IiKTsKICAgICAgICAgbXkg JGdldHRlciA9ICJqcyIgLiAkaW50ZXJmYWNlTmFtZSAuICJDb25zdHJ1Y3RvciI7CiAgICAgICAg IHB1c2goQGhhc2hWYWx1ZTEsICRnZXR0ZXIpOwotICAgICAgICBpZiAoJGRhdGFOb2RlLT5leHRl bmRlZEF0dHJpYnV0ZXMtPnsiUmVwbGFjZWFibGVDb25zdHJ1Y3RvciJ9KSB7CisgICAgICAgIGlm ICgkaW50ZXJmYWNlTmFtZSBlcSAiRE9NV2luZG93IikgewogICAgICAgICAgICAgbXkgJHNldHRl ciA9ICJzZXRKUyIgLiAkaW50ZXJmYWNlTmFtZSAuICJDb25zdHJ1Y3RvciI7CiAgICAgICAgICAg ICBwdXNoKEBoYXNoVmFsdWUyLCAkc2V0dGVyKTsKICAgICAgICAgICAgIHB1c2goQGhhc2hTcGVj aWFscywgIkRvbnRFbnVtIHwgRG9udERlbGV0ZSIpOwotICAgICAgICB9IGVsc2UgeyAgICAgICAg ICAgIAorICAgICAgICB9IGVsc2UgewogICAgICAgICAgICAgcHVzaChAaGFzaFZhbHVlMiwgIjAi KTsKICAgICAgICAgICAgIHB1c2goQGhhc2hTcGVjaWFscywgIkRvbnRFbnVtIHwgUmVhZE9ubHki KTsKICAgICAgICAgfQpAQCAtMjAwMiw3ICsyMDAyLDcgQEAgc3ViIEdlbmVyYXRlSW1wbGVtZW50 YXRpb24KICAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICB9CiAKLSAgICAgICAgICAgIGlm ICgkZGF0YU5vZGUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJSZXBsYWNlYWJsZUNvbnN0cnVjdG9y In0pIHsKKyAgICAgICAgICAgIGlmICgkaW50ZXJmYWNlTmFtZSBlcSAiRE9NV2luZG93Iikgewog ICAgICAgICAgICAgICAgIG15ICRjb25zdHJ1Y3RvckZ1bmN0aW9uTmFtZSA9ICJzZXRKUyIgLiAk aW50ZXJmYWNlTmFtZSAuICJDb25zdHJ1Y3RvciI7CiAKICAgICAgICAgICAgICAgICBwdXNoKEBp bXBsQ29udGVudCwgInZvaWQgJHtjb25zdHJ1Y3RvckZ1bmN0aW9uTmFtZX0oRXhlY1N0YXRlKiBl eGVjLCBKU09iamVjdCogdGhpc09iamVjdCwgSlNWYWx1ZSB2YWx1ZSlcbiIpOwpAQCAtMjAxNywx NCArMjAxNyw5IEBAIHN1YiBHZW5lcmF0ZUltcGxlbWVudGF0aW9uCiAgICAgICAgICAgICAgICAg fQogCiAgICAgICAgICAgICAgICAgcHVzaChAaW1wbENvbnRlbnQsICIgICAgLy8gU2hhZG93aW5n IGEgYnVpbHQtaW4gY29uc3RydWN0b3JcbiIpOwotCi0gICAgICAgICAgICAgICAgaWYgKCRpbnRl cmZhY2VOYW1lIGVxICJET01XaW5kb3ciKSB7Ci0gICAgICAgICAgICAgICAgICAgIHB1c2goQGlt cGxDb250ZW50LCAiICAgIHN0YXRpY19jYXN0PCRjbGFzc05hbWUqPih0aGlzT2JqZWN0KS0+cHV0 RGlyZWN0KGV4ZWMtPmdsb2JhbERhdGEoKSwgZXhlYy0+cHJvcGVydHlOYW1lcygpLmNvbnN0cnVj dG9yLCB2YWx1ZSk7XG4iKTsKLSAgICAgICAgICAgICAgICB9IGVsc2UgewotICAgICAgICAgICAg ICAgICAgICBkaWUgIk5vIHdheSB0byBoYW5kbGUgaW50ZXJmYWNlIHdpdGggUmVwbGFjZWFibGVD b25zdHJ1Y3RvciBleHRlbmRlZCBhdHRyaWJ1dGU6ICRpbnRlcmZhY2VOYW1lIjsKLSAgICAgICAg ICAgICAgICB9CisgICAgICAgICAgICAgICAgcHVzaChAaW1wbENvbnRlbnQsICIgICAgc3RhdGlj X2Nhc3Q8JGNsYXNzTmFtZSo+KHRoaXNPYmplY3QpLT5wdXREaXJlY3QoZXhlYy0+Z2xvYmFsRGF0 YSgpLCBleGVjLT5wcm9wZXJ0eU5hbWVzKCkuY29uc3RydWN0b3IsIHZhbHVlKTtcbiIpOwogICAg ICAgICAgICAgICAgIHB1c2goQGltcGxDb250ZW50LCAifVxuXG4iKTsKLSAgICAgICAgICAgIH0g ICAgICAgIAorICAgICAgICAgICAgfQogICAgICAgICB9CiAgICAgfQogCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RP TVdpbmRvdy5pZGwKaW5kZXggNjYwOWRmZTQ4NTc1ZTRjMGNjYmU2ZmZlODI0ZmY0YTU2NjFiMjAz Ni4uMDY2NmZkMjVhYjY3NDI4YzQxMjAxMDhjMGRiZGI5NTE5NjM4OTAwOCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGFnZS9ET01XaW5kb3cuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bh Z2UvRE9NV2luZG93LmlkbApAQCAtMzgsNyArMzgsNiBAQCBtb2R1bGUgd2luZG93IHsKICAgICAg ICAgRXZlbnRUYXJnZXQsCiAgICAgICAgIEV4dGVuZHNET01HbG9iYWxPYmplY3QsCiAgICAgICAg IEdlbmVyYXRlTmF0aXZlQ29udmVydGVyLAotICAgICAgICBSZXBsYWNlYWJsZUNvbnN0cnVjdG9y LAogICAgICAgICBKU0xlZ2FjeVBhcmVudD1KU0RPTVdpbmRvd0Jhc2UKICAgICBdIERPTVdpbmRv dyB7CiAgICAgICAgIC8vIERPTSBMZXZlbCAwCg==