77966 2012-02-07 04:42:36 -0800 Remove the [ExtendsDOMGlobalObject] IDL attribute 2013-11-20 03:01:38 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 118191 P2 Normal --- 77393 1 haraken haraken abarth darin japhet ojan webkit.review.bot zan oldest_to_newest 550849 0 haraken 2012-02-07 04:42:36 -0800 The [ExtendsDOMGlobalObject] attribute might be verbose. It is used only by DOMWindow.idl and IDL files with [IsWorkerContext] attribute. (Note: It would be OK to handle DOMWindow.idl specially in code generators (rather than introducing a new IDL attribute just for DOMWindow.idl), since DOMWindow.idl is already handled specially here and there.) 550855 1 125818 haraken 2012-02-07 04:47:47 -0800 Created attachment 125818 Patch 551066 2 ap 2012-02-07 09:44:08 -0800 I agree with what Darin said in webkit-deb thread - adding more special cases to code generating scripts is a step in the wrong direction. 551221 3 darin 2012-02-07 12:07:07 -0800 I do not think removing this keyword is an improvement. It’s probably the best-named one of the DOMWindow-related keywords. I think the other special cases of DOMWindow should be merged into this keyword or possibly one of the others if the concerns are really orthogonal. Hardcoding the actual name DOMWindow in the scripts is not nearly as good; we should work instead to wipe that out. Especially if features like workers eventually lead us to wanting to refactor this. 551514 4 125818 eric 2012-02-07 16:03:26 -0800 Comment on attachment 125818 Patch Hmmm... Seems like someone was trying to make the idl more general. This seems to be used in more places than just DOMWindow.idl? 551532 5 haraken 2012-02-07 16:16:44 -0800 > Hardcoding the actual name DOMWindow in the scripts is not nearly as good; OK. > I think the other special cases of DOMWindow should be merged into this keyword or possibly one of the others if the concerns are really orthogonal. There are 18 hard-coded "DOMWindow" in CodeGeneratorJS.pm and 25 hard-coded "DOMWindow" in CodeGeneratorV8.pm. At least, removing these hard-coded "DOMWindow"s by introducing many new IDL attributes would not be desirable. Maybe we can introduce [IsDOMWindow] attribute? Although this just replaces hard-coded "DOMWindow" to [IsDOMWindow] attribute, but code generators would be more readable than introducing many IDL attributes. (I do agree that we should avoid hard-coding in code generators, but it would be also important to make code generators more readable by reducing the number of IDL attributes, and prevent people from using "don't know" IDL attributes.) Then, [ExtendsDOMGlobalObject] can be replaced with "[IsDOMWindow] or [IsWorkerContext]". WDYT? 551586 6 darin 2012-02-07 17:17:13 -0800 (In reply to comment #5) > removing these hard-coded "DOMWindow"s by introducing many new IDL attributes would not be desirable Yes, I’d want to use existing IDL attributes or add a small number. I don’t think IsDOMWindow is the attribute I’d add, though. We could look at the 18 to find out what the pattern is of why DOMWindow is special. 599172 7 125818 haraken 2012-04-10 05:22:23 -0700 Comment on attachment 125818 Patch For now, let me invalidate r?. Sooner or later, I'd like to work on removing DOMWindow-specific IDL attributes. 952517 8 zan 2013-11-20 03:01:38 -0800 This attribute was removed in r152168 (bug #118191). http://trac.webkit.org/changeset/152168 Marking this bug as a duplicate of that one. *** This bug has been marked as a duplicate of bug 118191 *** 125818 2012-02-07 04:47:47 -0800 2012-04-10 05:22:23 -0700 Patch bug-77966-20120207214745.patch text/plain 4823 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2OTE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDZkYjJmNGQ1ZGIwYmZh MjZlNDA3NTA1OGIzMzY1N2U3NGIxOTBmZS4uZmQ2OWMwNTcxMjQ5MjlmMjU3N2Y0NmEzZWZjYTM1 N2Y5ODdjNjNlZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEyLTAyLTA3ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZW1vdmUgdGhlIFtF eHRlbmRzRE9NR2xvYmFsT2JqZWN0XSBJREwgYXR0cmlidXRlCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03Nzk2NgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBbRXh0ZW5kc0RPTUdsb2JhbE9iamVjdF0g YXR0cmlidXRlIGlzIHVzZWQgb25seSBieSBET01XaW5kb3cuaWRsIGFuZCBJREwgZmlsZXMKKyAg ICAgICAgd2l0aCBbSXNXb3JrZXJDb250ZXh0XSBhdHRyaWJ1dGUuIFRoaXMgcGF0Y2ggcmVwbGFj ZXMgW0V4dGVuZHNET01HbG9iYWxPYmplY3RdCisgICAgICAgIHdpdGggIkRPTVdpbmRvdyBvciBb SXNXb3JrZXJDb250ZXh0XSIuIEl0IHdvdWxkIGJlIE9LIHRvIGhhbmRsZSBET01XaW5kb3cgc3Bl Y2lhbGx5CisgICAgICAgIGluIGNvZGUgZ2VuZXJhdG9ycyByYXRoZXIgdGhhbiBpbnRyb2R1Y2lu ZyBhIG5ldyBJREwgYXR0cmlidXRlIGp1c3QgZm9yIERPTVdpbmRvdywKKyAgICAgICAgc2luY2Ug RE9NV2luZG93IGlzIGFscmVhZHkgaGFuZGxlZCBzcGVjaWFsbHkgaGVyZSBhbmQgdGhlcmUuCisK KyAgICAgICAgTm8gdGVzdHMuIE5vIGNoYW5nZSBpbiBiZWhhdmlvci4KKworICAgICAgICAqIGJp bmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtOgorICAgICAgICAoR2VuZXJhdGVIZWFk ZXIpOgorICAgICAgICAoR2VuZXJhdGVJbXBsZW1lbnRhdGlvbik6CisgICAgICAgICogcGFnZS9E T01XaW5kb3cuaWRsOgorICAgICAgICAqIHdvcmtlcnMvRGVkaWNhdGVkV29ya2VyQ29udGV4dC5p ZGw6CisgICAgICAgICogd29ya2Vycy9TaGFyZWRXb3JrZXJDb250ZXh0LmlkbDoKKyAgICAgICAg KiB3b3JrZXJzL1dvcmtlckNvbnRleHQuaWRsOgorCiAyMDEyLTAyLTA3ICBTaGVyaWZmIEJvdCAg PHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xs aW5nIG91dCByMTA2OTEyLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2Ny aXB0cy9Db2RlR2VuZXJhdG9ySlMucG0gYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRz L0NvZGVHZW5lcmF0b3JKUy5wbQppbmRleCA5MzNlMjQ1Zjg0M2VkNzNlNTMyZmJiYTQ5ODMzNThm MjQwYjI5NmNiLi5lNzM0NzVhNjM0Nzg1NzVjZTc1YjAyMzc5NzdmMDEwYjQwNjgwN2Y2IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5w bQorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5w bQpAQCAtNzQ3LDcgKzc0Nyw3IEBAIHN1YiBHZW5lcmF0ZUhlYWRlcgogICAgIH0KIAogICAgICMg UHJvdG90eXBlCi0gICAgcHVzaChAaGVhZGVyQ29udGVudCwgIiAgICBzdGF0aWMgSlNDOjpKU09i amVjdCogY3JlYXRlUHJvdG90eXBlKEpTQzo6RXhlY1N0YXRlKiwgSlNDOjpKU0dsb2JhbE9iamVj dCopO1xuIikgdW5sZXNzICgkZGF0YU5vZGUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJFeHRlbmRz RE9NR2xvYmFsT2JqZWN0In0pOworICAgIHB1c2goQGhlYWRlckNvbnRlbnQsICIgICAgc3RhdGlj IEpTQzo6SlNPYmplY3QqIGNyZWF0ZVByb3RvdHlwZShKU0M6OkV4ZWNTdGF0ZSosIEpTQzo6SlNH bG9iYWxPYmplY3QqKTtcbiIpIHVubGVzcyAkaW50ZXJmYWNlTmFtZSBlcSAiRE9NV2luZG93IiB8 fCAkZGF0YU5vZGUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJJc1dvcmtlckNvbnRleHQifTsKIAog ICAgICRoZWFkZXJUcmFpbGluZ0luY2x1ZGVzeyIke2NsYXNzTmFtZX1DdXN0b20uaCJ9ID0gMSBp ZiAkZGF0YU5vZGUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJDdXN0b21IZWFkZXIifTsKIApAQCAt MTU5NSw3ICsxNTk1LDcgQEAgc3ViIEdlbmVyYXRlSW1wbGVtZW50YXRpb24KICAgICAgICAgcHVz aChAaW1wbENvbnRlbnQsICJ9XG5cbiIpOwogICAgIH0KIAotICAgIGlmICghJGRhdGFOb2RlLT5l eHRlbmRlZEF0dHJpYnV0ZXMtPnsiRXh0ZW5kc0RPTUdsb2JhbE9iamVjdCJ9KSB7CisgICAgaWYg KCEoJGludGVyZmFjZU5hbWUgZXEgIkRPTVdpbmRvdyIgfHwgJGRhdGFOb2RlLT5leHRlbmRlZEF0 dHJpYnV0ZXMtPnsiSXNXb3JrZXJDb250ZXh0In0pKSB7CiAgICAgICAgIHB1c2goQGltcGxDb250 ZW50LCAiSlNPYmplY3QqICR7Y2xhc3NOYW1lfTo6Y3JlYXRlUHJvdG90eXBlKEV4ZWNTdGF0ZSog ZXhlYywgSlNHbG9iYWxPYmplY3QqIGdsb2JhbE9iamVjdClcbiIpOwogICAgICAgICBwdXNoKEBp bXBsQ29udGVudCwgIntcbiIpOwogICAgICAgICBpZiAoJGhhc1BhcmVudCAmJiAkcGFyZW50Q2xh c3NOYW1lIG5lICJKU0M6OkRPTU5vZGVGaWx0ZXIiKSB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wYWdlL0RPTVdpbmRvdy5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5p ZGwKaW5kZXggNjYwOWRmZTQ4NTc1ZTRjMGNjYmU2ZmZlODI0ZmY0YTU2NjFiMjAzNi4uZDg5MmFh NzlkZTIyNDNmYmJmNzgzODlmYzUxYWIyYTJkN2QxN2IxMiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcGFnZS9ET01XaW5kb3cuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NV2lu ZG93LmlkbApAQCAtMzYsNyArMzYsNiBAQCBtb2R1bGUgd2luZG93IHsKICAgICAgICAgSlNDdXN0 b21Ub05hdGl2ZU9iamVjdCwKICAgICAgICAgQ3VzdG9tUHV0RnVuY3Rpb24sCiAgICAgICAgIEV2 ZW50VGFyZ2V0LAotICAgICAgICBFeHRlbmRzRE9NR2xvYmFsT2JqZWN0LAogICAgICAgICBHZW5l cmF0ZU5hdGl2ZUNvbnZlcnRlciwKICAgICAgICAgUmVwbGFjZWFibGVDb25zdHJ1Y3RvciwKICAg ICAgICAgSlNMZWdhY3lQYXJlbnQ9SlNET01XaW5kb3dCYXNlCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS93b3JrZXJzL0RlZGljYXRlZFdvcmtlckNvbnRleHQuaWRsIGIvU291cmNlL1dlYkNv cmUvd29ya2Vycy9EZWRpY2F0ZWRXb3JrZXJDb250ZXh0LmlkbAppbmRleCBjZGVjZDJjOWExMjli NGQ1OWQ4ODdlYTNlOTZkNDJmN2VjZWFkYmEzLi4zZDU3MzI3MzYzY2EyZWE1N2FkMjQ3NjM0OWNj ZmI4Mzk3ZTRmNzUxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL0RlZGljYXRl ZFdvcmtlckNvbnRleHQuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvRGVkaWNhdGVk V29ya2VyQ29udGV4dC5pZGwKQEAgLTMyLDcgKzMyLDYgQEAgbW9kdWxlIHRocmVhZHMgewogCiAg ICAgaW50ZXJmYWNlIFsKICAgICAgICAgQ29uZGl0aW9uYWw9V09SS0VSUywKLSAgICAgICAgRXh0 ZW5kc0RPTUdsb2JhbE9iamVjdCwKICAgICAgICAgSXNXb3JrZXJDb250ZXh0LAogICAgICAgICBH ZW5lcmF0ZU5hdGl2ZUNvbnZlcnRlciwKICAgICAgICAgSlNOb1N0YXRpY1RhYmxlcywKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvU2hhcmVkV29ya2VyQ29udGV4dC5pZGwgYi9T b3VyY2UvV2ViQ29yZS93b3JrZXJzL1NoYXJlZFdvcmtlckNvbnRleHQuaWRsCmluZGV4IGY3ODQ4 ZmEzMTlkZjllYjNjYzI3NTI1MWNiZjhkOTI0NTNmZjMwNzAuLjNiNjVmNzQzZjE0NDVmZjU3NTA5 ZTUxNDU1Y2MwNGViM2QxYjY1MTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMv U2hhcmVkV29ya2VyQ29udGV4dC5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUvd29ya2Vycy9TaGFy ZWRXb3JrZXJDb250ZXh0LmlkbApAQCAtMzIsNyArMzIsNiBAQCBtb2R1bGUgdGhyZWFkcyB7CiAK ICAgICBpbnRlcmZhY2UgWwogICAgICAgICBDb25kaXRpb25hbD1TSEFSRURfV09SS0VSUywKLSAg ICAgICAgRXh0ZW5kc0RPTUdsb2JhbE9iamVjdCwKICAgICAgICAgSXNXb3JrZXJDb250ZXh0LAog ICAgICAgICBHZW5lcmF0ZU5hdGl2ZUNvbnZlcnRlciwKICAgICAgICAgSlNOb1N0YXRpY1RhYmxl cywKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvV29ya2VyQ29udGV4dC5pZGwg Yi9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL1dvcmtlckNvbnRleHQuaWRsCmluZGV4IGMyYjkzM2Zi ZjM0YzJjNDA5MDc3Yzk1NjZlZGJjMGJjYThlNTkzNzEuLmFhY2Q3ZjNhNWIxMmQwYmY3ZGM3NWEy MzIyNmJmZWU1NTQxOGFiZjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvV29y a2VyQ29udGV4dC5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUvd29ya2Vycy9Xb3JrZXJDb250ZXh0 LmlkbApAQCAtMzEsNyArMzEsNiBAQCBtb2R1bGUgdGhyZWFkcyB7CiAgICAgICAgIEpTQ3VzdG9t TWFya0Z1bmN0aW9uLAogICAgICAgICBEZWxlZ2F0aW5nR2V0T3duUHJvcGVydHlTbG90LAogICAg ICAgICBFdmVudFRhcmdldCwKLSAgICAgICAgRXh0ZW5kc0RPTUdsb2JhbE9iamVjdCwKICAgICAg ICAgSXNXb3JrZXJDb250ZXh0LAogICAgICAgICBKU0xlZ2FjeVBhcmVudD1KU1dvcmtlckNvbnRl eHRCYXNlLAogICAgICAgICBKU05vU3RhdGljVGFibGVzLAo=