77954 2012-02-07 02:37:48 -0800 MediaStream API: Add the onstatechange callback to PeerConnection 2012-02-08 01:52:42 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 56459 1 tommyw tommyw abarth ojan webkit.review.bot oldest_to_newest 550755 0 tommyw 2012-02-07 02:37:48 -0800 The current implementation is missing the onstatechange callback. Note that the patch doesn't contain iceState or sdpState, that will be added when the dust settles regarding ROAP/JSEP in the standard. 550757 1 125796 tommyw 2012-02-07 02:42:10 -0800 Created attachment 125796 Patch 551113 2 125796 abarth 2012-02-07 10:38:48 -0800 Comment on attachment 125796 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125796&action=review > Source/WebCore/ChangeLog:10 > + Tests for the Media Stream API will be provided by the bug 56587, pending enough landed code. How close are we to being able to write these tests? It feels like we've got a lot of this code landed now. 551864 3 125796 tommyw 2012-02-08 00:54:49 -0800 Comment on attachment 125796 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125796&action=review >> Source/WebCore/ChangeLog:10 >> + Tests for the Media Stream API will be provided by the bug 56587, pending enough landed code. > > How close are we to being able to write these tests? It feels like we've got a lot of this code landed now. Expect the first rough patch later this week :) Agree that it is long overdue... 551872 4 abarth 2012-02-08 00:59:07 -0800 > Expect the first rough patch later this week :) Yay! 551900 5 125796 webkit.review.bot 2012-02-08 01:52:37 -0800 Comment on attachment 125796 Patch Clearing flags on attachment: 125796 Committed r107054: <http://trac.webkit.org/changeset/107054> 551901 6 webkit.review.bot 2012-02-08 01:52:42 -0800 All reviewed patches have been landed. Closing bug. 125796 2012-02-07 02:42:10 -0800 2012-02-08 01:52:37 -0800 Patch bug-77954-20120207114208.patch text/plain 5337 tommyw U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2OTE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDZkYjJmNGQ1ZGIwYmZh MjZlNDA3NTA1OGIzMzY1N2U3NGIxOTBmZS4uYWQ1ZGY2NDkxYTE4YmJhYmYxYjk0YjdiMDM1NWNm NGIxNzU0MWU1ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEyLTAyLTA3ICBUb21t eSBXaWRlbmZseWNodCAgPHRvbW15d0Bnb29nbGUuY29tPgorCisgICAgICAgIE1lZGlhU3RyZWFt IEFQSTogQWRkaW5nIHRoZSBvbnN0YXRlY2hhbmdlIGNhbGxiYWNrIHRvIFBlZXJDb25uZWN0aW9u CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03Nzk1NAor CisgICAgICAgIFdoZW4gcmVhZHlTdGF0ZSBjaGFuZ2VzIGEgY2FsbGJhY2sgc2hvdWxkIGJlIHRy aWdnZXJlZC4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBUZXN0cyBmb3IgdGhlIE1lZGlhIFN0cmVhbSBBUEkgd2lsbCBiZSBwcm92aWRlZCBieSB0aGUg YnVnIDU2NTg3LCBwZW5kaW5nIGVub3VnaCBsYW5kZWQgY29kZS4KKworICAgICAgICAqIGRvbS9F dmVudE5hbWVzLmg6CisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKiBtZWRpYXN0cmVhbS9Q ZWVyQ29ubmVjdGlvbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQZWVyQ29ubmVjdGlvbjo6Y2hh bmdlUmVhZHlTdGF0ZSk6CisgICAgICAgICogbWVkaWFzdHJlYW0vUGVlckNvbm5lY3Rpb24uaDoK KyAgICAgICAgKFBlZXJDb25uZWN0aW9uKToKKyAgICAgICAgKFdlYkNvcmU6OlBlZXJDb25uZWN0 aW9uOjpkaWRDaGFuZ2VTdGF0ZSk6CisgICAgICAgICogbWVkaWFzdHJlYW0vUGVlckNvbm5lY3Rp b24uaWRsOgorICAgICAgICAqIHBsYXRmb3JtL21lZGlhc3RyZWFtL1BlZXJDb25uZWN0aW9uSGFu ZGxlckNsaWVudC5oOgorICAgICAgICAoUGVlckNvbm5lY3Rpb25IYW5kbGVyQ2xpZW50KToKKwog MjAxMi0wMi0wNyAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAK ICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjEwNjkxMi4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2RvbS9FdmVudE5hbWVzLmggYi9Tb3VyY2UvV2ViQ29yZS9kb20vRXZlbnRO YW1lcy5oCmluZGV4IDY0NjRkOGMxMDBkMWE3NGM3MWRmYWIwNWJhODUyNjg2YjI0ZTRiZWUuLmE2 MTZmNzQ3NmVhYWEzMTg2NGRiNzVmOTI0NjFhOWU1YmZjZjM2ZjAgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2RvbS9FdmVudE5hbWVzLmgKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0V2ZW50 TmFtZXMuaApAQCAtMTk0LDYgKzE5NCw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICBtYWNy byhjb25uZWN0aW5nKSBcCiAgICAgbWFjcm8oYWRkc3RyZWFtKSBcCiAgICAgbWFjcm8ocmVtb3Zl c3RyZWFtKSBcCisgICAgbWFjcm8oc3RhdGVjaGFuZ2UpIFwKICAgICBcCiAgICAgbWFjcm8oc2hv dykgXAogICAgIFwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL21lZGlhc3RyZWFtL1BlZXJD b25uZWN0aW9uLmNwcCBiL1NvdXJjZS9XZWJDb3JlL21lZGlhc3RyZWFtL1BlZXJDb25uZWN0aW9u LmNwcAppbmRleCBiYjQ5M2Q3NjgzODlmODgwNDQ0YzFiYTM1ZDJmN2IzMmVlNjNlODI0Li4xMTk0 NDgyM2JmOTg2OGUyZTViY2M2NTM1YjMxNmIyNjU0NzU3MjA1IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9tZWRpYXN0cmVhbS9QZWVyQ29ubmVjdGlvbi5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvbWVkaWFzdHJlYW0vUGVlckNvbm5lY3Rpb24uY3BwCkBAIC0zNjcsNiArMzY3LDggQEAgdm9p ZCBQZWVyQ29ubmVjdGlvbjo6Y2hhbmdlUmVhZHlTdGF0ZShSZWFkeVN0YXRlIHJlYWR5U3RhdGUp CiAgICAgY2FzZSBDTE9TRUQ6CiAgICAgICAgIGJyZWFrOwogICAgIH0KKworICAgIGRpc3BhdGNo RXZlbnQoRXZlbnQ6OmNyZWF0ZShldmVudE5hbWVzKCkuc3RhdGVjaGFuZ2VFdmVudCwgZmFsc2Us IGZhbHNlKSk7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL21lZGlhc3RyZWFtL1BlZXJDb25uZWN0aW9uLmggYi9Tb3VyY2UvV2ViQ29yZS9t ZWRpYXN0cmVhbS9QZWVyQ29ubmVjdGlvbi5oCmluZGV4IGQyOWQxNjI1ZmM4ZjA4YWZlYjRhZjM3 YWIwMjdiZjUwNThjNTZhMDYuLmZkMmYyZmIyZDQyODI2YjYzNjAwMTU1NmIzNmIzYWFlNzNiZjVj MjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL21lZGlhc3RyZWFtL1BlZXJDb25uZWN0aW9u LmgKKysrIGIvU291cmNlL1dlYkNvcmUvbWVkaWFzdHJlYW0vUGVlckNvbm5lY3Rpb24uaApAQCAt NTgsMTQgKzU4LDYgQEAgcHVibGljOgogCiAgICAgdm9pZCBwcm9jZXNzU2lnbmFsaW5nTWVzc2Fn ZShjb25zdCBTdHJpbmcmIG1lc3NhZ2UsIEV4Y2VwdGlvbkNvZGUmKTsKIAotICAgIC8vIE5hbWUg YW5kIHZhbHVlcyBvZiB0aGUgZW51bSBtdXN0IG1hdGNoIHRoZSBjb3JyZXNzcG9uZGluZyBjb25z dGFudHMgaW4gdGhlIC5pZGwgZmlsZS4KLSAgICBlbnVtIFJlYWR5U3RhdGUgewotICAgICAgICBO RVcgPSAwLAotICAgICAgICBORUdPVElBVElORyA9IDEsCi0gICAgICAgIEFDVElWRSA9IDIsCi0g ICAgICAgIENMT1NFRCA9IDMKLSAgICB9OwotCiAgICAgUmVhZHlTdGF0ZSByZWFkeVN0YXRlKCkg Y29uc3Q7CiAKICAgICB2b2lkIHNlbmQoY29uc3QgU3RyaW5nJiB0ZXh0LCBFeGNlcHRpb25Db2Rl Jik7CkBAIC03OCw2ICs3MCw3IEBAIHB1YmxpYzoKICAgICBERUZJTkVfQVRUUklCVVRFX0VWRU5U X0xJU1RFTkVSKGNvbm5lY3RpbmcpOwogICAgIERFRklORV9BVFRSSUJVVEVfRVZFTlRfTElTVEVO RVIob3Blbik7CiAgICAgREVGSU5FX0FUVFJJQlVURV9FVkVOVF9MSVNURU5FUihtZXNzYWdlKTsK KyAgICBERUZJTkVfQVRUUklCVVRFX0VWRU5UX0xJU1RFTkVSKHN0YXRlY2hhbmdlKTsKICAgICBE RUZJTkVfQVRUUklCVVRFX0VWRU5UX0xJU1RFTkVSKGFkZHN0cmVhbSk7CiAgICAgREVGSU5FX0FU VFJJQlVURV9FVkVOVF9MSVNURU5FUihyZW1vdmVzdHJlYW0pOwogCkBAIC04Nyw2ICs4MCw3IEBA IHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQgZGlkUmVjZWl2ZURhdGFTdHJlYW1NZXNzYWdlKGNv bnN0IGNoYXIqIGRhdGEsIHNpemVfdCBsZW5ndGgpOwogICAgIHZpcnR1YWwgdm9pZCBkaWRBZGRS ZW1vdGVTdHJlYW0oUGFzc1JlZlB0cjxNZWRpYVN0cmVhbURlc2NyaXB0b3I+KTsKICAgICB2aXJ0 dWFsIHZvaWQgZGlkUmVtb3ZlUmVtb3RlU3RyZWFtKE1lZGlhU3RyZWFtRGVzY3JpcHRvciopOwor ICAgIHZpcnR1YWwgdm9pZCBkaWRDaGFuZ2VTdGF0ZShSZWFkeVN0YXRlIHN0YXRlKSB7IGNoYW5n ZVJlYWR5U3RhdGUoc3RhdGUpOyB9CiAKICAgICAvLyBFdmVudFRhcmdldAogICAgIHZpcnR1YWwg Y29uc3QgQXRvbWljU3RyaW5nJiBpbnRlcmZhY2VOYW1lKCkgY29uc3Q7CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9tZWRpYXN0cmVhbS9QZWVyQ29ubmVjdGlvbi5pZGwgYi9Tb3VyY2UvV2Vi Q29yZS9tZWRpYXN0cmVhbS9QZWVyQ29ubmVjdGlvbi5pZGwKaW5kZXggNTlkMzVlMzE2M2YyYjI0 M2E1MzA5Mzg3OGFmODU1ZGZkYjRjMjBjNC4uYWZhZWJkNzA1ZWU4ZjkzMjU2MmNiNjFjZDk2Mjc1 ZTUxODA4ZWE5OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbWVkaWFzdHJlYW0vUGVlckNv bm5lY3Rpb24uaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL21lZGlhc3RyZWFtL1BlZXJDb25uZWN0 aW9uLmlkbApAQCAtNTgsNiArNTgsNyBAQCBtb2R1bGUgcDJwIHsKICAgICAgICAgYXR0cmlidXRl IEV2ZW50TGlzdGVuZXIgb25jb25uZWN0aW5nOwogICAgICAgICBhdHRyaWJ1dGUgRXZlbnRMaXN0 ZW5lciBvbm9wZW47CiAgICAgICAgIGF0dHJpYnV0ZSBFdmVudExpc3RlbmVyIG9ubWVzc2FnZTsK KyAgICAgICAgYXR0cmlidXRlIEV2ZW50TGlzdGVuZXIgb25zdGF0ZWNoYW5nZTsKICAgICAgICAg YXR0cmlidXRlIEV2ZW50TGlzdGVuZXIgb25hZGRzdHJlYW07CiAgICAgICAgIGF0dHJpYnV0ZSBF dmVudExpc3RlbmVyIG9ucmVtb3Zlc3RyZWFtOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9QZWVyQ29ubmVjdGlvbkhhbmRsZXJDbGllbnQuaCBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL1BlZXJDb25uZWN0aW9uSGFuZGxlckNs aWVudC5oCmluZGV4IDdkNzdiNWYwYjI1OGI2ODUzZjFkNTk5M2JiM2Y5ZTIwNmMxYzE4MTEuLmU2 N2VmM2E1NTg0MDNhOWI4NWQ3NGFkZTcxMjQ1MzgzYTYyYzY4N2UgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL1BlZXJDb25uZWN0aW9uSGFuZGxlckNsaWVu dC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL1BlZXJDb25uZWN0 aW9uSGFuZGxlckNsaWVudC5oCkBAIC00Miw2ICs0MiwxNCBAQCBjbGFzcyBNZWRpYVN0cmVhbURl c2NyaXB0b3I7CiAKIGNsYXNzIFBlZXJDb25uZWN0aW9uSGFuZGxlckNsaWVudCB7CiBwdWJsaWM6 CisgICAgLy8gTmFtZSBhbmQgdmFsdWVzIG9mIHRoZSBlbnVtIG11c3QgbWF0Y2ggdGhlIGNvcnJl c3Nwb25kaW5nIGNvbnN0YW50cyBpbiB0aGUgUGVlckNvbm5lY3Rpb24uaWRsIGZpbGUuCisgICAg ZW51bSBSZWFkeVN0YXRlIHsKKyAgICAgICAgTkVXID0gMCwKKyAgICAgICAgTkVHT1RJQVRJTkcg PSAxLAorICAgICAgICBBQ1RJVkUgPSAyLAorICAgICAgICBDTE9TRUQgPSAzCisgICAgfTsKKwog ICAgIHZpcnR1YWwgflBlZXJDb25uZWN0aW9uSGFuZGxlckNsaWVudCgpIHsgfQogCiAgICAgdmly dHVhbCB2b2lkIGRpZENvbXBsZXRlSUNFUHJvY2Vzc2luZygpID0gMDsKQEAgLTQ5LDYgKzU3LDcg QEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9pZCBkaWRSZWNlaXZlRGF0YVN0cmVhbU1lc3NhZ2Uo Y29uc3QgY2hhciogZGF0YSwgc2l6ZV90IGxlbmd0aCkgPSAwOwogICAgIHZpcnR1YWwgdm9pZCBk aWRBZGRSZW1vdGVTdHJlYW0oUGFzc1JlZlB0cjxNZWRpYVN0cmVhbURlc2NyaXB0b3I+KSA9IDA7 CiAgICAgdmlydHVhbCB2b2lkIGRpZFJlbW92ZVJlbW90ZVN0cmVhbShNZWRpYVN0cmVhbURlc2Ny aXB0b3IqKSA9IDA7CisgICAgdmlydHVhbCB2b2lkIGRpZENoYW5nZVN0YXRlKFJlYWR5U3RhdGUp ID0gMDsKIH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUK