77952 2012-02-07 02:07:39 -0800 REGRESSION(r106819): ~28% or so performance regression on the ManInBlue HTML benchmark 2012-02-07 08:31:09 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 77879 1 rniwa webkit-unassigned cmarcelo kling koivisto morrita thorton tonyg oldest_to_newest 550735 0 rniwa 2012-02-07 02:07:39 -0800 From https://bugs.webkit.org/show_bug.cgi?id=77879: Comment #4 From Tim Horton 2012-02-06 13:32:31 PST (-) [reply] This change seems to significantly (~28% or so) regress performance of the ManInBlue HTML (http://themaninblue.com/experiment/AnimationBenchmark/html/) benchmark, among others. Looking at the change, though, I'm not sure how that's possible. Could you potentially take a look at this? 550739 1 125791 rniwa 2012-02-07 02:13:12 -0800 Created attachment 125791 Fix attempt This is a fix attempt per analysis on the bug 77879. As much as I'd like to finish writing this patch, my brain isn't functioning anymore at 2am in the morning. I'll try to finish up the patch tomorrow if cmarcelo hadn't done so by the time I can get back to it. 550752 2 rniwa 2012-02-07 02:31:27 -0800 Okay, not adding a new test isn't as bad as I thought. DOM/Accessors caught this regression: It also caused a regression on DOM/Accessors: http://webkit-perf.appspot.com/graph.html?#tests=[[3113,2001,32196]]&sel=1328551109987.2344,1328555918820.6528&displayrange=7&datatype=running It seems like we imported Dromaeo tests just in time :D 550841 3 kling 2012-02-07 04:29:29 -0800 (In reply to comment #1) > Created an attachment (id=125791) [details] > Fix attempt > > This is a fix attempt per analysis on the bug 77879. As much as I'd like to finish writing this patch, my brain isn't functioning anymore at 2am in the morning. I'll try to finish up the patch tomorrow if cmarcelo hadn't done so by the time I can get back to it. This patch looks fine to me, so I'm taking the liberty of saying r+ and landing it for you to get rid of the regression. 550842 4 kling 2012-02-07 04:29:39 -0800 Committed r106925: <http://trac.webkit.org/changeset/106925> 551013 5 rniwa 2012-02-07 08:31:09 -0800 (In reply to comment #3) > (In reply to comment #1) > > Created an attachment (id=125791) [details] [details] > > Fix attempt > > > > This is a fix attempt per analysis on the bug 77879. As much as I'd like to finish writing this patch, my brain isn't functioning anymore at 2am in the morning. I'll try to finish up the patch tomorrow if cmarcelo hadn't done so by the time I can get back to it. > > This patch looks fine to me, so I'm taking the liberty of saying r+ and landing it for you to get rid of the regression. Thanks! 125791 2012-02-07 02:13:12 -0800 2012-02-07 02:13:12 -0800 Fix attempt wip77952 text/plain 1921 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL2RvbS9TdHlsZWRFbGVtZW50LmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvZG9tL1N0eWxlZEVsZW1lbnQuaAkocmV2aXNpb24gMTA2OTAzKQorKysg U291cmNlL1dlYkNvcmUvZG9tL1N0eWxlZEVsZW1lbnQuaAkod29ya2luZyBjb3B5KQpAQCAtNDgs MTEgKzQ4LDExIEBACiAgICAgdm9pZCBpbnZhbGlkYXRlU3R5bGVBdHRyaWJ1dGUoKTsKIAogICAg IFN0eWxlUHJvcGVydHlTZXQqIGlubGluZVN0eWxlRGVjbCgpIGNvbnN0IHsgcmV0dXJuIGF0dHJp YnV0ZURhdGEoKSA/IGF0dHJpYnV0ZURhdGEoKS0+aW5saW5lU3R5bGVEZWNsKCkgOiAwOyB9Ci0g ICAgU3R5bGVQcm9wZXJ0eVNldCogZW5zdXJlSW5saW5lU3R5bGVEZWNsKCkgeyByZXR1cm4gZW5z dXJlQXR0cmlidXRlRGF0YSgpLT5lbnN1cmVJbmxpbmVTdHlsZURlY2wodGhpcyk7IH0KKyAgICBT dHlsZVByb3BlcnR5U2V0KiBlbnN1cmVJbmxpbmVTdHlsZURlY2woKSB7IHJldHVybiBlbnN1cmVB dHRyaWJ1dGVEYXRhV2l0aG91dFVwZGF0ZSgpLT5lbnN1cmVJbmxpbmVTdHlsZURlY2wodGhpcyk7 IH0KICAgICB2aXJ0dWFsIENTU1N0eWxlRGVjbGFyYXRpb24qIHN0eWxlKCkgT1ZFUlJJREUgeyBy ZXR1cm4gZW5zdXJlSW5saW5lU3R5bGVEZWNsKCktPmVuc3VyZUNTU1N0eWxlRGVjbGFyYXRpb24o KTsgfQogCiAgICAgU3R5bGVQcm9wZXJ0eVNldCogYXR0cmlidXRlU3R5bGUoKSBjb25zdCB7IHJl dHVybiBhdHRyaWJ1dGVEYXRhKCkgPyBhdHRyaWJ1dGVEYXRhKCktPmF0dHJpYnV0ZVN0eWxlKCkg OiAwOyB9Ci0gICAgU3R5bGVQcm9wZXJ0eVNldCogZW5zdXJlQXR0cmlidXRlU3R5bGUoKSB7IHJl dHVybiBlbnN1cmVBdHRyaWJ1dGVEYXRhKCktPmVuc3VyZUF0dHJpYnV0ZVN0eWxlKHRoaXMpOyB9 CisgICAgU3R5bGVQcm9wZXJ0eVNldCogZW5zdXJlQXR0cmlidXRlU3R5bGUoKSB7IHJldHVybiBl bnN1cmVBdHRyaWJ1dGVEYXRhV2l0aG91dFVwZGF0ZSgpLT5lbnN1cmVBdHRyaWJ1dGVTdHlsZSh0 aGlzKTsgfQogCiAgICAgY29uc3QgU3BhY2VTcGxpdFN0cmluZyYgY2xhc3NOYW1lcygpIGNvbnN0 OwogCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5oCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmgJKHJldmlzaW9uIDEwNjkwMykKKysrIFNvdXJjZS9X ZWJDb3JlL2RvbS9FbGVtZW50LmgJKHdvcmtpbmcgY29weSkKQEAgLTI0Miw2ICsyNDIsOSBAQAog ICAgIEVsZW1lbnRBdHRyaWJ1dGVEYXRhKiBhdHRyaWJ1dGVEYXRhKCkgY29uc3QgeyByZXR1cm4g bV9hdHRyaWJ1dGVNYXAgPyBtX2F0dHJpYnV0ZU1hcC0+YXR0cmlidXRlRGF0YSgpIDogMDsgfQog ICAgIEVsZW1lbnRBdHRyaWJ1dGVEYXRhKiBlbnN1cmVBdHRyaWJ1dGVEYXRhKCkgY29uc3QgeyBy ZXR1cm4gZW5zdXJlVXBkYXRlZEF0dHJpYnV0ZXMoKS0+YXR0cmlidXRlRGF0YSgpOyB9CiAKKyAg ICAvLyBGSVhNRTogVGhpcyBtZXRob2Qgc2hvdWxkIGJlIHJlbW92ZWQgb25jZSBBdHRyaWJ1dGVE YXRhIGlzIG1vdmVkIHRvIEVsZW1lbnQuCisgICAgRWxlbWVudEF0dHJpYnV0ZURhdGEqIGVuc3Vy ZUF0dHJpYnV0ZURhdGFXaXRob3V0VXBkYXRlKCkgY29uc3QgeyByZXR1cm4gZW5zdXJlQXR0cmli dXRlTWFwKCktPmF0dHJpYnV0ZURhdGEoKTsgfQorCiAgICAgdm9pZCBzZXRBdHRyaWJ1dGVzRnJv bUVsZW1lbnQoY29uc3QgRWxlbWVudCYpOwogCiAgICAgdmlydHVhbCB2b2lkIGNvcHlOb25BdHRy aWJ1dGVQcm9wZXJ0aWVzKGNvbnN0IEVsZW1lbnQqIHNvdXJjZSk7Cg==