<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>77942</bug_id>
          
          <creation_ts>2012-02-07 00:45:12 -0800</creation_ts>
          <short_desc>GTK &amp; QT Rebaseline after r106912</short_desc>
          <delta_ts>2012-02-07 03:57:05 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>77961</dependson>
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Kaustubh Atrawalkar">kaustubh.ra</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>kaustubh.ra</cc>
    
    <cc>levin</cc>
    
    <cc>ossy</cc>
    
    <cc>pnormand</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>550686</commentid>
    <comment_count>0</comment_count>
    <who name="Kaustubh Atrawalkar">kaustubh.ra</who>
    <bug_when>2012-02-07 00:45:12 -0800</bug_when>
    <thetext>Rebaselining the tests after r106912.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>550688</commentid>
    <comment_count>1</comment_count>
      <attachid>125778</attachid>
    <who name="Kaustubh Atrawalkar">kaustubh.ra</who>
    <bug_when>2012-02-07 00:48:00 -0800</bug_when>
    <thetext>Created attachment 125778
Patch

Re-committing the changes from http://trac.webkit.org/changeset/106105 &amp; http://trac.webkit.org/changeset/105493</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>550690</commentid>
    <comment_count>2</comment_count>
    <who name="Kaustubh Atrawalkar">kaustubh.ra</who>
    <bug_when>2012-02-07 00:52:52 -0800</bug_when>
    <thetext>(In reply to comment #1)
&gt; Created an attachment (id=125778) [details]
&gt; Patch
&gt; 
&gt; Re-committing the changes from http://trac.webkit.org/changeset/106105 &amp; http://trac.webkit.org/changeset/105493

GTK Rebaseline as per - http://trac.webkit.org/changeset/105520</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>550692</commentid>
    <comment_count>3</comment_count>
      <attachid>125778</attachid>
    <who name="David Levin">levin</who>
    <bug_when>2012-02-07 00:55:22 -0800</bug_when>
    <thetext>Comment on attachment 125778
Patch

These should have been in your patch :(</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>550696</commentid>
    <comment_count>4</comment_count>
    <who name="Kaustubh Atrawalkar">kaustubh.ra</who>
    <bug_when>2012-02-07 01:03:09 -0800</bug_when>
    <thetext>(In reply to comment #3)
&gt; (From update of attachment 125778 [details])
&gt; These should have been in your patch :(
I know :( Ossy (Csaba Osztrogonac) had asked me to add in patch but I missed those. My mistake. So added immediately.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>550736</commentid>
    <comment_count>5</comment_count>
      <attachid>125778</attachid>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2012-02-07 02:08:27 -0800</bug_when>
    <thetext>Comment on attachment 125778
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125778&amp;action=review

Is there a bug report to fix these expected failures?

&gt; LayoutTests/platform/gtk/fast/js/global-constructors-expected.txt:336
&gt; +FAIL webkitURL.toString() should be [object webkitURLConstructor]. Was [object DOMURLConstructor].

Is this fail expected?

&gt; LayoutTests/platform/qt/fast/js/global-constructors-expected.txt:318
&gt; +FAIL webkitURL.toString() should be [object webkitURLConstructor]. Was [object DOMURLConstructor].

Is this fail expected?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>550737</commentid>
    <comment_count>6</comment_count>
    <who name="Kaustubh Atrawalkar">kaustubh.ra</who>
    <bug_when>2012-02-07 02:12:02 -0800</bug_when>
    <thetext>(In reply to comment #5)
&gt; (From update of attachment 125778 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=125778&amp;action=review
&gt; 
&gt; Is there a bug report to fix these expected failures?
&gt; 
&gt; &gt; LayoutTests/platform/gtk/fast/js/global-constructors-expected.txt:336
&gt; &gt; +FAIL webkitURL.toString() should be [object webkitURLConstructor]. Was [object DOMURLConstructor].
&gt; 
&gt; Is this fail expected?
&gt; 
&gt; &gt; LayoutTests/platform/qt/fast/js/global-constructors-expected.txt:318
&gt; &gt; +FAIL webkitURL.toString() should be [object webkitURLConstructor]. Was [object DOMURLConstructor].
&gt; 
&gt; Is this fail expected?

Yes these are expected. need to fix the naming conventions for DOMURL. Currently there is no bug report filed. But will do it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>550745</commentid>
    <comment_count>7</comment_count>
      <attachid>125778</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-02-07 02:23:00 -0800</bug_when>
    <thetext>Comment on attachment 125778
Patch

Clearing flags on attachment: 125778

Committed r106915: &lt;http://trac.webkit.org/changeset/106915&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>550746</commentid>
    <comment_count>8</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-02-07 02:23:04 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>550807</commentid>
    <comment_count>9</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2012-02-07 03:52:03 -0800</bug_when>
    <thetext>It was rolled out (http://trac.webkit.org/changeset/106922) because the original r106912 was rolled out too.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>550810</commentid>
    <comment_count>10</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2012-02-07 03:57:05 -0800</bug_when>
    <thetext>Otherwise please don&apos;t open new bug report for rebaseline after rXXXXX,
but add it to the original bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>125778</attachid>
            <date>2012-02-07 00:48:00 -0800</date>
            <delta_ts>2012-02-07 02:23:00 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>77942.patch</filename>
            <type>text/plain</type>
            <size>4247</size>
            <attacher name="Kaustubh Atrawalkar">kaustubh.ra</attacher>
            
              <data encoding="base64">SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D
aGFuZ2VMb2cJKHJldmlzaW9uIDEwNjkxMikKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y
a2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEyLTAyLTA3ICBLYXVzdHViaCBBdHJhd2Fs
a2FyICA8a2F1c3R1YmhAbW90b3JvbGEuY29tPgorCisgICAgICAgIEdUSyAmIFFUIFJlYmFzZWxp
bmUgYWZ0ZXIgcjEwNjkxMi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i
dWcuY2dpP2lkPTc3OTQyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK
KyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvZmFzdC9kb20vcHJvdG90eXBlLWluaGVyaXRhbmNlLTIt
ZXhwZWN0ZWQudHh0OgorICAgICAgICAqIHBsYXRmb3JtL2d0ay9mYXN0L2pzL2dsb2JhbC1jb25z
dHJ1Y3RvcnMtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIHBsYXRmb3JtL3F0L2Zhc3QvZG9tL2Nv
bnN0cnVjdGVkLW9iamVjdHMtcHJvdG90eXBlcy1leHBlY3RlZC50eHQ6CisgICAgICAgICogcGxh
dGZvcm0vcXQvZmFzdC9kb20vcHJvdG90eXBlLWluaGVyaXRhbmNlLTItZXhwZWN0ZWQudHh0Ogor
ICAgICAgICAqIHBsYXRmb3JtL3F0L2Zhc3QvanMvZ2xvYmFsLWNvbnN0cnVjdG9ycy1leHBlY3Rl
ZC50eHQ6CisKIDIwMTItMDItMDcgIEthdXN0dWJoIEF0cmF3YWxrYXIgIDxrYXVzdHViaEBtb3Rv
cm9sYS5jb20+CiAKICAgICAgICAgTWlncmF0ZSBjcmVhdGVPYmplY3RVUkwgJiByZXZva2VPYmpl
Y3RVUkwgdG8gc3RhdGljIChDbGFzcykgbWV0aG9kcy4KSW5kZXg6IExheW91dFRlc3RzL3BsYXRm
b3JtL2d0ay9mYXN0L2RvbS9wcm90b3R5cGUtaW5oZXJpdGFuY2UtMi1leHBlY3RlZC50eHQKPT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2Zhc3QvZG9tL3Byb3RvdHlwZS1p
bmhlcml0YW5jZS0yLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMTA2OTEyKQorKysgTGF5b3V0VGVz
dHMvcGxhdGZvcm0vZ3RrL2Zhc3QvZG9tL3Byb3RvdHlwZS1pbmhlcml0YW5jZS0yLWV4cGVjdGVk
LnR4dAkod29ya2luZyBjb3B5KQpAQCAtMjQwLDYgKzI0MCw3IEBAIE5ldmVyIGZvdW5kIENsaXBi
b2FyZAogTmV2ZXIgZm91bmQgRE9NUGFyc2VyCiBOZXZlciBmb3VuZCBET01TZXR0YWJsZVRva2Vu
TGlzdAogTmV2ZXIgZm91bmQgRE9NU3RyaW5nTGlzdAorTmV2ZXIgZm91bmQgRE9NVVJMCiBOZXZl
ciBmb3VuZCBEb2N1bWVudAogTmV2ZXIgZm91bmQgRG9jdW1lbnRGcmFnbWVudAogTmV2ZXIgZm91
bmQgRG9jdW1lbnRUeXBlCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvZmFzdC9qcy9n
bG9iYWwtY29uc3RydWN0b3JzLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0
cy9wbGF0Zm9ybS9ndGsvZmFzdC9qcy9nbG9iYWwtY29uc3RydWN0b3JzLWV4cGVjdGVkLnR4dAko
cmV2aXNpb24gMTA2OTEyKQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2Zhc3QvanMvZ2xv
YmFsLWNvbnN0cnVjdG9ycy1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTMzMyw2ICsz
MzMsNyBAQCBQQVNTIFhQYXRoRXhjZXB0aW9uLnRvU3RyaW5nKCkgaXMgJ1tvYmplCiBQQVNTIFhQ
YXRoUmVzdWx0LnRvU3RyaW5nKCkgaXMgJ1tvYmplY3QgWFBhdGhSZXN1bHRDb25zdHJ1Y3Rvcl0n
CiBQQVNTIFhTTFRQcm9jZXNzb3IudG9TdHJpbmcoKSBpcyAnW29iamVjdCBYU0xUUHJvY2Vzc29y
Q29uc3RydWN0b3JdJwogRkFJTCB3ZWJraXRQZWVyQ29ubmVjdGlvbi50b1N0cmluZygpIHNob3Vs
ZCBiZSBbb2JqZWN0IHdlYmtpdFBlZXJDb25uZWN0aW9uQ29uc3RydWN0b3JdLiBXYXMgW29iamVj
dCBQZWVyQ29ubmVjdGlvbkNvbnN0cnVjdG9yXS4KK0ZBSUwgd2Via2l0VVJMLnRvU3RyaW5nKCkg
c2hvdWxkIGJlIFtvYmplY3Qgd2Via2l0VVJMQ29uc3RydWN0b3JdLiBXYXMgW29iamVjdCBET01V
UkxDb25zdHJ1Y3Rvcl0uCiBQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCiAKIFRFU1Qg
Q09NUExFVEUKSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL3F0L2Zhc3QvZG9tL2NvbnN0cnVj
dGVkLW9iamVjdHMtcHJvdG90eXBlcy1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0
VGVzdHMvcGxhdGZvcm0vcXQvZmFzdC9kb20vY29uc3RydWN0ZWQtb2JqZWN0cy1wcm90b3R5cGVz
LWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMTA2OTEyKQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0v
cXQvZmFzdC9kb20vY29uc3RydWN0ZWQtb2JqZWN0cy1wcm90b3R5cGVzLWV4cGVjdGVkLnR4dAko
d29ya2luZyBjb3B5KQpAQCAtNjEsNiArNjEsOCBAQCBQQVNTIChuZXcgaW5uZXIuWFBhdGhFdmFs
dWF0b3IoKSkuaXNJbm5lCiBQQVNTIChuZXcgaW5uZXIuWFBhdGhFdmFsdWF0b3IoKSkuY29uc3Ry
dWN0b3IuaXNJbm5lciBpcyB0cnVlCiBQQVNTIChuZXcgaW5uZXIuWFNMVFByb2Nlc3NvcigpKS5p
c0lubmVyIGlzIHRydWUKIFBBU1MgKG5ldyBpbm5lci5YU0xUUHJvY2Vzc29yKCkpLmNvbnN0cnVj
dG9yLmlzSW5uZXIgaXMgdHJ1ZQorUEFTUyAobmV3IGlubmVyLndlYmtpdFVSTCgpKS5pc0lubmVy
IGlzIHRydWUKK1BBU1MgKG5ldyBpbm5lci53ZWJraXRVUkwoKSkuY29uc3RydWN0b3IuaXNJbm5l
ciBpcyB0cnVlCiBQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCiAKIFRFU1QgQ09NUExF
VEUKSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL3F0L2Zhc3QvZG9tL3Byb3RvdHlwZS1pbmhl
cml0YW5jZS0yLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9y
bS9xdC9mYXN0L2RvbS9wcm90b3R5cGUtaW5oZXJpdGFuY2UtMi1leHBlY3RlZC50eHQJKHJldmlz
aW9uIDEwNjkxMikKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL3F0L2Zhc3QvZG9tL3Byb3RvdHlw
ZS1pbmhlcml0YW5jZS0yLWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMjQwLDYgKzI0
MCw3IEBAIE5ldmVyIGZvdW5kIENsaXBib2FyZAogTmV2ZXIgZm91bmQgRE9NUGFyc2VyCiBOZXZl
ciBmb3VuZCBET01TZXR0YWJsZVRva2VuTGlzdAogTmV2ZXIgZm91bmQgRE9NU3RyaW5nTGlzdAor
TmV2ZXIgZm91bmQgRE9NVVJMCiBOZXZlciBmb3VuZCBEb2N1bWVudAogTmV2ZXIgZm91bmQgRG9j
dW1lbnRGcmFnbWVudAogTmV2ZXIgZm91bmQgRG9jdW1lbnRUeXBlCkluZGV4OiBMYXlvdXRUZXN0
cy9wbGF0Zm9ybS9xdC9mYXN0L2pzL2dsb2JhbC1jb25zdHJ1Y3RvcnMtZXhwZWN0ZWQudHh0Cj09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL3F0L2Zhc3QvanMvZ2xvYmFsLWNvbnN0
cnVjdG9ycy1leHBlY3RlZC50eHQJKHJldmlzaW9uIDEwNjkxMikKKysrIExheW91dFRlc3RzL3Bs
YXRmb3JtL3F0L2Zhc3QvanMvZ2xvYmFsLWNvbnN0cnVjdG9ycy1leHBlY3RlZC50eHQJKHdvcmtp
bmcgY29weSkKQEAgLTMxNSw2ICszMTUsNyBAQCBQQVNTIFhQYXRoRXZhbHVhdG9yLnRvU3RyaW5n
KCkgaXMgJ1tvYmplCiBQQVNTIFhQYXRoRXhjZXB0aW9uLnRvU3RyaW5nKCkgaXMgJ1tvYmplY3Qg
WFBhdGhFeGNlcHRpb25Db25zdHJ1Y3Rvcl0nCiBQQVNTIFhQYXRoUmVzdWx0LnRvU3RyaW5nKCkg
aXMgJ1tvYmplY3QgWFBhdGhSZXN1bHRDb25zdHJ1Y3Rvcl0nCiBQQVNTIFhTTFRQcm9jZXNzb3Iu
dG9TdHJpbmcoKSBpcyAnW29iamVjdCBYU0xUUHJvY2Vzc29yQ29uc3RydWN0b3JdJworRkFJTCB3
ZWJraXRVUkwudG9TdHJpbmcoKSBzaG91bGQgYmUgW29iamVjdCB3ZWJraXRVUkxDb25zdHJ1Y3Rv
cl0uIFdhcyBbb2JqZWN0IERPTVVSTENvbnN0cnVjdG9yXS4KIFBBU1Mgc3VjY2Vzc2Z1bGx5UGFy
c2VkIGlzIHRydWUKIAogVEVTVCBDT01QTEVURQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>