77927 2012-02-06 19:41:04 -0800 [BlackBerry] Use WebPagePrivate instead of WebPage in GeolocationControllerClientBlackBerry 2012-02-06 21:09:35 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 73144 1 leo.yang leo.yang charles.wei rwlbuis staikos tonikitoo zimmermann oldest_to_newest 550548 0 leo.yang 2012-02-06 19:41:04 -0800 WebKit/blackberry/Api/WebPage which has a d pointer is designed for public API. GeolocationControllerClientBlackBerry in WebKit/blackberry/WebCoreSupport should use the d pointer directly because the client is internal implemenation. 550552 1 125755 leo.yang 2012-02-06 19:45:58 -0800 Created attachment 125755 Patch 550596 2 leo.yang 2012-02-06 21:09:35 -0800 Committed r106903: <http://trac.webkit.org/changeset/106903> 125755 2012-02-06 19:45:58 -0800 2012-02-06 20:22:07 -0800 Patch 0001-BlackBerry-Use-WebPagePrivate-instead-of-WebPage-in-.patch text/plain 7313 leo.yang RnJvbSAwYTUzOGJmMDc1NGE0M2JlZTQwZWFjNzdkODc4ZWEzMGVhY2UzZDNlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMZW8gWWFuZyA8bGVvLnlhbmdAdG9yY2htb2JpbGUuY29tLmNu PgpEYXRlOiBUdWUsIDcgRmViIDIwMTIgMTE6NDQ6MzkgKzA4MDAKU3ViamVjdDogW1BBVENIXSBb QmxhY2tCZXJyeV0gVXNlIFdlYlBhZ2VQcml2YXRlIGluc3RlYWQgb2YgV2ViUGFnZSBpbgogR2Vv bG9jYXRpb25Db250cm9sbGVyQ2xpZW50QmxhY2tCZXJyeQogaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTc3OTI3CgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCldl YktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlIHdoaWNoIGhhcyBhIGQgcG9pbnRlciBpcyBkZXNp Z25lZCBmb3IgcHVibGljIEFQSS4KR2VvbG9jYXRpb25Db250cm9sbGVyQ2xpZW50QmxhY2tCZXJy eSBpbiBXZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydCBzaG91bGQKdXNlIHRoZSBkIHBv aW50ZXIgZGlyZWN0bHkgYmVjYXVzZSB0aGUgY2xpZW50IGlzIGludGVybmFsIGltcGxlbWVudGF0 aW9uLgoKTm8gZnVuY3Rpb25hbGl0aWVzIGNoYW5nZWQsIG5vIG5ldyB0ZXN0cy4KCiogYmxhY2ti ZXJyeS9XZWJDb3JlU3VwcG9ydC9HZW9sb2NhdGlvbkNvbnRyb2xsZXJDbGllbnRCbGFja0JlcnJ5 LmNwcDoKKEdlb2xvY2F0aW9uQ29udHJvbGxlckNsaWVudEJsYWNrQmVycnk6Okdlb2xvY2F0aW9u Q29udHJvbGxlckNsaWVudEJsYWNrQmVycnkpOgooR2VvbG9jYXRpb25Db250cm9sbGVyQ2xpZW50 QmxhY2tCZXJyeTo6cmVxdWVzdFBlcm1pc3Npb24pOgooR2VvbG9jYXRpb25Db250cm9sbGVyQ2xp ZW50QmxhY2tCZXJyeTo6Y2FuY2VsUGVybWlzc2lvblJlcXVlc3QpOgooR2VvbG9jYXRpb25Db250 cm9sbGVyQ2xpZW50QmxhY2tCZXJyeTo6b25Mb2NhdGlvblVwZGF0ZSk6CihHZW9sb2NhdGlvbkNv bnRyb2xsZXJDbGllbnRCbGFja0JlcnJ5OjpvbkxvY2F0aW9uRXJyb3IpOgoqIGJsYWNrYmVycnkv V2ViQ29yZVN1cHBvcnQvR2VvbG9jYXRpb25Db250cm9sbGVyQ2xpZW50QmxhY2tCZXJyeS5oOgoo V2ViS2l0KToKKEdlb2xvY2F0aW9uQ29udHJvbGxlckNsaWVudEJsYWNrQmVycnkpOgotLS0KIFNv dXJjZS9XZWJLaXQvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAyMyAr KysrKysrKysrKysrKysrKysrKwogLi4uL0dlb2xvY2F0aW9uQ29udHJvbGxlckNsaWVudEJsYWNr QmVycnkuY3BwICAgICAgfCAgIDEzICsrKysrLS0tLS0tCiAuLi4vR2VvbG9jYXRpb25Db250cm9s bGVyQ2xpZW50QmxhY2tCZXJyeS5oICAgICAgICB8ICAgMTEgKysrKysrKy0tCiAzIGZpbGVzIGNo YW5nZWQsIDM3IGluc2VydGlvbnMoKyksIDEwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKaW5kZXggZDRl NTNiZC4uMzQ4ZWRhOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKKysrIGIv U291cmNlL1dlYktpdC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNiBAQAorMjAxMi0wMi0wNiAgTGVv IFlhbmcgIDxsZW8ueWFuZ0B0b3JjaG1vYmlsZS5jb20uY24+CisKKyAgICAgICAgW0JsYWNrQmVy cnldIFVzZSBXZWJQYWdlUHJpdmF0ZSBpbnN0ZWFkIG9mIFdlYlBhZ2UgaW4gR2VvbG9jYXRpb25D b250cm9sbGVyQ2xpZW50QmxhY2tCZXJyeQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9Nzc5MjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBXZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZSB3aGljaCBoYXMg YSBkIHBvaW50ZXIgaXMgZGVzaWduZWQgZm9yIHB1YmxpYyBBUEkuCisgICAgICAgIEdlb2xvY2F0 aW9uQ29udHJvbGxlckNsaWVudEJsYWNrQmVycnkgaW4gV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29y ZVN1cHBvcnQgc2hvdWxkCisgICAgICAgIHVzZSB0aGUgZCBwb2ludGVyIGRpcmVjdGx5IGJlY2F1 c2UgdGhlIGNsaWVudCBpcyBpbnRlcm5hbCBpbXBsZW1lbnRhdGlvbi4KKworICAgICAgICBObyBm dW5jdGlvbmFsaXRpZXMgY2hhbmdlZCwgbm8gbmV3IHRlc3RzLgorCisgICAgICAgICogYmxhY2ti ZXJyeS9XZWJDb3JlU3VwcG9ydC9HZW9sb2NhdGlvbkNvbnRyb2xsZXJDbGllbnRCbGFja0JlcnJ5 LmNwcDoKKyAgICAgICAgKEdlb2xvY2F0aW9uQ29udHJvbGxlckNsaWVudEJsYWNrQmVycnk6Okdl b2xvY2F0aW9uQ29udHJvbGxlckNsaWVudEJsYWNrQmVycnkpOgorICAgICAgICAoR2VvbG9jYXRp b25Db250cm9sbGVyQ2xpZW50QmxhY2tCZXJyeTo6cmVxdWVzdFBlcm1pc3Npb24pOgorICAgICAg ICAoR2VvbG9jYXRpb25Db250cm9sbGVyQ2xpZW50QmxhY2tCZXJyeTo6Y2FuY2VsUGVybWlzc2lv blJlcXVlc3QpOgorICAgICAgICAoR2VvbG9jYXRpb25Db250cm9sbGVyQ2xpZW50QmxhY2tCZXJy eTo6b25Mb2NhdGlvblVwZGF0ZSk6CisgICAgICAgIChHZW9sb2NhdGlvbkNvbnRyb2xsZXJDbGll bnRCbGFja0JlcnJ5OjpvbkxvY2F0aW9uRXJyb3IpOgorICAgICAgICAqIGJsYWNrYmVycnkvV2Vi Q29yZVN1cHBvcnQvR2VvbG9jYXRpb25Db250cm9sbGVyQ2xpZW50QmxhY2tCZXJyeS5oOgorICAg ICAgICAoV2ViS2l0KToKKyAgICAgICAgKEdlb2xvY2F0aW9uQ29udHJvbGxlckNsaWVudEJsYWNr QmVycnkpOgorCiAyMDEyLTAyLTA2ICBSb2JpbiBDYW8gIDxyb2Jpbi5jYW9AdG9yY2htb2JpbGUu Y29tLmNuPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBSZW1vdmUgdW51c2VkIHZhcmlhYmxlIGlu IEJhY2tpbmdTdG9yZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNv cmVTdXBwb3J0L0dlb2xvY2F0aW9uQ29udHJvbGxlckNsaWVudEJsYWNrQmVycnkuY3BwIGIvU291 cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0dlb2xvY2F0aW9uQ29udHJvbGxl ckNsaWVudEJsYWNrQmVycnkuY3BwCmluZGV4IGU0N2JiOTguLmZkNTlmMmUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9HZW9sb2NhdGlvbkNvbnRy b2xsZXJDbGllbnRCbGFja0JlcnJ5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkv V2ViQ29yZVN1cHBvcnQvR2VvbG9jYXRpb25Db250cm9sbGVyQ2xpZW50QmxhY2tCZXJyeS5jcHAK QEAgLTI0LDEzICsyNCwxMiBAQAogI2luY2x1ZGUgIkdlb2xvY2F0aW9uQ29udHJvbGxlci5oIgog I2luY2x1ZGUgIkdlb2xvY2F0aW9uRXJyb3IuaCIKICNpbmNsdWRlICJQYWdlLmgiCi0jaW5jbHVk ZSAiV2ViUGFnZS5oIgogI2luY2x1ZGUgIldlYlBhZ2VfcC5oIgogCiB1c2luZyBuYW1lc3BhY2Ug V2ViQ29yZTsKIAotR2VvbG9jYXRpb25Db250cm9sbGVyQ2xpZW50QmxhY2tCZXJyeTo6R2VvbG9j YXRpb25Db250cm9sbGVyQ2xpZW50QmxhY2tCZXJyeShCbGFja0JlcnJ5OjpXZWJLaXQ6OldlYlBh Z2UqIHdlYlBhZ2UpCi0gICAgOiBtX3dlYlBhZ2Uod2ViUGFnZSkKK0dlb2xvY2F0aW9uQ29udHJv bGxlckNsaWVudEJsYWNrQmVycnk6Okdlb2xvY2F0aW9uQ29udHJvbGxlckNsaWVudEJsYWNrQmVy cnkoQmxhY2tCZXJyeTo6V2ViS2l0OjpXZWJQYWdlUHJpdmF0ZSogd2ViUGFnZVByaXZhdGUpCisg ICAgOiBtX3dlYlBhZ2VQcml2YXRlKHdlYlBhZ2VQcml2YXRlKQogICAgICwgbV90cmFja2VyKDAp CiAgICAgLCBtX2FjY3VyYWN5KGZhbHNlKQogewpAQCAtNjcsNyArNjYsNyBAQCB2b2lkIEdlb2xv Y2F0aW9uQ29udHJvbGxlckNsaWVudEJsYWNrQmVycnk6OnJlcXVlc3RQZXJtaXNzaW9uKEdlb2xv Y2F0aW9uKiBsb2NhdAogICAgIEZyYW1lKiBmcmFtZSA9IGxvY2F0aW9uLT5mcmFtZSgpOwogICAg IGlmICghZnJhbWUpCiAgICAgICAgIHJldHVybjsKLSAgICBtX3dlYlBhZ2UtPmQtPm1fcGFnZS0+ Y2hyb21lKCktPnJlcXVlc3RHZW9sb2NhdGlvblBlcm1pc3Npb25Gb3JGcmFtZShmcmFtZSwgbG9j YXRpb24pOworICAgIG1fd2ViUGFnZVByaXZhdGUtPm1fcGFnZS0+Y2hyb21lKCktPnJlcXVlc3RH ZW9sb2NhdGlvblBlcm1pc3Npb25Gb3JGcmFtZShmcmFtZSwgbG9jYXRpb24pOwogfQogCiB2b2lk IEdlb2xvY2F0aW9uQ29udHJvbGxlckNsaWVudEJsYWNrQmVycnk6OmNhbmNlbFBlcm1pc3Npb25S ZXF1ZXN0KEdlb2xvY2F0aW9uKiBsb2NhdGlvbikKQEAgLTc1LDcgKzc0LDcgQEAgdm9pZCBHZW9s b2NhdGlvbkNvbnRyb2xsZXJDbGllbnRCbGFja0JlcnJ5OjpjYW5jZWxQZXJtaXNzaW9uUmVxdWVz dChHZW9sb2NhdGlvbioKICAgICBGcmFtZSogZnJhbWUgPSBsb2NhdGlvbi0+ZnJhbWUoKTsKICAg ICBpZiAoIWZyYW1lKQogICAgICAgICByZXR1cm47Ci0gICAgbV93ZWJQYWdlLT5kLT5tX3BhZ2Ut PmNocm9tZSgpLT5jYW5jZWxHZW9sb2NhdGlvblBlcm1pc3Npb25SZXF1ZXN0Rm9yRnJhbWUoZnJh bWUsIGxvY2F0aW9uKTsKKyAgICBtX3dlYlBhZ2VQcml2YXRlLT5tX3BhZ2UtPmNocm9tZSgpLT5j YW5jZWxHZW9sb2NhdGlvblBlcm1pc3Npb25SZXF1ZXN0Rm9yRnJhbWUoZnJhbWUsIGxvY2F0aW9u KTsKIH0KIAogdm9pZCBHZW9sb2NhdGlvbkNvbnRyb2xsZXJDbGllbnRCbGFja0JlcnJ5Ojpvbkxv Y2F0aW9uVXBkYXRlKGRvdWJsZSB0aW1lc3RhbXAsIGRvdWJsZSBsYXRpdHVkZSwgZG91YmxlIGxv bmdpdHVkZSwgZG91YmxlIGFjY3VyYWN5LCBkb3VibGUgYWx0aXR1ZGUsIGJvb2wgYWx0aXR1ZGVW YWxpZCwKQEAgLTgzLDEzICs4MiwxMyBAQCB2b2lkIEdlb2xvY2F0aW9uQ29udHJvbGxlckNsaWVu dEJsYWNrQmVycnk6Om9uTG9jYXRpb25VcGRhdGUoZG91YmxlIHRpbWVzdGFtcCwgZAogewogICAg IG1fbGFzdFBvc2l0aW9uID0gR2VvbG9jYXRpb25Qb3NpdGlvbjo6Y3JlYXRlKHRpbWVzdGFtcCwg bGF0aXR1ZGUsIGxvbmdpdHVkZSwgYWNjdXJhY3ksIGFsdGl0dWRlVmFsaWQsIGFsdGl0dWRlLCBh bHRpdHVkZUFjY3VyYWN5VmFsaWQsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgYWx0aXR1ZGVBY2N1cmFjeSwgaGVhZGluZ1ZhbGlkLCBoZWFkaW5nLCBz cGVlZFZhbGlkLCBzcGVlZCk7Ci0gICAgbV93ZWJQYWdlLT5kLT5tX3BhZ2UtPmdlb2xvY2F0aW9u Q29udHJvbGxlcigpLT5wb3NpdGlvbkNoYW5nZWQobV9sYXN0UG9zaXRpb24uZ2V0KCkpOworICAg IG1fd2ViUGFnZVByaXZhdGUtPm1fcGFnZS0+Z2VvbG9jYXRpb25Db250cm9sbGVyKCktPnBvc2l0 aW9uQ2hhbmdlZChtX2xhc3RQb3NpdGlvbi5nZXQoKSk7CiB9CiAKIHZvaWQgR2VvbG9jYXRpb25D b250cm9sbGVyQ2xpZW50QmxhY2tCZXJyeTo6b25Mb2NhdGlvbkVycm9yKGNvbnN0IGNoYXIqIGVy cm9yU3RyKQogewogICAgIFJlZlB0cjxHZW9sb2NhdGlvbkVycm9yPiBlcnJvciA9IEdlb2xvY2F0 aW9uRXJyb3I6OmNyZWF0ZShHZW9sb2NhdGlvbkVycm9yOjpQb3NpdGlvblVuYXZhaWxhYmxlLCBT dHJpbmc6OmZyb21VVEY4KGVycm9yU3RyKSk7Ci0gICAgbV93ZWJQYWdlLT5kLT5tX3BhZ2UtPmdl b2xvY2F0aW9uQ29udHJvbGxlcigpLT5lcnJvck9jY3VycmVkKGVycm9yLmdldCgpKTsKKyAgICBt X3dlYlBhZ2VQcml2YXRlLT5tX3BhZ2UtPmdlb2xvY2F0aW9uQ29udHJvbGxlcigpLT5lcnJvck9j Y3VycmVkKGVycm9yLmdldCgpKTsKIH0KIAogdm9pZCBHZW9sb2NhdGlvbkNvbnRyb2xsZXJDbGll bnRCbGFja0JlcnJ5OjpvblBlcm1pc3Npb24odm9pZCogY29udGV4dCwgYm9vbCBpc0FsbG93ZWQp CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvR2Vv bG9jYXRpb25Db250cm9sbGVyQ2xpZW50QmxhY2tCZXJyeS5oIGIvU291cmNlL1dlYktpdC9ibGFj a2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0dlb2xvY2F0aW9uQ29udHJvbGxlckNsaWVudEJsYWNrQmVy cnkuaAppbmRleCAxNGIwOTVkLi5lYTYzNGJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvR2VvbG9jYXRpb25Db250cm9sbGVyQ2xpZW50QmxhY2tC ZXJyeS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9HZW9s b2NhdGlvbkNvbnRyb2xsZXJDbGllbnRCbGFja0JlcnJ5LmgKQEAgLTE5LDE3ICsxOSwyMiBAQAog I2lmbmRlZiBHZW9sb2NhdGlvbkNvbnRyb2xsZXJDbGllbnRCbGFja0JlcnJ5X2gKICNkZWZpbmUg R2VvbG9jYXRpb25Db250cm9sbGVyQ2xpZW50QmxhY2tCZXJyeV9oCiAKLSNpbmNsdWRlICJXZWJQ YWdlLmgiCiAjaW5jbHVkZSA8QmxhY2tCZXJyeVBsYXRmb3JtR2VvVHJhY2tlci5oPgogI2luY2x1 ZGUgPEJsYWNrQmVycnlQbGF0Zm9ybUdlb1RyYWNrZXJMaXN0ZW5lci5oPgogI2luY2x1ZGUgPEdl b2xvY2F0aW9uQ2xpZW50Lmg+CiAjaW5jbHVkZSA8R2VvbG9jYXRpb25Qb3NpdGlvbi5oPgogCitu YW1lc3BhY2UgQmxhY2tCZXJyeSB7CituYW1lc3BhY2UgV2ViS2l0IHsKK2NsYXNzIFdlYlBhZ2VQ cml2YXRlOworfQorfQorCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIGNsYXNzIEdlb2xvY2F0aW9u Q29udHJvbGxlckNsaWVudEJsYWNrQmVycnkgOiBwdWJsaWMgR2VvbG9jYXRpb25DbGllbnQsIHB1 YmxpYyBCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6R2VvVHJhY2tlckxpc3RlbmVyIHsKIHB1YmxpYzoK LSAgICBHZW9sb2NhdGlvbkNvbnRyb2xsZXJDbGllbnRCbGFja0JlcnJ5KEJsYWNrQmVycnk6Oldl YktpdDo6V2ViUGFnZSopOworICAgIEdlb2xvY2F0aW9uQ29udHJvbGxlckNsaWVudEJsYWNrQmVy cnkoQmxhY2tCZXJyeTo6V2ViS2l0OjpXZWJQYWdlUHJpdmF0ZSopOwogCiAgICAgdmlydHVhbCB2 b2lkIGdlb2xvY2F0aW9uRGVzdHJveWVkKCk7CiAgICAgdmlydHVhbCB2b2lkIHN0YXJ0VXBkYXRp bmcoKTsKQEAgLTQ2LDcgKzUxLDcgQEAgcHVibGljOgogICAgIEJsYWNrQmVycnk6OlBsYXRmb3Jt OjpHZW9UcmFja2VyKiB0cmFja2VyKCkgY29uc3QgeyByZXR1cm4gbV90cmFja2VyOyB9CiAKIHBy aXZhdGU6Ci0gICAgQmxhY2tCZXJyeTo6V2ViS2l0OjpXZWJQYWdlKiBtX3dlYlBhZ2U7CisgICAg QmxhY2tCZXJyeTo6V2ViS2l0OjpXZWJQYWdlUHJpdmF0ZSogbV93ZWJQYWdlUHJpdmF0ZTsKICAg ICBCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6R2VvVHJhY2tlciogbV90cmFja2VyOwogICAgIFJlZlB0 cjxHZW9sb2NhdGlvblBvc2l0aW9uPiBtX2xhc3RQb3NpdGlvbjsKICAgICBib29sIG1fYWNjdXJh Y3k7Ci0tIAoxLjcuNS40Cgo=