77924 2012-02-06 18:36:50 -0800 Dashboard on perf-o-matic should be sorted 2012-04-23 00:00:33 -0700 1 1 1 Unclassified WebKit WebKit Website 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa abarth morrita oldest_to_newest 550514 0 rniwa 2012-02-06 18:36:50 -0800 Right now, the tests on the dashboard show up on random order( depends on how Python generates JSON, which in turn depends on how they order hashed strings). We should sort them nicely so that people don't have to keep looking for the tests. 550521 1 125750 rniwa 2012-02-06 18:43:25 -0800 Created attachment 125750 Fixes the bug 551072 2 125750 tony 2012-02-07 09:58:47 -0800 Comment on attachment 125750 Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=125750&action=review > Websites/webkit-perf.appspot.com/js/config.js:84 > + for (test in testToId) > + tests.push(test); Can you use Object.keys(testToId)? > Websites/webkit-perf.appspot.com/js/config.js:88 > + for (var i = 0; i < tests.length; i++) > + sortedTestToId[tests[i]] = testToId[tests[i]]; > + dashboardManifest['testToId'] = sortedTestToId; This is OK, but it would be more efficient to sort when you use dashboardManifest['testToId']. I guess that involves changing perfomatic code. 551107 3 125750 rniwa 2012-02-07 10:34:28 -0800 Comment on attachment 125750 Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=125750&action=review >> Websites/webkit-perf.appspot.com/js/config.js:84 >> + tests.push(test); > > Can you use Object.keys(testToId)? Sure. >> Websites/webkit-perf.appspot.com/js/config.js:88 >> + dashboardManifest['testToId'] = sortedTestToId; > > This is OK, but it would be more efficient to sort when you use dashboardManifest['testToId']. I guess that involves changing perfomatic code. Right. And we can't sort tests on Mozilla's version (the order is hard-coded there). 607508 4 rniwa 2012-04-23 00:00:33 -0700 Fixed in http://trac.webkit.org/changeset/106960. 125750 2012-02-06 18:43:25 -0800 2012-02-07 10:34:28 -0800 Fixes the bug bug-77924-20120206184324.patch text/plain 1564 rniwa SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDEwNjg5 MSkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTAy LTA2ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIERhc2hib2Fy ZCBvbiBwZXJmLW8tbWF0aWMgc2hvdWxkIGJlIHNvcnRlZAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Nzc5MjQKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTb3J0IHRlc3RzIGluIHRoZSBmcm9udGVuZCB1c2lu ZyB0aGUgZmFjdCBFUzUga2VlcHMgdGhlIHByb3BlcnR5IG9yZGVyIGluIHRoZSBpbnNlcnRpb24g b3JkZXIuCisKKyAgICAgICAgKiBXZWJzaXRlcy93ZWJraXQtcGVyZi5hcHBzcG90LmNvbS9qcy9j b25maWcuanM6CisgICAgICAgIChmZXRjaERhc2hib2FyZE1hbmlmZXN0KToKKwogMjAxMi0wMi0w NiAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBQZXJmLW8tbWF0 aWMgc2hvdWxkIHNob3cgbWluL21heC9zdGRldiBvbiBncmFwaHMKSW5kZXg6IFdlYnNpdGVzL3dl YmtpdC1wZXJmLmFwcHNwb3QuY29tL2pzL2NvbmZpZy5qcwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJzaXRl cy93ZWJraXQtcGVyZi5hcHBzcG90LmNvbS9qcy9jb25maWcuanMJKHJldmlzaW9uIDEwNjg5MCkK KysrIFdlYnNpdGVzL3dlYmtpdC1wZXJmLmFwcHNwb3QuY29tL2pzL2NvbmZpZy5qcwkod29ya2lu ZyBjb3B5KQpAQCAtNzYsNSArNzYsMTYgQEAgZnVuY3Rpb24gZmV0Y2hEYXNoYm9hcmRNYW5pZmVz dChjYWxsYmFjawogICAgICAgICBjYWNoZTogdHJ1ZSwKICAgICB9KTsKIAotICAgICQuZ2V0SlNP TihTRVJWRVIgKyAnL2FwaS90ZXN0L2Rhc2hib2FyZCcsIGNhbGxiYWNrKTsKKyAgICAkLmdldEpT T04oU0VSVkVSICsgJy9hcGkvdGVzdC9kYXNoYm9hcmQnLCBmdW5jdGlvbiAoZGFzaGJvYXJkTWFu aWZlc3QpIHsKKyAgICAgICAgdmFyIHRlc3RUb0lkID0gZGFzaGJvYXJkTWFuaWZlc3RbJ3Rlc3RU b0lkJ107CisgICAgICAgIHZhciB0ZXN0cyA9IFtdOworICAgICAgICB2YXIgc29ydGVkVGVzdFRv SWQgPSB7fTsKKyAgICAgICAgZm9yICh0ZXN0IGluIHRlc3RUb0lkKQorICAgICAgICAgICAgdGVz dHMucHVzaCh0ZXN0KTsKKyAgICAgICAgdGVzdHMuc29ydCgpOworICAgICAgICBmb3IgKHZhciBp ID0gMDsgaSA8IHRlc3RzLmxlbmd0aDsgaSsrKQorICAgICAgICAgICAgc29ydGVkVGVzdFRvSWRb dGVzdHNbaV1dID0gdGVzdFRvSWRbdGVzdHNbaV1dOworICAgICAgICBkYXNoYm9hcmRNYW5pZmVz dFsndGVzdFRvSWQnXSA9IHNvcnRlZFRlc3RUb0lkOworICAgICAgICBjYWxsYmFjayhkYXNoYm9h cmRNYW5pZmVzdCk7CisgICAgfSk7CiB9Cg==