77922 2012-02-06 18:22:57 -0800 Apple/Safari: Enable WebGL multisampling on ATI cards for particular builds 2012-07-05 18:53:48 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 90649 1 dino dino cmarrin jamesr kbr webkit-bug-importer zmo oldest_to_newest 550507 0 dino 2012-02-06 18:22:57 -0800 Currently GraphicsContext3DOpenGLCommon validates the incoming antialias attribute and only enables it for NVIDIA cards. Chromium allows multisampling on OS X + ATI when on 10.7.2 and above. For more info: http://code.google.com/codesearch#OAMlx_jo-ck/src/chrome/browser/resources/software_rendering_list/software_rendering_list.json&exact_package=chromium&ct=rc&cd=1&q=software_rendering_list.json http://src.chromium.org/viewvc/chrome/trunk/deps/gpu/software_rendering_list/software_rendering_list.json?view=log 550508 1 webkit-bug-importer 2012-02-06 18:23:54 -0800 <rdar://problem/10817469> 550516 2 kbr 2012-02-06 18:39:54 -0800 zmo's responsible for Chromium's GPU blacklist and could help advise on changes in this area. Though this is far beyond the scope of this issue, it would be fantastic if we could figure out how to share the GPU blacklist information not only between WebKit ports but also between browsers. 550524 3 jamesr 2012-02-06 18:45:10 -0800 Firefox exposes their blacklisting info on this wiki: https://wiki.mozilla.org/Blocklisting/Blocked_Graphics_Drivers. It looks like they've taken a slightly different approach to MSAA, quoting from the version currently there: "For MSAA, we block all ATI cards except for AMD Radeon HD 6490M (device id 0x6760) and ATI Radeon HD 4670 (device id 0x9488). See Chromium issue 83153 [1]." 550529 4 kbr 2012-02-06 18:48:13 -0800 zmo recently verified that even older ATI hardware seems to support multisampled frame buffer objects well with 10.7.2, where the same cards hung while creating a multisampled renderbuffer on earlier versions of Mac OS. That informed Chrome's decision to stop blacklisting ATI cards on 10.7. 550549 5 125754 dino 2012-02-06 19:43:31 -0800 Created attachment 125754 Patch 550553 6 dino 2012-02-06 19:47:46 -0800 (In reply to comment #2) > Though this is far beyond the scope of this issue, it would be fantastic if we could figure out how to share the GPU blacklist information not only between WebKit ports but also between browsers. Definitely! I expect we'll (Apple'll) will always lag on this while WebGL is disabled by default. It would be so much nicer for us if there was a shared system. 550554 7 125754 webkit-ews 2012-02-06 19:47:47 -0800 Comment on attachment 125754 Patch Attachment 125754 did not pass qt-ews (qt): Output: http://queues.webkit.org/results/11436119 550555 8 125754 dino 2012-02-06 19:49:22 -0800 Comment on attachment 125754 Patch breaks QT 550559 9 125756 dino 2012-02-06 19:52:19 -0800 Created attachment 125756 Patch 551062 10 dino 2012-02-07 09:36:36 -0800 http://trac.webkit.org/changeset/106956 551075 11 125756 ap 2012-02-07 10:00:20 -0800 Comment on attachment 125756 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125756&action=review > Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:63 > + static SInt32 version; I recommend always adding ASSERT(isMainThread()) in functions that use static variables. > Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:69 > + return version > 0x1072; This doesn't match comments or description in ChangeLog (should be ">="?) 551084 12 dino 2012-02-07 10:06:44 -0800 (In reply to comment #11) > (From update of attachment 125756 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=125756&action=review > > > Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:63 > > + static SInt32 version; > > I recommend always adding ASSERT(isMainThread()) in functions that use static variables. I'll fix this. > > Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:69 > > + return version > 0x1072; > > This doesn't match comments or description in ChangeLog (should be ">="?) Indeed! Sorry. 551154 13 dino 2012-02-07 11:19:22 -0800 Followup. http://trac.webkit.org/changeset/106964 125754 2012-02-06 19:43:31 -0800 2012-02-06 19:52:16 -0800 Patch bug-77922-20120206194330.patch text/plain 2628 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2Njk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWYyYTk4OGRjYjFlOTk4 NTZlYjdjNjAyZjk4MmM4MDA3MGJjYWI3Ny4uNjExZTgyNjMxNWNkODQ4OThmYjc0MTRkZDM1ZjBj ZDYyOWQyOWMxOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTAyLTA2ICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBBcHBsZS9TYWZhcmk6IEVuYWJs ZSBXZWJHTCBtdWx0aXNhbXBsaW5nIG9uIEFUSSBjYXJkcworICAgICAgICBmb3IgcGFydGljdWxh ciBidWlsZHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTc3OTIyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Rm9sbG93IENocm9tZSdzIGxlYWQgdG8gYWxsb3cgV2ViR0wgYW50aWFsaWFzaW5nCisgICAgICAg IG9uIEFUSSBjYXJkcyBhcyBsb25nIGFzIHdlJ3JlIG9uIDEwLjcuMiBhbmQgYWJvdmUuCisKKyAg ICAgICAgTm8gbmV3IHRlc3RzLiBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3RzLgorCisgICAgICAg ICogcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0dyYXBoaWNzQ29udGV4dDNET3BlbkdMQ29tbW9u LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnN5c3RlbUFsbG93c011bHRpc2FtcGxpbmdPbkFUSUNh cmRzKToKKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NDb250 ZXh0M0Q6OnZhbGlkYXRlQXR0cmlidXRlcyk6CisKIDIwMTItMDItMDMgIFlvbmcgTGkgIDx5b2xp QHJpbS5jb20+CiAKICAgICAgICAgW0JsYWNrQmVycnldIExldCB1c2VySWRsZVRpbWUoKSByZXR1 cm4gbWF4aW11bSBudW1iZXIgaW5zdGVhZCBvZiAwIGFzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvR3JhcGhpY3NDb250ZXh0M0RPcGVuR0xDb21t b24uY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0dyYXBoaWNz Q29udGV4dDNET3BlbkdMQ29tbW9uLmNwcAppbmRleCBlNjhiYmE3ZmQ3ZjUxOWZkNzhjMTY5YTcy OTNjOWIyYWQ1MjYwZGU4Li43NWMzMDZhOWU3MTdmMGMwNWFmYWQwMmQ4ODc4NDhmNjE4NWU0M2Mw IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvR3Jh cGhpY3NDb250ZXh0M0RPcGVuR0xDb21tb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL29wZW5nbC9HcmFwaGljc0NvbnRleHQzRE9wZW5HTENvbW1vbi5jcHAKQEAg LTU3LDYgKzU3LDE3IEBACiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAorc3RhdGljIGJvb2wgc3lz dGVtQWxsb3dzTXVsdGlzYW1wbGluZ09uQVRJQ2FyZHMoKQoreworICAgIHN0YXRpYyBTSW50MzIg dmVyc2lvbjsKKyAgICBpZiAoIXZlcnNpb24pIHsKKyAgICAgICAgaWYgKEdlc3RhbHQoZ2VzdGFs dFN5c3RlbVZlcnNpb24sICZ2ZXJzaW9uKSAhPSBub0VycikgCisgICAgICAgICAgICByZXR1cm4g ZmFsc2U7CisgICAgfQorICAgIC8vIFNlZSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9Nzc5MjIgZm9yIG1vcmUgZGV0YWlscworICAgIHJldHVybiB2ZXJzaW9uID4gMHgx MDcyOworfQorCiB2b2lkIEdyYXBoaWNzQ29udGV4dDNEOjp2YWxpZGF0ZUF0dHJpYnV0ZXMoKQog ewogICAgIEV4dGVuc2lvbnMzRCogZXh0ZW5zaW9ucyA9IGdldEV4dGVuc2lvbnMoKTsKQEAgLTcw LDkgKzgxLDEwIEBAIHZvaWQgR3JhcGhpY3NDb250ZXh0M0Q6OnZhbGlkYXRlQXR0cmlidXRlcygp CiAgICAgfQogICAgIGlmIChtX2F0dHJzLmFudGlhbGlhcykgewogICAgICAgICBib29sIGlzVmFs aWRWZW5kb3IgPSB0cnVlOwotICAgICAgICAvLyBDdXJyZW50bHkgaW4gTWFjIHdlIG9ubHkgdHVy biBvbiBhbnRpYWxpYXMgaWYgdmVuZG9yIGlzIE5WSURJQS4KKyAgICAgICAgLy8gQ3VycmVudGx5 IGluIE1hYyB3ZSBvbmx5IHR1cm4gb24gYW50aWFsaWFzIGlmIHZlbmRvciBpcyBOVklESUEsCisg ICAgICAgIC8vIG9yIGlmIEFUSSBhbmQgb24gMTAuNy4yIGFuZCBhYm92ZS4KICAgICAgICAgY29u c3QgY2hhciogdmVuZG9yID0gcmVpbnRlcnByZXRfY2FzdDxjb25zdCBjaGFyKj4oOjpnbEdldFN0 cmluZyhHTF9WRU5ET1IpKTsKLSAgICAgICAgaWYgKCFzdGQ6OnN0cnN0cih2ZW5kb3IsICJOVklE SUEiKSkKKyAgICAgICAgaWYgKCFzdGQ6OnN0cnN0cih2ZW5kb3IsICJOVklESUEiKSAmJiAhKHN0 ZDo6c3Ryc3RyKHZlbmRvciwgIkFUSSIpICYmIHN5c3RlbUFsbG93c011bHRpc2FtcGxpbmdPbkFU SUNhcmRzKCkpKQogICAgICAgICAgICAgaXNWYWxpZFZlbmRvciA9IGZhbHNlOwogICAgICAgICBp ZiAoIWlzVmFsaWRWZW5kb3IgfHwgIWV4dGVuc2lvbnMtPnN1cHBvcnRzKCJHTF9BTkdMRV9mcmFt ZWJ1ZmZlcl9tdWx0aXNhbXBsZSIpKQogICAgICAgICAgICAgbV9hdHRycy5hbnRpYWxpYXMgPSBm YWxzZTsK 125756 2012-02-06 19:52:19 -0800 2012-02-07 10:00:20 -0800 Patch bug-77922-20120206195218.patch text/plain 2681 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2Njk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWYyYTk4OGRjYjFlOTk4 NTZlYjdjNjAyZjk4MmM4MDA3MGJjYWI3Ny4uNjExZTgyNjMxNWNkODQ4OThmYjc0MTRkZDM1ZjBj ZDYyOWQyOWMxOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTAyLTA2ICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBBcHBsZS9TYWZhcmk6IEVuYWJs ZSBXZWJHTCBtdWx0aXNhbXBsaW5nIG9uIEFUSSBjYXJkcworICAgICAgICBmb3IgcGFydGljdWxh ciBidWlsZHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTc3OTIyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Rm9sbG93IENocm9tZSdzIGxlYWQgdG8gYWxsb3cgV2ViR0wgYW50aWFsaWFzaW5nCisgICAgICAg IG9uIEFUSSBjYXJkcyBhcyBsb25nIGFzIHdlJ3JlIG9uIDEwLjcuMiBhbmQgYWJvdmUuCisKKyAg ICAgICAgTm8gbmV3IHRlc3RzLiBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3RzLgorCisgICAgICAg ICogcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0dyYXBoaWNzQ29udGV4dDNET3BlbkdMQ29tbW9u LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnN5c3RlbUFsbG93c011bHRpc2FtcGxpbmdPbkFUSUNh cmRzKToKKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NDb250 ZXh0M0Q6OnZhbGlkYXRlQXR0cmlidXRlcyk6CisKIDIwMTItMDItMDMgIFlvbmcgTGkgIDx5b2xp QHJpbS5jb20+CiAKICAgICAgICAgW0JsYWNrQmVycnldIExldCB1c2VySWRsZVRpbWUoKSByZXR1 cm4gbWF4aW11bSBudW1iZXIgaW5zdGVhZCBvZiAwIGFzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvR3JhcGhpY3NDb250ZXh0M0RPcGVuR0xDb21t b24uY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0dyYXBoaWNz Q29udGV4dDNET3BlbkdMQ29tbW9uLmNwcAppbmRleCBlNjhiYmE3ZmQ3ZjUxOWZkNzhjMTY5YTcy OTNjOWIyYWQ1MjYwZGU4Li41NTIyNjcwZjU2ZWY3OTg0ZDhjOTU2Y2JlYWY5Y2E1ZDIzMWI5YTQ0 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvR3Jh cGhpY3NDb250ZXh0M0RPcGVuR0xDb21tb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL29wZW5nbC9HcmFwaGljc0NvbnRleHQzRE9wZW5HTENvbW1vbi5jcHAKQEAg LTU3LDYgKzU3LDIxIEBACiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAorc3RhdGljIGJvb2wgc3lz dGVtQWxsb3dzTXVsdGlzYW1wbGluZ09uQVRJQ2FyZHMoKQoreworI2lmIFBMQVRGT1JNKE1BQykK KyAgICBzdGF0aWMgU0ludDMyIHZlcnNpb247CisgICAgaWYgKCF2ZXJzaW9uKSB7CisgICAgICAg IGlmIChHZXN0YWx0KGdlc3RhbHRTeXN0ZW1WZXJzaW9uLCAmdmVyc2lvbikgIT0gbm9FcnIpIAor ICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIH0KKyAgICAvLyBTZWUgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc3OTIyIGZvciBtb3JlIGRldGFpbHMKKyAgICBy ZXR1cm4gdmVyc2lvbiA+IDB4MTA3MjsKKyNlbHNlCisgICAgcmV0dXJuIGZhbHNlOworI2VuZGlm Cit9CisKIHZvaWQgR3JhcGhpY3NDb250ZXh0M0Q6OnZhbGlkYXRlQXR0cmlidXRlcygpCiB7CiAg ICAgRXh0ZW5zaW9uczNEKiBleHRlbnNpb25zID0gZ2V0RXh0ZW5zaW9ucygpOwpAQCAtNzAsOSAr ODUsMTAgQEAgdm9pZCBHcmFwaGljc0NvbnRleHQzRDo6dmFsaWRhdGVBdHRyaWJ1dGVzKCkKICAg ICB9CiAgICAgaWYgKG1fYXR0cnMuYW50aWFsaWFzKSB7CiAgICAgICAgIGJvb2wgaXNWYWxpZFZl bmRvciA9IHRydWU7Ci0gICAgICAgIC8vIEN1cnJlbnRseSBpbiBNYWMgd2Ugb25seSB0dXJuIG9u IGFudGlhbGlhcyBpZiB2ZW5kb3IgaXMgTlZJRElBLgorICAgICAgICAvLyBDdXJyZW50bHkgaW4g TWFjIHdlIG9ubHkgdHVybiBvbiBhbnRpYWxpYXMgaWYgdmVuZG9yIGlzIE5WSURJQSwKKyAgICAg ICAgLy8gb3IgaWYgQVRJIGFuZCBvbiAxMC43LjIgYW5kIGFib3ZlLgogICAgICAgICBjb25zdCBj aGFyKiB2ZW5kb3IgPSByZWludGVycHJldF9jYXN0PGNvbnN0IGNoYXIqPig6OmdsR2V0U3RyaW5n KEdMX1ZFTkRPUikpOwotICAgICAgICBpZiAoIXN0ZDo6c3Ryc3RyKHZlbmRvciwgIk5WSURJQSIp KQorICAgICAgICBpZiAoIXN0ZDo6c3Ryc3RyKHZlbmRvciwgIk5WSURJQSIpICYmICEoc3RkOjpz dHJzdHIodmVuZG9yLCAiQVRJIikgJiYgc3lzdGVtQWxsb3dzTXVsdGlzYW1wbGluZ09uQVRJQ2Fy ZHMoKSkpCiAgICAgICAgICAgICBpc1ZhbGlkVmVuZG9yID0gZmFsc2U7CiAgICAgICAgIGlmICgh aXNWYWxpZFZlbmRvciB8fCAhZXh0ZW5zaW9ucy0+c3VwcG9ydHMoIkdMX0FOR0xFX2ZyYW1lYnVm ZmVyX211bHRpc2FtcGxlIikpCiAgICAgICAgICAgICBtX2F0dHJzLmFudGlhbGlhcyA9IGZhbHNl Owo=