77912 2012-02-06 16:24:08 -0800 [CG] Remove old CG specific shadow setting code from canvas 2012-02-07 13:53:03 -0800 1 1 1 Unclassified WebKit Canvas 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mdelaney7 mdelaney7 cmarrin mdelaney7 mitz oldest_to_newest 550398 0 mdelaney7 2012-02-06 16:24:08 -0800 CanvasRenderingContext2D has an old setShadows method that sets CMYKa shadows for CG in a hardcoded manner. This hardcoded path is useless now since it'll get overwritten on the CG context via the normal shadow setting route and thus it should be ripped out. This function is currently hit by two canvas layout tests which both still pass after removing the hardcoded CG-specific path. (fast/canvas/shadow-offset-7.html AND fast/canvas/canvas-overloads-setShadow.html). 550444 1 125734 mdelaney7 2012-02-06 17:13:31 -0800 Created attachment 125734 Patch 550684 2 125734 simon.fraser 2012-02-07 00:42:46 -0800 Comment on attachment 125734 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125734&action=review > Source/WebCore/ChangeLog:4 > + Removing old CG shadow code. This needs to be a bit more detailed. Why was the old code added? Why is it OK to remove it now? 551087 3 125868 mdelaney7 2012-02-07 10:08:36 -0800 Created attachment 125868 Patch 551222 4 125868 simon.fraser 2012-02-07 12:12:12 -0800 Comment on attachment 125868 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125868&action=review > Source/WebCore/ChangeLog:8 > + The CG specific shadow offset hack was added in http://trac.webkit.org/changeset/34317 > + but has since moved down into GraphicsContextCG::setLegacyShadow that is called > + by applyShadow() thus the shadow hack is redundant here if we call applyShadow() It's very hard to parse this run-on sentence. > Source/WebCore/ChangeLog:12 > + The CG specific shadow setting block of code is redundant since any setting we > + do here to the CGContext will get overwritten later by any subsequent shadow setting > + or unsetting since the values in the State object are what's push down into CG. And this one. 551343 5 mdelaney7 2012-02-07 13:53:03 -0800 Committed r106988: <http://trac.webkit.org/changeset/106988> 125734 2012-02-06 17:13:31 -0800 2012-02-07 10:08:32 -0800 Patch bug-77912-20120206171329.patch text/plain 1566 mdelaney7 SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwNjg3NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTAyLTA2ICBNYXR0aGV3 IERlbGFuZXkgIDxtZGVsYW5leUBhcHBsZS5jb20+CisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc3OTEyCisgICAgICAgIFJlbW92aW5nIG9sZCBDRyBz aGFkb3cgY29kZS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBObyBuZXcgdGVzdHMuIEN1cnJlbnQgY2FudmFzIHRlc3RzIGNvdmVyIHRoaXMgcGF0aC4K KworICAgICAgICAqIGh0bWwvY2FudmFzL0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyRC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpDYW52YXNSZW5kZXJpbmdDb250ZXh0MkQ6OnNldFNoYWRvdyk6CisK IDIwMTItMDItMDYgIEdyZWcgU2ltb24gIDxncmVnc2ltb25AY2hyb21pdW0ub3JnPgogCiAgICAg ICAgIHBvc3RNZXNzYWdlIGxlYWtzIE1lbW9yeUV2ZW50IG9iamVjdApJbmRleDogU291cmNlL1dl YkNvcmUvaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250ZXh0MkQu Y3BwCShyZXZpc2lvbiAxMDY4NjQpCisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9DYW52 YXNSZW5kZXJpbmdDb250ZXh0MkQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMjA2LDE2ICsxMjA2 LDggQEAgdm9pZCBDYW52YXNSZW5kZXJpbmdDb250ZXh0MkQ6OnNldFNoYWRvdwogICAgIEdyYXBo aWNzQ29udGV4dCogZGMgPSBkcmF3aW5nQ29udGV4dCgpOwogICAgIGlmICghZGMpCiAgICAgICAg IHJldHVybjsKLSNpZiBVU0UoQ0cpCi0gICAgY29uc3QgQ0dGbG9hdCBjb21wb25lbnRzWzVdID0g eyBjLCBtLCB5LCBrLCBhIH07Ci0gICAgQ0dDb2xvclNwYWNlUmVmIGNvbG9yU3BhY2UgPSBDR0Nv bG9yU3BhY2VDcmVhdGVEZXZpY2VDTVlLKCk7Ci0gICAgQ0dDb2xvclJlZiBzaGFkb3dDb2xvciA9 IENHQ29sb3JDcmVhdGUoY29sb3JTcGFjZSwgY29tcG9uZW50cyk7Ci0gICAgQ0dDb2xvclNwYWNl UmVsZWFzZShjb2xvclNwYWNlKTsKLSAgICBDR0NvbnRleHRTZXRTaGFkb3dXaXRoQ29sb3IoZGMt PnBsYXRmb3JtQ29udGV4dCgpLCBhZGp1c3RlZFNoYWRvd1NpemUod2lkdGgsIC1oZWlnaHQpLCBi bHVyLCBzaGFkb3dDb2xvcik7Ci0gICAgQ0dDb2xvclJlbGVhc2Uoc2hhZG93Q29sb3IpOwotI2Vs c2UKKwogICAgIGFwcGx5U2hhZG93KCk7Ci0jZW5kaWYKIH0KIAogdm9pZCBDYW52YXNSZW5kZXJp bmdDb250ZXh0MkQ6OmNsZWFyU2hhZG93KCkK 125868 2012-02-07 10:08:36 -0800 2012-02-07 12:12:12 -0800 Patch bug-77912-20120207100834.patch text/plain 3126 mdelaney7 SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwNjg0NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDEyLTAyLTA3ICBNYXR0aGV3 IERlbGFuZXkgIDxtZGVsYW5leUBhcHBsZS5jb20+CisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc3OTEyCisgICAgICAgIFJlbW92aW5nIG9sZCBDRyBz aGFkb3cgY29kZS4KKyAgICAgICAgCisgICAgICAgIFRoZSBDRyBzcGVjaWZpYyBzaGFkb3cgb2Zm c2V0IGhhY2sgd2FzIGFkZGVkIGluIGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzM0 MzE3CisgICAgICAgIGJ1dCBoYXMgc2luY2UgbW92ZWQgZG93biBpbnRvIEdyYXBoaWNzQ29udGV4 dENHOjpzZXRMZWdhY3lTaGFkb3cgdGhhdCBpcyBjYWxsZWQKKyAgICAgICAgYnkgYXBwbHlTaGFk b3coKSB0aHVzIHRoZSBzaGFkb3cgaGFjayBpcyByZWR1bmRhbnQgaGVyZSBpZiB3ZSBjYWxsIGFw cGx5U2hhZG93KCkKKworICAgICAgICBUaGUgQ0cgc3BlY2lmaWMgc2hhZG93IHNldHRpbmcgYmxv Y2sgb2YgY29kZSBpcyByZWR1bmRhbnQgc2luY2UgYW55IHNldHRpbmcgd2UKKyAgICAgICAgZG8g aGVyZSB0byB0aGUgQ0dDb250ZXh0IHdpbGwgZ2V0IG92ZXJ3cml0dGVuIGxhdGVyIGJ5IGFueSBz dWJzZXF1ZW50IHNoYWRvdyBzZXR0aW5nCisgICAgICAgIG9yIHVuc2V0dGluZyBzaW5jZSB0aGUg dmFsdWVzIGluIHRoZSBTdGF0ZSBvYmplY3QgYXJlIHdoYXQncyBwdXNoIGRvd24gaW50byBDRy4K KworICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBGcmFzZXIuCisKKyAgICAgICAgTm8gbmV3IHRl c3RzLiBDdXJyZW50IGNhbnZhcyB0ZXN0cyBjb3ZlciB0aGlzIHBhdGguCisKKyAgICAgICAgKiBo dG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250ZXh0MkQuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6Q2FudmFzUmVuZGVyaW5nQ29udGV4dDJEOjpzZXRTaGFkb3cpOgorCiAyMDEyLTAyLTA2ICBK YW1lcyBSb2JpbnNvbiAgPGphbWVzckBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgU3VwcG9ydCBk ZXRhY2hpbmcgVGV4dHVyZU1hbmFnZXIgZnJvbSBNYW5hZ2VkVGV4dHVyZQpJbmRleDogU291cmNl L1dlYkNvcmUvaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250ZXh0 MkQuY3BwCShyZXZpc2lvbiAxMDY4NDUpCisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9D YW52YXNSZW5kZXJpbmdDb250ZXh0MkQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMTAyLDI2ICsx MTAyLDYgQEAgdm9pZCBDYW52YXNSZW5kZXJpbmdDb250ZXh0MkQ6OnN0cm9rZVJlYwogICAgIGRp ZERyYXcoYm91bmRpbmdSZWN0KTsKIH0KIAotI2lmIFVTRShDRykKLXN0YXRpYyBpbmxpbmUgQ0dT aXplIGFkanVzdGVkU2hhZG93U2l6ZShDR0Zsb2F0IHdpZHRoLCBDR0Zsb2F0IGhlaWdodCkKLXsK LSAgICAvLyBXb3JrIGFyb3VuZCA8cmRhcjovL3Byb2JsZW0vNTUzOTM4OD4gYnkgZW5zdXJpbmcg dGhhdCBzaGFkb3cgb2Zmc2V0cyB3aWxsIGdldCB0cnVuY2F0ZWQKLSAgICAvLyB0byB0aGUgZGVz aXJlZCBpbnRlZ2VyLgotICAgIHN0YXRpYyBjb25zdCBDR0Zsb2F0IGV4dHJhU2hhZG93T2Zmc2V0 ID0gbmFycm93UHJlY2lzaW9uVG9DR0Zsb2F0KDEuMCAvIDEyOCk7Ci0gICAgaWYgKHdpZHRoID4g MCkKLSAgICAgICAgd2lkdGggKz0gZXh0cmFTaGFkb3dPZmZzZXQ7Ci0gICAgZWxzZSBpZiAod2lk dGggPCAwKQotICAgICAgICB3aWR0aCAtPSBleHRyYVNoYWRvd09mZnNldDsKLQotICAgIGlmICho ZWlnaHQgPiAwKQotICAgICAgICBoZWlnaHQgKz0gZXh0cmFTaGFkb3dPZmZzZXQ7Ci0gICAgZWxz ZSBpZiAoaGVpZ2h0IDwgMCkKLSAgICAgICAgaGVpZ2h0IC09IGV4dHJhU2hhZG93T2Zmc2V0Owot Ci0gICAgcmV0dXJuIENHU2l6ZU1ha2Uod2lkdGgsIGhlaWdodCk7Ci19Ci0jZW5kaWYKLQogdm9p ZCBDYW52YXNSZW5kZXJpbmdDb250ZXh0MkQ6OnNldFNoYWRvdyhmbG9hdCB3aWR0aCwgZmxvYXQg aGVpZ2h0LCBmbG9hdCBibHVyKQogewogICAgIHN0YXRlKCkubV9zaGFkb3dPZmZzZXQgPSBGbG9h dFNpemUod2lkdGgsIGhlaWdodCk7CkBAIC0xMjAyLDIwICsxMTgyLDcgQEAgdm9pZCBDYW52YXNS ZW5kZXJpbmdDb250ZXh0MkQ6OnNldFNoYWRvdwogICAgIHN0YXRlKCkubV9zaGFkb3dPZmZzZXQg PSBGbG9hdFNpemUod2lkdGgsIGhlaWdodCk7CiAgICAgc3RhdGUoKS5tX3NoYWRvd0JsdXIgPSBi bHVyOwogICAgIHN0YXRlKCkubV9zaGFkb3dDb2xvciA9IG1ha2VSR0JBRnJvbUNNWUtBKGMsIG0s IHksIGssIGEpOwotCi0gICAgR3JhcGhpY3NDb250ZXh0KiBkYyA9IGRyYXdpbmdDb250ZXh0KCk7 Ci0gICAgaWYgKCFkYykKLSAgICAgICAgcmV0dXJuOwotI2lmIFVTRShDRykKLSAgICBjb25zdCBD R0Zsb2F0IGNvbXBvbmVudHNbNV0gPSB7IGMsIG0sIHksIGssIGEgfTsKLSAgICBDR0NvbG9yU3Bh Y2VSZWYgY29sb3JTcGFjZSA9IENHQ29sb3JTcGFjZUNyZWF0ZURldmljZUNNWUsoKTsKLSAgICBD R0NvbG9yUmVmIHNoYWRvd0NvbG9yID0gQ0dDb2xvckNyZWF0ZShjb2xvclNwYWNlLCBjb21wb25l bnRzKTsKLSAgICBDR0NvbG9yU3BhY2VSZWxlYXNlKGNvbG9yU3BhY2UpOwotICAgIENHQ29udGV4 dFNldFNoYWRvd1dpdGhDb2xvcihkYy0+cGxhdGZvcm1Db250ZXh0KCksIGFkanVzdGVkU2hhZG93 U2l6ZSh3aWR0aCwgLWhlaWdodCksIGJsdXIsIHNoYWRvd0NvbG9yKTsKLSAgICBDR0NvbG9yUmVs ZWFzZShzaGFkb3dDb2xvcik7Ci0jZWxzZQogICAgIGFwcGx5U2hhZG93KCk7Ci0jZW5kaWYKIH0K IAogdm9pZCBDYW52YXNSZW5kZXJpbmdDb250ZXh0MkQ6OmNsZWFyU2hhZG93KCkK