77877 2012-02-06 08:29:10 -0800 Web Inspector: don't mark object is queriable if it is only reachable by internal reference 2012-02-07 04:53:12 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 yurys yurys apavlov bweinstein dglazkov joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 550022 0 yurys 2012-02-06 08:29:10 -0800 Web Inspector: don't mark object is queriable if it is only reachable by internal reference 550025 1 125655 yurys 2012-02-06 08:32:09 -0800 Created attachment 125655 Patch 550026 2 125655 mnaganov 2012-02-06 08:35:20 -0800 Comment on attachment 125655 Patch looks good to me 550030 3 125655 loislo 2012-02-06 08:41:15 -0800 Comment on attachment 125655 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125655&action=review > Source/WebCore/inspector/front-end/HeapSnapshot.js:-1127 > - if (this._flags[node.nodeIndex] & flag) > - continue; this is necessary check. please revert this. 550031 4 125656 yurys 2012-02-06 08:41:29 -0800 Created attachment 125656 Patch 550032 5 125656 loislo 2012-02-06 08:42:48 -0800 Comment on attachment 125656 Patch looks good to me 550051 6 125656 webkit.review.bot 2012-02-06 09:11:59 -0800 Comment on attachment 125656 Patch Attachment 125656 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11430457 New failing tests: inspector/profiler/heap-snapshot.html 550860 7 yurys 2012-02-07 04:53:12 -0800 Committed r106928: <http://trac.webkit.org/changeset/106928> 125655 2012-02-06 08:32:09 -0800 2012-02-06 08:41:22 -0800 Patch bug-77877-20120206203207.patch text/plain 2052 yurys U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2ODA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzMxYWI3MTE5MGI1ZjBh NjEzMzQzYTE4NzBhOWUyNGMzNDNhZTBjNy4uYThjYTg3ZTM5NDAzYmNhODM0Zjc2YmNiMzMxY2E1 OTlhNDQ4MzBlZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTAyLTA2ICBZdXJ5 IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IGRvbid0IG1hcmsgb2JqZWN0IGlzIHF1ZXJpYWJsZSBpZiBpdCBpcyBvbmx5IHJlYWNoYWJs ZSBieSBpbnRlcm5hbCByZWZlcmVuY2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTc3ODc3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiAoT09QUyEpCisKKyAgICAgICAgKiBpbnNwZWN0 b3IvZnJvbnQtZW5kL0hlYXBTbmFwc2hvdC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5IZWFw U25hcHNob3QucHJvdG90eXBlLl9tYXJrUXVlcmlhYmxlSGVhcE9iamVjdHMpOgorCiAyMDEyLTAy LTA2ICBObydhbSBSb3NlbnRoYWwgIDxub2FtLnJvc2VudGhhbEBub2tpYS5jb20+CiAKICAgICAg ICAgW1RleG1hcF1bUXRdIEF2b2lkIGFuIGltYWdlIGNvcHkgd2hlbiB1cGxvYWRpbmcgdGV4dHVy ZXMgaW4gV2ViS2l0MQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250 LWVuZC9IZWFwU25hcHNob3QuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5k L0hlYXBTbmFwc2hvdC5qcwppbmRleCA0ZDA2ZGJkODc2ZTkxOTc3ZDNiNTk2MjMxMmEyMWU4NDFm NzQ0OTg5Li4yZmU1YmNhYTA0MDgwMDNmNzUwYWQxYTY3YTQwMTEzODkzOTk2MDJhIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0hlYXBTbmFwc2hvdC5qcwor KysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0hlYXBTbmFwc2hvdC5qcwpA QCAtMTEyMywyMCArMTEyMywxOCBAQCBXZWJJbnNwZWN0b3IuSGVhcFNuYXBzaG90LnByb3RvdHlw ZSA9IHsKIAogICAgICAgICB3aGlsZSAobGlzdC5sZW5ndGgpIHsKICAgICAgICAgICAgIHZhciBu b2RlID0gbGlzdC5wb3AoKTsKLSAgICAgICAgICAgIGlmICh0aGlzLl9mbGFnc1tub2RlLm5vZGVJ bmRleF0gJiBmbGFnKQotICAgICAgICAgICAgICAgIGNvbnRpbnVlOwogICAgICAgICAgICAgdGhp cy5fZmxhZ3Nbbm9kZS5ub2RlSW5kZXhdIHw9IGZsYWc7CiAgICAgICAgICAgICBmb3IgKHZhciBp dGVyID0gbm9kZS5lZGdlczsgaXRlci5oYXNOZXh0KCk7IGl0ZXIubmV4dCgpKSB7CiAgICAgICAg ICAgICAgICAgdmFyIGVkZ2UgPSBpdGVyLmVkZ2U7CiAgICAgICAgICAgICAgICAgdmFyIG5vZGUg PSBlZGdlLm5vZGU7Ci0gICAgICAgICAgICAgICAgaWYgKHRoaXMuX2ZsYWdzW25vZGUubm9kZUlu ZGV4XSkKKyAgICAgICAgICAgICAgICBpZiAodGhpcy5fZmxhZ3Nbbm9kZS5ub2RlSW5kZXhdICYg ZmxhZykKICAgICAgICAgICAgICAgICAgICAgY29udGludWU7CiAgICAgICAgICAgICAgICAgaWYg KGVkZ2UuaXNIaWRkZW4gfHwgZWRnZS5pc0ludmlzaWJsZSkKICAgICAgICAgICAgICAgICAgICAg Y29udGludWU7CiAgICAgICAgICAgICAgICAgdmFyIG5hbWUgPSBlZGdlLm5hbWU7CiAgICAgICAg ICAgICAgICAgaWYgKCFuYW1lKQogICAgICAgICAgICAgICAgICAgICBjb250aW51ZTsKLSAgICAg ICAgICAgICAgICBpZiAoZWRnZS5pc0ludGVybmFsICYmIG5hbWUgIT09ICJuYXRpdmUiKQorICAg ICAgICAgICAgICAgIGlmIChlZGdlLmlzSW50ZXJuYWwpCiAgICAgICAgICAgICAgICAgICAgIGNv bnRpbnVlOwogICAgICAgICAgICAgICAgIGxpc3QucHVzaChub2RlKTsKICAgICAgICAgICAgIH0K 125656 2012-02-06 08:41:29 -0800 2012-02-06 09:11:59 -0800 Patch bug-77877-20120206204127.patch text/plain 1853 yurys U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2ODA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzMxYWI3MTE5MGI1ZjBh NjEzMzQzYTE4NzBhOWUyNGMzNDNhZTBjNy4uYThjYTg3ZTM5NDAzYmNhODM0Zjc2YmNiMzMxY2E1 OTlhNDQ4MzBlZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTAyLTA2ICBZdXJ5 IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IGRvbid0IG1hcmsgb2JqZWN0IGlzIHF1ZXJpYWJsZSBpZiBpdCBpcyBvbmx5IHJlYWNoYWJs ZSBieSBpbnRlcm5hbCByZWZlcmVuY2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTc3ODc3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiAoT09QUyEpCisKKyAgICAgICAgKiBpbnNwZWN0 b3IvZnJvbnQtZW5kL0hlYXBTbmFwc2hvdC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5IZWFw U25hcHNob3QucHJvdG90eXBlLl9tYXJrUXVlcmlhYmxlSGVhcE9iamVjdHMpOgorCiAyMDEyLTAy LTA2ICBObydhbSBSb3NlbnRoYWwgIDxub2FtLnJvc2VudGhhbEBub2tpYS5jb20+CiAKICAgICAg ICAgW1RleG1hcF1bUXRdIEF2b2lkIGFuIGltYWdlIGNvcHkgd2hlbiB1cGxvYWRpbmcgdGV4dHVy ZXMgaW4gV2ViS2l0MQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250 LWVuZC9IZWFwU25hcHNob3QuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5k L0hlYXBTbmFwc2hvdC5qcwppbmRleCA0ZDA2ZGJkODc2ZTkxOTc3ZDNiNTk2MjMxMmEyMWU4NDFm NzQ0OTg5Li5kZWY5MjczOGIwMzA5ZDcyNmRlNWU5YjgwMjdkN2RmMDhlNGQ4ZTY5IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0hlYXBTbmFwc2hvdC5qcwor KysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0hlYXBTbmFwc2hvdC5qcwpA QCAtMTEyOSwxNCArMTEyOSwxNCBAQCBXZWJJbnNwZWN0b3IuSGVhcFNuYXBzaG90LnByb3RvdHlw ZSA9IHsKICAgICAgICAgICAgIGZvciAodmFyIGl0ZXIgPSBub2RlLmVkZ2VzOyBpdGVyLmhhc05l eHQoKTsgaXRlci5uZXh0KCkpIHsKICAgICAgICAgICAgICAgICB2YXIgZWRnZSA9IGl0ZXIuZWRn ZTsKICAgICAgICAgICAgICAgICB2YXIgbm9kZSA9IGVkZ2Uubm9kZTsKLSAgICAgICAgICAgICAg ICBpZiAodGhpcy5fZmxhZ3Nbbm9kZS5ub2RlSW5kZXhdKQorICAgICAgICAgICAgICAgIGlmICh0 aGlzLl9mbGFnc1tub2RlLm5vZGVJbmRleF0gJiBmbGFnKQogICAgICAgICAgICAgICAgICAgICBj b250aW51ZTsKICAgICAgICAgICAgICAgICBpZiAoZWRnZS5pc0hpZGRlbiB8fCBlZGdlLmlzSW52 aXNpYmxlKQogICAgICAgICAgICAgICAgICAgICBjb250aW51ZTsKICAgICAgICAgICAgICAgICB2 YXIgbmFtZSA9IGVkZ2UubmFtZTsKICAgICAgICAgICAgICAgICBpZiAoIW5hbWUpCiAgICAgICAg ICAgICAgICAgICAgIGNvbnRpbnVlOwotICAgICAgICAgICAgICAgIGlmIChlZGdlLmlzSW50ZXJu YWwgJiYgbmFtZSAhPT0gIm5hdGl2ZSIpCisgICAgICAgICAgICAgICAgaWYgKGVkZ2UuaXNJbnRl cm5hbCkKICAgICAgICAgICAgICAgICAgICAgY29udGludWU7CiAgICAgICAgICAgICAgICAgbGlz dC5wdXNoKG5vZGUpOwogICAgICAgICAgICAgfQo=