77868 2012-02-06 06:19:30 -0800 LayoutTest failures on r106797 2012-02-06 11:38:11 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tonyg allan.jensen allan.jensen jchaffraix oldest_to_newest 549945 0 tonyg 2012-02-06 06:19:30 -0800 Several indexeddb related LayoutTests began failing with r106797: ASSERTION FAILED: iter->first->suspendIfNeededCalled() storage/indexeddb/createObjectStore-null-name.html storage/indexeddb/cursor-index-delete.html storage/indexeddb/cursor-skip-deleted.html storage/indexeddb/create-object-store-options.html storage/indexeddb/cursor-primary-key-order.html storage/indexeddb/cursor-delete.html storage/indexeddb/deleteIndex.html storage/indexeddb/deleteObjectStore-null-name.html storage/indexeddb/factory-basics.html storage/indexeddb/database-basics.html storage/indexeddb/cursor-update.html storage/indexeddb/error-causes-abort-by-default.html http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=storage%2Findexeddb%2FcreateObjectStore-null-name.html%2Cstorage%2Findexeddb%2Fcursor-index-delete.html%2Cstorage%2Findexeddb%2Fcursor-skip-deleted.html%2Cstorage%2Findexeddb%2Fcreate-object-store-options.html%2Cstorage%2Findexeddb%2Fcursor-primary-key-order.html%2Cstorage%2Findexeddb%2Fcursor-delete.html%2Cstorage%2Findexeddb%2FdeleteIndex.html%2Cstorage%2Findexeddb%2FdeleteObjectStore-null-name.html%2Cstorage%2Findexeddb%2Ffactory-basics.html%2Cstorage%2Findexeddb%2Fdatabase-basics.html%2Cstorage%2Findexeddb%2Fcursor-update.html%2Cstorage%2Findexeddb%2Ferror-causes-abort-by-default.html storage/indexeddb/mozilla/cursors.html storage/indexeddb/mozilla/autoincrement-indexes.html storage/indexeddb/mozilla/cursor-mutation.html storage/indexeddb/mozilla/key-requirements-inline-and-passed.html storage/indexeddb/mozilla/object-cursors.html storage/indexeddb/mozilla/create-index-with-integer-keys.html storage/indexeddb/mozilla/event-source.html storage/indexeddb/mozilla/key-requirements-put-null-key.html storage/indexeddb/mozilla/indexes.html storage/indexeddb/mozilla/create-objectstore-null-name.html storage/indexeddb/mozilla/clear.html http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=storage%2Findexeddb%2Fmozilla%2Fcursors.html%2Cstorage%2Findexeddb%2Fmozilla%2Fautoincrement-indexes.html%2Cstorage%2Findexeddb%2Fmozilla%2Fcursor-mutation.html%2Cstorage%2Findexeddb%2Fmozilla%2Fkey-requirements-inline-and-passed.html%2Cstorage%2Findexeddb%2Fmozilla%2Fobject-cursors.html%2Cstorage%2Findexeddb%2Fmozilla%2Fcreate-index-with-integer-keys.html%2Cstorage%2Findexeddb%2Fmozilla%2Fevent-source.html%2Cstorage%2Findexeddb%2Fmozilla%2Fkey-requirements-put-null-key.html%2Cstorage%2Findexeddb%2Fmozilla%2Findexes.html%2Cstorage%2Findexeddb%2Fmozilla%2Fcreate-objectstore-null-name.html%2Cstorage%2Findexeddb%2Fmozilla%2Fclear.html http/tests/inspector/indexeddb/database-structure.html http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=http%2Ftests%2Finspector%2Findexeddb%2Fdatabase-structure.html 549989 1 125642 allan.jensen 2012-02-06 07:34:21 -0800 Created attachment 125642 Patch Catch one more derived class of ActiveDOMObject. 549996 2 125642 hausmann 2012-02-06 07:46:39 -0800 Comment on attachment 125642 Patch Seems like the same pattern as in http://trac.webkit.org/changeset/106797 . rs=me 550005 3 125642 tonyg 2012-02-06 08:06:09 -0800 Comment on attachment 125642 Patch Clearing flags on attachment: 125642 Committed r106806: <http://trac.webkit.org/changeset/106806> 550006 4 tonyg 2012-02-06 08:06:15 -0800 All reviewed patches have been landed. Closing bug. 550007 5 tonyg 2012-02-06 08:08:03 -0800 After getting Allan's permission on #webkit, I used webkit-patch land-attachment to green things up without waiting for the cq. 550106 6 jchaffraix 2012-02-06 10:59:04 -0800 I am seeing the same ASSERT triggering in webaudio. There seem to be another instance of ActiveDOMObject there too. Is it possible that we are missing the same fix there? 550138 7 allan.jensen 2012-02-06 11:38:11 -0800 (In reply to comment #6) > I am seeing the same ASSERT triggering in webaudio. There seem to be another instance of ActiveDOMObject there too. Is it possible that we are missing the same fix there? It is possible. I have checked all classes directly derived from ActiveDOMObject, and all classes indirectly derived from ActiveDOMObject used by Qt. But I might have missed a classes indirectly inheriting from ActiveDOMObject in modules not used by Qt. If this is the case, it can be fixed by calling suspendIfNeeded() in the create class. 125642 2012-02-06 07:34:21 -0800 2012-02-06 08:06:09 -0800 Patch Patch text/plain 1589 allan.jensen ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkNWI2YWJlLi5mMDRjMTE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcg QEAKIDIwMTItMDItMDYgIEFsbGFuIFNhbmRmZWxkIEplbnNlbiAgPGFsbGFuLmplbnNlbkBub2tp YS5jb20+CiAKKyAgICAgICAgTGF5b3V0VGVzdCBmYWlsdXJlcyBvbiByMTA2Nzk3CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03Nzg2OAorCisgICAgICAg IENhbGwgc3VzcGVuZElmTmVlZGVkIGZyb20gc3ViY2xhc3Mgb2YgSURCUmVxdWVzdCwgSURCVmVy c2lvbkNoYW5nZVJlcXVlc3QuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBzdG9yYWdlL0lEQlZlcnNpb25DaGFuZ2VSZXF1ZXN0LmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OklEQlZlcnNpb25DaGFuZ2VSZXF1ZXN0OjpjcmVhdGUpOgorCisyMDEyLTAy LTA2ICBBbGxhbiBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5Abm9raWEuY29tPgorCiAg ICAgICAgIFdlYkdlc3R1cmVFdmVudCBjYW4gbm90IGVuY29kZSBkZWx0YSBhbmQgYXJlYS4KICAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc3NzI4CiAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N0b3JhZ2UvSURCVmVyc2lvbkNoYW5nZVJlcXVlc3Qu Y3BwIGIvU291cmNlL1dlYkNvcmUvc3RvcmFnZS9JREJWZXJzaW9uQ2hhbmdlUmVxdWVzdC5jcHAK aW5kZXggMDgxZDI0Yy4uZjEzY2E5ZDNjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9zdG9y YWdlL0lEQlZlcnNpb25DaGFuZ2VSZXF1ZXN0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9zdG9y YWdlL0lEQlZlcnNpb25DaGFuZ2VSZXF1ZXN0LmNwcApAQCAtMzUsNyArMzUsMTAgQEAgbmFtZXNw YWNlIFdlYkNvcmUgewogCiBQYXNzUmVmUHRyPElEQlZlcnNpb25DaGFuZ2VSZXF1ZXN0PiBJREJW ZXJzaW9uQ2hhbmdlUmVxdWVzdDo6Y3JlYXRlKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqIGNvbnRl eHQsIFBhc3NSZWZQdHI8SURCQW55PiBzb3VyY2UsIGNvbnN0IFN0cmluZyYgdmVyc2lvbikKIHsK LSAgICByZXR1cm4gYWRvcHRSZWYobmV3IElEQlZlcnNpb25DaGFuZ2VSZXF1ZXN0KGNvbnRleHQs IHNvdXJjZSwgdmVyc2lvbikpOworICAgIFJlZlB0cjxJREJWZXJzaW9uQ2hhbmdlUmVxdWVzdD4g cmVxdWVzdChhZG9wdFJlZihuZXcgSURCVmVyc2lvbkNoYW5nZVJlcXVlc3QoY29udGV4dCwgc291 cmNlLCB2ZXJzaW9uKSkpOworICAgIHJlcXVlc3QtPnN1c3BlbmRJZk5lZWRlZCgpOworICAgIHJl dHVybiByZXF1ZXN0LnJlbGVhc2UoKTsKKwogfQogCiBJREJWZXJzaW9uQ2hhbmdlUmVxdWVzdDo6 SURCVmVyc2lvbkNoYW5nZVJlcXVlc3QoU2NyaXB0RXhlY3V0aW9uQ29udGV4dCogY29udGV4dCwg UGFzc1JlZlB0cjxJREJBbnk+IHNvdXJjZSwgY29uc3QgU3RyaW5nJiB2ZXJzaW9uKQo=