77866 2012-02-06 05:21:28 -0800 [webkitpy] cpp style-checker complains about readability/naming in GStreamer elements source files 2012-02-06 09:35:52 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned abarth levin ojan pnormand webkit.review.bot oldest_to_newest 549919 0 pnormand 2012-02-06 05:21:28 -0800 These files define GObjects, which implies some definitions of variables and functions containing underscores. 549923 1 125624 pnormand 2012-02-06 05:29:08 -0800 Created attachment 125624 Patch 549924 2 webkit.review.bot 2012-02-06 05:30:28 -0800 Attachment 125624 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy..." exit_code: 1 Tools/Scripts/webkitpy/style/checker.py:215: missing whitespace after ',' [pep8/E231] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 550049 3 125624 mrobinson 2012-02-06 09:10:02 -0800 Comment on attachment 125624 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125624&action=review >> Tools/Scripts/webkitpy/style/checker.py:215 >> + ["-readability/naming",]), > > missing whitespace after ',' [pep8/E231] [5] I think you can just remove the interior comma to make the style bot happy. 550066 4 pnormand 2012-02-06 09:35:52 -0800 Committed r106814: <http://trac.webkit.org/changeset/106814> 125624 2012-02-06 05:29:08 -0800 2012-02-06 09:10:01 -0800 Patch Patch.patch text/plain 2914 pnormand RnJvbSA2NmU2YzUwZTNkMWM2Zjg3ZjE0MmE4ZjljMjM0Y2QwZmYzZWZjYWQ5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBNb24sIDYgRmViIDIwMTIgMTQ6Mjc6MjAgKzAxMDAKU3ViamVjdDogW1BBVENIXSBQ YXRjaAoKLS0tCiBUb29scy9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgfCAgIDEyICsrKysrKysrKysrKwogVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVj a2VyLnB5ICAgICAgICAgIHwgICAgNyArKysrKysrCiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0 eWxlL2NoZWNrZXJfdW5pdHRlc3QucHkgfCAgICAzICsrKwogMyBmaWxlcyBjaGFuZ2VkLCAyMiBp bnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxv ZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAxY2QwODAzLi4zODY0ODA1IDEwMDY0NAotLS0gYS9U b29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIw MTItMDItMDYgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgorCisgICAg ICAgIFt3ZWJraXRweV0gY3BwIHN0eWxlLWNoZWNrZXIgY29tcGxhaW5zIGFib3V0IHJlYWRhYmls aXR5L25hbWluZyBpbiBHU3RyZWFtZXIgZWxlbWVudHMgc291cmNlIGZpbGVzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03Nzg2NgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9z dHlsZS9jaGVja2VyLnB5OiBJZ25vcmUgcmVhZGFiaWxpdHkvbmFtaW5nCisgICAgICAgIGVycm9y cyBpbiBzb21lIGdzdHJlYW1lciBzb3VyY2UgY29kZSBmaWxlcyBkZWZpbmluZyBuZXcgR1N0cmVh bWVyIGVsZW1lbnRzLgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcl91 bml0dGVzdC5weToKKyAgICAgICAgKEdsb2JhbFZhcmlhYmxlc1Rlc3QudGVzdF9wYXRoX3J1bGVz X3NwZWNpZmllcik6CisKIDIwMTItMDItMDEgIEphY29iIEdvbGRzdGVpbiAgPGphY29iZ0BhZG9i ZS5jb20+CiAKICAgICAgICAgV2Via2l0IGdlbmVyYXRlLWNvdmVyYWdlLWRhdGEgc2NyaXB0IG5l ZWRzIHVwZGF0ZSB0byB1c2UgbmV3IHRlc3Qgc2NyaXB0CmRpZmYgLS1naXQgYS9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXIucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0 eWxlL2NoZWNrZXIucHkKaW5kZXggMzQ0MDYwOS4uZTNjMzRmYiAxMDA2NDQKLS0tIGEvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2VyLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvc3R5bGUvY2hlY2tlci5weQpAQCAtMjA2LDYgKzIwNiwxMyBAQCBfUEFUSF9SVUxFU19T UEVDSUZJRVIgPSBbCiAgICAgIFsiLXJlYWRhYmlsaXR5L25hbWluZyIsCiAgICAgICAiLXJlYWRh YmlsaXR5L3BhcmFtZXRlcl9uYW1lIiwKICAgICAgICItd2hpdGVzcGFjZS9kZWNsYXJhdGlvbiJd KSwKKyAgICAoWyMgVGhlc2UgZmlsZXMgZGVmaW5lIEdPYmplY3RzLCB3aGljaCBpbXBsaWVzIHNv bWUgZGVmaW5pdGlvbnMgb2YKKyAgICAgICMgdmFyaWFibGVzIGFuZCBmdW5jdGlvbnMgY29udGFp bmluZyB1bmRlcnNjb3Jlcy4KKyAgICAgICJTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9nc3RyZWFtZXIvVmlkZW9TaW5rR1N0cmVhbWVyMS5jcHAiLAorICAgICAgIlNvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9WaWRlb1NpbmtHU3RyZWFtZXIuY3BwIiwK KyAgICAgICJTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvV2ViS2l0 V2ViU291cmNlR1N0cmVhbWVyLmNwcCIsCisgICAgICAiU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v YXVkaW8vZ3N0cmVhbWVyL1dlYktpdFdlYkF1ZGlvU291cmNlR1N0cmVhbWVyLmNwcCJdLAorICAg ICBbIi1yZWFkYWJpbGl0eS9uYW1pbmciLF0pLAogCiAgICAgIyBGb3IgdGhpcmQtcGFydHkgUHl0 aG9uIGNvZGUsIGtlZXAgb25seSB0aGUgZm9sbG93aW5nIGNoZWNrcy0tCiAgICAgIwpkaWZmIC0t Z2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2VyX3VuaXR0ZXN0LnB5IGIv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2VyX3VuaXR0ZXN0LnB5CmluZGV4IDQ4 YmIxOTUuLjQ5YmFhZGEgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUv Y2hlY2tlcl91bml0dGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2No ZWNrZXJfdW5pdHRlc3QucHkKQEAgLTI1Myw2ICsyNTMsOSBAQCBjbGFzcyBHbG9iYWxWYXJpYWJs ZXNUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICAgICAgYXNzZXJ0Tm9DaGVjaygiU291cmNl L1dlYkNvcmUvRm9yd2FyZGluZ0hlYWRlcnMvZGVidWdnZXIvRGVidWdnZXIuaCIsCiAgICAgICAg ICAgICAgICAgICAgICAgImJ1aWxkL2hlYWRlcl9ndWFyZCIpCiAKKyAgICAgICAgYXNzZXJ0Tm9D aGVjaygiU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1ZpZGVvU2lu a0dTdHJlYW1lci5jcHAiLAorICAgICAgICAgICAgICAgICAgICAgICJyZWFkYWJpbGl0eS9uYW1p bmciKQorCiAgICAgICAgICMgVGhpcmQtcGFydHkgUHl0aG9uIGNvZGU6IHdlYmtpdHB5L3RoaXJk cGFydHkKICAgICAgICAgcGF0aCA9ICJUb29scy9TY3JpcHRzL3dlYmtpdHB5L3RoaXJkcGFydHkv bW9jay5weSIKICAgICAgICAgYXNzZXJ0Tm9DaGVjayhwYXRoLCAiYnVpbGQvaW5jbHVkZSIpCi0t IAoxLjcuOQ==