77839 2012-02-05 16:09:46 -0800 Web Inspector: Fix CallArgument type in Inspector.json 2012-02-06 01:28:08 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 prybin webkit-unassigned apavlov bweinstein joepeck keishi loislo pfeldman pmuellr prybin rik timothy webkit.review.bot yurys oldest_to_newest 549626 0 prybin 2012-02-05 16:09:46 -0800 Currently CallArgument has the following field: { "name": "objectId", "$ref": "RemoteObject", "optional": true, "description": "Remote object handle." } The field name doesn't conform to field value type. Field type should be fixed to a correct "RemoteObjectId" which has always been expected in the InjectedScriptSource.js implementation. See also https://bugs.webkit.org/show_bug.cgi?id=74110 549627 1 prybin 2012-02-05 16:15:21 -0800 Inspector.json should be fixed. Inspector-0.1.json and Inspector-1.0.json should also be retroactively fixed. 549628 2 125540 prybin 2012-02-05 16:19:12 -0800 Created attachment 125540 Patch 549829 3 125540 webkit.review.bot 2012-02-06 01:28:03 -0800 Comment on attachment 125540 Patch Clearing flags on attachment: 125540 Committed r106787: <http://trac.webkit.org/changeset/106787> 549830 4 webkit.review.bot 2012-02-06 01:28:08 -0800 All reviewed patches have been landed. Closing bug. 125540 2012-02-05 16:19:12 -0800 2012-02-06 01:28:03 -0800 Patch bug-77839-20120206041910.patch text/plain 3717 prybin U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2NDcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmM3ZmUyOGU3NDY0ZWZi ODc0NzMzZDhjZGNlMDJiNzhiZjlhZTkxYi4uMDQ2YzhhMjk3MThkZTAwYTc1ODdjMmNkMmMwMmZm ZWQ1N2JjYjI5MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTAyLTA1ICBQZXRl ciBSeWJpbiAgPHBldGVyLnJ5YmluQGdtYWlsLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBGaXggQ2FsbEFyZ3VtZW50IHR5cGUgaW4gSW5zcGVjdG9yLmpzb24KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc3ODM5CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUHJvdG9jb2wgZGVzY3JpcHRpb24gaXMg Zml4ZWQ6IGZpZWxkIHR5cGUgaXMgY2hhbmdlZC4gTm8gY2hhbmdlcyB0bworICAgICAgICBwcm9n cmFtIGNvZGUgYXJlIG5lY2Vzc2FyeS4KKworICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3It MC4xLmpzb246CisgICAgICAgICogaW5zcGVjdG9yL0luc3BlY3Rvci0xLjAuanNvbjoKKyAgICAg ICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yLmpzb246CisKIDIwMTItMDItMDEgIE1hcmlvIFNhbmNo ZXogUHJhZGEgIDxtc2FuY2hlekBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIGVkaXRpbmcv aW5zZXJ0aW5nLzQ5NjAxMjAtMi5odG1sIGZsYWt5IGNyYXNoCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yLTAuMS5qc29uIGIvU291cmNlL1dlYkNvcmUvaW5z cGVjdG9yL0luc3BlY3Rvci0wLjEuanNvbgppbmRleCAwNGEwZjgxNWQxZTYzNzAzY2NkMTQwN2M2 N2MyZTI0ODM4NWFjZjAzLi4wMDg2ZDlhNThlZjE1ZWM5MDlmNDY2ODI1ZGNjZDhmNDQ0YTAzMjcw IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yLTAuMS5qc29u CisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3ItMC4xLmpzb24KQEAgLTI3 OSw3ICsyNzksNyBAQAogICAgICAgICAgICAgICAgICJkZXNjcmlwdGlvbiI6ICJSZXByZXNlbnRz IGZ1bmN0aW9uIGNhbGwgYXJndW1lbnQuIEVpdGhlciByZW1vdGUgb2JqZWN0IGlkIDxjb2RlPm9i amVjdElkPC9jb2RlPiBvciBwcmltaXRpdmUgPGNvZGU+dmFsdWU8L2NvZGU+IG9yIG5laXRoZXIg b2YgKGZvciB1bmRlZmluZWQpIHRoZW0gc2hvdWxkIGJlIHNwZWNpZmllZC4iLAogICAgICAgICAg ICAgICAgICJwcm9wZXJ0aWVzIjogWwogICAgICAgICAgICAgICAgICAgICB7ICJuYW1lIjogInZh bHVlIiwgInR5cGUiOiAiYW55IiwgIm9wdGlvbmFsIjogdHJ1ZSwgImRlc2NyaXB0aW9uIjogIlBy aW1pdGl2ZSB2YWx1ZS4iIH0sCi0gICAgICAgICAgICAgICAgICAgIHsgIm5hbWUiOiAib2JqZWN0 SWQiLCAiJHJlZiI6ICJSZW1vdGVPYmplY3QiLCAib3B0aW9uYWwiOiB0cnVlLCAiZGVzY3JpcHRp b24iOiAiUmVtb3RlIG9iamVjdCBoYW5kbGUuIiB9CisgICAgICAgICAgICAgICAgICAgIHsgIm5h bWUiOiAib2JqZWN0SWQiLCAiJHJlZiI6ICJSZW1vdGVPYmplY3RJZCIsICJvcHRpb25hbCI6IHRy dWUsICJkZXNjcmlwdGlvbiI6ICJSZW1vdGUgb2JqZWN0IGhhbmRsZS4iIH0KICAgICAgICAgICAg ICAgICBdCiAgICAgICAgICAgICB9CiAgICAgICAgIF0sCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yLTEuMC5qc29uIGIvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL0luc3BlY3Rvci0xLjAuanNvbgppbmRleCAzMzkxMmI4ZGUzMjEyMjEyNzU4MmNhZGE3M2U1 M2JjODhhYTYyMjIzLi4xZDNjYmRjMDIwYjA0ZWIzZTFlNDg0YWIyMWQ2ZWYwMmE3NmI5NjJmIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yLTEuMC5qc29uCisr KyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3ItMS4wLmpzb24KQEAgLTM5MCw3 ICszOTAsNyBAQAogICAgICAgICAgICAgICAgICJkZXNjcmlwdGlvbiI6ICJSZXByZXNlbnRzIGZ1 bmN0aW9uIGNhbGwgYXJndW1lbnQuIEVpdGhlciByZW1vdGUgb2JqZWN0IGlkIDxjb2RlPm9iamVj dElkPC9jb2RlPiBvciBwcmltaXRpdmUgPGNvZGU+dmFsdWU8L2NvZGU+IG9yIG5laXRoZXIgb2Yg KGZvciB1bmRlZmluZWQpIHRoZW0gc2hvdWxkIGJlIHNwZWNpZmllZC4iLAogICAgICAgICAgICAg ICAgICJwcm9wZXJ0aWVzIjogWwogICAgICAgICAgICAgICAgICAgICB7ICJuYW1lIjogInZhbHVl IiwgInR5cGUiOiAiYW55IiwgIm9wdGlvbmFsIjogdHJ1ZSwgImRlc2NyaXB0aW9uIjogIlByaW1p dGl2ZSB2YWx1ZS4iIH0sCi0gICAgICAgICAgICAgICAgICAgIHsgIm5hbWUiOiAib2JqZWN0SWQi LCAiJHJlZiI6ICJSZW1vdGVPYmplY3QiLCAib3B0aW9uYWwiOiB0cnVlLCAiZGVzY3JpcHRpb24i OiAiUmVtb3RlIG9iamVjdCBoYW5kbGUuIiB9CisgICAgICAgICAgICAgICAgICAgIHsgIm5hbWUi OiAib2JqZWN0SWQiLCAiJHJlZiI6ICJSZW1vdGVPYmplY3RJZCIsICJvcHRpb25hbCI6IHRydWUs ICJkZXNjcmlwdGlvbiI6ICJSZW1vdGUgb2JqZWN0IGhhbmRsZS4iIH0KICAgICAgICAgICAgICAg ICBdCiAgICAgICAgICAgICB9CiAgICAgICAgIF0sCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9pbnNwZWN0b3IvSW5zcGVjdG9yLmpzb24gYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5z cGVjdG9yLmpzb24KaW5kZXggZThkYTAzOGE3NGQyOWY5NDk1NzE4NGRmYmZlMjVkNWU2OGFkNGVk NS4uN2YwZGM0NGQwY2IxNjQ5OWE4NThkYjJlNDEwMjE4YmIyNzBlY2Y2NiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3Rvci5qc29uCisrKyBiL1NvdXJjZS9XZWJD b3JlL2luc3BlY3Rvci9JbnNwZWN0b3IuanNvbgpAQCAtMzkxLDcgKzM5MSw3IEBACiAgICAgICAg ICAgICAgICAgImRlc2NyaXB0aW9uIjogIlJlcHJlc2VudHMgZnVuY3Rpb24gY2FsbCBhcmd1bWVu dC4gRWl0aGVyIHJlbW90ZSBvYmplY3QgaWQgPGNvZGU+b2JqZWN0SWQ8L2NvZGU+IG9yIHByaW1p dGl2ZSA8Y29kZT52YWx1ZTwvY29kZT4gb3IgbmVpdGhlciBvZiAoZm9yIHVuZGVmaW5lZCkgdGhl bSBzaG91bGQgYmUgc3BlY2lmaWVkLiIsCiAgICAgICAgICAgICAgICAgInByb3BlcnRpZXMiOiBb CiAgICAgICAgICAgICAgICAgICAgIHsgIm5hbWUiOiAidmFsdWUiLCAidHlwZSI6ICJhbnkiLCAi b3B0aW9uYWwiOiB0cnVlLCAiZGVzY3JpcHRpb24iOiAiUHJpbWl0aXZlIHZhbHVlLiIgfSwKLSAg ICAgICAgICAgICAgICAgICAgeyAibmFtZSI6ICJvYmplY3RJZCIsICIkcmVmIjogIlJlbW90ZU9i amVjdCIsICJvcHRpb25hbCI6IHRydWUsICJkZXNjcmlwdGlvbiI6ICJSZW1vdGUgb2JqZWN0IGhh bmRsZS4iIH0KKyAgICAgICAgICAgICAgICAgICAgeyAibmFtZSI6ICJvYmplY3RJZCIsICIkcmVm IjogIlJlbW90ZU9iamVjdElkIiwgIm9wdGlvbmFsIjogdHJ1ZSwgImRlc2NyaXB0aW9uIjogIlJl bW90ZSBvYmplY3QgaGFuZGxlLiIgfQogICAgICAgICAgICAgICAgIF0KICAgICAgICAgICAgIH0K ICAgICAgICAgXSwK