77832 2012-02-05 04:37:39 -0800 [Gtk] compilation error in WebCore/platform/graphics/pango/FontPlatformData.h 2012-02-06 13:59:27 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 tuxator webkit-unassigned kalevlember webkit.review.bot oldest_to_newest 549578 0 tuxator 2012-02-05 04:37:39 -0800 When trying to cross compile WebkitGtk for windows with build options being: --with-target=win32 --with-gtk=2.0 --with-font-backend=pango --with-unicode-backend=icu i get compilation error in --with-target=win32 --with-gtk=2.0 --with-font-backend=pango --with-unicode-backend=icu ./Source/WebCore/platform/graphics/pango/FontPlatformData.h:32:30: fatal error: pango/pangocairo.h: No such file or directory 549579 1 tuxator 2012-02-05 04:42:22 -0800 Last lines printed by make CXX Source/WebCore/accessibility/libWebCore_la-AccessibilityARIAGridCell.lo CXX Source/WebCore/accessibility/libWebCore_la-AccessibilityARIAGrid.lo In file included from /usr/i686-w64-mingw32/sys-root/mingw/include/libsoup-2.4/libsoup/soup-portability.h:13:0, from /usr/i686-w64-mingw32/sys-root/mingw/include/libsoup-2.4/libsoup/soup-address.h:11, from /usr/i686-w64-mingw32/sys-root/mingw/include/libsoup-2.4/libsoup/soup.h:13, from ./Source/WebCore/platform/network/soup/ResourceResponse.h:31, from ./Source/WebCore/platform/network/AuthenticationChallengeBase.h:30, from ./Source/WebCore/platform/network/soup/AuthenticationChallenge.h:28, from ./Source/WebCore/platform/network/ResourceHandle.h:29, from ./Source/WebCore/loader/ResourceLoaderOptions.h:34, from ./Source/WebCore/loader/cache/CachedResource.h:30, from ./Source/WebCore/loader/cache/CachedImage.h:26, from ./Source/WebCore/rendering/RenderObject.h:29, from Source/WebCore/accessibility/AccessibilityARIAGrid.cpp:37: /usr/i686-w64-mingw32/sys-root/mingw/include/winsock2.h:15:2: warning: #warning Please include winsock2.h before windows.h [-Wcpp] In file included from ./Source/WebCore/platform/graphics/FontPlatformData.h:37:0, from ./Source/WebCore/platform/graphics/SimpleFontData.h:30, from ./Source/WebCore/platform/graphics/FontFallbackList.h:25, from ./Source/WebCore/platform/graphics/Font.h:29, from ./Source/WebCore/rendering/style/RenderStyle.h:38, from ./Source/WebCore/rendering/RenderObject.h:36, from Source/WebCore/accessibility/AccessibilityARIAGrid.cpp:37: ./Source/WebCore/platform/graphics/pango/FontPlatformData.h:32:30: fatal error: pango/pangocairo.h: No such file or directory compilation terminated. make[1]: *** [Source/WebCore/accessibility/libWebCore_la-AccessibilityARIAGrid.lo] Error 1 make[1]: Leaving directory `/home/pawel/src/WebKit' make: *** [all] Error 2 549580 2 125525 kalevlember 2012-02-05 04:50:05 -0800 Created attachment 125525 Patch to add missing $(PANGO_CFLAGS) to relevant places 549591 3 tuxator 2012-02-05 08:52:12 -0800 I can confirm that patch attached above fixes this issue. 550261 4 125525 webkit.review.bot 2012-02-06 13:59:23 -0800 Comment on attachment 125525 Patch to add missing $(PANGO_CFLAGS) to relevant places Clearing flags on attachment: 125525 Committed r106847: <http://trac.webkit.org/changeset/106847> 550262 5 webkit.review.bot 2012-02-06 13:59:27 -0800 All reviewed patches have been landed. Closing bug. 125525 2012-02-05 04:50:05 -0800 2012-02-06 13:59:23 -0800 Patch to add missing $(PANGO_CFLAGS) to relevant places 0001-Add-missing-pango-include-dir-to-fix-build.patch text/plain 2359 kalevlember RnJvbSAxOWZjOGY2NmJmOTNmN2RhZmU5NjM5MDJiZDEwMjBiZmJiZDNlYTg3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLYWxldiBMZW1iZXIgPGthbGV2bGVtYmVyQGdtYWlsLmNvbT4K RGF0ZTogU3VuLCA1IEZlYiAyMDEyIDE0OjQ4OjIxICswMjAwClN1YmplY3Q6IFtQQVRDSF0gQWRk IG1pc3NpbmcgcGFuZ28gaW5jbHVkZSBkaXIgdG8gZml4IGJ1aWxkCgotLS0KIFNvdXJjZS9XZWJD b3JlL0NoYW5nZUxvZyAgICAgIHwgICAgOSArKysrKysrKysKIFNvdXJjZS9XZWJDb3JlL0dOVW1h a2VmaWxlLmFtIHwgICAgMSArCiBUb29scy9DaGFuZ2VMb2cgICAgICAgICAgICAgICB8ICAgIDkg KysrKysrKysrCiBUb29scy9HTlVtYWtlZmlsZS5hbSAgICAgICAgICB8ICAgIDEgKwogNCBmaWxl cyBjaGFuZ2VkLCAyMCBpbnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRl eCBhMjA1Yzk2Li5jZDMwM2UxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTItMDIt MDUgIEthbGV2IExlbWJlciAgPGthbGV2bGVtYmVyQGdtYWlsLmNvbT4KKworICAgICAgICBbR1RL XSBBZGQgbWlzc2luZyBwYW5nbyBpbmNsdWRlIGRpciB0byBmaXggYnVpbGQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc3ODMyCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBHTlVtYWtlZmlsZS5hbTogQWRk ZWQgJChQQU5HT19DRkxBR1MpIHRvIGxpYldlYkNvcmVfbGFfQ1BQRkxBR1MuCisKIDIwMTItMDIt MDQgIEFuZHJlYXMgS2xpbmcgIDxhd2Vzb21la2xpbmdAYXBwbGUuY29tPgogCiAgICAgICAgIEVs ZW1lbnQ6IFJlbW92ZSB1bm5lY2Vzc2FyeSBhdHRyaWJ1dGVDaGFuZ2VkKCkgYXJndW1lbnQuCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9HTlVtYWtlZmlsZS5hbSBiL1NvdXJjZS9XZWJDb3Jl L0dOVW1ha2VmaWxlLmFtCmluZGV4IGVmZGVmNjkuLjA1NDg1NWUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0dOVW1ha2VmaWxlLmFtCisrKyBiL1NvdXJjZS9XZWJDb3JlL0dOVW1ha2VmaWxl LmFtCkBAIC04MzUsNiArODM1LDcgQEAgbGliV2ViQ29yZV9sYV9DUFBGTEFHUyA9IFwKIAkkKExJ QlNPVVBfQ0ZMQUdTKSBcCiAJJChMSUJYTUxfQ0ZMQUdTKSBcCiAJJChMSUJYU0xUX0NGTEFHUykg XAorCSQoUEFOR09fQ0ZMQUdTKSBcCiAJJChTUUxJVEUzX0NGTEFHUykgXAogCSQoVU5JQ09ERV9D RkxBR1MpIFwKIAkkKFhSRU5ERVJfQ0ZMQUdTKSBcCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VM b2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTlkMWI4NS4uMTU3NWIwYiAxMDA2NDQKLS0tIGEv VG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisy MDEyLTAyLTA1ICBLYWxldiBMZW1iZXIgIDxrYWxldmxlbWJlckBnbWFpbC5jb20+CisKKyAgICAg ICAgW0dUS10gQWRkIG1pc3NpbmcgcGFuZ28gaW5jbHVkZSBkaXIgdG8gZml4IGJ1aWxkCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NzgzMgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogR05VbWFrZWZpbGUu YW06IEFkZGVkICQoUEFOR09fQ0ZMQUdTKSB0byBsaWJXZWJDb3JlSW50ZXJuYWxzX2xhX0NQUEZM QUdTLgorCiAyMDEyLTAyLTA0ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgZ2FyZGVuLW8tbWF0aWMncyBBbGwgRmFpbHVyZSB0YWIgc2hvdWxkIGxldCB5b3UgZXhh bWluZSBhbmQgcmViYXNlbGluZSBleHBlY3RlZCBmYWlsdXJlcwpkaWZmIC0tZ2l0IGEvVG9vbHMv R05VbWFrZWZpbGUuYW0gYi9Ub29scy9HTlVtYWtlZmlsZS5hbQppbmRleCA2ODdiMmI3Li4wMDVm MzU3IDEwMDY0NAotLS0gYS9Ub29scy9HTlVtYWtlZmlsZS5hbQorKysgYi9Ub29scy9HTlVtYWtl ZmlsZS5hbQpAQCAtNjQsNiArNjQsNyBAQCBsaWJXZWJDb3JlSW50ZXJuYWxzX2xhX0NQUEZMQUdT ID0gXAogCSQoamF2YXNjcmlwdGNvcmVfY3BwZmxhZ3MpIFwKIAkkKENBSVJPX0NGTEFHUykgXAog CSQoTElCU09VUF9DRkxBR1MpIFwKKwkkKFBBTkdPX0NGTEFHUykgXAogCS1JJCh0b3BfYnVpbGRk aXIpL0Rlcml2ZWRTb3VyY2VzIFwKIAktSSQodG9wX2J1aWxkZGlyKS9EZXJpdmVkU291cmNlcy9X ZWJDb3JlCiAKLS0gCjEuNy43LjYKCg==