77816 2012-02-04 15:53:21 -0800 WKPreferences instances cannot be copied 2012-02-06 20:48:30 -0800 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mitz mitz andersca darin mrowe rniwa oldest_to_newest 549487 0 mitz 2012-02-04 15:53:21 -0800 WKPreferences instances cannot be copied 549488 1 mitz 2012-02-04 15:59:40 -0800 <rdar://problem/10772406> 549489 2 125504 mitz 2012-02-04 16:11:58 -0800 Created attachment 125504 Add WKPreferencesCreateCopy() 549490 3 mitz 2012-02-04 16:18:46 -0800 Fixed in <http://trac.webkit.org/r106749>. 550134 4 rniwa 2012-02-06 11:31:55 -0800 In GCC, I'm getting the following compilation error: cc1plus: warnings being treated as errors /Volumes/Data/webkit4/Source/WebKit2/UIProcess/WebPreferences.cpp: In copy constructor 'WebKit::WebPreferences::WebPreferences(const WebKit::WebPreferences&)': /Volumes/Data/webkit4/Source/WebKit2/UIProcess/WebPreferences.cpp:44: warning: base class 'class WebKit::APIObject' should be explicitly initialized in the copy constructor PhaseScriptExecution "Check For Framework Include Consistency" /Volumes/Data/webkit4/WebKitBuild/WebKit2.build/Debug/WebKit2.build/Script-5DF408C6131DD49700130071.sh cd /Volumes/Data/webkit4/Source/WebKit2 550136 5 rniwa 2012-02-06 11:37:35 -0800 "Fixed" in http://trac.webkit.org/changeset/106824. 550143 6 rniwa 2012-02-06 11:40:28 -0800 I'm not happy about using the default constructor of APIObject but I couldn't figure out a good way to fix it properly without being invasive here. Maybe andersca, bdash, or darin would know? 550376 7 darin 2012-02-06 15:57:03 -0800 I think your fix was correct. 550590 8 rniwa 2012-02-06 20:48:30 -0800 (In reply to comment #7) > I think your fix was correct. That is good to hear. 125504 2012-02-04 16:11:58 -0800 2012-02-04 16:14:58 -0800 Add WKPreferencesCreateCopy() bug-77816-20120204161154.patch text/plain 5652 mitz SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwNjc0OCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDEyLTAyLTA0ICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzEwNzcy NDA2PiBXS1ByZWZlcmVuY2VzIGluc3RhbmNlcyBjYW5ub3QgYmUgY29waWVkCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NzgxNgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3QgYWRkZWQgaW4gVGVzdFdl YktpdEFQSS9UZXN0cy9XZWJLaXQyL1dLUHJlZmVyZW5jZXMuY3BwLgorCisgICAgICAgICogVUlQ cm9jZXNzL0FQSS9DL1dLUHJlZmVyZW5jZXMuY3BwOgorICAgICAgICAoV0tQcmVmZXJlbmNlc0Ny ZWF0ZUNvcHkpOiBBZGRlZC4KKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0MvV0tQcmVmZXJlbmNl c1ByaXZhdGUuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUHJlZmVyZW5jZXMuY3BwOgorICAg ICAgICAoV2ViS2l0OjpXZWJQcmVmZXJlbmNlczo6V2ViUHJlZmVyZW5jZXMpOiBBZGRlZCB0aGlz IGNvbnN0cnVjdG9yIHRoYXQgY29waWVzIHRoZQorICAgICAgICBXZWJQcmVmZXJlbmNlc1N0b3Jl IG9mIHRoZSBnaXZlbiBXZWJQcmVmZXJlbmNlcy4KKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUHJl ZmVyZW5jZXMuaDoKKyAgICAgICAgKFdlYktpdDo6V2ViUHJlZmVyZW5jZXM6OmNyZWF0ZSk6IEFk ZGVkIHRoaXMgY3JlYXRlIGZ1bmN0aW9uIHRoYXQgdGFrZXMgYSBXZWJQcmVmZXJlbmNlcworICAg ICAgICBpbnN0YW5jZSBhbmQgY3JlYXRlcyBhIG5ldyBpbnN0YW5jZSB3aXRoIGEgY29weSBvZiB0 aGUgZ2l2ZW4gaW5zdGFuY2XigJlzIHN0b3JlLgorCiAyMDEyLTAyLTAzICBBbmRlcnMgQ2FybHNz b24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgV2ViS2l0MiBzaG91bGQgZGlzcGF0 Y2ggd2hlZWwgZXZlbnRzIHRvIHRoZSBuZXcgU2Nyb2xsaW5nVHJlZSBjbGFzcwpJbmRleDogU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlByZWZlcmVuY2VzLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUHJlZmVyZW5jZXMuY3BwCShyZXZpc2lvbiAxMDY3 NDApCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUHJlZmVyZW5jZXMuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC00MSw2ICs0MSwxMiBAQCBXZWJQcmVmZXJlbmNlczo6V2ViUHJlZmVyZW5j ZXMoY29uc3QgU3RyCiAgICAgcGxhdGZvcm1Jbml0aWFsaXplU3RvcmUoKTsKIH0KIAorV2ViUHJl ZmVyZW5jZXM6OldlYlByZWZlcmVuY2VzKGNvbnN0IFdlYlByZWZlcmVuY2VzJiBvdGhlcikKKyAg ICA6IG1fc3RvcmUob3RoZXIubV9zdG9yZSkKK3sKKyAgICBwbGF0Zm9ybUluaXRpYWxpemVTdG9y ZSgpOworfQorCiBXZWJQcmVmZXJlbmNlczo6fldlYlByZWZlcmVuY2VzKCkKIHsKIH0KSW5kZXg6 IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQcmVmZXJlbmNlcy5oCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQcmVmZXJlbmNlcy5oCShyZXZpc2lvbiAxMDY3 NDApCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUHJlZmVyZW5jZXMuaAkod29ya2lu ZyBjb3B5KQpAQCAtNTQsNiArNTQsMTEgQEAgcHVibGljOgogICAgICAgICByZXR1cm4gYWRvcHRS ZWYobmV3IFdlYlByZWZlcmVuY2VzKGlkZW50aWZpZXIpKTsKICAgICB9CiAKKyAgICBzdGF0aWMg UGFzc1JlZlB0cjxXZWJQcmVmZXJlbmNlcz4gY3JlYXRlKGNvbnN0IFdlYlByZWZlcmVuY2VzJiBv dGhlcikKKyAgICB7CisgICAgICAgIHJldHVybiBhZG9wdFJlZihuZXcgV2ViUHJlZmVyZW5jZXMo b3RoZXIpKTsKKyAgICB9CisKICAgICB2aXJ0dWFsIH5XZWJQcmVmZXJlbmNlcygpOwogCiAgICAg dm9pZCBhZGRQYWdlR3JvdXAoV2ViUGFnZUdyb3VwKik7CkBAIC03NSw2ICs4MCw3IEBAIHB1Ymxp YzoKIHByaXZhdGU6CiAgICAgV2ViUHJlZmVyZW5jZXMoKTsKICAgICBXZWJQcmVmZXJlbmNlcyhj b25zdCBTdHJpbmcmIGlkZW50aWZpZXIpOworICAgIFdlYlByZWZlcmVuY2VzKGNvbnN0IFdlYlBy ZWZlcmVuY2VzJik7CiAKICAgICB2b2lkIHBsYXRmb3JtSW5pdGlhbGl6ZVN0b3JlKCk7CiAKSW5k ZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS1ByZWZlcmVuY2VzLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tQcmVmZXJlbmNlcy5j cHAJKHJldmlzaW9uIDEwNjc0MCkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9X S1ByZWZlcmVuY2VzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTIsNiArNTIsMTIgQEAgV0tQcmVm ZXJlbmNlc1JlZiBXS1ByZWZlcmVuY2VzQ3JlYXRlV2l0aAogICAgIHJldHVybiB0b0FQSShwcmVm ZXJlbmNlcy5yZWxlYXNlKCkubGVha1JlZigpKTsKIH0KIAorV0tQcmVmZXJlbmNlc1JlZiBXS1By ZWZlcmVuY2VzQ3JlYXRlQ29weShXS1ByZWZlcmVuY2VzUmVmIHByZWZlcmVuY2VzUmVmKQorewor ICAgIFJlZlB0cjxXZWJQcmVmZXJlbmNlcz4gcHJlZmVyZW5jZXMgPSBXZWJQcmVmZXJlbmNlczo6 Y3JlYXRlKCp0b0ltcGwocHJlZmVyZW5jZXNSZWYpKTsKKyAgICByZXR1cm4gdG9BUEkocHJlZmVy ZW5jZXMucmVsZWFzZSgpLmxlYWtSZWYoKSk7Cit9CisKIHZvaWQgV0tQcmVmZXJlbmNlc1NldEph dmFTY3JpcHRFbmFibGVkKFdLUHJlZmVyZW5jZXNSZWYgcHJlZmVyZW5jZXNSZWYsIGJvb2wgamF2 YVNjcmlwdEVuYWJsZWQpCiB7CiAgICAgdG9JbXBsKHByZWZlcmVuY2VzUmVmKS0+c2V0SmF2YVNj cmlwdEVuYWJsZWQoamF2YVNjcmlwdEVuYWJsZWQpOwpJbmRleDogU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9DL1dLUHJlZmVyZW5jZXNQcml2YXRlLmgKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLUHJlZmVyZW5jZXNQcml2YXRlLmgJKHJldmlzaW9u IDEwNjc0MCkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS1ByZWZlcmVuY2Vz UHJpdmF0ZS5oCSh3b3JraW5nIGNvcHkpCkBAIC01Miw2ICs1Miw5IEBAIGVudW0gV0tFZGl0YWJs ZUxpbmtCZWhhdmlvciB7CiB9OwogdHlwZWRlZiBlbnVtIFdLRWRpdGFibGVMaW5rQmVoYXZpb3Ig V0tFZGl0YWJsZUxpbmtCZWhhdmlvcjsKIAorLy8gQ3JlYXRlcyBhIGNvcHkgd2l0aCBubyBpZGVu dGlmaWVyLgorV0tfRVhQT1JUIFdLUHJlZmVyZW5jZXNSZWYgV0tQcmVmZXJlbmNlc0NyZWF0ZUNv cHkoV0tQcmVmZXJlbmNlc1JlZik7CisKIC8vIERlZmF1bHRzIHRvIGtXS0ZvbnRTbW9vdGhpbmdM ZXZlbFdpbmRvd3Mgb24gV2luZG93cywga1dLRm9udFNtb290aGluZ0xldmVsTWVkaXVtIG9uIG90 aGVyIHBsYXRmb3Jtcy4KIFdLX0VYUE9SVCB2b2lkIFdLUHJlZmVyZW5jZXNTZXRGb250U21vb3Ro aW5nTGV2ZWwoV0tQcmVmZXJlbmNlc1JlZiwgV0tGb250U21vb3RoaW5nTGV2ZWwpOwogV0tfRVhQ T1JUIFdLRm9udFNtb290aGluZ0xldmVsIFdLUHJlZmVyZW5jZXNHZXRGb250U21vb3RoaW5nTGV2 ZWwoV0tQcmVmZXJlbmNlc1JlZik7CkluZGV4OiBUb29scy9DaGFuZ2VMb2cKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gVG9vbHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxMDY3NDgpCisrKyBUb29scy9DaGFuZ2VMb2cJ KHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxMi0wMi0wNCAgRGFuIEJlcm5zdGVp biAgPG1pdHpAYXBwbGUuY29tPgorCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xMDc3MjQwNj4g V0tQcmVmZXJlbmNlcyBpbnN0YW5jZXMgY2Fubm90IGJlIGNvcGllZAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Nzc4MTYKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV2Vi S2l0Mi9XS1ByZWZlcmVuY2VzLmNwcDoKKyAgICAgICAgKFRlc3RXZWJLaXRBUEk6OlRFU1QpOgor CiAyMDEyLTAyLTA0ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAg Z2FyZGVuLW8tbWF0aWMncyBBbGwgRmFpbHVyZSB0YWIgc2hvdWxkIGxldCB5b3UgZXhhbWluZSBh bmQgcmViYXNlbGluZSBleHBlY3RlZCBmYWlsdXJlcwpJbmRleDogVG9vbHMvVGVzdFdlYktpdEFQ SS9UZXN0cy9XZWJLaXQyL1dLUHJlZmVyZW5jZXMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1Rl c3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Mi9XS1ByZWZlcmVuY2VzLmNwcAkocmV2aXNpb24gMTA2 NzQwKQorKysgVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQyL1dLUHJlZmVyZW5jZXMu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC05Nyw0ICs5NywxOCBAQCBURVNUKFdlYktpdDIsIFdLUHJl ZmVyZW5jZXNEZWZhdWx0cykKICAgICBXS1JlbGVhc2UocHJlZmVyZW5jZSk7CiB9CiAKK1RFU1Qo V2ViS2l0MiwgV0tQcmVmZXJlbmNlc0NvcHlpbmcpCit7CisgICAgV0tSZXRhaW5QdHI8V0tTdHJp bmdSZWY+IGlkZW50aWZpZXIoQWRvcHRXSywgV0tTdHJpbmdDcmVhdGVXaXRoVVRGOENTdHJpbmco ImlkZW50aWZpZXIiKSk7CisKKyAgICBXS1JldGFpblB0cjxXS1ByZWZlcmVuY2VzUmVmPiBwcmVm ZXJlbmNlcyhBZG9wdFdLLCBXS1ByZWZlcmVuY2VzQ3JlYXRlV2l0aElkZW50aWZpZXIoaWRlbnRp Zmllci5nZXQoKSkpOworICAgIFdLUHJlZmVyZW5jZXNTZXREZWZhdWx0Rm9udFNpemUocHJlZmVy ZW5jZXMuZ2V0KCksIDM2KTsKKworICAgIFdLUmV0YWluUHRyPFdLUHJlZmVyZW5jZXNSZWY+IGNv cHkoQWRvcHRXSywgV0tQcmVmZXJlbmNlc0NyZWF0ZUNvcHkocHJlZmVyZW5jZXMuZ2V0KCkpKTsK KworICAgIFdLUHJlZmVyZW5jZXNTZXREZWZhdWx0Rm9udFNpemUocHJlZmVyZW5jZXMuZ2V0KCks IDI0KTsKKyAgICBFWFBFQ1RfRVEoMjR1LCBXS1ByZWZlcmVuY2VzR2V0RGVmYXVsdEZvbnRTaXpl KHByZWZlcmVuY2VzLmdldCgpKSk7CisgICAgRVhQRUNUX0VRKDM2dSwgV0tQcmVmZXJlbmNlc0dl dERlZmF1bHRGb250U2l6ZShjb3B5LmdldCgpKSk7Cit9CisKIH0gLy8gbmFtZXNwYWNlIFRlc3RX ZWJLaXRBUEkK