77809 2012-02-04 03:33:42 -0800 Use the wide character version of win32 API by default 2012-02-04 14:24:21 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 kalevlember webkit-unassigned webkit.review.bot oldest_to_newest 549424 0 kalevlember 2012-02-04 03:33:42 -0800 Some win32 specific code makes the assumption that the build system is turning on the wide character win32 API. For example, PluginDatabaseWin.cpp uses wchar_t* as an argument to PathRemoveFileSpec(). Depending on whether _UNICODE and UNICODE are defined by the build system, it resolves to either PathRemoveFileSpecA(char *) or PathRemoveFileSpecW(wchar_t *). Now, since PluginDatabaseWin.cpp uses wchar_t* there, the A() version of the API can't work and we need to define _UNICODE and UNICODE to make it use the W() variant. PluginDatabaseWin.cpp:397:50: error: cannot convert 'WCHAR* {aka wchar_t*}' to 'LPSTR {aka char*}' for argument '1' to 'BOOL PathRemoveFileSpecA(LPSTR)' 549426 1 125491 kalevlember 2012-02-04 03:37:46 -0800 Created attachment 125491 [GTK] Use the wide character version of win32 API by default [GTK] Use the wide character version of win32 API by default https://bugs.webkit.org/show_bug.cgi?id=77809 Reviewed by NOBODY (OOPS!). Certain win32-specific files (like PluginDatabaseWin.cpp) make the assumption that the wide character version of win32 API is the default. Define _UNICODE and UNICODE to do this, similar to what other win32 ports are doing. * GNUmakefile.am: 549466 2 125491 webkit.review.bot 2012-02-04 14:24:17 -0800 Comment on attachment 125491 [GTK] Use the wide character version of win32 API by default Clearing flags on attachment: 125491 Committed r106742: <http://trac.webkit.org/changeset/106742> 549467 3 webkit.review.bot 2012-02-04 14:24:21 -0800 All reviewed patches have been landed. Closing bug. 125491 2012-02-04 03:37:46 -0800 2012-02-04 14:24:17 -0800 [GTK] Use the wide character version of win32 API by default 0002-GTK-Use-the-wide-character-version-of-win32-API-by-d.patch text/plain 1725 kalevlember RnJvbSBjMGQ0ZGIwOWY3ZTUxMjI2NWE1MTc3MTk0YzFlNDRhNzg4YzNlYjE5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLYWxldiBMZW1iZXIgPGthbGV2bGVtYmVyQGdtYWlsLmNvbT4K RGF0ZTogU2F0LCA0IEZlYiAyMDEyIDEzOjAzOjI0ICswMjAwClN1YmplY3Q6IFtQQVRDSCAyLzJd IFtHVEtdIFVzZSB0aGUgd2lkZSBjaGFyYWN0ZXIgdmVyc2lvbiBvZiB3aW4zMiBBUEkgYnkKIGRl ZmF1bHQKCkNlcnRhaW4gd2luMzItc3BlY2lmaWMgZmlsZXMgKGxpa2UgUGx1Z2luRGF0YWJhc2VX aW4uY3BwKSBtYWtlIHRoZQphc3N1bXB0aW9uIHRoYXQgdGhlIHdpZGUgY2hhcmFjdGVyIHZlcnNp b24gb2Ygd2luMzIgQVBJIGlzIHRoZSBkZWZhdWx0LgpEZWZpbmUgX1VOSUNPREUgYW5kIFVOSUNP REUgdG8gZG8gdGhpcywgc2ltaWxhciB0byB3aGF0IG90aGVyIHdpbjMyCnBvcnRzIGFyZSBkb2lu Zy4KLS0tCiBDaGFuZ2VMb2cgICAgICB8ICAgMTQgKysrKysrKysrKysrKysKIEdOVW1ha2VmaWxl LmFtIHwgICAgNyArKysrKysrCiAyIGZpbGVzIGNoYW5nZWQsIDIxIGluc2VydGlvbnMoKyksIDAg ZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IGVl ZTg2ODYuLjQxYjIwYTggMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNyBAQAorMjAxMi0wMi0wNCAgS2FsZXYgTGVtYmVyICA8a2FsZXZsZW1iZXJAZ21h aWwuY29tPgorCisgICAgICAgIFtHVEtdIFVzZSB0aGUgd2lkZSBjaGFyYWN0ZXIgdmVyc2lvbiBv ZiB3aW4zMiBBUEkgYnkgZGVmYXVsdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9Nzc4MDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBDZXJ0YWluIHdpbjMyLXNwZWNpZmljIGZpbGVzIChsaWtlIFBsdWdpbkRh dGFiYXNlV2luLmNwcCkgbWFrZSB0aGUKKyAgICAgICAgYXNzdW1wdGlvbiB0aGF0IHRoZSB3aWRl IGNoYXJhY3RlciB2ZXJzaW9uIG9mIHdpbjMyIEFQSSBpcyB0aGUgZGVmYXVsdC4KKyAgICAgICAg RGVmaW5lIF9VTklDT0RFIGFuZCBVTklDT0RFIHRvIGRvIHRoaXMsIHNpbWlsYXIgdG8gd2hhdCBv dGhlciB3aW4zMgorICAgICAgICBwb3J0cyBhcmUgZG9pbmcuCisKKyAgICAgICAgKiBHTlVtYWtl ZmlsZS5hbToKKwogMjAxMi0wMi0wMyAgS2FsZXYgTGVtYmVyICA8a2FsZXZsZW1iZXJAZ21haWwu Y29tPgogCiAgICAgICAgIFtHVEtdIGNvbmZpZ3VyZTogUHJpbnQgb3V0IHRoZSAtV25vLWMrKzB4 LWNvbXBhdCB0ZXN0IHJlc3VsdApkaWZmIC0tZ2l0IGEvR05VbWFrZWZpbGUuYW0gYi9HTlVtYWtl ZmlsZS5hbQppbmRleCAzM2VmNDYyLi43NDdlYTJlIDEwMDY0NAotLS0gYS9HTlVtYWtlZmlsZS5h bQorKysgYi9HTlVtYWtlZmlsZS5hbQpAQCAtMTUwLDYgKzE1MCwxMyBAQCBnbG9iYWxfY3BwZmxh Z3MgKz0gXAogCS1EWFBfVU5JWAogZW5kaWYKIAorIyBVc2UgdGhlIHdpZGUgY2hhcmFjdGVyIHZl cnNpb24gb2Ygd2luMzIgQVBJIGJ5IGRlZmF1bHQKK2lmIFRBUkdFVF9XSU4zMgorZ2xvYmFsX2Nw cGZsYWdzICs9IFwKKwktRFVOSUNPREUgXAorCS1EX1VOSUNPREUKK2VuZGlmCisKIGlmIFVTRV9J Q1VfVU5JQ09ERQogZ2xvYmFsX2NwcGZsYWdzICs9IFwKIAktRFdURl9VU0VfSUNVX1VOSUNPREU9 MQotLSAKMS43LjcuNgoK