77791 2012-02-03 16:15:43 -0800 [GTK] Web content oftens steals focus from other widgets 2012-02-20 18:04:19 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mrobinson mrobinson cgarcia diegoe webkit.review.bot xan.lopez oldest_to_newest 549214 0 mrobinson 2012-02-03 16:15:43 -0800 This is an annoying bug. To reproduce it, load Google in Epiphany and then quickly press "Ctr+L" to re-focus the address bar. The page will steal focus from the address bar shortly thereafter. 549220 1 mrobinson 2012-02-03 16:18:16 -0800 Believe it or not this seems to be a regression from 2007. Before that time a widget would only grab focus if it was backed by a real widget. Nowadays it grabs focus no matter what. If there is no real widget, it forces the WebView to grab focus. 549221 2 mrobinson 2012-02-03 16:18:27 -0800 Here's the change in question: http://trac.webkit.org/changeset/24963 549222 3 mrobinson 2012-02-03 16:19:39 -0800 Another interesting data point is that we were very diligent in making sure this bug also existed in WebKit2. 549258 4 125451 mrobinson 2012-02-03 17:15:19 -0800 Created attachment 125451 Patch 560503 5 125451 webkit.review.bot 2012-02-20 18:04:14 -0800 Comment on attachment 125451 Patch Clearing flags on attachment: 125451 Committed r108278: <http://trac.webkit.org/changeset/108278> 560504 6 webkit.review.bot 2012-02-20 18:04:19 -0800 All reviewed patches have been landed. Closing bug. 125451 2012-02-03 17:15:19 -0800 2012-02-20 18:04:14 -0800 Patch bug-77791-20120203171518.patch text/plain 5155 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2NTc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmEwODM4OWFlYzQxZWM5 ZGQyMTM0YjlkODVhY2M3OGRjZGVmMzRmZi4uYjYzZmJhNjdhMTAzYWYzZGZiMDhlMTc4ZmQ2Mzlh NWQ5NTg0MWI2MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTAyLTAzICBNYXJ0 aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBXZWIg Y29udGVudCBvZnRlbnMgc3RlYWxzIGZvY3VzIGZyb20gb3RoZXIgd2lkZ2V0cworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Nzc3OTEKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2d0ay9XaWRn ZXRHdGsuY3BwOgorICAgICAgICAoV2ViQ29yZTo6V2lkZ2V0OjpzZXRGb2N1cyk6IE5vIGxvbmdl ciBkbyBhbnl0aGluZyBzcGVjaWFsIHRvIHRyeQorICAgICAgICB0byBncmFiICJyZWFsIiB3aWRn ZXQgZm9jdXMuIFRoaXMgbWF0Y2hlcyB0aGUgYmVoYXZpb3Igb24gUXQuCisgICAgICAgICogcGx1 Z2lucy9ndGsvUGx1Z2luVmlld0d0ay5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQbHVnaW5WaWV3 OjpzZXRGb2N1cyk6IE1vdmVkIHRoZSBmb2N1cyBoYW5kbGluZyB0byBoZXJlLgorICAgICAgICBU aGlzIGVuc3VyZXMgdGhhdCBiZWhhdmlvciBmb3IgcGx1Z2lucyBkb2VzIG5vdCBjaGFuZ2UuCisK IDIwMTItMDItMDIgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAg ICAgICBOUEFQSSB3aWxsIG5vdCBzZW5kIG1vdXNlIHVwIGV2ZW50cyB3aGVuIG1vdXNlIGlzIG91 dHNpZGUgcGx1Z2luIGFyZWEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxv ZyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwppbmRleCA2ZGJlYTY1NjA2NzVlNmM2MTc4 YjBhZTY3OWZhZjY3ODNiMzA4MjVhLi5lMDA3ZjM3ZTkyY2ExNzVmYTQzNWVkODY3NGNjYzMxMjk2 YWIwMmU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTItMDItMDMgIE1h cnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIFdl YiBjb250ZW50IG9mdGVucyBzdGVhbHMgZm9jdXMgZnJvbSBvdGhlciB3aWRnZXRzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03Nzc5MQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogdGVzdHMvdGVzdHdlYnZp ZXcuYzogQWRkZWQgYSBXZWJLaXQxIHRlc3QgdG8gdmVyaWZ5IHRoaXMgYmVoYXZpb3IuCisKIDIw MTItMDItMDIgIENsYXVkaW8gU2FhdmVkcmEgIDxjc2FhdmVkcmFAaWdhbGlhLmNvbT4gYW5kIE1h cnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIFdl YktpdFdlYlZpZXcgd29uJ3Qgd29yayBpbiBhIEd0a09mZnNjcmVlbldpbmRvdwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1dpZGdldEd0ay5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ndGsvV2lkZ2V0R3RrLmNwcAppbmRleCBiYTIxMjI2ZWJiZDgwNTllNjcz YmIyYmY5Mzg5ZGJiNzY2NjJiYTdiLi4yMDNmM2M5YzdjOWE2ZTJjOWEzNGMwOTFlZTk0YmNiMTM3 OGM2ZjM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvV2lkZ2V0R3Rr LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvV2lkZ2V0R3RrLmNwcApAQCAt NTgsMTggKzU4LDYgQEAgV2lkZ2V0Ojp+V2lkZ2V0KCkKIAogdm9pZCBXaWRnZXQ6OnNldEZvY3Vz KGJvb2wgZm9jdXNlZCkKIHsKLSAgICBpZiAoIWZvY3VzZWQpCi0gICAgICAgIHJldHVybjsKLQot ICAgIEd0a1dpZGdldCogd2lkZ2V0ID0gcGxhdGZvcm1XaWRnZXQoKSA/IHBsYXRmb3JtV2lkZ2V0 KCkgOiByb290KCktPmhvc3RXaW5kb3coKS0+cGxhdGZvcm1QYWdlQ2xpZW50KCk7Ci0gICAgaWYg KHdpZGdldCkgewotICAgICAgICBndGtfd2lkZ2V0X2dyYWJfZm9jdXMod2lkZ2V0KTsKLSAgICAg ICAgcmV0dXJuOwotICAgIH0KLQotICAgIC8vIFdlIGFyZSBydW5uaW5nIFdLMi4KLSAgICBpZiAo RnJhbWUqIGZyYW1lID0gRnJhbWU6OmZyYW1lRm9yV2lkZ2V0KHRoaXMpKQotICAgICAgICBmcmFt ZS0+cGFnZSgpLT5jaHJvbWUoKS0+Zm9jdXMoKTsKIH0KIAogdm9pZCBXaWRnZXQ6OnNldEN1cnNv cihjb25zdCBDdXJzb3ImIGN1cnNvcikKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsdWdp bnMvZ3RrL1BsdWdpblZpZXdHdGsuY3BwIGIvU291cmNlL1dlYkNvcmUvcGx1Z2lucy9ndGsvUGx1 Z2luVmlld0d0ay5jcHAKaW5kZXggYWJmNGYxOTZjMGVlYjdlYzY1ZjhlYzc2YjMxZGZkYjM0YTA2 YzQ1OC4uM2VmMjAzZjU0ZDBmNWQ2NjA2MzE2MTgxNDI3NmJiZjAyNDJmYWExNyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGx1Z2lucy9ndGsvUGx1Z2luVmlld0d0ay5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvcGx1Z2lucy9ndGsvUGx1Z2luVmlld0d0ay5jcHAKQEAgLTE2NSw2ICsxNjUs OCBAQCB2b2lkIFBsdWdpblZpZXc6OnVwZGF0ZVBsdWdpbldpZGdldCgpCiB2b2lkIFBsdWdpblZp ZXc6OnNldEZvY3VzKGJvb2wgZm9jdXNlZCkKIHsKICAgICBBU1NFUlQocGxhdGZvcm1QbHVnaW5X aWRnZXQoKSA9PSBwbGF0Zm9ybVdpZGdldCgpKTsKKyAgICBpZiAoZm9jdXNlZCAmJiBwbGF0Zm9y bVdpZGdldCgpKQorICAgICAgICBndGtfd2lkZ2V0X2dyYWJfZm9jdXMocGxhdGZvcm1XaWRnZXQo KSk7CiAgICAgV2lkZ2V0OjpzZXRGb2N1cyhmb2N1c2VkKTsKIH0KIApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9ndGsvdGVzdHMvdGVzdHdlYnZpZXcuYyBiL1NvdXJjZS9XZWJLaXQvZ3RrL3Rl c3RzL3Rlc3R3ZWJ2aWV3LmMKaW5kZXggNDFjZjMwOGY2OWQzODUzNzg3NGQ0OTBjMjkxYzlhMjI4 NDNmZTA5NC4uZWQ2ZmVjNmFlOWY5YzUxODY3YmNlZjExNTJkMDU2MGI3ZjA5ZjQ5ZSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9ndGsvdGVzdHMvdGVzdHdlYnZpZXcuYworKysgYi9Tb3VyY2Uv V2ViS2l0L2d0ay90ZXN0cy90ZXN0d2Vidmlldy5jCkBAIC0zODIsNiArMzgyLDQwIEBAIHN0YXRp YyB2b2lkIHRlc3Rfd2Via2l0X3dlYl92aWV3X2luX29mZnNjcmVlbl93aW5kb3dfZG9lc19ub3Rf Y3Jhc2goKQogICAgIGdfbWFpbl9sb29wX3VucmVmKGxvb3ApOwogfQogCitzdGF0aWMgdm9pZCB0 ZXN0X3dlYmtpdF93ZWJfdmlld19kb2VzX25vdF9zdGVhbF9mb2N1cygpCit7CisgICAgbG9vcCA9 IGdfbWFpbl9sb29wX25ldyhOVUxMLCBUUlVFKTsKKworICAgIEd0a1dpZGdldCAqd2luZG93ID0g Z3RrX29mZnNjcmVlbl93aW5kb3dfbmV3KCk7CisgICAgR3RrV2lkZ2V0ICp3ZWJWaWV3ID0gd2Vi a2l0X3dlYl92aWV3X25ldygpOworICAgIEd0a1dpZGdldCAqZW50cnkgPSBndGtfZW50cnlfbmV3 KCk7CisgICAgR3RrV2lkZ2V0ICpib3ggPSBndGtfYm94X25ldyhHVEtfT1JJRU5UQVRJT05fSE9S SVpPTlRBTCwgMCk7CisKKyAgICBndGtfY29udGFpbmVyX2FkZChHVEtfQ09OVEFJTkVSKGJveCks IHdlYlZpZXcpOworICAgIGd0a19jb250YWluZXJfYWRkKEdUS19DT05UQUlORVIoYm94KSwgZW50 cnkpOworICAgIGd0a19jb250YWluZXJfYWRkKEdUS19DT05UQUlORVIod2luZG93KSwgYm94KTsK KyAgICBndGtfd2lkZ2V0X3Nob3dfYWxsKHdpbmRvdyk7CisKKyAgICBndGtfd2lkZ2V0X2dyYWJf Zm9jdXMoZW50cnkpOworICAgIGdfYXNzZXJ0KGd0a193aWRnZXRfaXNfZm9jdXMoZW50cnkpKTsK KworICAgIGdfc2lnbmFsX2Nvbm5lY3Qod2ViVmlldywgIm5vdGlmeTo6bG9hZC1zdGF0dXMiLCBH X0NBTExCQUNLKGlkbGVfcXVpdF9sb29wX2NiKSwgTlVMTCk7CisgICAgd2Via2l0X3dlYl92aWV3 X2xvYWRfaHRtbF9zdHJpbmcoV0VCS0lUX1dFQl9WSUVXKHdlYlZpZXcpLAorICAgICAgICAiPGh0 bWw+PGJvZHk+IgorICAgICAgICAiICAgIDxpbnB1dCBpZD1cImVudHJ5XCIgdHlwZT1cInRleHRc Ii8+IgorICAgICAgICAiICAgIDxzY3JpcHQ+IgorICAgICAgICAiICAgICAgICBkb2N1bWVudC5n ZXRFbGVtZW50QnlJZChcImVudHJ5XCIpLmZvY3VzKCk7IgorICAgICAgICAiICAgIDwvc2NyaXB0 PiIKKyAgICAgICAgIjwvYm9keT48L2h0bWw+IiwgImZpbGU6Ly8iKTsKKworICAgIGdfbWFpbl9s b29wX3J1bihsb29wKTsKKworICAgIGdfYXNzZXJ0KGd0a193aWRnZXRfaXNfZm9jdXMoZW50cnkp KTsKKworICAgIGd0a193aWRnZXRfZGVzdHJveSh3aW5kb3cpOworICAgIGdfbWFpbl9sb29wX3Vu cmVmKGxvb3ApOworfQorCiBpbnQgbWFpbihpbnQgYXJnYywgY2hhcioqIGFyZ3YpCiB7CiAgICAg U291cFNlcnZlciogc2VydmVyOwpAQCAtNDEwLDYgKzQ0NCw3IEBAIGludCBtYWluKGludCBhcmdj LCBjaGFyKiogYXJndikKICAgICBnX3Rlc3RfYWRkX2Z1bmMoIi93ZWJraXQvd2Vidmlldy9ncmFi X2ZvY3VzIiwgdGVzdF93ZWJraXRfd2ViX3ZpZXdfZ3JhYl9mb2N1cyk7CiAgICAgZ190ZXN0X2Fk ZF9mdW5jKCIvd2Via2l0L3dlYnZpZXcvd2luZG93LWZlYXR1cmVzIiwgdGVzdF93ZWJraXRfd2Vi X3ZpZXdfd2luZG93X2ZlYXR1cmVzKTsKICAgICBnX3Rlc3RfYWRkX2Z1bmMoIi93ZWJraXQvd2Vi dmlldy93ZWJ2aWV3LWluLW9mZnNjcmVlbi13aW5kb3ctZG9lcy1ub3QtY3Jhc2giLCB0ZXN0X3dl YmtpdF93ZWJfdmlld19pbl9vZmZzY3JlZW5fd2luZG93X2RvZXNfbm90X2NyYXNoKTsKKyAgICBn X3Rlc3RfYWRkX2Z1bmMoIi93ZWJraXQvd2Vidmlldy93ZWJ2aWV3LWRvZXMtbm90LXN0ZWFsLWZv Y3VzIiwgdGVzdF93ZWJraXRfd2ViX3ZpZXdfZG9lc19ub3Rfc3RlYWxfZm9jdXMpOwogCiAgICAg cmV0dXJuIGdfdGVzdF9ydW4gKCk7CiB9Cg==