77768 2012-02-03 13:01:08 -0800 Fix bugs in two SVG manual tests: animateColor-from-by.svg and svg-link-hover-use.svg 2012-02-04 14:57:17 -0800 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 pdr webkit-unassigned eric krit rwlbuis webkit.review.bot zimmermann oldest_to_newest 548982 0 pdr 2012-02-03 13:01:08 -0800 Two small bugs: 1) svg-link-hover-use.svg uses xlink:href="rect" but it should use xlink:href="#rect" according to http://www.w3.org/TR/SVG/struct.html#UseElement. 2) animateColor-from-by.svg says that it animates from "red to purple" but it should say from "red to blue". 548990 1 125392 pdr 2012-02-03 13:06:12 -0800 Created attachment 125392 Fix animateColor-from-by.svg and svg-link-hover-use.svg 549373 2 125392 eric 2012-02-03 21:53:49 -0800 Comment on attachment 125392 Fix animateColor-from-by.svg and svg-link-hover-use.svg View in context: https://bugs.webkit.org/attachment.cgi?id=125392&action=review > ManualTests/svg-link-hover-use.svg:6 > + <use xlink:href="#rect" onmouseover="alert('foo')" /> I think this is technically incorrect, but I think we handle this case regardless, no? > ManualTests/animation/animateColor-from-by.svg:5 > - <text x='10' y='120'>The rect should animate from red to purple over 3 seconds</text> > + <text x='10' y='120'>The rect should animate from red to blue over 3 seconds</text> Why? It starts at DD00DD and should got to DD00DD which seems purple to me... 549456 3 pdr 2012-02-04 13:22:48 -0800 (In reply to comment #2) > (From update of attachment 125392 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=125392&action=review > > > ManualTests/svg-link-hover-use.svg:6 > > + <use xlink:href="#rect" onmouseover="alert('foo')" /> > > I think this is technically incorrect, but I think we handle this case regardless, no? At one point we did allow it but recently the IRI handling was improved with https://bugs.webkit.org/show_bug.cgi?id=63283, causing this test to fail. The bug report discusses this case and it looks like the conclusion was that it's best if we err on the side of correctness. Firefox handles this similarly, causing the test to fail without the #. > > > ManualTests/animation/animateColor-from-by.svg:5 > > - <text x='10' y='120'>The rect should animate from red to purple over 3 seconds</text> > > + <text x='10' y='120'>The rect should animate from red to blue over 3 seconds</text> > > Why? It starts at DD00DD and should got to DD00DD which seems purple to me... Great catch. https://bugs.webkit.org/show_bug.cgi?id=77812 549457 4 125499 pdr 2012-02-04 13:29:05 -0800 Created attachment 125499 Fix bug in svg-link-hover-use.svg 549469 5 125499 eric 2012-02-04 14:28:16 -0800 Comment on attachment 125499 Fix bug in svg-link-hover-use.svg OK. 549479 6 125499 webkit.review.bot 2012-02-04 14:57:13 -0800 Comment on attachment 125499 Fix bug in svg-link-hover-use.svg Clearing flags on attachment: 125499 Committed r106747: <http://trac.webkit.org/changeset/106747> 549480 7 webkit.review.bot 2012-02-04 14:57:17 -0800 All reviewed patches have been landed. Closing bug. 125392 2012-02-03 13:06:12 -0800 2012-02-04 13:29:05 -0800 Fix animateColor-from-by.svg and svg-link-hover-use.svg 77768.1.patch text/plain 1807 pdr SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDEwNjY4 NikKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEyLTAy LTAzICBQaGlsaXAgUm9nZXJzICA8cGRyQGdvb2dsZS5jb20+CisKKyAgICAgICAgRml4IGFuaW1h dGVDb2xvci1mcm9tLWJ5LnN2ZyBhbmQgc3ZnLWxpbmstaG92ZXItdXNlLnN2ZworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Nzc3NjgKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIE1hbnVhbFRlc3RzL2FuaW1h dGlvbi9hbmltYXRlQ29sb3ItZnJvbS1ieS5zdmc6CisgICAgICAgICogTWFudWFsVGVzdHMvc3Zn LWxpbmstaG92ZXItdXNlLnN2ZzoKKwogMjAxMi0wMi0wMyAgU2ltb24gSGF1c21hbm4gIDxzaW1v bi5oYXVzbWFubkBub2tpYS5jb20+CiAKICAgICAgICAgW1F0XSBSZXBsYWNlIEdOVSBsaW5rZXIg c2NyaXB0IGZvciBleHBvcnRzIHdpdGggZXhwb3J0IG1hY3JvcyBpbiBXVEYvSlNDCkluZGV4OiBN YW51YWxUZXN0cy9zdmctbGluay1ob3Zlci11c2Uuc3ZnCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIE1hbnVhbFRl c3RzL3N2Zy1saW5rLWhvdmVyLXVzZS5zdmcJKHJldmlzaW9uIDEwNjY2MykKKysrIE1hbnVhbFRl c3RzL3N2Zy1saW5rLWhvdmVyLXVzZS5zdmcJKHdvcmtpbmcgY29weSkKQEAgLTMsNyArMyw3IEBA CiAgICAgPHJlY3QgaWQ9J3JlY3QnIHdpZHRoPScxMDAnIGhlaWdodD0iMTAwIiBmaWxsPSdibHVl JyAvPgogICA8L2RlZnM+CiAgIDxhIHhsaW5rOmhyZWY9Imh0dHA6Ly93d3cud2Via2l0Lm9yZyIg PgotICAgICAgPHVzZSB4bGluazpocmVmPSJyZWN0IiBvbm1vdXNlb3Zlcj0iYWxlcnQoJ2Zvbycp IiAvPgorICAgICAgPHVzZSB4bGluazpocmVmPSIjcmVjdCIgb25tb3VzZW92ZXI9ImFsZXJ0KCdm b28nKSIgLz4KICAgPC9hPgogICA8dGV4dCB5PScxMjAnIHg9JzEwJz5UaGUgYWJvdmUgYmx1ZSBz cXVhcmUgaXMgYSBsaW5rLCB0aGUgY3Vyc29yIHNob3VsZCBiZSBhIGhhbmQgYWJvdmUgaXQuPC90 ZXh0PgogPC9zdmc+CkluZGV4OiBNYW51YWxUZXN0cy9hbmltYXRpb24vYW5pbWF0ZUNvbG9yLWZy b20tYnkuc3ZnCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIE1hbnVhbFRlc3RzL2FuaW1hdGlvbi9hbmltYXRlQ29s b3ItZnJvbS1ieS5zdmcJKHJldmlzaW9uIDEwNjY2MykKKysrIE1hbnVhbFRlc3RzL2FuaW1hdGlv bi9hbmltYXRlQ29sb3ItZnJvbS1ieS5zdmcJKHdvcmtpbmcgY29weSkKQEAgLTIsNSArMiw1IEBA CiAgIDxyZWN0IHdpZHRoPScxMDAnIGhlaWdodD0nMTAwJz4KICAgICA8YW5pbWF0ZUNvbG9yIGF0 dHJpYnV0ZU5hbWU9ImZpbGwiIGZyb209JyNERDAwMDAnIGJ5PScjMDAwMEREJyBkdXI9JzNzJyBm aWxsPSdmcmVlemUnIC8+CiAgIDwvcmVjdD4KLSAgPHRleHQgeD0nMTAnIHk9JzEyMCc+VGhlIHJl Y3Qgc2hvdWxkIGFuaW1hdGUgZnJvbSByZWQgdG8gcHVycGxlIG92ZXIgMyBzZWNvbmRzPC90ZXh0 PgorICA8dGV4dCB4PScxMCcgeT0nMTIwJz5UaGUgcmVjdCBzaG91bGQgYW5pbWF0ZSBmcm9tIHJl ZCB0byBibHVlIG92ZXIgMyBzZWNvbmRzPC90ZXh0PgogPC9zdmc+Cg== 125499 2012-02-04 13:29:05 -0800 2012-02-04 14:57:13 -0800 Fix bug in svg-link-hover-use.svg 77768.2.patch text/plain 1112 pdr SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDEwNjc0 MCkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDEyLTAy LTA0ICBQaGlsaXAgUm9nZXJzICA8cGRyQGdvb2dsZS5jb20+CisKKyAgICAgICAgRml4IGJ1ZyBp biBzdmctbGluay1ob3Zlci11c2Uuc3ZnCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD03Nzc2OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogTWFudWFsVGVzdHMvc3ZnLWxpbmstaG92ZXItdXNlLnN2ZzoKKwog MjAxMi0wMi0wMyAgS2FsZXYgTGVtYmVyICA8a2FsZXZsZW1iZXJAZ21haWwuY29tPgogCiAgICAg ICAgIFtHVEtdIGNvbmZpZ3VyZTogUHJpbnQgb3V0IHRoZSAtV25vLWMrKzB4LWNvbXBhdCB0ZXN0 IHJlc3VsdApJbmRleDogTWFudWFsVGVzdHMvc3ZnLWxpbmstaG92ZXItdXNlLnN2Zwo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBNYW51YWxUZXN0cy9zdmctbGluay1ob3Zlci11c2Uuc3ZnCShyZXZpc2lvbiAxMDY3 NDApCisrKyBNYW51YWxUZXN0cy9zdmctbGluay1ob3Zlci11c2Uuc3ZnCSh3b3JraW5nIGNvcHkp CkBAIC0zLDcgKzMsNyBAQAogICAgIDxyZWN0IGlkPSdyZWN0JyB3aWR0aD0nMTAwJyBoZWlnaHQ9 IjEwMCIgZmlsbD0nYmx1ZScgLz4KICAgPC9kZWZzPgogICA8YSB4bGluazpocmVmPSJodHRwOi8v d3d3LndlYmtpdC5vcmciID4KLSAgICAgIDx1c2UgeGxpbms6aHJlZj0icmVjdCIgb25tb3VzZW92 ZXI9ImFsZXJ0KCdmb28nKSIgLz4KKyAgICAgIDx1c2UgeGxpbms6aHJlZj0iI3JlY3QiIG9ubW91 c2VvdmVyPSJhbGVydCgnZm9vJykiIC8+CiAgIDwvYT4KICAgPHRleHQgeT0nMTIwJyB4PScxMCc+ VGhlIGFib3ZlIGJsdWUgc3F1YXJlIGlzIGEgbGluaywgdGhlIGN1cnNvciBzaG91bGQgYmUgYSBo YW5kIGFib3ZlIGl0LjwvdGV4dD4KIDwvc3ZnPgo=