77760 2012-02-03 11:49:16 -0800 GtkLauncher.exe doesn't draw anything in its webkitwebview 2012-02-04 11:32:39 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 77743 P2 Normal --- 0 kalevlember webkit-unassigned oldest_to_newest 548914 0 kalevlember 2012-02-03 11:49:16 -0800 On Windows, GtkLauncher.exe starts up with two Gdk-CRITICAL **: IA__gdk_window_create_similar_surface: assertion `GDK_IS_WINDOW (window)' failed warnings, and doesn't draw anything in its WebKitWebView. This is coming from createSurfaceForBackingStore() in WidgetBackingStoreCairo.cpp, which tries to call gtk_widget_get_window() before the widget is realized. 548916 1 125378 kalevlember 2012-02-03 11:50:41 -0800 Created attachment 125378 Create the backing store after WebKitWebView is realized The widget backing store was created in size_allocate() before the widget was realized. This wasn't a problem for GtkWidgetBackingStoreX11, but WidgetBackingStoreCairo's constructor needs the widget's GDK window, which is is created in realize(). Fixes the WebKitWebView not painting on platforms that use WidgetBackingStoreCairo, e.g. win32. Gdk-CRITICAL **: IA__gdk_window_create_similar_surface: assertion `GDK_IS_WINDOW (window)' failed 548980 2 125378 mrobinson 2012-02-03 12:59:48 -0800 Comment on attachment 125378 Create the backing store after WebKitWebView is realized Please check if my patch at https://bugs.webkit.org/show_bug.cgi?id=77743 fixes this issue. It should delay the backing store creation until mapping. 549044 3 kalevlember 2012-02-03 13:55:34 -0800 I can confirm that the patch in bug 77743 also fixes it, thanks! *** This bug has been marked as a duplicate of bug 77743 *** 125378 2012-02-03 11:50:41 -0800 2012-02-04 11:32:39 -0800 Create the backing store after WebKitWebView is realized 0003-Create-the-backing-store-after-WebKitWebView-is-real.patch text/plain 3599 kalevlember RnJvbSA1NmQ1Y2ZhZWYxODAxOWI0NmVmY2VmZjUxOWM0MzA1M2ZiYTQwYTVlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLYWxldiBMZW1iZXIgPGthbGV2bGVtYmVyQGdtYWlsLmNvbT4K RGF0ZTogRnJpLCAzIEZlYiAyMDEyIDIxOjI5OjUwICswMjAwClN1YmplY3Q6IFtQQVRDSCAzLzNd IENyZWF0ZSB0aGUgYmFja2luZyBzdG9yZSBhZnRlciBXZWJLaXRXZWJWaWV3IGlzIHJlYWxpemVk CgpUaGUgd2lkZ2V0IGJhY2tpbmcgc3RvcmUgd2FzIGNyZWF0ZWQgaW4gc2l6ZV9hbGxvY2F0ZSgp IGJlZm9yZSB0aGUKd2lkZ2V0IHdhcyByZWFsaXplZC4gVGhpcyB3YXNuJ3QgYSBwcm9ibGVtIGZv ciBHdGtXaWRnZXRCYWNraW5nU3RvcmVYMTEsCmJ1dCBXaWRnZXRCYWNraW5nU3RvcmVDYWlybydz IGNvbnN0cnVjdG9yIG5lZWRzIHRoZSB3aWRnZXQncyBHREsgd2luZG93LAp3aGljaCBpcyBpcyBj cmVhdGVkIGluIHJlYWxpemUoKS4KCkZpeGVzIHRoZSBXZWJLaXRXZWJWaWV3IG5vdCBwYWludGlu ZyBvbiBwbGF0Zm9ybXMgdGhhdCB1c2UKV2lkZ2V0QmFja2luZ1N0b3JlQ2Fpcm8sIGUuZy4gd2lu MzIuCgpHZGstQ1JJVElDQUwgKio6IElBX19nZGtfd2luZG93X2NyZWF0ZV9zaW1pbGFyX3N1cmZh Y2U6IGFzc2VydGlvbiBgR0RLX0lTX1dJTkRPVyAod2luZG93KScgZmFpbGVkCi0tLQogU291cmNl L1dlYktpdC9ndGsvQ2hhbmdlTG9nICAgICAgICAgICAgICAgIHwgICAyMSArKysrKysrKysrKysr KysrKysrKysKIFNvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcCB8ICAg IDkgKysrKysrLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDI3IGluc2VydGlvbnMoKyksIDMgZGVsZXRp b25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvU291cmNl L1dlYktpdC9ndGsvQ2hhbmdlTG9nCmluZGV4IDJkYmNkZDMuLjM1NGQ4YTkgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyNCBAQAorMjAxMi0wMi0wMyAgS2FsZXYgTGVtYmVyICA8a2FsZXZs ZW1iZXJAZ21haWwuY29tPgorCisgICAgICAgIFtHVEtdIENyZWF0ZSB0aGUgYmFja2luZyBzdG9y ZSBhZnRlciBXZWJLaXRXZWJWaWV3IGlzIHJlYWxpemVkCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03Nzc2MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSB3aWRnZXQgYmFja2luZyBzdG9yZSB3YXMgY3Jl YXRlZCBpbiBzaXplX2FsbG9jYXRlKCkgYmVmb3JlIHRoZQorICAgICAgICB3aWRnZXQgd2FzIHJl YWxpemVkLiBUaGlzIHdhc24ndCBhIHByb2JsZW0gZm9yIEd0a1dpZGdldEJhY2tpbmdTdG9yZVgx MSwKKyAgICAgICAgYnV0IFdpZGdldEJhY2tpbmdTdG9yZUNhaXJvJ3MgY29uc3RydWN0b3IgbmVl ZHMgdGhlIHdpZGdldCdzIEdESyB3aW5kb3csCisgICAgICAgIHdoaWNoIGlzIGlzIGNyZWF0ZWQg aW4gcmVhbGl6ZSgpLgorCisgICAgICAgIEZpeGVzIHRoZSBXZWJLaXRXZWJWaWV3IG5vdCBwYWlu dGluZyBvbiBwbGF0Zm9ybXMgdGhhdCB1c2UKKyAgICAgICAgV2lkZ2V0QmFja2luZ1N0b3JlQ2Fp cm8sIGUuZy4gd2luMzIuCisKKyAgICAgICAgR2RrLUNSSVRJQ0FMICoqOiBJQV9fZ2RrX3dpbmRv d19jcmVhdGVfc2ltaWxhcl9zdXJmYWNlOiBhc3NlcnRpb24gYEdES19JU19XSU5ET1cgKHdpbmRv dyknIGZhaWxlZAorCisgICAgICAgICogd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwOgorICAgICAg ICAod2Via2l0X3dlYl92aWV3X3NpemVfYWxsb2NhdGUpOgorICAgICAgICAod2Via2l0X3dlYl92 aWV3X3JlYWxpemUpOgorCiAyMDEyLTAyLTAyICBLYWxldiBMZW1iZXIgIDxrYWxldmxlbWJlckBn bWFpbC5jb20+CiAKICAgICAgICAgW0dUS10gRG9uJ3QgdXNlIHVpbnQKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQv Z3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcAppbmRleCBhYzYxNThiLi42NGVjMGRmIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKKysrIGIv U291cmNlL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCkBAIC04NzIsOSArODcy LDExIEBAIHN0YXRpYyB2b2lkIHdlYmtpdF93ZWJfdmlld19zaXplX2FsbG9jYXRlKEd0a1dpZGdl dCogd2lkZ2V0LCBHdGtBbGxvY2F0aW9uKiBhbGxvCiAKICAgICBndGtfY29udGFpbmVyX2ZvcmFs bChHVEtfQ09OVEFJTkVSKHdpZGdldCksIHVwZGF0ZUNoaWxkQWxsb2NhdGlvbkZyb21QZW5kaW5n QWxsb2NhdGlvbiwgMCk7CiAKLSAgICBXZWJLaXQ6OkNocm9tZUNsaWVudCogY2hyb21lQ2xpZW50 ID0gc3RhdGljX2Nhc3Q8V2ViS2l0OjpDaHJvbWVDbGllbnQqPihwYWdlLT5jaHJvbWUoKS0+Y2xp ZW50KCkpOwotICAgIGNocm9tZUNsaWVudC0+d2lkZ2V0U2l6ZUNoYW5nZWQob2xkU2l6ZSwgSW50 U2l6ZShhbGxvY2F0aW9uLT53aWR0aCwgYWxsb2NhdGlvbi0+aGVpZ2h0KSk7Ci0gICAgY2hyb21l Q2xpZW50LT5hZGp1c3RtZW50V2F0Y2hlcigpLT51cGRhdGVBZGp1c3RtZW50c0Zyb21TY3JvbGxi YXJzKCk7CisgICAgaWYgKGd0a193aWRnZXRfZ2V0X3JlYWxpemVkKHdpZGdldCkpIHsKKyAgICAg ICAgV2ViS2l0OjpDaHJvbWVDbGllbnQqIGNocm9tZUNsaWVudCA9IHN0YXRpY19jYXN0PFdlYktp dDo6Q2hyb21lQ2xpZW50Kj4ocGFnZS0+Y2hyb21lKCktPmNsaWVudCgpKTsKKyAgICAgICAgY2hy b21lQ2xpZW50LT53aWRnZXRTaXplQ2hhbmdlZChvbGRTaXplLCBJbnRTaXplKGFsbG9jYXRpb24t PndpZHRoLCBhbGxvY2F0aW9uLT5oZWlnaHQpKTsKKyAgICAgICAgY2hyb21lQ2xpZW50LT5hZGp1 c3RtZW50V2F0Y2hlcigpLT51cGRhdGVBZGp1c3RtZW50c0Zyb21TY3JvbGxiYXJzKCk7CisgICAg fQogCiAjaWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQogICAgIFdFQktJVF9XRUJfVklF Vyh3aWRnZXQpLT5wcml2LT5hY2NlbGVyYXRlZENvbXBvc2l0aW5nQ29udGV4dC0+cmVzaXplUm9v dExheWVyKEludFNpemUoYWxsb2NhdGlvbi0+d2lkdGgsIGFsbG9jYXRpb24tPmhlaWdodCkpOwpA QCAtOTk2LDYgKzk5OCw3IEBAIHN0YXRpYyB2b2lkIHdlYmtpdF93ZWJfdmlld19yZWFsaXplKEd0 a1dpZGdldCogd2lkZ2V0KQogICAgIFdlYktpdFdlYlZpZXcqIHdlYlZpZXcgPSBXRUJLSVRfV0VC X1ZJRVcod2lkZ2V0KTsKICAgICBXZWJLaXRXZWJWaWV3UHJpdmF0ZSogcHJpdiA9IHdlYlZpZXct PnByaXY7CiAgICAgZ3RrX2ltX2NvbnRleHRfc2V0X2NsaWVudF93aW5kb3cocHJpdi0+aW1Db250 ZXh0LmdldCgpLCB3aW5kb3cpOworICAgIHByaXYtPmJhY2tpbmdTdG9yZSA9IFdlYkNvcmU6Oldp ZGdldEJhY2tpbmdTdG9yZTo6Y3JlYXRlKHdpZGdldCwgSW50U2l6ZShhbGxvY2F0aW9uLndpZHRo LCBhbGxvY2F0aW9uLmhlaWdodCkpOwogfQogCiAjaWZkZWYgR1RLX0FQSV9WRVJTSU9OXzIKLS0g CjEuNy45Cgo=