77759 2012-02-03 11:43:05 -0800 Missing include in TestNetscapePlugIn 2012-02-22 12:51:23 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 kalevlember webkit-unassigned morrita peter webkit.review.bot oldest_to_newest 548905 0 kalevlember 2012-02-03 11:43:05 -0800 gcc 4.7 in Fedora 17 needs unistd.h include for sleep(). The include is there, but guarded by #ifdef (ANDROID), which should be expanded to cover all Linux/Unix targets. 548910 1 125376 kalevlember 2012-02-03 11:44:14 -0800 Created attachment 125376 Explicitly include unistd.h in TestNetscapePlugIn Fixes build with gcc 4.7. r100432 added the include only for ANDROID; this changes the ifdef to cover all unix platforms. On Fedora 17 the gcc 4.7 compiler no longer implicitly includes unistd.h from standard headers and other unix platforms are likely to get gcc 4.7 as well in the future. 548969 2 125376 mrobinson 2012-02-03 12:54:34 -0800 Comment on attachment 125376 Explicitly include unistd.h in TestNetscapePlugIn Are you sure the Android build defines XP_UNIX? 549009 3 kalevlember 2012-02-03 13:27:33 -0800 Adding Peter Beverloo to CC. Peter, could you check please if XP_UNIX gets defined on Android? 560598 4 125376 morrita 2012-02-20 20:32:23 -0800 Comment on attachment 125376 Explicitly include unistd.h in TestNetscapePlugIn We can just have both XP_UNIX and ANDROID. That would be intention revealing and barely hurt the code. I hope we had EWS for Android but currently we don't. Let us be conservative until then. 560690 5 127925 kalevlember 2012-02-20 23:22:57 -0800 Created attachment 127925 Patch v2 560691 6 kalevlember 2012-02-20 23:24:05 -0800 (In reply to comment #4) > We can just have both XP_UNIX and ANDROID. That would be intention revealing and barely hurt the code. Fair enough. Uploaded a new patch that does this. 560798 7 peter 2012-02-21 04:02:10 -0800 Sorry for the late reply, this slipped through! The change works well for Android, SGTM. Only nit would be that the title could be slightly clearer by appending "for GCC 4.7", but I was guilty of not doing that myself in the Android patch as well, so it should be fine :-). Thanks! 561313 8 127925 morrita 2012-02-21 16:00:57 -0800 Comment on attachment 127925 Patch v2 Perter, thanks for investigation! @kalevlember could you update the bug summary? I'm happy to land this then. 561315 9 morrita 2012-02-21 16:02:17 -0800 Oops s/Perter/Peter/. 561734 10 128154 kalevlember 2012-02-22 01:21:40 -0800 Created attachment 128154 Patch v3 Thanks! Updated the patch title as requested. 562278 11 128154 webkit.review.bot 2012-02-22 12:51:15 -0800 Comment on attachment 128154 Patch v3 Clearing flags on attachment: 128154 Committed r108540: <http://trac.webkit.org/changeset/108540> 562279 12 webkit.review.bot 2012-02-22 12:51:23 -0800 All reviewed patches have been landed. Closing bug. 125376 2012-02-03 11:44:14 -0800 2012-02-20 23:22:57 -0800 Explicitly include unistd.h in TestNetscapePlugIn 0002-Explicitly-include-unistd.h-in-TestNetscapePlugIn.patch text/plain 2017 kalevlember RnJvbSAwYzRiMzI2ZGM3ODgxMzI0ZDM1M2E0YjkwOTRjYjczZDcwMGE5MTM3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLYWxldiBMZW1iZXIgPGthbGV2bGVtYmVyQGdtYWlsLmNvbT4K RGF0ZTogRnJpLCAzIEZlYiAyMDEyIDIxOjI0OjQ2ICswMjAwClN1YmplY3Q6IFtQQVRDSCAyLzNd IEV4cGxpY2l0bHkgaW5jbHVkZSB1bmlzdGQuaCBpbiBUZXN0TmV0c2NhcGVQbHVnSW4KCkZpeGVz IGJ1aWxkIHdpdGggZ2NjIDQuNy4KCnIxMDA0MzIgYWRkZWQgdGhlIGluY2x1ZGUgb25seSBmb3Ig QU5EUk9JRDsgdGhpcyBjaGFuZ2VzIHRoZSBpZmRlZiB0bwpjb3ZlciBhbGwgdW5peCBwbGF0Zm9y bXMuIE9uIEZlZG9yYSAxNyB0aGUgZ2NjIDQuNyBjb21waWxlciBubyBsb25nZXIKaW1wbGljaXRs eSBpbmNsdWRlcyB1bmlzdGQuaCBmcm9tIHN0YW5kYXJkIGhlYWRlcnMgYW5kIG90aGVyIHVuaXgK cGxhdGZvcm1zIGFyZSBsaWtlbHkgdG8gZ2V0IGdjYyA0LjcgYXMgd2VsbCBpbiB0aGUgZnV0dXJl LgotLS0KIFRvb2xzL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IHwgICAxNiArKysrKysrKysrKysrKysrCiAuLi4vVGVzdE5ldHNjYXBlUGx1Z0luL1BsdWdpblRl c3QuY3BwICAgICAgICAgICAgICB8ICAgIDIgKy0KIDIgZmlsZXMgY2hhbmdlZCwgMTcgaW5zZXJ0 aW9ucygrKSwgMSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9U b29scy9DaGFuZ2VMb2cKaW5kZXggYjkxMGMxOC4uMGE2ZGRhYSAxMDA2NDQKLS0tIGEvVG9vbHMv Q2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTAy LTAzICBLYWxldiBMZW1iZXIgIDxrYWxldmxlbWJlckBnbWFpbC5jb20+CisKKyAgICAgICAgRXhw bGljaXRseSBpbmNsdWRlIHVuaXN0ZC5oIGluIFRlc3ROZXRzY2FwZVBsdWdJbgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Nzc3NTkKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXhlcyBidWlsZCB3aXRoIGdj YyA0LjcuCisKKyAgICAgICAgcjEwMDQzMiBhZGRlZCB0aGUgaW5jbHVkZSBvbmx5IGZvciBBTkRS T0lEOyB0aGlzIGNoYW5nZXMgdGhlIGlmZGVmIHRvCisgICAgICAgIGNvdmVyIGFsbCB1bml4IHBs YXRmb3Jtcy4gT24gRmVkb3JhIDE3IHRoZSBnY2MgNC43IGNvbXBpbGVyIG5vIGxvbmdlcgorICAg ICAgICBpbXBsaWNpdGx5IGluY2x1ZGVzIHVuaXN0ZC5oIGZyb20gc3RhbmRhcmQgaGVhZGVycyBh bmQgb3RoZXIgdW5peAorICAgICAgICBwbGF0Zm9ybXMgYXJlIGxpa2VseSB0byBnZXQgZ2NjIDQu NyBhcyB3ZWxsIGluIHRoZSBmdXR1cmUuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9UZXN0 TmV0c2NhcGVQbHVnSW4vUGx1Z2luVGVzdC5jcHA6CisKIDIwMTItMDItMDMgIFNpbW9uIEhhdXNt YW5uICA8c2ltb24uaGF1c21hbm5Abm9raWEuY29tPgogCiAgICAgICAgIFtRdF0gUmVwbGFjZSBH TlUgbGlua2VyIHNjcmlwdCBmb3IgZXhwb3J0cyB3aXRoIGV4cG9ydCBtYWNyb3MgaW4gV1RGL0pT QwpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvVGVzdE5ldHNjYXBlUGx1Z0luL1Bs dWdpblRlc3QuY3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvVGVzdE5ldHNjYXBlUGx1Z0luL1Bs dWdpblRlc3QuY3BwCmluZGV4IDk4OWUxNmQuLmY4NzA0NDMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1 bXBSZW5kZXJUcmVlL1Rlc3ROZXRzY2FwZVBsdWdJbi9QbHVnaW5UZXN0LmNwcAorKysgYi9Ub29s cy9EdW1wUmVuZGVyVHJlZS9UZXN0TmV0c2NhcGVQbHVnSW4vUGx1Z2luVGVzdC5jcHAKQEAgLTI5 LDcgKzI5LDcgQEAKICNpbmNsdWRlIDxhc3NlcnQuaD4KICNpbmNsdWRlIDxzdHJpbmcuaD4KIAot I2lmIGRlZmluZWQoQU5EUk9JRCkKKyNpZmRlZiBYUF9VTklYCiAjaW5jbHVkZSA8dW5pc3RkLmg+ CiAjZW5kaWYKIAotLSAKMS43LjkKCg== 127925 2012-02-20 23:22:57 -0800 2012-02-22 01:21:40 -0800 Patch v2 webkit-unistd.h text/plain 1303 kalevlember ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBmZmFl ODc4Li5kNmRjOGU1IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTItMDItMDMgIEthbGV2IExlbWJlciAgPGthbGV2 bGVtYmVyQGdtYWlsLmNvbT4KKworICAgICAgICBFeHBsaWNpdGx5IGluY2x1ZGUgdW5pc3RkLmgg aW4gVGVzdE5ldHNjYXBlUGx1Z0luCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD03Nzc1OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEZpeGVzIGJ1aWxkIHdpdGggZ2NjIDQuNy4KKworICAgICAgICByMTAwNDMy IGFkZGVkIHRoZSBpbmNsdWRlIG9ubHkgZm9yIEFORFJPSUQ7IHRoaXMgY2hhbmdlcyB0aGUgaWZk ZWYgdG8KKyAgICAgICAgYWxzbyBjb3ZlciBvdGhlciB1bml4IHBsYXRmb3Jtcy4gT24gRmVkb3Jh IDE3IHRoZSBnY2MgNC43IGNvbXBpbGVyIG5vCisgICAgICAgIGxvbmdlciBpbXBsaWNpdGx5IGlu Y2x1ZGVzIHVuaXN0ZC5oIGZyb20gc3RhbmRhcmQgaGVhZGVycyBhbmQgb3RoZXIKKyAgICAgICAg dW5peCBwbGF0Zm9ybXMgYXJlIGxpa2VseSB0byBnZXQgZ2NjIDQuNyBhcyB3ZWxsIGluIHRoZSBm dXR1cmUuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9UZXN0TmV0c2NhcGVQbHVnSW4vUGx1 Z2luVGVzdC5jcHA6CisKIDIwMTItMDItMTkgIEp1bmdKaWsgTGVlICA8anVuZ2ppay5sZWVAc2Ft c3VuZy5jb20+CiAKICAgICAgICAgW0VGTF0gVXNlIG1vZGlmaWVyIGtleXMgdG8gZXhlY3V0ZSBw cmUtcmVuZGVyaW5nLgpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvVGVzdE5ldHNj YXBlUGx1Z0luL1BsdWdpblRlc3QuY3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvVGVzdE5ldHNj YXBlUGx1Z0luL1BsdWdpblRlc3QuY3BwCmluZGV4IDk4OWUxNmQuLjY1ZGNhZWMgMTAwNjQ0Ci0t LSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL1Rlc3ROZXRzY2FwZVBsdWdJbi9QbHVnaW5UZXN0LmNw cAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9UZXN0TmV0c2NhcGVQbHVnSW4vUGx1Z2luVGVz dC5jcHAKQEAgLTI5LDcgKzI5LDcgQEAKICNpbmNsdWRlIDxhc3NlcnQuaD4KICNpbmNsdWRlIDxz dHJpbmcuaD4KIAotI2lmIGRlZmluZWQoQU5EUk9JRCkKKyNpZiBkZWZpbmVkKFhQX1VOSVgpIHx8 IGRlZmluZWQoQU5EUk9JRCkKICNpbmNsdWRlIDx1bmlzdGQuaD4KICNlbmRpZgogCg== 128154 2012-02-22 01:21:40 -0800 2012-02-22 12:51:15 -0800 Patch v3 webkit-unistd3.patch text/plain 1315 kalevlember ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBmZmFl ODc4Li5kNmRjOGU1IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTItMDItMDMgIEthbGV2IExlbWJlciAgPGthbGV2 bGVtYmVyQGdtYWlsLmNvbT4KKworICAgICAgICBFeHBsaWNpdGx5IGluY2x1ZGUgdW5pc3RkLmgg aW4gVGVzdE5ldHNjYXBlUGx1Z0luIGZvciBHQ0MgNC43CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03Nzc1OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeGVzIGJ1aWxkIHdpdGggZ2NjIDQuNy4KKworICAg ICAgICByMTAwNDMyIGFkZGVkIHRoZSBpbmNsdWRlIG9ubHkgZm9yIEFORFJPSUQ7IHRoaXMgY2hh bmdlcyB0aGUgaWZkZWYgdG8KKyAgICAgICAgYWxzbyBjb3ZlciBvdGhlciB1bml4IHBsYXRmb3Jt cy4gT24gRmVkb3JhIDE3IHRoZSBnY2MgNC43IGNvbXBpbGVyIG5vCisgICAgICAgIGxvbmdlciBp bXBsaWNpdGx5IGluY2x1ZGVzIHVuaXN0ZC5oIGZyb20gc3RhbmRhcmQgaGVhZGVycyBhbmQgb3Ro ZXIKKyAgICAgICAgdW5peCBwbGF0Zm9ybXMgYXJlIGxpa2VseSB0byBnZXQgZ2NjIDQuNyBhcyB3 ZWxsIGluIHRoZSBmdXR1cmUuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9UZXN0TmV0c2Nh cGVQbHVnSW4vUGx1Z2luVGVzdC5jcHA6CisKIDIwMTItMDItMTkgIEp1bmdKaWsgTGVlICA8anVu Z2ppay5sZWVAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0VGTF0gVXNlIG1vZGlmaWVyIGtleXMg dG8gZXhlY3V0ZSBwcmUtcmVuZGVyaW5nLgpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRy ZWUvVGVzdE5ldHNjYXBlUGx1Z0luL1BsdWdpblRlc3QuY3BwIGIvVG9vbHMvRHVtcFJlbmRlclRy ZWUvVGVzdE5ldHNjYXBlUGx1Z0luL1BsdWdpblRlc3QuY3BwCmluZGV4IDk4OWUxNmQuLjY1ZGNh ZWMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL1Rlc3ROZXRzY2FwZVBsdWdJbi9Q bHVnaW5UZXN0LmNwcAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9UZXN0TmV0c2NhcGVQbHVn SW4vUGx1Z2luVGVzdC5jcHAKQEAgLTI5LDcgKzI5LDcgQEAKICNpbmNsdWRlIDxhc3NlcnQuaD4K ICNpbmNsdWRlIDxzdHJpbmcuaD4KIAotI2lmIGRlZmluZWQoQU5EUk9JRCkKKyNpZiBkZWZpbmVk KFhQX1VOSVgpIHx8IGRlZmluZWQoQU5EUk9JRCkKICNpbmNsdWRlIDx1bmlzdGQuaD4KICNlbmRp ZgogCg==