77757 2012-02-03 11:37:57 -0800 configure: Two tests are displayed on the same line 2012-02-03 13:13:35 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 kalevlember webkit-unassigned webkit.review.bot oldest_to_newest 548897 0 kalevlember 2012-02-03 11:37:57 -0800 The -Wno-c++0x-compat test doesn't print out "yes" or "no" and the following test continues on the same line. checking if we have to disable C++0x compat warnings for GCC >= 4.6.0... checking pthread.h usability... yes 548899 1 125373 kalevlember 2012-02-03 11:39:59 -0800 Created attachment 125373 configure: Print out the -Wno-c++0x-compat test result The check whether -Wno-c++0x-compat flag is needed didn't print out the test result (and newline), which caused the following test to be displayed on the same line. 548967 2 125373 mrobinson 2012-02-03 12:53:07 -0800 Comment on attachment 125373 configure: Print out the -Wno-c++0x-compat test result View in context: https://bugs.webkit.org/attachment.cgi?id=125373&action=review > configure.ac:121 > -CXXFLAGS="$TMPCXXFLAGS", CXXFLAGS="$TMPCXXFLAGS -Wno-c++0x-compat") > +disable_cxx0x_compat=no, > +disable_cxx0x_compat=yes) > +AC_MSG_RESULT($disable_cxx0x_compat) > +if test "$disable_cxx0x_compat" = yes; then > + CXXFLAGS="$TMPCXXFLAGS -Wno-c++0x-compat" > +else > + CXXFLAGS="$TMPCXXFLAGS" > +fi Would it be sufficient here to simply add AC_MSG_RESULT 549000 3 125373 webkit.review.bot 2012-02-03 13:13:31 -0800 Comment on attachment 125373 configure: Print out the -Wno-c++0x-compat test result Clearing flags on attachment: 125373 Committed r106688: <http://trac.webkit.org/changeset/106688> 549001 4 webkit.review.bot 2012-02-03 13:13:35 -0800 All reviewed patches have been landed. Closing bug. 125373 2012-02-03 11:39:59 -0800 2012-02-03 13:13:31 -0800 configure: Print out the -Wno-c++0x-compat test result 0001-configure-Print-out-the-Wno-c-0x-compat-test-result.patch text/plain 1992 kalevlember RnJvbSBjNTRiYzZiMDE0MTg3YzE4YjcyZDVkODQ4MmZmNWFhNjNjYzI5YWRiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLYWxldiBMZW1iZXIgPGthbGV2bGVtYmVyQGdtYWlsLmNvbT4K RGF0ZTogRnJpLCAzIEZlYiAyMDEyIDIxOjE4OjU4ICswMjAwClN1YmplY3Q6IFtQQVRDSCAxLzNd IGNvbmZpZ3VyZTogUHJpbnQgb3V0IHRoZSAtV25vLWMrKzB4LWNvbXBhdCB0ZXN0IHJlc3VsdAoK VGhlIGNoZWNrIHdoZXRoZXIgLVduby1jKysweC1jb21wYXQgZmxhZyBpcyBuZWVkZWQgZGlkbid0 IHByaW50IG91dCB0aGUKdGVzdCByZXN1bHQgKGFuZCBuZXdsaW5lKSwgd2hpY2ggY2F1c2VkIHRo ZSBmb2xsb3dpbmcgdGVzdCB0byBiZQpkaXNwbGF5ZWQgb24gdGhlIHNhbWUgbGluZS4KCmNoZWNr aW5nIGlmIHdlIGhhdmUgdG8gZGlzYWJsZSBDKysweCBjb21wYXQgd2FybmluZ3MgZm9yIEdDQyA+ PSA0LjYuMC4uLiBjaGVja2luZyBwdGhyZWFkLmggdXNhYmlsaXR5Li4uIHllcwotLS0KIENoYW5n ZUxvZyAgICB8ICAgMTUgKysrKysrKysrKysrKysrCiBjb25maWd1cmUuYWMgfCAgICA5ICsrKysr KysrLQogMiBmaWxlcyBjaGFuZ2VkLCAyMyBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9ucygtKQoK ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAwY2UyNWUzLi43MjczMzU1 IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAK KzIwMTItMDItMDMgIEthbGV2IExlbWJlciAgPGthbGV2bGVtYmVyQGdtYWlsLmNvbT4KKworICAg ICAgICBbR1RLXSBjb25maWd1cmU6IFByaW50IG91dCB0aGUgLVduby1jKysweC1jb21wYXQgdGVz dCByZXN1bHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTc3NzU3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg VGhlIGNoZWNrIHdoZXRoZXIgLVduby1jKysweC1jb21wYXQgZmxhZyBpcyBuZWVkZWQgZGlkbid0 IHByaW50IG91dAorICAgICAgICB0aGUgdGVzdCByZXN1bHQgKGFuZCBuZXdsaW5lKSwgd2hpY2gg Y2F1c2VkIHRoZSBmb2xsb3dpbmcgdGVzdCB0byBiZQorICAgICAgICBkaXNwbGF5ZWQgb24gdGhl IHNhbWUgbGluZS4KKworICAgICAgICBjaGVja2luZyBpZiB3ZSBoYXZlIHRvIGRpc2FibGUgQysr MHggY29tcGF0IHdhcm5pbmdzIGZvciBHQ0MgPj0gNC42LjAuLi4gY2hlY2tpbmcgcHRocmVhZC5o IHVzYWJpbGl0eS4uLiB5ZXMKKworICAgICAgICAqIGNvbmZpZ3VyZS5hYzoKKwogMjAxMi0wMi0w MyAgU2ltb24gSGF1c21hbm4gIDxzaW1vbi5oYXVzbWFubkBub2tpYS5jb20+CiAKICAgICAgICAg W1F0XSBSZXBsYWNlIEdOVSBsaW5rZXIgc2NyaXB0IGZvciBleHBvcnRzIHdpdGggZXhwb3J0IG1h Y3JvcyBpbiBXVEYvSlNDCmRpZmYgLS1naXQgYS9jb25maWd1cmUuYWMgYi9jb25maWd1cmUuYWMK aW5kZXggZWQ5NWYwNi4uOGMxZTNkNSAxMDA2NDQKLS0tIGEvY29uZmlndXJlLmFjCisrKyBiL2Nv bmZpZ3VyZS5hYwpAQCAtMTExLDcgKzExMSwxNCBAQCBuYW1lc3BhY2Ugc3RkIHsKIH0KIGV4dGVy biBzdGQ6Om51bGxwdHJfdCBudWxscHRyOwogXSwgW3JldHVybiAwO10sCi1DWFhGTEFHUz0iJFRN UENYWEZMQUdTIiwgQ1hYRkxBR1M9IiRUTVBDWFhGTEFHUyAtV25vLWMrKzB4LWNvbXBhdCIpCitk aXNhYmxlX2N4eDB4X2NvbXBhdD1ubywKK2Rpc2FibGVfY3h4MHhfY29tcGF0PXllcykKK0FDX01T R19SRVNVTFQoJGRpc2FibGVfY3h4MHhfY29tcGF0KQoraWYgdGVzdCAiJGRpc2FibGVfY3h4MHhf Y29tcGF0IiA9IHllczsgdGhlbgorICBDWFhGTEFHUz0iJFRNUENYWEZMQUdTIC1Xbm8tYysrMHgt Y29tcGF0IgorZWxzZQorICBDWFhGTEFHUz0iJFRNUENYWEZMQUdTIgorZmkKIEFDX0xBTkdfUE9Q KEMrKykKIAogIyBwdGhyZWFkIChub3QgbmVlZGVkIG9uIFdpbmRvd3MpCi0tIAoxLjcuOQoK