77744 2012-02-03 09:20:47 -0800 check-webkit-style is throwing an exception 2012-02-04 01:51:10 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pdr ojan abarth dpranke eric levin ojan webkit.review.bot oldest_to_newest 548780 0 pdr 2012-02-03 09:20:47 -0800 On a clean checkout, make a minor change to any test_expectation file and then run check-webkit-style. You'll get the following error: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1 Traceback (most recent call last): File "Tools/Scripts/check-webkit-style", line 48, in <module> sys.exit(CheckWebKitStyle().main()) File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/main.py", line 154, in main patch_checker.check(patch) File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/patchreader.py", line 66, in check self._text_file_reader.process_file(file_path=path, line_numbers=line_numbers) File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/filereader.py", line 130, in process_file self._processor.process(lines, file_path, **kwargs) File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/checker.py", line 826, in process checker.check(lines) File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/checkers/test_expectations.py", line 117, in check overrides=overrides) File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/checkers/test_expectations.py", line 96, in check_test_expectations is_lint_mode=True, overrides=overrides) File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py", line 721, in __init__ self._add_skipped_tests(port.skipped_tests(tests)) File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/layout_tests/port/webkit.py", line 376, in skipped_tests return self.skipped_layout_tests(test_list) File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/layout_tests/port/webkit.py", line 372, in skipped_layout_tests tests_to_skip.update(self._skipped_tests_for_unsupported_features(test_list)) File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/layout_tests/port/webkit.py", line 319, in _skipped_tests_for_unsupported_features if self._has_test_in_directories(self._missing_feature_to_skipped_tests().values(), test_list): File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/layout_tests/port/webkit.py", line 311, in _has_test_in_directories for directory, test in itertools.product(directories, test_list): TypeError: 'NoneType' object is not iterable This same output can be seen on various bugs, for instance: https://bugs.webkit.org/show_bug.cgi?id=77067 https://bugs.webkit.org/show_bug.cgi?id=77245 548944 1 eric 2012-02-03 12:26:12 -0800 Sounds like this is a regression from yesterday? 548945 2 eric 2012-02-03 12:26:45 -0800 Likely from Ojan's changes to speed up NRWT. 549172 3 125437 ojan 2012-02-03 15:43:55 -0800 Created attachment 125437 Patch 549179 4 125437 levin 2012-02-03 15:47:43 -0800 Comment on attachment 125437 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125437&action=review > Tools/Scripts/webkitpy/layout_tests/port/webkit.py:313 > directories = itertools.chain.from_iterable(directory_lists) Would it make sense to make itertools.product return [] in this case, so every place that uses it just works when "not test_list"? 549197 5 ojan 2012-02-03 15:59:19 -0800 (In reply to comment #4) > (From update of attachment 125437 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=125437&action=review > > > Tools/Scripts/webkitpy/layout_tests/port/webkit.py:313 > > directories = itertools.chain.from_iterable(directory_lists) > > Would it make sense to make itertools.product return [] in this case, so every place that uses it just works when "not test_list"? It might, but it's a python library, so... :) 549406 6 125437 webkit.review.bot 2012-02-04 01:51:04 -0800 Comment on attachment 125437 Patch Clearing flags on attachment: 125437 Committed r106735: <http://trac.webkit.org/changeset/106735> 549407 7 webkit.review.bot 2012-02-04 01:51:10 -0800 All reviewed patches have been landed. Closing bug. 125437 2012-02-03 15:43:55 -0800 2012-02-04 01:51:04 -0800 Patch bug-77744-20120203154353.patch text/plain 2818 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2Njc0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMWQ3YjcxOTFjYzk4OWQ4NTU5Yzg2MGMwMDk5M2NhN2Iw M2Y5YTY1Ny4uZjUwZDU3NDYxMWU1ZjcyMzc2YTkxOGVlODYzODZjN2RjNTczZWQ5NCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDEyLTAyLTAzICBPamFuIFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CisKKyAgICAg ICAgY2hlY2std2Via2l0LXN0eWxlIGlzIHRocm93aW5nIGFuIGV4Y2VwdGlvbgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Nzc3NDQKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJZiB0aGUgdGVzdF9saXN0IGlz IE5vbmUsIHRoZW4gd2UgZG9uJ3QgbmVlZCB0byBjaGVjayBmb3IgdW5zdXBwb3J0ZWQKKyAgICAg ICAgZmVhdHVyZSB0ZXN0cyB0byBza2lwLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9s YXlvdXRfdGVzdHMvcG9ydC93ZWJraXQucHk6CisgICAgICAgIChXZWJLaXRQb3J0Ll9oYXNfdGVz dF9pbl9kaXJlY3Rvcmllcyk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVz dHMvcG9ydC93ZWJraXRfdW5pdHRlc3QucHk6CisgICAgICAgICh0ZXN0X3NraXBwZWRfdGVzdHNf Zm9yX3Vuc3VwcG9ydGVkX2ZlYXR1cmVzX2VtcHR5X3Rlc3RfbGlzdCk6CisKIDIwMTItMDItMDMg IEpvY2VseW4gVHVyY290dGUgIDxqb2NlbHluLnR1cmNvdHRlQG5va2lhLmNvbT4KIAogICAgICAg ICBbUXRdIFNwbGl0IFFRdWlja1dlYlZpZXdQcml2YXRlIGluIHR3byBjbGFzc2VzLCBmb3IgZGVz a3RvcCBhbmQgdG91Y2ggYmVoYXZpb3IuCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYmtpdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv bGF5b3V0X3Rlc3RzL3BvcnQvd2Via2l0LnB5CmluZGV4IDZmNzk2N2VmZTEwOTAxYWY2MmFmMzg4 MzY5NjE4NGY2ZjYzMTc4YWUuLjFjNzgwNTM1OTI2OGMzNjc5YmY5ZGVjYTE3ZDIxNDU3NjU1OTI5 YjggMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQv d2Via2l0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQv d2Via2l0LnB5CkBAIC0zMDcsNiArMzA3LDkgQEAgY2xhc3MgV2ViS2l0UG9ydChQb3J0KToKICAg ICAgICAgfQogCiAgICAgZGVmIF9oYXNfdGVzdF9pbl9kaXJlY3RvcmllcyhzZWxmLCBkaXJlY3Rv cnlfbGlzdHMsIHRlc3RfbGlzdCk6CisgICAgICAgIGlmIG5vdCB0ZXN0X2xpc3Q6CisgICAgICAg ICAgICByZXR1cm4gRmFsc2UKKwogICAgICAgICBkaXJlY3RvcmllcyA9IGl0ZXJ0b29scy5jaGFp bi5mcm9tX2l0ZXJhYmxlKGRpcmVjdG9yeV9saXN0cykKICAgICAgICAgZm9yIGRpcmVjdG9yeSwg dGVzdCBpbiBpdGVydG9vbHMucHJvZHVjdChkaXJlY3RvcmllcywgdGVzdF9saXN0KToKICAgICAg ICAgICAgIGlmIHRlc3Quc3RhcnRzd2l0aChkaXJlY3RvcnkpOgpkaWZmIC0tZ2l0IGEvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC93ZWJraXRfdW5pdHRlc3QucHkgYi9U b29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYmtpdF91bml0dGVzdC5w eQppbmRleCBhOGNjOGU1YjgxNmNkYTcxMjAwZTNjZTMyNTA3NmRlMDIwZmE2M2RkLi5mZmFhZTZl Yjc2NTViODk5M2JlNGE1MTlkOGE1YzNlOTIxZmRhZjg0IDEwMDc1NQotLS0gYS9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYmtpdF91bml0dGVzdC5weQorKysgYi9U b29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYmtpdF91bml0dGVzdC5w eQpAQCAtMTQ1LDYgKzE0NSwxMiBAQCBjbGFzcyBXZWJLaXRQb3J0VGVzdChwb3J0X3Rlc3RjYXNl LlBvcnRUZXN0Q2FzZSk6CiAgICAgICAgIHJlc3VsdF9kaXJlY3RvcmllcyA9IHNldChUZXN0V2Vi S2l0UG9ydChOb25lLCBzdXBwb3J0ZWRfZmVhdHVyZXMpLl9za2lwcGVkX3Rlc3RzX2Zvcl91bnN1 cHBvcnRlZF9mZWF0dXJlcyh0ZXN0X2xpc3Q9Wydmb28uaHRtbCddKSkKICAgICAgICAgc2VsZi5h c3NlcnRFcXVhbChyZXN1bHRfZGlyZWN0b3JpZXMsIGV4cGVjdGVkX2RpcmVjdG9yaWVzKQogCisg ICAgZGVmIHRlc3Rfc2tpcHBlZF90ZXN0c19mb3JfdW5zdXBwb3J0ZWRfZmVhdHVyZXNfZW1wdHlf dGVzdF9saXN0KHNlbGYpOgorICAgICAgICBzdXBwb3J0ZWRfZmVhdHVyZXMgPSBbIkFjY2VsZXJh dGVkIENvbXBvc2l0aW5nIiwgIkZvbyBGZWF0dXJlIl0KKyAgICAgICAgZXhwZWN0ZWRfZGlyZWN0 b3JpZXMgPSBzZXQoW10pCisgICAgICAgIHJlc3VsdF9kaXJlY3RvcmllcyA9IHNldChUZXN0V2Vi S2l0UG9ydChOb25lLCBzdXBwb3J0ZWRfZmVhdHVyZXMpLl9za2lwcGVkX3Rlc3RzX2Zvcl91bnN1 cHBvcnRlZF9mZWF0dXJlcyh0ZXN0X2xpc3Q9Tm9uZSkpCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1 YWwocmVzdWx0X2RpcmVjdG9yaWVzLCBleHBlY3RlZF9kaXJlY3RvcmllcykKKwogICAgIGRlZiB0 ZXN0X3NraXBwZWRfbGF5b3V0X3Rlc3RzKHNlbGYpOgogICAgICAgICBzZWxmLmFzc2VydEVxdWFs KFRlc3RXZWJLaXRQb3J0KE5vbmUsIE5vbmUpLnNraXBwZWRfbGF5b3V0X3Rlc3RzKHRlc3RfbGlz dD1bXSksIHNldChbJ21lZGlhJ10pKQogCg==