77733 2012-02-03 06:38:13 -0800 [Chromium] Context menu on password field should not have search options 2012-02-08 12:16:40 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bauerb webkit-unassigned bauerb jochen webkit.review.bot oldest_to_newest 548671 0 bauerb 2012-02-03 06:38:13 -0800 [Chromium] Context menu on password field should not have search options 548673 1 125317 bauerb 2012-02-03 06:39:26 -0800 Created attachment 125317 Patch 548675 2 bauerb 2012-02-03 06:41:23 -0800 See http://crbug.com/112498: "The context menu when selecting text in an input type=password field has an option to use "Search Google For"; that option should not be there. It simply searches google for a few dot characters." 549985 3 jochen 2012-02-06 07:27:35 -0800 LGTM 550272 4 125317 abarth 2012-02-06 14:10:55 -0800 Comment on attachment 125317 Patch Should we write a unit test for this bug? Maybe we should have a test in Chromium-land for it? 550279 5 bauerb 2012-02-06 14:20:54 -0800 TBH, I'm not sure how we would write a non-flaky (in the way that interactive_ui_tests is flaky) test for this :-/ 552347 6 125317 jochen 2012-02-08 11:50:39 -0800 Comment on attachment 125317 Patch I guess it should be possible to write a non-flaky browser test in chromium for this 552348 7 bauerb 2012-02-08 11:51:47 -0800 SGTM. 552376 8 125317 webkit.review.bot 2012-02-08 12:16:36 -0800 Comment on attachment 125317 Patch Clearing flags on attachment: 125317 Committed r107115: <http://trac.webkit.org/changeset/107115> 552377 9 webkit.review.bot 2012-02-08 12:16:40 -0800 All reviewed patches have been landed. Closing bug. 125317 2012-02-03 06:39:26 -0800 2012-02-08 12:16:36 -0800 Patch bug-77733-20120203153923.patch text/plain 1729 bauerb U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2NTY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGM0N2Q2YWVkNzY1MTQ2ZWQ4N2IwZGU5NzFiNjI3OTJmNjUwMjViMWQuLjg4MjMxOTQ2ZGRiNzg1 YWVjN2QyOTY4OGE3ZmRhZDEwOGNhZDI5ZGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTItMDItMDMgIEJlcm5oYXJkIEJhdWVyICA8YmF1ZXJiQGdvb2ds ZS5jb20+CisKKyAgICAgICAgW0Nocm9taXVtXSBEb24ndCBhZGQgc2VsZWN0aW9uIGZyb20gcGFz c3dvcmQgZmllbGRzIHRvIGNvbnRleHQgbWVudS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTc3NzMzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBzcmMvQ29udGV4dE1lbnVDbGllbnRJbXBsLmNwcDoKKyAg ICAgICAgKFdlYktpdDo6Q29udGV4dE1lbnVDbGllbnRJbXBsOjpnZXRDdXN0b21NZW51RnJvbURl ZmF1bHRJdGVtcyk6CisKIDIwMTItMDItMDIgIEFsbGFuIFNhbmRmZWxkIEplbnNlbiAgPGFsbGFu LmplbnNlbkBub2tpYS5jb20+CiAKICAgICAgICAgVXBkYXRlIGVudW0gbmFtZSBmb3IgSGl0VGVz dFJlcXVlc3Q6OlJlcXVlc3RUeXBlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L3NyYy9Db250ZXh0TWVudUNsaWVudEltcGwuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9z cmMvQ29udGV4dE1lbnVDbGllbnRJbXBsLmNwcAppbmRleCBjZGNlYjA3NjM3YWRkYTY1NTNjOWY0 Nzg3ODJkMWIwOWM0ZTFlYjUyLi43OTBhOWM1MmJkY2M4MDE4MjEwZGYxNWU2YWEzMjZjYjQ5Zjlk YWY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9Db250ZXh0TWVudUNs aWVudEltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0NvbnRleHRNZW51 Q2xpZW50SW1wbC5jcHAKQEAgLTI1OSw4ICsyNTksMTAgQEAgUGxhdGZvcm1NZW51RGVzY3JpcHRp b24gQ29udGV4dE1lbnVDbGllbnRJbXBsOjpnZXRDdXN0b21NZW51RnJvbURlZmF1bHRJdGVtcygK ICAgICAgICAgICAgIGRhdGEuZnJhbWVIaXN0b3J5SXRlbSA9IFdlYkhpc3RvcnlJdGVtKGhpc3Rv cnlJdGVtKTsKICAgICB9CiAKLSAgICBpZiAoci5pc1NlbGVjdGVkKCkpCi0gICAgICAgIGRhdGEu c2VsZWN0ZWRUZXh0ID0gc2VsZWN0ZWRGcmFtZS0+ZWRpdG9yKCktPnNlbGVjdGVkVGV4dCgpLnN0 cmlwV2hpdGVTcGFjZSgpOworICAgIGlmIChyLmlzU2VsZWN0ZWQoKSkgeworICAgICAgICBpZiAo IXIuaW5uZXJOb25TaGFyZWROb2RlKCktPmhhc1RhZ05hbWUoSFRNTE5hbWVzOjppbnB1dFRhZykg fHwgIXN0YXRpY19jYXN0PEhUTUxJbnB1dEVsZW1lbnQqPihyLmlubmVyTm9uU2hhcmVkTm9kZSgp KS0+aXNQYXNzd29yZEZpZWxkKCkpCisgICAgICAgICAgICBkYXRhLnNlbGVjdGVkVGV4dCA9IHNl bGVjdGVkRnJhbWUtPmVkaXRvcigpLT5zZWxlY3RlZFRleHQoKS5zdHJpcFdoaXRlU3BhY2UoKTsK KyAgICB9CiAKICAgICBpZiAoci5pc0NvbnRlbnRFZGl0YWJsZSgpKSB7CiAgICAgICAgIGRhdGEu aXNFZGl0YWJsZSA9IHRydWU7Cg==