77712 2012-02-02 21:28:30 -0800 [JSC] Range of cache flush is not guaranteed by Linux kernel 2012-03-14 17:06:26 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Linux RESOLVED FIXED P2 Normal --- 0 hojong.han webkit-unassigned barraclough fpizlo ggaren hausmann loki msaboff webkit.review.bot zherczeg oldest_to_newest 548428 0 hojong.han 2012-02-02 21:28:30 -0800 Current MetaAllocator concept, always coalesces adjacent free spaces, doesn't meet memory management of Linux kernel. In a certain case Linux kernel doesn't regard contiguous virtual memory areas as one but two. Let's assume that mmap is called by MetaAllocator three times like below. 1. 8KB allocated from 0x41000000 to 0x41002000 by the 1st mmap call 2. 8KB allocated from 0x41004000 to 0x41006000 by the 2nd mmap call 3. 8KB allocated from 0x41002000 to 0x41004000 by the 3rd mmap call These virtual memory areas(VMAs) above are contiguous from 0x41000000 to 0x41006000, but the kernel merges only the third allocated 8KB with the first allocated 8KB although the second one is adjacent to the third. Because newly allocated VMA can be coalesced with the previously allocated and it's not allowed between previously allocated VMAs which internally have different information about annoymous pages. But current MetaAllocator is not considered on this kernel operation, thereby it just coalesces adjacent spaces when those are freed. This different mergence operation between MetaAllocator and Linux kernel finally causes the problem during cache flush. MetaAllocator hands over coalesced free space that the kernel regards it just as parts of two separated VMAs. The free space, coalesced by MetaAllocator, will be filled with JIT and cache flush will be run before the execution. At that time the flush range of the coalesced space is not guaranteed by kernel. It means inconsistency of data and instruction cache, and nobody knows what happens when this JIT code runs. The bottom line is that routines, handling this kernel operation, is necessary in MetaAllocator. 574626 1 130982 hojong.han 2012-03-08 22:07:38 -0800 Created attachment 130982 Patch 574631 2 webkit.review.bot 2012-03-08 22:11:02 -0800 Attachment 130982 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/jit/ExecutableAllocator.h:202: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 574789 3 130982 wingo 2012-03-09 03:30:39 -0800 Comment on attachment 130982 Patch Is size_t the right type to use for startPage and endPage? It seems safer to use intptr_t or something. Also it seems to me that you would be better off doing uintptr_t start = reinterpret_cast<uintptr_t>(code) & ~(pageSize() - 1); and just adding pageSize() each round instead of doing the divide-and-multiply dance. Dunno. I'm not a reviewer, so please take these comments with a grain of salt. 574806 4 hojong.han 2012-03-09 04:14:04 -0800 (In reply to comment #3) > (From update of attachment 130982 [details]) > Is size_t the right type to use for startPage and endPage? It seems safer to use intptr_t or something. > > Also it seems to me that you would be better off doing > > uintptr_t start = reinterpret_cast<uintptr_t>(code) & ~(pageSize() - 1); > > and just adding pageSize() each round instead of doing the divide-and-multiply dance. Dunno. > > I'm not a reviewer, so please take these comments with a grain of salt. Thank you. It's really necessary salt for me. I'm going to put it into new patch. 575097 5 ggaren 2012-03-09 12:48:48 -0800 Phil, does this mean that munmap will eventually fail as well? 575099 6 fpizlo 2012-03-09 12:49:57 -0800 (In reply to comment #5) > Phil, does this mean that munmap will eventually fail as well? Nope. We munmap one page at a time. 575865 7 131264 hojong.han 2012-03-11 18:05:59 -0700 Created attachment 131264 Patch 575866 8 webkit.review.bot 2012-03-11 18:07:51 -0700 Attachment 131264 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/jit/ExecutableAllocator.h:202: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 575881 9 131268 hojong.han 2012-03-11 18:56:28 -0700 Created attachment 131268 Patch 575882 10 webkit.review.bot 2012-03-11 19:00:06 -0700 Attachment 131268 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/jit/ExecutableAllocator.h:202: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 576341 11 131268 ggaren 2012-03-12 11:45:54 -0700 Comment on attachment 131268 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=131268&action=review > Source/JavaScriptCore/jit/ExecutableAllocator.h:209 > + current = next; You can eliminate the "next" variable if you change this line to "current += pageSize()". > Source/JavaScriptCore/jit/ExecutableAllocator.h:211 > + } while (end >= current); In C++, "end" traditionally means one-past-the-end. That's not the case here, so I don't think you should use the word "end". I'd suggest "currentPage" and "lastPage" for variable names. 576928 12 131496 hojong.han 2012-03-12 19:35:42 -0700 Created attachment 131496 Patch 576932 13 webkit.review.bot 2012-03-12 19:38:23 -0700 Attachment 131496 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/jit/ExecutableAllocator.h:201: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 577111 14 hojong.han 2012-03-12 23:59:02 -0700 (In reply to comment #11) > (From update of attachment 131268 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=131268&action=review > > > Source/JavaScriptCore/jit/ExecutableAllocator.h:209 > > + current = next; > > You can eliminate the "next" variable if you change this line to "current += pageSize()". > > > Source/JavaScriptCore/jit/ExecutableAllocator.h:211 > > + } while (end >= current); > > In C++, "end" traditionally means one-past-the-end. That's not the case here, so I don't think you should use the word "end". > > I'd suggest "currentPage" and "lastPage" for variable names. Thanks for your kind comments. I reflect your advice. 578904 15 131496 ggaren 2012-03-14 16:26:12 -0700 Comment on attachment 131496 Patch r=me 578955 16 131496 webkit.review.bot 2012-03-14 17:06:20 -0700 Comment on attachment 131496 Patch Clearing flags on attachment: 131496 Committed r110792: <http://trac.webkit.org/changeset/110792> 578956 17 webkit.review.bot 2012-03-14 17:06:26 -0700 All reviewed patches have been landed. Closing bug. 130982 2012-03-08 22:07:38 -0800 2012-03-11 18:05:50 -0700 Patch bug-77712-20120309150734.patch text/plain 3109 hojong.han U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwMTQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAy OTVjMDE4N2MyYTI4N2VmMjQyNDJkYWVkOWJhZDg3NWY1MTIwMGQwLi5iMmEyZmFkMzcxZTc3Nzgx YmE5ZDY2OWVhNTllY2MzYjkxM2QyMjVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxMi0wMy0wOCAgSG9qb25nIEhhbiAgPGhvam9uZy5oYW5Ac2Ftc3VuZy5j b20+CisKKyAgICAgICAgUnVuIGNhY2hlRmx1c2ggcGFnZSBieSBwYWdlIHRvIGFzc3VyZSBvZiBm bHVzaGluZyBhbGwgdGhlIHJlcXVlc3RlZCByYW5nZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc3NzEyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQ3VycmVudCBNZXRhQWxsb2NhdG9yIGNvbmNlcHQsIGFs d2F5cyBjb2FsZXNjZXMgYWRqYWNlbnQgZnJlZSBzcGFjZXMsCisgICAgICAgIGRvZXNuJ3QgbWVl dCBtZW1vcnkgbWFuYWdlbWVudCBvZiBMaW51eCBrZXJuZWwuCisgICAgICAgIEluIGEgY2VydGFp biBjYXNlIExpbnV4IGtlcm5lbCBkb2Vzbid0IHJlZ2FyZCBjb250aWd1b3VzIHZpcnR1YWwgbWVt b3J5IGFyZWFzIGFzIG9uZSBidXQgdHdvLgorICAgICAgICBUaGVyZWZvcmUgY2FjaGVGbHVzaCBw YWdlIGJ5IHBhZ2UgZ3VhcmFudGVlcyBhIGZsdXNoLXJlcXVlc3RlZCByYW5nZS4KKworICAgICAg ICAqIGppdC9FeGVjdXRhYmxlQWxsb2NhdG9yLmg6CisgICAgICAgIChKU0M6OkV4ZWN1dGFibGVB bGxvY2F0b3I6OmNhY2hlRmx1c2gpOgorCiAyMDEyLTAzLTA3ICBTaGVyaWZmIEJvdCAgPHdlYmtp dC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91 dCByMTEwMTI3LgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9FeGVjdXRh YmxlQWxsb2NhdG9yLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0V4ZWN1dGFibGVBbGxv Y2F0b3IuaAppbmRleCAwYTA1ODMwY2QyMmNjOTYyZmFmZjg0Y2JlNDE1Zjg2ZjRiNzBlNzg0Li5i MjMxMDlkZGQ2OTVkNTkyNDA1ZWM4YjEwZDgxZmVmMzU5NmJhMDYyIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvaml0L0V4ZWN1dGFibGVBbGxvY2F0b3IuaAorKysgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvaml0L0V4ZWN1dGFibGVBbGxvY2F0b3IuaApAQCAtMTg5LDE4ICsxODks MjkgQEAgcHVibGljOgogI2VsaWYgQ1BVKEFSTV9UUkFESVRJT05BTCkgJiYgT1MoTElOVVgpICYm IENPTVBJTEVSKEdDQykKICAgICBzdGF0aWMgdm9pZCBjYWNoZUZsdXNoKHZvaWQqIGNvZGUsIHNp emVfdCBzaXplKQogICAgIHsKLSAgICAgICAgYXNtIHZvbGF0aWxlICgKLSAgICAgICAgICAgICJw dXNoICAgIHtyN31cbiIKLSAgICAgICAgICAgICJtb3YgICAgIHIwLCAlMFxuIgotICAgICAgICAg ICAgIm1vdiAgICAgcjEsICUxXG4iCi0gICAgICAgICAgICAibW92ICAgICByNywgIzB4ZjAwMDBc biIKLSAgICAgICAgICAgICJhZGQgICAgIHI3LCByNywgIzB4MlxuIgotICAgICAgICAgICAgIm1v diAgICAgcjIsICMweDBcbiIKLSAgICAgICAgICAgICJzdmMgICAgIDB4MFxuIgotICAgICAgICAg ICAgInBvcCAgICAge3I3fVxuIgotICAgICAgICAgICAgOgotICAgICAgICAgICAgOiAiciIgKGNv ZGUpLCAiciIgKHJlaW50ZXJwcmV0X2Nhc3Q8Y2hhcio+KGNvZGUpICsgc2l6ZSkKLSAgICAgICAg ICAgIDogInIwIiwgInIxIiwgInIyIik7CisgICAgICAgIHNpemVfdCBwYWdlQnl0ZXMgPSBwYWdl U2l6ZSgpOworICAgICAgICBzaXplX3Qgc3RhcnRQYWdlID0gKHJlaW50ZXJwcmV0X2Nhc3Q8c2l6 ZV90Pihjb2RlKSkgLyBwYWdlQnl0ZXM7CisgICAgICAgIHNpemVfdCBlbmRQYWdlID0gKHJlaW50 ZXJwcmV0X2Nhc3Q8c2l6ZV90PihyZWludGVycHJldF9jYXN0PGNoYXIqPihjb2RlKSArIHNpemUp KSAvIHBhZ2VCeXRlczsKKworICAgICAgICAvLyBDdXJyZW50IE1ldGFBbGxvY2F0b3IgY29uY2Vw dCwgYWx3YXlzIGNvYWxlc2NlcyBhZGphY2VudCBmcmVlIHNwYWNlcywKKyAgICAgICAgLy8gZG9l c24ndCBtZWV0IG1lbW9yeSBtYW5hZ2VtZW50IG9mIExpbnV4IGtlcm5lbC4KKyAgICAgICAgLy8g SW4gYSBjZXJ0YWluIGNhc2UgTGludXgga2VybmVsIGRvZXNuJ3QgcmVnYXJkIGNvbnRpZ3VvdXMg dmlydHVhbCBtZW1vcnkgYXJlYXMgYXMgb25lIGJ1dCB0d28uCisgICAgICAgIC8vIFJ1biBjYWNo ZUZsdXNoIHBhZ2UgYnkgcGFnZSB0byBhc3N1cmUgb2YgZmx1c2hpbmcgYWxsIHRoZSByZXF1ZXN0 ZWQgcmFuZ2VzLgorICAgICAgICBkbyB7CisgICAgICAgICAgICBjaGFyKiBzdGFydCA9IHJlaW50 ZXJwcmV0X2Nhc3Q8Y2hhcio+KHN0YXJ0UGFnZSAqIHBhZ2VCeXRlcyk7CisgICAgICAgICAgICBh c20gdm9sYXRpbGUgKAorICAgICAgICAgICAgICAgICJwdXNoICAgIHtyN31cbiIKKyAgICAgICAg ICAgICAgICAibW92ICAgICByMCwgJTBcbiIKKyAgICAgICAgICAgICAgICAibW92ICAgICByMSwg JTFcbiIKKyAgICAgICAgICAgICAgICAibW92ICAgICByNywgIzB4ZjAwMDBcbiIKKyAgICAgICAg ICAgICAgICAiYWRkICAgICByNywgcjcsICMweDJcbiIKKyAgICAgICAgICAgICAgICAibW92ICAg ICByMiwgIzB4MFxuIgorICAgICAgICAgICAgICAgICJzdmMgICAgIDB4MFxuIgorICAgICAgICAg ICAgICAgICJwb3AgICAgIHtyN31cbiIKKyAgICAgICAgICAgICAgICA6CisgICAgICAgICAgICAg ICAgOiAiciIgKHN0YXJ0KSwgInIiIChzdGFydCArIHBhZ2VCeXRlcykKKyAgICAgICAgICAgICAg ICA6ICJyMCIsICJyMSIsICJyMiIpOworICAgICAgICB9IHdoaWxlIChlbmRQYWdlID49ICgrK3N0 YXJ0UGFnZSkpOwogICAgIH0KICNlbGlmIE9TKFdJTkNFKQogICAgIHN0YXRpYyB2b2lkIGNhY2hl Rmx1c2godm9pZCogY29kZSwgc2l6ZV90IHNpemUpCg== 131264 2012-03-11 18:05:59 -0700 2012-03-11 18:56:20 -0700 Patch bug-77712-20120312100557.patch text/plain 2740 hojong.han U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwMTQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAy OTVjMDE4N2MyYTI4N2VmMjQyNDJkYWVkOWJhZDg3NWY1MTIwMGQwLi4wYzFmNGUzZGIxMTU2NmRk YTIxYjY1YWIwY2I1ODdjYmUxYTU5NmMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxMi0wMy0xMSAgSG9qb25nIEhhbiAgPGhvam9uZy5oYW5Ac2Ftc3VuZy5j b20+CisKKyAgICAgICAgUnVuIGNhY2hlRmx1c2ggcGFnZSBieSBwYWdlIHRvIGFzc3VyZSBvZiBm bHVzaGluZyBhbGwgdGhlIHJlcXVlc3RlZCByYW5nZXMgCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NzcxMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEN1cnJlbnQgTWV0YUFsbG9jYXRvciBjb25jZXB0LCBh bHdheXMgY29hbGVzY2VzIGFkamFjZW50IGZyZWUgc3BhY2VzLAorICAgICAgICBkb2Vzbid0IG1l ZXQgbWVtb3J5IG1hbmFnZW1lbnQgb2YgTGludXgga2VybmVsLgorICAgICAgICBJbiBhIGNlcnRh aW4gY2FzZSBMaW51eCBrZXJuZWwgZG9lc24ndCByZWdhcmQgY29udGlndW91cyB2aXJ0dWFsIG1l bW9yeSBhcmVhcyBhcyBvbmUgYnV0IHR3by4KKyAgICAgICAgVGhlcmVmb3JlIGNhY2hlRmx1c2gg cGFnZSBieSBwYWdlIGd1YXJhbnRlZXMgYSBmbHVzaC1yZXF1ZXN0ZWQgcmFuZ2UuCisKKyAgICAg ICAgKiBqaXQvRXhlY3V0YWJsZUFsbG9jYXRvci5oOgorICAgICAgICAoSlNDOjpFeGVjdXRhYmxl QWxsb2NhdG9yOjpjYWNoZUZsdXNoKToKKwogMjAxMi0wMy0wNyAgU2hlcmlmZiBCb3QgIDx3ZWJr aXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBv dXQgcjExMDEyNy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvRXhlY3V0 YWJsZUFsbG9jYXRvci5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9FeGVjdXRhYmxlQWxs b2NhdG9yLmgKaW5kZXggMGEwNTgzMGNkMjJjYzk2MmZhZmY4NGNiZTQxNWY4NmY0YjcwZTc4NC4u OGE1MmQ1MjRlMjgzMjE2MzcyNDBiNDgxNDdhN2Q5ZTk2ZGVkMWM4OSAxMDA2NDQKLS0tIGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9FeGVjdXRhYmxlQWxsb2NhdG9yLmgKKysrIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL2ppdC9FeGVjdXRhYmxlQWxsb2NhdG9yLmgKQEAgLTE4OSwxOCArMTg5 LDI2IEBAIHB1YmxpYzoKICNlbGlmIENQVShBUk1fVFJBRElUSU9OQUwpICYmIE9TKExJTlVYKSAm JiBDT01QSUxFUihHQ0MpCiAgICAgc3RhdGljIHZvaWQgY2FjaGVGbHVzaCh2b2lkKiBjb2RlLCBz aXplX3Qgc2l6ZSkKICAgICB7Ci0gICAgICAgIGFzbSB2b2xhdGlsZSAoCi0gICAgICAgICAgICAi cHVzaCAgICB7cjd9XG4iCi0gICAgICAgICAgICAibW92ICAgICByMCwgJTBcbiIKLSAgICAgICAg ICAgICJtb3YgICAgIHIxLCAlMVxuIgotICAgICAgICAgICAgIm1vdiAgICAgcjcsICMweGYwMDAw XG4iCi0gICAgICAgICAgICAiYWRkICAgICByNywgcjcsICMweDJcbiIKLSAgICAgICAgICAgICJt b3YgICAgIHIyLCAjMHgwXG4iCi0gICAgICAgICAgICAic3ZjICAgICAweDBcbiIKLSAgICAgICAg ICAgICJwb3AgICAgIHtyN31cbiIKLSAgICAgICAgICAgIDoKLSAgICAgICAgICAgIDogInIiIChj b2RlKSwgInIiIChyZWludGVycHJldF9jYXN0PGNoYXIqPihjb2RlKSArIHNpemUpCi0gICAgICAg ICAgICA6ICJyMCIsICJyMSIsICJyMiIpOworICAgICAgICB1aW50cHRyX3QgY3VycmVudCA9IHJl aW50ZXJwcmV0X2Nhc3Q8dWludHB0cl90Pihjb2RlKSAmIH4ocGFnZVNpemUoKSAtIDEpOworICAg ICAgICB1aW50cHRyX3QgZW5kID0gKHJlaW50ZXJwcmV0X2Nhc3Q8dWludHB0cl90Pihjb2RlKSAr IHNpemUpICYgfihwYWdlU2l6ZSgpIC0gMSk7CisgICAgICAgIHVpbnRwdHJfdCBuZXh0ID0gY3Vy cmVudCArIHBhZ2VTaXplKCk7CisKKyAgICAgICAgZG8geworICAgICAgICAgICAgYXNtIHZvbGF0 aWxlICgKKyAgICAgICAgICAgICAgICAicHVzaCAgICB7cjd9XG4iCisgICAgICAgICAgICAgICAg Im1vdiAgICAgcjAsICUwXG4iCisgICAgICAgICAgICAgICAgIm1vdiAgICAgcjEsICUxXG4iCisg ICAgICAgICAgICAgICAgIm1vdiAgICAgcjcsICMweGYwMDAwXG4iCisgICAgICAgICAgICAgICAg ImFkZCAgICAgcjcsIHI3LCAjMHgyXG4iCisgICAgICAgICAgICAgICAgIm1vdiAgICAgcjIsICMw eDBcbiIKKyAgICAgICAgICAgICAgICAic3ZjICAgICAweDBcbiIKKyAgICAgICAgICAgICAgICAi cG9wICAgICB7cjd9XG4iCisgICAgICAgICAgICAgICAgOgorICAgICAgICAgICAgICAgIDogInIi IChjdXJyZW50KSwgInIiIChuZXh0KQorICAgICAgICAgICAgICAgIDogInIwIiwgInIxIiwgInIy Iik7CisgICAgICAgICAgICBjdXJyZW50ID0gbmV4dDsKKyAgICAgICAgICAgIG5leHQgKz0gcGFn ZVNpemUoKTsKKyAgICAgICAgfSB3aGlsZSAoZW5kID49IG5leHQpOwogICAgIH0KICNlbGlmIE9T KFdJTkNFKQogICAgIHN0YXRpYyB2b2lkIGNhY2hlRmx1c2godm9pZCogY29kZSwgc2l6ZV90IHNp emUpCg== 131268 2012-03-11 18:56:28 -0700 2012-03-12 19:35:34 -0700 Patch bug-77712-20120312105626.patch text/plain 2742 hojong.han U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwMTQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAy OTVjMDE4N2MyYTI4N2VmMjQyNDJkYWVkOWJhZDg3NWY1MTIwMGQwLi40NDZlOTJmNjI0YTlkZjY0 MWM3M2RmOTFiOTY4NTU5ZTU4MjY0OWNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxMi0wMy0xMSAgSG9qb25nIEhhbiAgPGhvam9uZy5oYW5Ac2Ftc3VuZy5j b20+CisKKyAgICAgICAgUnVuIGNhY2hlRmx1c2ggcGFnZSBieSBwYWdlIHRvIGFzc3VyZSBvZiBm bHVzaGluZyBhbGwgdGhlIHJlcXVlc3RlZCByYW5nZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc3NzEyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQ3VycmVudCBNZXRhQWxsb2NhdG9yIGNvbmNlcHQsIGFs d2F5cyBjb2FsZXNjZXMgYWRqYWNlbnQgZnJlZSBzcGFjZXMsCisgICAgICAgIGRvZXNuJ3QgbWVl dCBtZW1vcnkgbWFuYWdlbWVudCBvZiBMaW51eCBrZXJuZWwuCisgICAgICAgIEluIGEgY2VydGFp biBjYXNlIExpbnV4IGtlcm5lbCBkb2Vzbid0IHJlZ2FyZCBjb250aWd1b3VzIHZpcnR1YWwgbWVt b3J5IGFyZWFzIGFzIG9uZSBidXQgdHdvLgorICAgICAgICBUaGVyZWZvcmUgY2FjaGVGbHVzaCBw YWdlIGJ5IHBhZ2UgZ3VhcmFudGVlcyBhIGZsdXNoLXJlcXVlc3RlZCByYW5nZS4KKworICAgICAg ICAqIGppdC9FeGVjdXRhYmxlQWxsb2NhdG9yLmg6CisgICAgICAgIChKU0M6OkV4ZWN1dGFibGVB bGxvY2F0b3I6OmNhY2hlRmx1c2gpOgorCiAyMDEyLTAzLTA3ICBTaGVyaWZmIEJvdCAgPHdlYmtp dC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91 dCByMTEwMTI3LgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9FeGVjdXRh YmxlQWxsb2NhdG9yLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0V4ZWN1dGFibGVBbGxv Y2F0b3IuaAppbmRleCAwYTA1ODMwY2QyMmNjOTYyZmFmZjg0Y2JlNDE1Zjg2ZjRiNzBlNzg0Li42 MTM5NmMwYzhmYzNiOTM5Y2VjYmY1MzEwYTNlNDVmMTFlYmNhOGE0IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvaml0L0V4ZWN1dGFibGVBbGxvY2F0b3IuaAorKysgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvaml0L0V4ZWN1dGFibGVBbGxvY2F0b3IuaApAQCAtMTg5LDE4ICsxODks MjYgQEAgcHVibGljOgogI2VsaWYgQ1BVKEFSTV9UUkFESVRJT05BTCkgJiYgT1MoTElOVVgpICYm IENPTVBJTEVSKEdDQykKICAgICBzdGF0aWMgdm9pZCBjYWNoZUZsdXNoKHZvaWQqIGNvZGUsIHNp emVfdCBzaXplKQogICAgIHsKLSAgICAgICAgYXNtIHZvbGF0aWxlICgKLSAgICAgICAgICAgICJw dXNoICAgIHtyN31cbiIKLSAgICAgICAgICAgICJtb3YgICAgIHIwLCAlMFxuIgotICAgICAgICAg ICAgIm1vdiAgICAgcjEsICUxXG4iCi0gICAgICAgICAgICAibW92ICAgICByNywgIzB4ZjAwMDBc biIKLSAgICAgICAgICAgICJhZGQgICAgIHI3LCByNywgIzB4MlxuIgotICAgICAgICAgICAgIm1v diAgICAgcjIsICMweDBcbiIKLSAgICAgICAgICAgICJzdmMgICAgIDB4MFxuIgotICAgICAgICAg ICAgInBvcCAgICAge3I3fVxuIgotICAgICAgICAgICAgOgotICAgICAgICAgICAgOiAiciIgKGNv ZGUpLCAiciIgKHJlaW50ZXJwcmV0X2Nhc3Q8Y2hhcio+KGNvZGUpICsgc2l6ZSkKLSAgICAgICAg ICAgIDogInIwIiwgInIxIiwgInIyIik7CisgICAgICAgIHVpbnRwdHJfdCBjdXJyZW50ID0gcmVp bnRlcnByZXRfY2FzdDx1aW50cHRyX3Q+KGNvZGUpICYgfihwYWdlU2l6ZSgpIC0gMSk7CisgICAg ICAgIHVpbnRwdHJfdCBlbmQgPSAocmVpbnRlcnByZXRfY2FzdDx1aW50cHRyX3Q+KGNvZGUpICsg c2l6ZSkgJiB+KHBhZ2VTaXplKCkgLSAxKTsKKyAgICAgICAgdWludHB0cl90IG5leHQgPSBjdXJy ZW50ICsgcGFnZVNpemUoKTsKKworICAgICAgICBkbyB7CisgICAgICAgICAgICBhc20gdm9sYXRp bGUgKAorICAgICAgICAgICAgICAgICJwdXNoICAgIHtyN31cbiIKKyAgICAgICAgICAgICAgICAi bW92ICAgICByMCwgJTBcbiIKKyAgICAgICAgICAgICAgICAibW92ICAgICByMSwgJTFcbiIKKyAg ICAgICAgICAgICAgICAibW92ICAgICByNywgIzB4ZjAwMDBcbiIKKyAgICAgICAgICAgICAgICAi YWRkICAgICByNywgcjcsICMweDJcbiIKKyAgICAgICAgICAgICAgICAibW92ICAgICByMiwgIzB4 MFxuIgorICAgICAgICAgICAgICAgICJzdmMgICAgIDB4MFxuIgorICAgICAgICAgICAgICAgICJw b3AgICAgIHtyN31cbiIKKyAgICAgICAgICAgICAgICA6CisgICAgICAgICAgICAgICAgOiAiciIg KGN1cnJlbnQpLCAiciIgKG5leHQpCisgICAgICAgICAgICAgICAgOiAicjAiLCAicjEiLCAicjIi KTsKKyAgICAgICAgICAgIGN1cnJlbnQgPSBuZXh0OworICAgICAgICAgICAgbmV4dCArPSBwYWdl U2l6ZSgpOworICAgICAgICB9IHdoaWxlIChlbmQgPj0gY3VycmVudCk7CiAgICAgfQogI2VsaWYg T1MoV0lOQ0UpCiAgICAgc3RhdGljIHZvaWQgY2FjaGVGbHVzaCh2b2lkKiBjb2RlLCBzaXplX3Qg c2l6ZSkK 131496 2012-03-12 19:35:42 -0700 2012-03-14 17:06:20 -0700 Patch bug-77712-20120313113540.patch text/plain 2709 hojong.han U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwNDEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBl ZjcwYzQ2MzA2MmNiZjBiMWI1ZTA3ZDQzYjNmYTczY2NmNDA2MmVkLi5hMmQwZDQ5MDkzZGJlZGUx NDY0YjZmNDgxMDg2NDMxMTdiZTZhZDliIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxMi0wMy0xMiAgSG9qb25nIEhhbiAgPGhvam9uZy5oYW5Ac2Ftc3VuZy5j b20+CisKKyAgICAgICAgUnVuIGNhY2hlRmx1c2ggcGFnZSBieSBwYWdlIHRvIGFzc3VyZSBvZiBm bHVzaGluZyBhbGwgdGhlIHJlcXVlc3RlZCByYW5nZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc3NzEyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQ3VycmVudCBNZXRhQWxsb2NhdG9yIGNvbmNlcHQsIGFs d2F5cyBjb2FsZXNjZXMgYWRqYWNlbnQgZnJlZSBzcGFjZXMsCisgICAgICAgIGRvZXNuJ3QgbWVl dCBtZW1vcnkgbWFuYWdlbWVudCBvZiBMaW51eCBrZXJuZWwuCisgICAgICAgIEluIGEgY2VydGFp biBjYXNlIExpbnV4IGtlcm5lbCBkb2Vzbid0IHJlZ2FyZCBjb250aWd1b3VzIHZpcnR1YWwgbWVt b3J5IGFyZWFzIGFzIG9uZSBidXQgdHdvLgorICAgICAgICBUaGVyZWZvcmUgY2FjaGVGbHVzaCBw YWdlIGJ5IHBhZ2UgZ3VhcmFudGVlcyBhIGZsdXNoLXJlcXVlc3RlZCByYW5nZS4KKworICAgICAg ICAqIGppdC9FeGVjdXRhYmxlQWxsb2NhdG9yLmg6CisgICAgICAgIChKU0M6OkV4ZWN1dGFibGVB bGxvY2F0b3I6OmNhY2hlRmx1c2gpOgorCiAyMDEyLTAzLTEwICBGaWxpcCBQaXpsbyAgPGZwaXps b0BhcHBsZS5jb20+CiAKICAgICAgICAgTExJbnQgc2hvdWxkIHN1cHBvcnQgSlNWQUxVRTY0CmRp ZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0V4ZWN1dGFibGVBbGxvY2F0b3Iu aCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvRXhlY3V0YWJsZUFsbG9jYXRvci5oCmluZGV4 IDhhMTRhYzY3ZTFkYzA5ODU0MTUwZmQwMTE0MzFiYmRhNzM1MWU0YTAuLjMyYTkxMTNkNzg1NjE5 MGI5ZjRhNjAzMTM1NWRkZDUzZDUyN2NlNjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9qaXQvRXhlY3V0YWJsZUFsbG9jYXRvci5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9qaXQvRXhlY3V0YWJsZUFsbG9jYXRvci5oCkBAIC0xOTQsMTggKzE5NCwyNSBAQCBwdWJsaWM6 CiAjZWxpZiBDUFUoQVJNX1RSQURJVElPTkFMKSAmJiBPUyhMSU5VWCkgJiYgQ09NUElMRVIoR0ND KQogICAgIHN0YXRpYyB2b2lkIGNhY2hlRmx1c2godm9pZCogY29kZSwgc2l6ZV90IHNpemUpCiAg ICAgewotICAgICAgICBhc20gdm9sYXRpbGUgKAotICAgICAgICAgICAgInB1c2ggICAge3I3fVxu IgotICAgICAgICAgICAgIm1vdiAgICAgcjAsICUwXG4iCi0gICAgICAgICAgICAibW92ICAgICBy MSwgJTFcbiIKLSAgICAgICAgICAgICJtb3YgICAgIHI3LCAjMHhmMDAwMFxuIgotICAgICAgICAg ICAgImFkZCAgICAgcjcsIHI3LCAjMHgyXG4iCi0gICAgICAgICAgICAibW92ICAgICByMiwgIzB4 MFxuIgotICAgICAgICAgICAgInN2YyAgICAgMHgwXG4iCi0gICAgICAgICAgICAicG9wICAgICB7 cjd9XG4iCi0gICAgICAgICAgICA6Ci0gICAgICAgICAgICA6ICJyIiAoY29kZSksICJyIiAocmVp bnRlcnByZXRfY2FzdDxjaGFyKj4oY29kZSkgKyBzaXplKQotICAgICAgICAgICAgOiAicjAiLCAi cjEiLCAicjIiKTsKKyAgICAgICAgdWludHB0cl90IGN1cnJlbnRQYWdlID0gcmVpbnRlcnByZXRf Y2FzdDx1aW50cHRyX3Q+KGNvZGUpICYgfihwYWdlU2l6ZSgpIC0gMSk7CisgICAgICAgIHVpbnRw dHJfdCBsYXN0UGFnZSA9IChyZWludGVycHJldF9jYXN0PHVpbnRwdHJfdD4oY29kZSkgKyBzaXpl KSAmIH4ocGFnZVNpemUoKSAtIDEpOworCisgICAgICAgIGRvIHsKKyAgICAgICAgICAgIGFzbSB2 b2xhdGlsZSAoCisgICAgICAgICAgICAgICAgInB1c2ggICAge3I3fVxuIgorICAgICAgICAgICAg ICAgICJtb3YgICAgIHIwLCAlMFxuIgorICAgICAgICAgICAgICAgICJtb3YgICAgIHIxLCAlMVxu IgorICAgICAgICAgICAgICAgICJtb3YgICAgIHI3LCAjMHhmMDAwMFxuIgorICAgICAgICAgICAg ICAgICJhZGQgICAgIHI3LCByNywgIzB4MlxuIgorICAgICAgICAgICAgICAgICJtb3YgICAgIHIy LCAjMHgwXG4iCisgICAgICAgICAgICAgICAgInN2YyAgICAgMHgwXG4iCisgICAgICAgICAgICAg ICAgInBvcCAgICAge3I3fVxuIgorICAgICAgICAgICAgICAgIDoKKyAgICAgICAgICAgICAgICA6 ICJyIiAoY3VycmVudFBhZ2UpLCAiciIgKGN1cnJlbnRQYWdlICsgcGFnZVNpemUoKSkKKyAgICAg ICAgICAgICAgICA6ICJyMCIsICJyMSIsICJyMiIpOworICAgICAgICAgICAgY3VycmVudFBhZ2Ug Kz0gcGFnZVNpemUoKTsKKyAgICAgICAgfSB3aGlsZSAobGFzdFBhZ2UgPj0gY3VycmVudFBhZ2Up OworICAgICB9CiAgICAgfQogI2VsaWYgT1MoV0lOQ0UpCiAgICAgc3RhdGljIHZvaWQgY2FjaGVG bHVzaCh2b2lkKiBjb2RlLCBzaXplX3Qgc2l6ZSkK