77709 2012-02-02 20:35:49 -0800 Rename [Deletable] IDL to [NotConfigurable] IDL 2012-02-03 01:10:40 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 77393 1 haraken haraken abarth darin japhet ojan webkit.review.bot oldest_to_newest 548397 0 haraken 2012-02-02 20:35:49 -0800 [Deletable] is a negation of [[Configurable]] in the ECMAScript spec (8.6.1 of http://www.ecma-international.org/publications/files/ECMA-ST/Ecma-262.pdf). We can rename [Deletable] to [NotConfigurable]. 548401 1 125249 haraken 2012-02-02 20:38:40 -0800 Created attachment 125249 Patch 548405 2 haraken 2012-02-02 20:45:26 -0800 BTW, [NotConfigurable] is implemented in JSC only. Should we also implement it in V8? Currently, [NotConfigurable] is used by HTMLDocument.all only. I could not find the HTMLDocument.all spec (HTMLDocument does not have |all| in the HTML5 spec (http://www.w3.org/TR/html5/dom.html#htmldocument)), and I am not sure if it is acceptable to make HTMLDocument.all [[NotConfigurable]] in V8. 548457 3 haraken 2012-02-02 22:29:16 -0800 (In reply to comment #2) > BTW, [NotConfigurable] is implemented in JSC only. Should we also implement it in V8? > > Currently, [NotConfigurable] is used by HTMLDocument.all only. I could not find the HTMLDocument.all spec (HTMLDocument does not have |all| in the HTML5 spec (http://www.w3.org/TR/html5/dom.html#htmldocument)), and I am not sure if it is acceptable to make HTMLDocument.all [[NotConfigurable]] in V8. Sorry, the HTML spec is here: http://www.whatwg.org/specs/web-apps/current-work/multipage/obsolete.html#dom-document-all As far as I see the HTML spec and the Web IDL spec, it seems that HTMLDocument.all should not be configurable. Maybe we do not need to implement it in V8. 548535 4 abarth 2012-02-03 00:52:25 -0800 > Maybe we do not need to implement it in V8. That seems likely. It's also possible V8 does this with custom code given that it's only used in one place. 548538 5 125249 abarth 2012-02-03 00:54:07 -0800 Comment on attachment 125249 Patch I'm not sure this is an improvement. Deletable is very easy for me to understand what it means. If we could align exactly with WebIDL, that might swing the balance, but given that we're not going to match WebIDL exactly, I'd opt for the clearer "Deletable" over the somewhat-confusing "NotConfigurable". Thoughts? 548543 6 haraken 2012-02-03 00:57:48 -0800 (In reply to comment #5) > (From update of attachment 125249 [details]) > I'm not sure this is an improvement. Deletable is very easy for me to understand what it means. If we could align exactly with WebIDL, that might swing the balance, but given that we're not going to match WebIDL exactly, I'd opt for the clearer "Deletable" over the somewhat-confusing "NotConfigurable". > > Thoughts? IMO, [NotEnumerable] will be acceptable. [NotConfigurable] might be acceptable. [NotWritable] is worse than [ReadOnly] (though I posted the patch). OK, then let us mark the renaming patches for [NotConfigurable] and [ReadOnly] as "WONTFIX". 548555 7 haraken 2012-02-03 01:10:40 -0800 (In reply to comment #6) > (In reply to comment #5) > IMO, ... [NotWritable] is worse than [ReadOnly] (though I posted the patch). OK, then let us mark the renaming patches for ... [ReadOnly] as "WONTFIX". Please ignore the above comment. I've not yet posted the patch:-) Thanks indeed for reviewing patches. 125249 2012-02-02 20:38:40 -0800 2012-02-03 00:54:06 -0800 Patch bug-77709-20120203133838.patch text/plain 3708 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2NjA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDI5NWZjYTY1MmI1MWJk Yzg5M2JhMTQ2ZTBhMWQwYmVmMzUyYmU4Ny4uZDEyZjI2YjgyY2IxNDE2OGNkZjA2ZGNkMWNiYTQ4 YzQzMjI2YzAzZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTAyLTAyICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZW5hbWUgW0RlbGV0 YWJsZV0gSURMIHRvIFtOb3RDb25maWd1cmFibGVdIElETAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Nzc3MDkKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbRGVsZXRhYmxlXSBpcyBhIG5lZ2F0aW9uIG9mIFtb Q29uZmlndXJhYmxlXV0gaW4gdGhlIEVDTUFTY3JpcHQgc3BlYworICAgICAgICAoOC42LjEgb2Yg aHR0cDovL3d3dy5lY21hLWludGVybmF0aW9uYWwub3JnL3B1YmxpY2F0aW9ucy9maWxlcy9FQ01B LVNUL0VjbWEtMjYyLnBkZikuCisgICAgICAgIFdlIGNhbiByZW5hbWUgW0RlbGV0YWJsZV0gdG8g W05vdENvbmZpZ3VyYWJsZV0uCisKKyAgICAgICAgTm8gdGVzdHMuIE5vIGNoYW5nZXMgaW4gYmVo YXZpb3IuCisKKyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbToK KyAgICAgICAgKEdlbmVyYXRlQXR0cmlidXRlc0hhc2hUYWJsZSk6CisgICAgICAgIChHZW5lcmF0 ZUltcGxlbWVudGF0aW9uKToKKyAgICAgICAgKiBodG1sL0hUTUxEb2N1bWVudC5pZGw6CisKIDIw MTItMDEtMjkgIFBhYmxvIEZsb3VyZXQgIDxwYWJsb2ZAbW90b3JvbGEuY29tPgogCiAgICAgICAg IFY4IGlkbCBjb2RlIGdlbmVyYXRvciBkb2Vzbid0IGhhbmRsZSBTZXJpYWxpemVkU2NyaXB0VmFs dWUgYXR0cmlidXRlcyBwcm9wZXJseS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv c2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG0KaW5kZXggODRjMDYxZjQ3N2QyYTI1MzA2MGU5N2Jj OThhZDhiMGQ0ZGY5YmU1My4uMDhkOTQyYTljY2YyNWRjODg5ZTUyNWQ0NmM5OTE3Y2IwNjk0MzUx YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJh dG9ySlMucG0KKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJh dG9ySlMucG0KQEAgLTExNjgsNyArMTE2OCw3IEBAIHN1YiBHZW5lcmF0ZUF0dHJpYnV0ZXNIYXNo VGFibGUoJCQpCiAgICAgICAgIHB1c2goQGhhc2hLZXlzLCAkbmFtZSk7CiAKICAgICAgICAgbXkg QHNwZWNpYWxzID0gKCk7Ci0gICAgICAgIHB1c2goQHNwZWNpYWxzLCAiRG9udERlbGV0ZSIpIHVu bGVzcyAkYXR0cmlidXRlLT5zaWduYXR1cmUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJEZWxldGFi bGUifTsKKyAgICAgICAgcHVzaChAc3BlY2lhbHMsICJEb250RGVsZXRlIikgdW5sZXNzICRhdHRy aWJ1dGUtPnNpZ25hdHVyZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57Ik5vdENvbmZpZ3VyYWJsZSJ9 OwogICAgICAgICBwdXNoKEBzcGVjaWFscywgIkRvbnRFbnVtIikgaWYgJGF0dHJpYnV0ZS0+c2ln bmF0dXJlLT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsiRG9udEVudW0ifTsKICAgICAgICAgcHVzaChA c3BlY2lhbHMsICJSZWFkT25seSIpIGlmICRhdHRyaWJ1dGUtPnR5cGUgPX4gL3JlYWRvbmx5LzsK ICAgICAgICAgbXkgJHNwZWNpYWwgPSAoQHNwZWNpYWxzID4gMCkgPyBqb2luKCIgfCAiLCBAc3Bl Y2lhbHMpIDogIjAiOwpAQCAtMTM5NSw3ICsxMzk1LDcgQEAgc3ViIEdlbmVyYXRlSW1wbGVtZW50 YXRpb24KICAgICAgICAgICAgIHB1c2goQGhhc2hWYWx1ZTIsICRudW1QYXJhbWV0ZXJzKTsKIAog ICAgICAgICAgICAgbXkgQHNwZWNpYWxzID0gKCk7Ci0gICAgICAgICAgICBwdXNoKEBzcGVjaWFs cywgIkRvbnREZWxldGUiKSB1bmxlc3MgJGZ1bmN0aW9uLT5zaWduYXR1cmUtPmV4dGVuZGVkQXR0 cmlidXRlcy0+eyJEZWxldGFibGUifTsKKyAgICAgICAgICAgIHB1c2goQHNwZWNpYWxzLCAiRG9u dERlbGV0ZSIpIHVubGVzcyAkZnVuY3Rpb24tPnNpZ25hdHVyZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVz LT57Ik5vdENvbmZpZ3VyYWJsZSJ9OwogICAgICAgICAgICAgcHVzaChAc3BlY2lhbHMsICJEb250 RW51bSIpIGlmICRmdW5jdGlvbi0+c2lnbmF0dXJlLT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsiRG9u dEVudW0ifTsKICAgICAgICAgICAgIHB1c2goQHNwZWNpYWxzLCAiSlNDOjpGdW5jdGlvbiIpOwog ICAgICAgICAgICAgbXkgJHNwZWNpYWwgPSAoQHNwZWNpYWxzID4gMCkgPyBqb2luKCIgfCAiLCBA c3BlY2lhbHMpIDogIjAiOwpAQCAtMTQ1OSw3ICsxNDU5LDcgQEAgc3ViIEdlbmVyYXRlSW1wbGVt ZW50YXRpb24KICAgICAgICAgcHVzaChAaGFzaFZhbHVlMiwgJG51bVBhcmFtZXRlcnMpOwogCiAg ICAgICAgIG15IEBzcGVjaWFscyA9ICgpOwotICAgICAgICBwdXNoKEBzcGVjaWFscywgIkRvbnRE ZWxldGUiKSB1bmxlc3MgJGZ1bmN0aW9uLT5zaWduYXR1cmUtPmV4dGVuZGVkQXR0cmlidXRlcy0+ eyJEZWxldGFibGUifTsKKyAgICAgICAgcHVzaChAc3BlY2lhbHMsICJEb250RGVsZXRlIikgdW5s ZXNzICRmdW5jdGlvbi0+c2lnbmF0dXJlLT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsiTm90Q29uZmln dXJhYmxlIn07CiAgICAgICAgIHB1c2goQHNwZWNpYWxzLCAiRG9udEVudW0iKSBpZiAkZnVuY3Rp b24tPnNpZ25hdHVyZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IkRvbnRFbnVtIn07CiAgICAgICAg IHB1c2goQHNwZWNpYWxzLCAiSlNDOjpGdW5jdGlvbiIpOwogICAgICAgICBteSAkc3BlY2lhbCA9 IChAc3BlY2lhbHMgPiAwKSA/IGpvaW4oIiB8ICIsIEBzcGVjaWFscykgOiAiMCI7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxEb2N1bWVudC5pZGwgYi9Tb3VyY2UvV2ViQ29y ZS9odG1sL0hUTUxEb2N1bWVudC5pZGwKaW5kZXggYTdhNmJjZGE2MWI5NDUwNDNkMmE1NjJmOGEw NTg1NzgwNWIzZWNhMS4uNmMxYTA0MGM2NDU5YzhmNTI2ZjIxNjJmZWU0ZGM1Mzc3ODdkMTE2MSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRG9jdW1lbnQuaWRsCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2h0bWwvSFRNTERvY3VtZW50LmlkbApAQCAtMzYsNyArMzYsNyBAQCBtb2R1 bGUgaHRtbCB7CiAKICNpZiBkZWZpbmVkKExBTkdVQUdFX0pBVkFTQ1JJUFQpICYmIExBTkdVQUdF X0pBVkFTQ1JJUFQKICAgICAgICAgLy8gRklYTUU6IFRoaXMgc2hvdWxkIGV2ZW50dWFsbHkgYmUg YXZhaWxhYmxlIChpZiB0aGV5IGFyZSB3YW50ZWQpIGZvciBhbGwgbGFuZ3VhZ2VzLgotICAgICAg ICAgICAgICAgICBhdHRyaWJ1dGUgW0N1c3RvbSwgRGVsZXRhYmxlXSBIVE1MQWxsQ29sbGVjdGlv biBhbGw7CisgICAgICAgICAgICAgICAgIGF0dHJpYnV0ZSBbQ3VzdG9tLCBOb3RDb25maWd1cmFi bGVdIEhUTUxBbGxDb2xsZWN0aW9uIGFsbDsKICNlbmRpZgogCiAgICAgICAgIHZvaWQgY2xlYXIo KTsK