77707 2012-02-02 19:56:33 -0800 Add the "CPP" prefix to CPP specific IDL attributes 2012-02-03 02:32:02 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 77393 1 haraken haraken abarth darin japhet macpherson menard ojan webkit.review.bot oldest_to_newest 548379 0 haraken 2012-02-02 19:56:33 -0800 We should add the "CPP" prefix to CPP specific IDL attributes. Specifically, we should rename [PureInterface] to [CPPPureInterface]. 548381 1 125245 haraken 2012-02-02 19:58:49 -0800 Created attachment 125245 Patch 548529 2 125245 abarth 2012-02-03 00:48:03 -0800 Comment on attachment 125245 Patch This certainly seems helpful. 548596 3 125245 webkit.review.bot 2012-02-03 02:31:57 -0800 Comment on attachment 125245 Patch Clearing flags on attachment: 125245 Committed r106643: <http://trac.webkit.org/changeset/106643> 548597 4 webkit.review.bot 2012-02-03 02:32:02 -0800 All reviewed patches have been landed. Closing bug. 125245 2012-02-02 19:58:49 -0800 2012-02-03 02:31:57 -0800 Patch bug-77707-20120203125847.patch text/plain 5863 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2NjA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDI5NWZjYTY1MmI1MWJk Yzg5M2JhMTQ2ZTBhMWQwYmVmMzUyYmU4Ny4uNzJjZjgxNTdiZTY4ZDVjZjEyYTdmMmVhMTZmYWI1 M2E1MzZiNzEyZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTAyLTAyICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBBZGQgdGhlICJDUFAi IHByZWZpeCB0byBDUFAgc3BlY2lmaWMgSURMIGF0dHJpYnV0ZXMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc3NzA3CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBwYXRjaCBhZGRzIHRoZSAiQ1BQIiBw cmVmaXggdG8gYSBDUFAgc3BlY2lmaWMgSURMIGF0dHJpYnV0ZS4KKyAgICAgICAgU3BlY2lmaWNh bGx5LCB0aGlzIHBhdGNoIHJlbmFtZXMgW1B1cmVJbnRlcmZhY2VdIHRvIFtDUFBQdXJlSW50ZXJm YWNlXQorCisgICAgICAgIE5vIHRlc3RzLiBObyBjaGFuZ2UgaW4gYmVoYXZpb3IuCisKKyAgICAg ICAgKiBiaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JDUFAucG06CisgICAgICAgIChHZW5l cmF0ZUhlYWRlcik6CisgICAgICAgIChHZW5lcmF0ZUltcGxlbWVudGF0aW9uKToKKyAgICAgICAg KiBjc3MvTWVkaWFRdWVyeUxpc3RMaXN0ZW5lci5pZGw6CisgICAgICAgICogZG9tL0V2ZW50TGlz dGVuZXIuaWRsOgorICAgICAgICAqIGRvbS9FdmVudFRhcmdldC5pZGw6CisgICAgICAgICogZG9t L05vZGVGaWx0ZXIuaWRsOgorCiAyMDEyLTAxLTI5ICBQYWJsbyBGbG91cmV0ICA8cGFibG9mQG1v dG9yb2xhLmNvbT4KIAogICAgICAgICBWOCBpZGwgY29kZSBnZW5lcmF0b3IgZG9lc24ndCBoYW5k bGUgU2VyaWFsaXplZFNjcmlwdFZhbHVlIGF0dHJpYnV0ZXMgcHJvcGVybHkuCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JDUFAucG0gYi9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JDUFAucG0KaW5kZXgg YjU3YzY5ZjJiMmVmYWUzN2Y0MThkZWQzZTZkODVmNWZhNGRhOWFhNi4uMGFlNDZmMThmNzhhM2Jl ZjBmODJmNmY2ODY4YjgyMWJkODgzMDZiNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yQ1BQLnBtCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckNQUC5wbQpAQCAtNDgyLDcgKzQ4Miw3IEBAIHN1 YiBHZW5lcmF0ZUhlYWRlcgogICAgICAgICAgICAgICAgICRwYXJhbWV0ZXJJbmRleCsrOwogICAg ICAgICAgICAgfQogICAgICAgICAgICAgJGZ1bmN0aW9uU2lnIC49ICIpIjsKLSAgICAgICAgICAg IGlmICgkZGF0YU5vZGUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJQdXJlSW50ZXJmYWNlIn0pIHsK KyAgICAgICAgICAgIGlmICgkZGF0YU5vZGUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJDUFBQdXJl SW50ZXJmYWNlIn0pIHsKICAgICAgICAgICAgICAgICBwdXNoKEBpbnRlcmZhY2VGdW5jdGlvbnMs ICIgICAgdmlydHVhbCAiIC4gJGZ1bmN0aW9uU2lnIC4gIiA9IDA7XG4iKTsKICAgICAgICAgICAg IH0KICAgICAgICAgICAgIG15ICRmdW5jdGlvbkRlY2xhcmF0aW9uID0gJGZ1bmN0aW9uU2lnOwpA QCAtNTE0LDkgKzUxNCw5IEBAIHN1YiBHZW5lcmF0ZUhlYWRlcgogCiAgICAgcHVzaChAaGVhZGVy Q29udGVudCwgIn07XG5cbiIpOwogCi0gICAgIyBmb3IgUHVyZUludGVyZmFjZSBjbGFzc2VzIGFs c28gYWRkIHRoZSBpbnRlcmZhY2UgdGhhdCB0aGUgY2xpZW50IGNvZGUgbmVlZHMgdG8KKyAgICAj IGZvciBDUFBQdXJlSW50ZXJmYWNlIGNsYXNzZXMgYWxzbyBhZGQgdGhlIGludGVyZmFjZSB0aGF0 IHRoZSBjbGllbnQgY29kZSBuZWVkcyB0bwogICAgICMgaW1wbGVtZW50Ci0gICAgaWYgKCRkYXRh Tm9kZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IlB1cmVJbnRlcmZhY2UifSkgeworICAgIGlmICgk ZGF0YU5vZGUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJDUFBQdXJlSW50ZXJmYWNlIn0pIHsKICAg ICAgICAgcHVzaChAaGVhZGVyQ29udGVudCwgImNsYXNzIFdlYlVzZXIkaW50ZXJmYWNlTmFtZSB7 XG4iKTsKICAgICAgICAgcHVzaChAaGVhZGVyQ29udGVudCwgInB1YmxpYzpcbiIpOwogICAgICAg ICBwdXNoKEBoZWFkZXJDb250ZW50LCAiICAgIHZpcnR1YWwgdm9pZCByZWYoKSA9IDA7XG4iKTsK QEAgLTUzMCw3ICs1MzAsNyBAQCBzdWIgR2VuZXJhdGVIZWFkZXIKICAgICBteSAkbmFtZXNwYWNl ID0gR2V0TmFtZXNwYWNlRm9yQ2xhc3MoJGltcGxDbGFzc05hbWUpOwogICAgIHB1c2goQGhlYWRl ckNvbnRlbnQsICIkbmFtZXNwYWNlIiAuICI6OiRpbXBsQ2xhc3NOYW1lKiB0b1dlYkNvcmUoY29u c3QgJGNsYXNzTmFtZSYpO1xuIik7CiAgICAgcHVzaChAaGVhZGVyQ29udGVudCwgIiRjbGFzc05h bWUgdG9XZWJLaXQoJG5hbWVzcGFjZSIgLiAiOjokaW1wbENsYXNzTmFtZSopO1xuIik7Ci0gICAg aWYgKCRkYXRhTm9kZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IlB1cmVJbnRlcmZhY2UifSkgewor ICAgIGlmICgkZGF0YU5vZGUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJDUFBQdXJlSW50ZXJmYWNl In0pIHsKICAgICAgICAgcHVzaChAaGVhZGVyQ29udGVudCwgIiRjbGFzc05hbWUgdG9XZWJLaXQo V2ViVXNlciRpbnRlcmZhY2VOYW1lKik7XG4iKTsKICAgICB9CiAgICAgcHVzaChAaGVhZGVyQ29u dGVudCwgIlxuI2VuZGlmXG4iKTsKQEAgLTc4NCw4ICs3ODQsOCBAQCBzdWIgR2VuZXJhdGVJbXBs ZW1lbnRhdGlvbgogICAgICMgLSBGdW5jdGlvbnMKICAgICBpZiAoJG51bUZ1bmN0aW9ucyA+IDAp IHsKICAgICAgICAgZm9yZWFjaCBteSAkZnVuY3Rpb24gKEB7JGRhdGFOb2RlLT5mdW5jdGlvbnN9 KSB7Ci0gICAgICAgICAgICAjIFRyZWF0IFB1cmVJbnRlcmZhY2UgYXMgQ3VzdG9tIGFzIHdlbGws IHNpbmNlIHRoZSBXZWJDb3JlIHZlcnNpb25zIHdpbGwgdGFrZSBhIHNjcmlwdCBjb250ZXh0IGFz IHdlbGwKLSAgICAgICAgICAgIG5leHQgaWYgU2hvdWxkU2tpcFR5cGUoJGZ1bmN0aW9uKSB8fCAk ZGF0YU5vZGUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJQdXJlSW50ZXJmYWNlIn07CisgICAgICAg ICAgICAjIFRyZWF0IENQUFB1cmVJbnRlcmZhY2UgYXMgQ3VzdG9tIGFzIHdlbGwsIHNpbmNlIHRo ZSBXZWJDb3JlIHZlcnNpb25zIHdpbGwgdGFrZSBhIHNjcmlwdCBjb250ZXh0IGFzIHdlbGwKKyAg ICAgICAgICAgIG5leHQgaWYgU2hvdWxkU2tpcFR5cGUoJGZ1bmN0aW9uKSB8fCAkZGF0YU5vZGUt PmV4dGVuZGVkQXR0cmlidXRlcy0+eyJDUFBQdXJlSW50ZXJmYWNlIn07CiAgICAgICAgICAgICBB ZGRJbmNsdWRlc0ZvclR5cGUoJGZ1bmN0aW9uLT5zaWduYXR1cmUtPnR5cGUpOwogCiAgICAgICAg ICAgICBteSAkZnVuY3Rpb25OYW1lID0gJGZ1bmN0aW9uLT5zaWduYXR1cmUtPm5hbWU7CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvTWVkaWFRdWVyeUxpc3RMaXN0ZW5lci5pZGwgYi9T b3VyY2UvV2ViQ29yZS9jc3MvTWVkaWFRdWVyeUxpc3RMaXN0ZW5lci5pZGwKaW5kZXggZGZlNjU5 YjBkMmI2YzI5MzJiMjJhMjUxZTgzMWY5NTJlNzUxZjdjNy4uOTkwMjYwODBkYmVmOTk4NDFmOWM5 ZjIzODA2ZjRiYjViZjlmZjk2MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL01lZGlh UXVlcnlMaXN0TGlzdGVuZXIuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9NZWRpYVF1ZXJ5 TGlzdExpc3RlbmVyLmlkbApAQCAtMjEsNyArMjEsNyBAQCBtb2R1bGUgdmlldyB7CiAgICAgaW50 ZXJmYWNlIFsKICAgICAgICAgTm9TdGF0aWNUYWJsZXMsCiAgICAgICAgIE9iakNQcm90b2NvbCwK LSAgICAgICAgUHVyZUludGVyZmFjZSwKKyAgICAgICAgQ1BQUHVyZUludGVyZmFjZSwKICAgICAg ICAgT21pdENvbnN0cnVjdG9yCiAgICAgXSBNZWRpYVF1ZXJ5TGlzdExpc3RlbmVyIHsKICAgICAg ICAgdm9pZCBxdWVyeUNoYW5nZWQoaW4gW09wdGlvbmFsPUNhbGxXaXRoRGVmYXVsdFZhbHVlXSBN ZWRpYVF1ZXJ5TGlzdCBsaXN0KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FdmVu dExpc3RlbmVyLmlkbCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FdmVudExpc3RlbmVyLmlkbAppbmRl eCAwMjM3NzdiZjM5NDMyNTdlOWQzYmM2NjI0NTk3ZTMxMGQwZTY2OTMyLi4yMWE3YjFmOTA0ODVm NDI2MDI2YzVhZWYzZDEzN2Y0YzdhZmNjMDRjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9k b20vRXZlbnRMaXN0ZW5lci5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0V2ZW50TGlzdGVu ZXIuaWRsCkBAIC0yNCw3ICsyNCw3IEBAIG1vZHVsZSBldmVudHMgewogICAgIGludGVyZmFjZSBb CiAgICAgICAgIE5vU3RhdGljVGFibGVzLAogICAgICAgICBPYmpDUHJvdG9jb2wsCi0gICAgICAg IFB1cmVJbnRlcmZhY2UsCisgICAgICAgIENQUFB1cmVJbnRlcmZhY2UsCiAgICAgICAgIE9taXRD b25zdHJ1Y3RvcgogICAgIF0gRXZlbnRMaXN0ZW5lciB7CiAgICAgICAgIHZvaWQgICAgICAgICAg ICAgICBoYW5kbGVFdmVudChpbiBFdmVudCBldnQpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvZG9tL0V2ZW50VGFyZ2V0LmlkbCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FdmVudFRhcmdldC5p ZGwKaW5kZXggOGM2ODNkYTFlZTAwN2NlMTg4MGQ5MDkyNmY3MDEyMDkyMDExYWUzYi4uNzEyYjNi MWI4MTJlNDgzYTBmOGE2MDJlNDg2MGNkNzIxNjVlMmI1NiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvZG9tL0V2ZW50VGFyZ2V0LmlkbAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRXZlbnRU YXJnZXQuaWRsCkBAIC0yMyw3ICsyMyw3IEBAIG1vZHVsZSBldmVudHMgewogICAgIC8vIEludHJv ZHVjZWQgaW4gRE9NIExldmVsIDI6CiAgICAgaW50ZXJmYWNlIFsKICAgICAgICAgT2JqQ1Byb3Rv Y29sLAotICAgICAgICBQdXJlSW50ZXJmYWNlLAorICAgICAgICBDUFBQdXJlSW50ZXJmYWNlLAog ICAgICAgICBPbWl0Q29uc3RydWN0b3IKICAgICBdIEV2ZW50VGFyZ2V0IHsKICAgICAgICAgW09s ZFN0eWxlT2JqQ10gdm9pZCBhZGRFdmVudExpc3RlbmVyKGluIERPTVN0cmluZyB0eXBlLCAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Ob2RlRmlsdGVyLmlkbCBiL1NvdXJjZS9XZWJD b3JlL2RvbS9Ob2RlRmlsdGVyLmlkbAppbmRleCAzOGRhYzEwZjAzNTRiZjkyMDA2MDEzOGUwNDBj OTBhOWJhMTdjNDg0Li4wZDc5NjEyNGQ4NjZlNTc2YjZlMTA5MTQ2ZmEzY2NlMmY3Y2U3MzZlIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vTm9kZUZpbHRlci5pZGwKKysrIGIvU291cmNl L1dlYkNvcmUvZG9tL05vZGVGaWx0ZXIuaWRsCkBAIC0yNSw3ICsyNSw3IEBAIG1vZHVsZSB0cmF2 ZXJzYWwgewogICAgICAgICBDdXN0b21NYXJrRnVuY3Rpb24sCiAgICAgICAgIEN1c3RvbU5hdGl2 ZUNvbnZlcnRlciwKICAgICAgICAgT2JqQ1Byb3RvY29sLAotICAgICAgICBQdXJlSW50ZXJmYWNl CisgICAgICAgIENQUFB1cmVJbnRlcmZhY2UKICAgICBdIE5vZGVGaWx0ZXIgewogICAgICAgICAv LyBDb25zdGFudHMgcmV0dXJuZWQgYnkgYWNjZXB0Tm9kZQogICAgICAgICBjb25zdCBzaG9ydCAg ICAgICAgICAgICAgIEZJTFRFUl9BQ0NFUFQgICAgICAgICAgICAgICAgICA9IDE7Cg==