77706 2012-02-02 19:43:18 -0800 Remove [LegacyParent] from CodeGeneratorGObject.pm, and rename it to [JSLegacyParent] 2012-02-03 01:55:15 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 77393 1 haraken haraken abarth darin japhet ojan webkit.review.bot oldest_to_newest 548376 0 haraken 2012-02-02 19:43:18 -0800 [LegacyParent] is a JSC-specific IDL attribute, and we can rename it to [JSLegacyParent]. Also, we need to remove dead code about [LegacyParent] from CodeGeneratorGObject.pm. 548377 1 125244 haraken 2012-02-02 19:45:38 -0800 Created attachment 125244 Patch 548527 2 125244 abarth 2012-02-03 00:47:20 -0800 Comment on attachment 125244 Patch I think this rename names sense given that it's a legacy attribute. 548534 3 haraken 2012-02-03 00:51:21 -0800 (In reply to comment #2) > (From update of attachment 125244 [details]) > I think this rename names sense given that it's a legacy attribute. Do you mean we should rename it better? 548545 4 abarth 2012-02-03 00:59:38 -0800 > > I think this rename names sense given that it's a legacy attribute. > > Do you mean we should rename it better? I fail at typing. I meant to say "I think this rename does make sense given that it's a legacy attribute." :) 548581 5 125244 webkit.review.bot 2012-02-03 01:55:10 -0800 Comment on attachment 125244 Patch Clearing flags on attachment: 125244 Committed r106639: <http://trac.webkit.org/changeset/106639> 548582 6 webkit.review.bot 2012-02-03 01:55:15 -0800 All reviewed patches have been landed. Closing bug. 125244 2012-02-02 19:45:38 -0800 2012-02-03 01:55:10 -0800 Patch bug-77706-20120203124536.patch text/plain 4724 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2NjA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDI5NWZjYTY1MmI1MWJk Yzg5M2JhMTQ2ZTBhMWQwYmVmMzUyYmU4Ny4uYzIyOTRjZGM2MzdmNzcwMjk1NWU0ODMzY2MxZjEy MDkxOGU2NmNiYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEyLTAyLTAyICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZW1vdmUgW0xlZ2Fj eVBhcmVudF0gZnJvbSBDb2RlR2VuZXJhdG9yR09iamVjdC5wbSwgYW5kIHJlbmFtZSBpdCB0byBb SlNMZWdhY3lQYXJlbnRdCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD03NzcwNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFRoaXMgcGF0Y2ggcmVtb3ZlcyBkZWFkIGNvZGUgYWJvdXQgW0xlZ2FjeVBhcmVudF0g ZnJvbSBDb2RlR2VuZXJhdG9yR09iamVjdC5wbSwKKyAgICAgICAgYW5kIHJlbmFtZXMgW0xlZ2Fj eVBhcmVudF0gdG8gW0pTTGVnYWN5UGFyZW50XS4KKworICAgICAgICBObyB0ZXN0cy4gTm8gY2hh bmdlcyBpbiBiZWhhdmlvci4KKworICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVy YXRvckdPYmplY3QucG06CisgICAgICAgIChHZW5lcmF0ZSk6CisgICAgICAgICogYmluZGluZ3Mv c2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG06CisgICAgICAgIChHZXRQYXJlbnRDbGFzc05hbWUp OgorICAgICAgICAoR2VuZXJhdGVIZWFkZXIpOgorICAgICAgICAoR2VuZXJhdGVJbXBsZW1lbnRh dGlvbik6CisgICAgICAgICogcGFnZS9ET01XaW5kb3cuaWRsOgorICAgICAgICAqIHdvcmtlcnMv V29ya2VyQ29udGV4dC5pZGw6CisKIDIwMTItMDEtMjkgIFBhYmxvIEZsb3VyZXQgIDxwYWJsb2ZA bW90b3JvbGEuY29tPgogCiAgICAgICAgIFY4IGlkbCBjb2RlIGdlbmVyYXRvciBkb2Vzbid0IGhh bmRsZSBTZXJpYWxpemVkU2NyaXB0VmFsdWUgYXR0cmlidXRlcyBwcm9wZXJseS4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckdPYmplY3Qu cG0gYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JHT2JqZWN0 LnBtCmluZGV4IDM1OGIzYTk2MzgxMTNmYmJjYjU2N2YzM2NmMjJjNmE2MWE5MTgzMjguLjVkMjY0 MTRlYTg0ZTQzNGM4YWRhMDgwNzJkOTFjYWZlODQ3MTBlMjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckdPYmplY3QucG0KKysrIGIvU291 cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yR09iamVjdC5wbQpAQCAt MTIzMSw5ICsxMjMxLDYgQEAgRU9GCiBzdWIgR2VuZXJhdGUgewogICAgIG15ICgkb2JqZWN0LCAk ZGF0YU5vZGUpID0gQF87CiAKLSAgICBteSAkaGFzTGVnYWN5UGFyZW50ID0gJGRhdGFOb2RlLT5l eHRlbmRlZEF0dHJpYnV0ZXMtPnsiTGVnYWN5UGFyZW50In07Ci0gICAgbXkgJGhhc1JlYWxQYXJl bnQgPSBAeyRkYXRhTm9kZS0+cGFyZW50c30gPiAwOwotICAgIG15ICRoYXNQYXJlbnQgPSAkaGFz TGVnYWN5UGFyZW50IHx8ICRoYXNSZWFsUGFyZW50OwogICAgIG15ICRwYXJlbnRDbGFzc05hbWUg PSBHZXRQYXJlbnRDbGFzc05hbWUoJGRhdGFOb2RlKTsKICAgICBteSAkcGFyZW50R09ialR5cGUg PSBHZXRQYXJlbnRHT2JqVHlwZSgkZGF0YU5vZGUpOwogICAgIG15ICRpbnRlcmZhY2VOYW1lID0g JGRhdGFOb2RlLT5uYW1lOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2Ny aXB0cy9Db2RlR2VuZXJhdG9ySlMucG0gYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRz L0NvZGVHZW5lcmF0b3JKUy5wbQppbmRleCA4NGMwNjFmNDc3ZDJhMjUzMDYwZTk3YmM5OGFkOGIw ZDRkZjliZTUzLi42NjExYmM4ZWM0ZmE3NzZkODEyYmE5YmMwYTExNzQzN2IwMDMyZDI1IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5w bQorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5w bQpAQCAtMTg0LDcgKzE4NCw3IEBAIHN1YiBHZXRQYXJlbnRDbGFzc05hbWUKIHsKICAgICBteSAk ZGF0YU5vZGUgPSBzaGlmdDsKIAotICAgIHJldHVybiAkZGF0YU5vZGUtPmV4dGVuZGVkQXR0cmli dXRlcy0+eyJMZWdhY3lQYXJlbnQifSBpZiAkZGF0YU5vZGUtPmV4dGVuZGVkQXR0cmlidXRlcy0+ eyJMZWdhY3lQYXJlbnQifTsKKyAgICByZXR1cm4gJGRhdGFOb2RlLT5leHRlbmRlZEF0dHJpYnV0 ZXMtPnsiSlNMZWdhY3lQYXJlbnQifSBpZiAkZGF0YU5vZGUtPmV4dGVuZGVkQXR0cmlidXRlcy0+ eyJKU0xlZ2FjeVBhcmVudCJ9OwogICAgIHJldHVybiAiSlNET01XcmFwcGVyIiBpZiAoQHskZGF0 YU5vZGUtPnBhcmVudHN9IGVxIDApOwogICAgIHJldHVybiAiSlMiIC4gJGNvZGVHZW5lcmF0b3It PlN0cmlwTW9kdWxlKCRkYXRhTm9kZS0+cGFyZW50cygwKSk7CiB9CkBAIC02NTIsNyArNjUyLDcg QEAgc3ViIEdlbmVyYXRlSGVhZGVyCiAgICAgICAgICRjb2RlR2VuZXJhdG9yLT5BZGRNZXRob2Rz Q29uc3RhbnRzQW5kQXR0cmlidXRlc0Zyb21QYXJlbnRDbGFzc2VzKCRkYXRhTm9kZSwgXEBhbmNl c3RvckludGVyZmFjZU5hbWVzKTsKICAgICB9CiAKLSAgICBteSAkaGFzTGVnYWN5UGFyZW50ID0g JGRhdGFOb2RlLT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsiTGVnYWN5UGFyZW50In07CisgICAgbXkg JGhhc0xlZ2FjeVBhcmVudCA9ICRkYXRhTm9kZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IkpTTGVn YWN5UGFyZW50In07CiAgICAgbXkgJGhhc1JlYWxQYXJlbnQgPSBAeyRkYXRhTm9kZS0+cGFyZW50 c30gPiAwOwogICAgIG15ICRoYXNQYXJlbnQgPSAkaGFzTGVnYWN5UGFyZW50IHx8ICRoYXNSZWFs UGFyZW50OwogICAgIG15ICRwYXJlbnRDbGFzc05hbWUgPSBHZXRQYXJlbnRDbGFzc05hbWUoJGRh dGFOb2RlKTsKQEAgLTEzMjMsNyArMTMyMyw3IEBAIHN1YiBHZW5lcmF0ZUltcGxlbWVudGF0aW9u CiAgICAgbXkgJGNsYXNzTmFtZSA9ICJKUyRpbnRlcmZhY2VOYW1lIjsKICAgICBteSAkaW1wbENs YXNzTmFtZSA9ICRpbnRlcmZhY2VOYW1lOwogCi0gICAgbXkgJGhhc0xlZ2FjeVBhcmVudCA9ICRk YXRhTm9kZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IkxlZ2FjeVBhcmVudCJ9OworICAgIG15ICRo YXNMZWdhY3lQYXJlbnQgPSAkZGF0YU5vZGUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJKU0xlZ2Fj eVBhcmVudCJ9OwogICAgIG15ICRoYXNSZWFsUGFyZW50ID0gQHskZGF0YU5vZGUtPnBhcmVudHN9 ID4gMDsKICAgICBteSAkaGFzUGFyZW50ID0gJGhhc0xlZ2FjeVBhcmVudCB8fCAkaGFzUmVhbFBh cmVudDsKICAgICBteSAkcGFyZW50Q2xhc3NOYW1lID0gR2V0UGFyZW50Q2xhc3NOYW1lKCRkYXRh Tm9kZSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5pZGwgYi9T b3VyY2UvV2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5pZGwKaW5kZXggZGM0NDQzNGZmZjFhYTk4ZjQ5 MGI3YzZjNjA1Y2JjNzk5MWU0ZjM3Ni4uNjFiMmNhYWVlNjQ1MWQ0ZDE3NWI1OGEyZTdhMGRiMzU5 ZmVmN2MzNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9ET01XaW5kb3cuaWRsCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NV2luZG93LmlkbApAQCAtNDAsNyArNDAsNyBAQCBt b2R1bGUgd2luZG93IHsKICAgICAgICAgRXh0ZW5kc0RPTUdsb2JhbE9iamVjdCwKICAgICAgICAg R2VuZXJhdGVOYXRpdmVDb252ZXJ0ZXIsCiAgICAgICAgIFJlcGxhY2VhYmxlQ29uc3RydWN0b3Is Ci0gICAgICAgIExlZ2FjeVBhcmVudD1KU0RPTVdpbmRvd0Jhc2UKKyAgICAgICAgSlNMZWdhY3lQ YXJlbnQ9SlNET01XaW5kb3dCYXNlCiAgICAgXSBET01XaW5kb3cgewogICAgICAgICAvLyBET00g TGV2ZWwgMAogICAgICAgICBhdHRyaWJ1dGUgW1JlcGxhY2VhYmxlXSBTY3JlZW4gc2NyZWVuOwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvd29ya2Vycy9Xb3JrZXJDb250ZXh0LmlkbCBiL1Nv dXJjZS9XZWJDb3JlL3dvcmtlcnMvV29ya2VyQ29udGV4dC5pZGwKaW5kZXggZDA0ZjA2YjZkOGJh YzRlYjRlYjVlMjc1ODQ4NDY5ZmE4YTIzZDlmNi4uNjZhMzk2ODQzZjc4OWM5NGI3NTZjMzBjOWFi YmFjYjVjM2UyMmY2ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvd29ya2Vycy9Xb3JrZXJD b250ZXh0LmlkbAorKysgYi9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL1dvcmtlckNvbnRleHQuaWRs CkBAIC0zMyw3ICszMyw3IEBAIG1vZHVsZSB0aHJlYWRzIHsKICAgICAgICAgRXZlbnRUYXJnZXQs CiAgICAgICAgIEV4dGVuZHNET01HbG9iYWxPYmplY3QsCiAgICAgICAgIElzV29ya2VyQ29udGV4 dCwKLSAgICAgICAgTGVnYWN5UGFyZW50PUpTV29ya2VyQ29udGV4dEJhc2UsCisgICAgICAgIEpT TGVnYWN5UGFyZW50PUpTV29ya2VyQ29udGV4dEJhc2UsCiAgICAgICAgIE5vU3RhdGljVGFibGVz LAogICAgICAgICBPbWl0Q29uc3RydWN0b3IKICAgICBdIFdvcmtlckNvbnRleHQgewo=