77701 2012-02-02 18:26:22 -0800 Remove OVERRIDE from ColorInputType::valueAsColor 2012-02-07 12:39:12 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 keishi keishi darin tkent webkit.review.bot oldest_to_newest 548321 0 keishi 2012-02-02 18:26:22 -0800 Remove OVERRIDE from ColorInputType::valueAsColor, it was a mistake. 548327 1 125226 keishi 2012-02-02 18:31:03 -0800 Created attachment 125226 Patch 548349 2 125226 tkent 2012-02-02 19:04:52 -0800 Comment on attachment 125226 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125226&action=review > Source/WebCore/html/ColorInputType.h:57 > - virtual Color valueAsColor() const OVERRIDE; > + virtual Color valueAsColor() const; Do we need virtual? 548352 3 125235 keishi 2012-02-02 19:10:33 -0800 Created attachment 125235 Patch 548353 4 125235 tkent 2012-02-02 19:11:17 -0800 Comment on attachment 125235 Patch ok 548416 5 125235 webkit.review.bot 2012-02-02 21:14:56 -0800 Comment on attachment 125235 Patch Clearing flags on attachment: 125235 Committed r106624: <http://trac.webkit.org/changeset/106624> 548417 6 webkit.review.bot 2012-02-02 21:15:00 -0800 All reviewed patches have been landed. Closing bug. 551249 7 darin 2012-02-07 12:39:12 -0800 Hooray, this is just what OVERRIDE is for! Without OVERRIDE we probably would have had an unnecessary virtual function. 125226 2012-02-02 18:31:03 -0800 2012-02-02 19:10:23 -0800 Patch bug-77701-20120203113101.patch text/plain 1407 keishi U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2NjA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjczYjA5ZDU4ZGU1MGRl ZDU3ZDBjNzA3OTliNjIwYmJmMmUxMTVmZi4uNDdhNDcyMzMxZmVhNWNjZjFiMTljOWFmY2JkYjIx YTgwN2M4MTllMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTAyLTAyICBLZWlz aGkgSGF0dG9yaSAgPGtlaXNoaUB3ZWJraXQub3JnPgorCisgICAgICAgIFJlbW92ZSBPVkVSUklE RSBmcm9tIENvbG9ySW5wdXRUeXBlOjp2YWx1ZUFzQ29sb3IKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc3NzAxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBodG1sL0NvbG9ySW5wdXRUeXBlLmg6CisgICAg ICAgIChXZWJDb3JlOjpDb2xvcklucHV0VHlwZTo6dmFsdWVBc0NvbG9yKToKKwogMjAxMi0wMi0w MiAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBT Y3JvbGxpbmdUcmVlIGNsYXNzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0NvbG9y SW5wdXRUeXBlLmggYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0NvbG9ySW5wdXRUeXBlLmgKaW5kZXgg ZDUxZGVhYTdkYmU1M2UyNjhlYWY3NmQ4YmExNWM2M2YzNGI0YmQxNS4uNzY4MTY2MzkxM2FlNWE5 NjQyMDEwM2UzMjQyN2ExZDMyZjMzZGYzNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRt bC9Db2xvcklucHV0VHlwZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvQ29sb3JJbnB1dFR5 cGUuaApAQCAtNTQsNyArNTQsNyBAQCBwcml2YXRlOgogICAgIHZpcnR1YWwgYm9vbCBzdXBwb3J0 c1JlcXVpcmVkKCkgY29uc3QgT1ZFUlJJREU7CiAgICAgdmlydHVhbCBTdHJpbmcgZmFsbGJhY2tW YWx1ZSgpIGNvbnN0IE9WRVJSSURFOwogICAgIHZpcnR1YWwgU3RyaW5nIHNhbml0aXplVmFsdWUo Y29uc3QgU3RyaW5nJikgY29uc3QgT1ZFUlJJREU7Ci0gICAgdmlydHVhbCBDb2xvciB2YWx1ZUFz Q29sb3IoKSBjb25zdCBPVkVSUklERTsKKyAgICB2aXJ0dWFsIENvbG9yIHZhbHVlQXNDb2xvcigp IGNvbnN0OwogICAgIHZpcnR1YWwgdm9pZCBjcmVhdGVTaGFkb3dTdWJ0cmVlKCkgT1ZFUlJJREU7 CiAgICAgdmlydHVhbCB2b2lkIHNldFZhbHVlKGNvbnN0IFN0cmluZyYsIGJvb2wgdmFsdWVDaGFu Z2VkLCBib29sIHNlbmRDaGFuZ2VFdmVudCkgT1ZFUlJJREU7CiAgICAgdmlydHVhbCB2b2lkIGhh bmRsZURPTUFjdGl2YXRlRXZlbnQoRXZlbnQqKSBPVkVSUklERTsK 125235 2012-02-02 19:10:33 -0800 2012-02-02 21:14:56 -0800 Patch bug-77701-20120203121031.patch text/plain 1545 keishi U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2NjA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjczYjA5ZDU4ZGU1MGRl ZDU3ZDBjNzA3OTliNjIwYmJmMmUxMTVmZi4uNDdhNDcyMzMxZmVhNWNjZjFiMTljOWFmY2JkYjIx YTgwN2M4MTllMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTAyLTAyICBLZWlz aGkgSGF0dG9yaSAgPGtlaXNoaUB3ZWJraXQub3JnPgorCisgICAgICAgIFJlbW92ZSBPVkVSUklE RSBmcm9tIENvbG9ySW5wdXRUeXBlOjp2YWx1ZUFzQ29sb3IKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc3NzAxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBodG1sL0NvbG9ySW5wdXRUeXBlLmg6CisgICAg ICAgIChXZWJDb3JlOjpDb2xvcklucHV0VHlwZTo6dmFsdWVBc0NvbG9yKToKKwogMjAxMi0wMi0w MiAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBT Y3JvbGxpbmdUcmVlIGNsYXNzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0NvbG9y SW5wdXRUeXBlLmggYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0NvbG9ySW5wdXRUeXBlLmgKaW5kZXgg ZDUxZGVhYTdkYmU1M2UyNjhlYWY3NmQ4YmExNWM2M2YzNGI0YmQxNS4uM2UwNjRiZDQ0MDljMDM2 NjgzMjM1YmZlOTZlNTNkNDFiOWU3NDJiMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRt bC9Db2xvcklucHV0VHlwZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvQ29sb3JJbnB1dFR5 cGUuaApAQCAtNTQsMTIgKzU0LDEyIEBAIHByaXZhdGU6CiAgICAgdmlydHVhbCBib29sIHN1cHBv cnRzUmVxdWlyZWQoKSBjb25zdCBPVkVSUklERTsKICAgICB2aXJ0dWFsIFN0cmluZyBmYWxsYmFj a1ZhbHVlKCkgY29uc3QgT1ZFUlJJREU7CiAgICAgdmlydHVhbCBTdHJpbmcgc2FuaXRpemVWYWx1 ZShjb25zdCBTdHJpbmcmKSBjb25zdCBPVkVSUklERTsKLSAgICB2aXJ0dWFsIENvbG9yIHZhbHVl QXNDb2xvcigpIGNvbnN0IE9WRVJSSURFOwogICAgIHZpcnR1YWwgdm9pZCBjcmVhdGVTaGFkb3dT dWJ0cmVlKCkgT1ZFUlJJREU7CiAgICAgdmlydHVhbCB2b2lkIHNldFZhbHVlKGNvbnN0IFN0cmlu ZyYsIGJvb2wgdmFsdWVDaGFuZ2VkLCBib29sIHNlbmRDaGFuZ2VFdmVudCkgT1ZFUlJJREU7CiAg ICAgdmlydHVhbCB2b2lkIGhhbmRsZURPTUFjdGl2YXRlRXZlbnQoRXZlbnQqKSBPVkVSUklERTsK ICAgICB2aXJ0dWFsIHZvaWQgZGV0YWNoKCkgT1ZFUlJJREU7CiAKKyAgICBDb2xvciB2YWx1ZUFz Q29sb3IoKSBjb25zdDsKICAgICB2b2lkIGVuZENvbG9yQ2hvb3NlcigpOwogICAgIHZvaWQgdXBk YXRlQ29sb3JTd2F0Y2goKTsKICAgICBIVE1MRWxlbWVudCogc2hhZG93Q29sb3JTd2F0Y2goKSBj b25zdDsK