7770 2006-03-14 16:57:57 -0800 Should only dispatch the khtmlTextInsertedEvent for high level editing operations 2006-03-14 19:14:52 -0800 1 1 1 Unclassified WebKit HTML Editing 420+ Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 justin.garcia justin.garcia adele oldest_to_newest 36342 0 justin.garcia 2006-03-14 16:57:57 -0800 The khtmlTextInsertedEvent is used to tell the new form fields that their inner div has been edited. We don't need to tell them about every low level editing operation that we use to implement the higher level ones. This also eliminates a big performance regression. 36343 1 7068 justin.garcia 2006-03-14 16:58:50 -0800 Created attachment 7068 patch 36344 2 7068 adele 2006-03-14 17:03:50 -0800 Comment on attachment 7068 patch looks good! thanks for fixing this up. 36348 3 justin.garcia 2006-03-14 19:14:39 -0800 We noticed that high level commands that go into an open TypingCommand don't go through EditCommand::apply, however they do go through appliedEditing/unappliedEditing/reappliedEditing on Frame, so that's where we dispatch. 7068 2006-03-14 16:58:50 -0800 2006-03-14 17:03:50 -0800 patch 7770.txt text/plain 3386 justin.garcia SW5kZXg6IEVkaXRDb21tYW5kLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBFZGl0Q29tbWFuZC5jcHAJKHJl dmlzaW9uIDEzMjU1KQorKysgRWRpdENvbW1hbmQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xOTks NiArMTk5LDE2IEBACiB7CiB9CiAKK3ZvaWQgRWRpdENvbW1hbmQ6OmRpc3BhdGNoS0hUTUxUZXh0 SW5zZXJ0ZWRFdmVudCgpCit7CisgICAgTm9kZUltcGwqIHN0YXJ0Tm9kZSA9IGVuZGluZ1NlbGVj dGlvbigpLnN0YXJ0KCkubm9kZSgpOworICAgIGlmIChzdGFydE5vZGUgJiYgc3RhcnROb2RlLT5y b290RWRpdGFibGVFbGVtZW50KCkpIHsKKyAgICAgICAgRXhjZXB0aW9uQ29kZSBlYyA9IDA7Cisg ICAgICAgIFJlZlB0cjxFdmVudEltcGw+IGV2dCA9IG5ldyBFdmVudEltcGwoa2h0bWxUZXh0SW5z ZXJ0ZWRFdmVudCwgZmFsc2UsIGZhbHNlKTsKKyAgICAgICAgc3RhcnROb2RlLT5yb290RWRpdGFi bGVFbGVtZW50KCktPmRpc3BhdGNoRXZlbnQoZXZ0LCBlYywgdHJ1ZSk7CisgICAgfQorfQorCiB2 b2lkIEVkaXRDb21tYW5kOjphcHBseSgpCiB7CiAgICAgQVNTRVJUKG1fZG9jdW1lbnQpOwpAQCAt MjIwLDE1ICsyMzAsOCBAQAogICAgICAgICB1cGRhdGVMYXlvdXQoKTsKICAgICAgICAgRWRpdENv bW1hbmRQdHIgY21kKHRoaXMpOwogICAgICAgICBmcmFtZS0+YXBwbGllZEVkaXRpbmcoY21kKTsK KyAgICAgICAgZGlzcGF0Y2hLSFRNTFRleHRJbnNlcnRlZEV2ZW50KCk7CiAgICAgfQotICAgIAot ICAgIE5vZGVJbXBsKiBzdGFydE5vZGUgPSBlbmRpbmdTZWxlY3Rpb24oKS5zdGFydCgpLm5vZGUo KTsKLSAgICBpZiAoc3RhcnROb2RlICYmIHN0YXJ0Tm9kZS0+cm9vdEVkaXRhYmxlRWxlbWVudCgp KSB7Ci0gICAgICAgIC8vIFNlbmQga2h0bWxUZXh0SW5zZXJ0ZWRFdmVudCB0byByb290RWRpdGFi bGVFbGVtZW50LgotICAgICAgICBFeGNlcHRpb25Db2RlIGVjID0gMDsKLSAgICAgICAgUmVmUHRy PEV2ZW50SW1wbD4gZXZ0ID0gbmV3IEV2ZW50SW1wbChraHRtbFRleHRJbnNlcnRlZEV2ZW50LCBm YWxzZSwgZmFsc2UpOwotICAgICAgICBzdGFydE5vZGUtPnJvb3RFZGl0YWJsZUVsZW1lbnQoKS0+ ZGlzcGF0Y2hFdmVudChldnQsIGVjLCB0cnVlKTsKLSAgICB9CiB9CiAKIHZvaWQgRWRpdENvbW1h bmQ6OnVuYXBwbHkoKQpAQCAtMjM2LDggKzIzOSw2IEBACiAgICAgQVNTRVJUKG1fZG9jdW1lbnQp OwogICAgIEFTU0VSVChtX2RvY3VtZW50LT5mcmFtZSgpKTsKICAgICBBU1NFUlQoc3RhdGUoKSA9 PSBBcHBsaWVkKTsKLQotICAgIGJvb2wgdG9wTGV2ZWwgPSAhaXNDb21wb3NpdGVTdGVwKCk7CiAg CiAgICAgRnJhbWUgKmZyYW1lID0gbV9kb2N1bWVudC0+ZnJhbWUoKTsKICAgICAKQEAgLTI0NSwx OSArMjQ2LDEyIEBACiAgICAgCiAgICAgbV9zdGF0ZSA9IE5vdEFwcGxpZWQ7CiAKLSAgICBpZiAo dG9wTGV2ZWwpIHsKKyAgICBpZiAoIWlzQ29tcG9zaXRlU3RlcCgpKSB7CiAgICAgICAgIHVwZGF0 ZUxheW91dCgpOwogICAgICAgICBFZGl0Q29tbWFuZFB0ciBjbWQodGhpcyk7CiAgICAgICAgIGZy YW1lLT51bmFwcGxpZWRFZGl0aW5nKGNtZCk7CisgICAgICAgIGRpc3BhdGNoS0hUTUxUZXh0SW5z ZXJ0ZWRFdmVudCgpOwogICAgIH0KLSAgICAKLSAgICBOb2RlSW1wbCogc3RhcnROb2RlID0gZW5k aW5nU2VsZWN0aW9uKCkuc3RhcnQoKS5ub2RlKCk7Ci0gICAgaWYgKHN0YXJ0Tm9kZSAmJiBzdGFy dE5vZGUtPnJvb3RFZGl0YWJsZUVsZW1lbnQoKSkgewotICAgICAgICAvLyBTZW5kIGtodG1sVGV4 dEluc2VydGVkRXZlbnQgdG8gcm9vdEVkaXRhYmxlRWxlbWVudC4KLSAgICAgICAgRXhjZXB0aW9u Q29kZSBlYyA9IDA7Ci0gICAgICAgIFJlZlB0cjxFdmVudEltcGw+IGV2dCA9IG5ldyBFdmVudElt cGwoa2h0bWxUZXh0SW5zZXJ0ZWRFdmVudCwgZmFsc2UsIGZhbHNlKTsKLSAgICAgICAgc3RhcnRO b2RlLT5yb290RWRpdGFibGVFbGVtZW50KCktPmRpc3BhdGNoRXZlbnQoZXZ0LCBlYywgdHJ1ZSk7 Ci0gICAgfQogfQogCiB2b2lkIEVkaXRDb21tYW5kOjpyZWFwcGx5KCkKQEAgLTI2NSw4ICsyNTks NiBAQAogICAgIEFTU0VSVChtX2RvY3VtZW50KTsKICAgICBBU1NFUlQobV9kb2N1bWVudC0+ZnJh bWUoKSk7CiAgICAgQVNTRVJUKHN0YXRlKCkgPT0gTm90QXBwbGllZCk7Ci0gICAgCi0gICAgYm9v bCB0b3BMZXZlbCA9ICFpc0NvbXBvc2l0ZVN0ZXAoKTsKICAKICAgICBGcmFtZSAqZnJhbWUgPSBt X2RvY3VtZW50LT5mcmFtZSgpOwogICAgIApAQCAtMjc0LDE5ICsyNjYsMTIgQEAKICAgICAKICAg ICBtX3N0YXRlID0gQXBwbGllZDsKIAotICAgIGlmICh0b3BMZXZlbCkgeworICAgIGlmICghaXND b21wb3NpdGVTdGVwKCkpIHsKICAgICAgICAgdXBkYXRlTGF5b3V0KCk7CiAgICAgICAgIEVkaXRD b21tYW5kUHRyIGNtZCh0aGlzKTsKICAgICAgICAgZnJhbWUtPnJlYXBwbGllZEVkaXRpbmcoY21k KTsKKyAgICAgICAgZGlzcGF0Y2hLSFRNTFRleHRJbnNlcnRlZEV2ZW50KCk7CiAgICAgfQotICAg IAotICAgIE5vZGVJbXBsKiBzdGFydE5vZGUgPSBlbmRpbmdTZWxlY3Rpb24oKS5zdGFydCgpLm5v ZGUoKTsKLSAgICBpZiAoc3RhcnROb2RlICYmIHN0YXJ0Tm9kZS0+cm9vdEVkaXRhYmxlRWxlbWVu dCgpKSB7Ci0gICAgICAgIC8vIFNlbmQga2h0bWxUZXh0SW5zZXJ0ZWRFdmVudCB0byByb290RWRp dGFibGVFbGVtZW50LgotICAgICAgICBFeGNlcHRpb25Db2RlIGVjID0gMDsKLSAgICAgICAgUmVm UHRyPEV2ZW50SW1wbD4gZXZ0ID0gbmV3IEV2ZW50SW1wbChraHRtbFRleHRJbnNlcnRlZEV2ZW50 LCBmYWxzZSwgZmFsc2UpOwotICAgICAgICBzdGFydE5vZGUtPnJvb3RFZGl0YWJsZUVsZW1lbnQo KS0+ZGlzcGF0Y2hFdmVudChldnQsIGVjLCB0cnVlKTsKLSAgICB9CiB9CiAKIHZvaWQgRWRpdENv bW1hbmQ6OmRvUmVhcHBseSgpCkluZGV4OiBFZGl0Q29tbWFuZC5oCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEVk aXRDb21tYW5kLmgJKHJldmlzaW9uIDEzMjU1KQorKysgRWRpdENvbW1hbmQuaAkod29ya2luZyBj b3B5KQpAQCAtOTUsNiArOTUsOCBAQAogICAgIFNlbGVjdGlvbiBtX2VuZGluZ1NlbGVjdGlvbjsK ICAgICBSZWZQdHI8Q1NTTXV0YWJsZVN0eWxlRGVjbGFyYXRpb25JbXBsPiBtX3R5cGluZ1N0eWxl OwogICAgIEVkaXRDb21tYW5kICptX3BhcmVudDsKKyAgICAKKyAgICB2b2lkIGRpc3BhdGNoS0hU TUxUZXh0SW5zZXJ0ZWRFdmVudCgpOwogfTsKIAogY2xhc3MgRWRpdENvbW1hbmRQdHIgOiBwdWJs aWMgUmVmUHRyPEVkaXRDb21tYW5kPgo=