77696 2012-02-02 17:50:31 -0800 Add webGLErrorsToConsoleEnabled Settings flag 2012-02-06 17:10:02 -0800 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 gman webkit-unassigned kbr webkit.review.bot oldest_to_newest 548291 0 gman 2012-02-02 17:50:31 -0800 Add webGLErrorsToConsoleEnabled Settings flag 548300 1 125221 gman 2012-02-02 17:54:54 -0800 Created attachment 125221 Patch 548301 2 gman 2012-02-02 17:57:10 -0800 This patch adds Settings::webGLErrorsToConsoleEnabled flag that UAs can set if they want synthesized WebGL errors to go to the JavaScript console. 550411 3 125221 kbr 2012-02-06 16:37:56 -0800 Comment on attachment 125221 Patch Looks good. r=me 550441 4 125221 webkit.review.bot 2012-02-06 17:09:58 -0800 Comment on attachment 125221 Patch Clearing flags on attachment: 125221 Committed r106881: <http://trac.webkit.org/changeset/106881> 550442 5 webkit.review.bot 2012-02-06 17:10:02 -0800 All reviewed patches have been landed. Closing bug. 125221 2012-02-02 17:54:54 -0800 2012-02-06 17:09:58 -0800 Patch bug-77696-20120202175512.patch text/plain 3724 gman U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2NjAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzE5ODM4MWQzMjU3MTI0 MDBjNDM0MDg0MjNlOWU3MzVhNzY4YWQ4YS4uNWM3NTg1MjUwZmFlNmNlOWM2NTNiNGE3MGUxZTEy Zjk3OTAzMjQzNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTAyLTAyICBHcmVn ZyBUYXZhcmVzICA8Z21hbkBnb29nbGUuY29tPgorCisgICAgICAgIEFkZCB3ZWJHTEVycm9yc1Rv Q29uc29sZUVuYWJsZWQgU2V0dGluZ3MgZmxhZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Nzc2OTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMgYXMgdGhlcmUgaXMgbm8gY2hhbmdlIGlu IGJlaGF2aW9yLgorCisgICAgICAgICogaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0 LmNwcDoKKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAgICAoV2ViQ29yZTo6V2ViR0xSZW5kZXJp bmdDb250ZXh0OjpzZXR1cEZsYWdzKToKKyAgICAgICAgKiBwYWdlL1NldHRpbmdzLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlNldHRpbmdzOjpTZXR0aW5ncyk6CisgICAgICAgICogcGFnZS9TZXR0 aW5ncy5oOgorICAgICAgICAoU2V0dGluZ3MpOgorICAgICAgICAoV2ViQ29yZTo6U2V0dGluZ3M6 OndlYkdMRXJyb3JzVG9Db25zb2xlRW5hYmxlZCk6CisKIDIwMTItMDItMDIgIEp1c3RpbiBOb3Zv c2FkICA8anVub3ZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtDaHJvbWl1bV0gVXNlIFNrQ2Fu dmFzOjpmbHVzaCBpbiBza2lhIHBvcnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwv Y2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL2Nh bnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwCmluZGV4IDk0NWMxN2U3NGYwYzNmMTAwYjBl YTRmN2Y5ZDQ3NGEyZGUxOTY0NmMuLmY3OThlZDJhYmRjZjliMmNiYzZkYjYxM2RhN2UzZjI5Yjc1 ODU4NDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVy aW5nQ29udGV4dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5k ZXJpbmdDb250ZXh0LmNwcApAQCAtNTE3LDYgKzUxNywxMCBAQCB2b2lkIFdlYkdMUmVuZGVyaW5n Q29udGV4dDo6c2V0dXBGbGFncygpCiB7CiAgICAgQVNTRVJUKG1fY29udGV4dCk7CiAKKyAgICBQ YWdlKiBwID0gY2FudmFzKCktPmRvY3VtZW50KCktPnBhZ2UoKTsKKyAgICBpZiAocCAmJiBwLT5z ZXR0aW5ncygpLT53ZWJHTEVycm9yc1RvQ29uc29sZUVuYWJsZWQoKSkKKyAgICAgICAgbV9zeW50 aGVzaXplZEVycm9yc1RvQ29uc29sZSA9IHRydWU7CisKICAgICBtX2lzR0xFUzJDb21wbGlhbnQg PSBtX2NvbnRleHQtPmlzR0xFUzJDb21wbGlhbnQoKTsKICAgICBtX2lzRXJyb3JHZW5lcmF0ZWRP bk91dE9mQm91bmRzQWNjZXNzZXMgPSBtX2NvbnRleHQtPmdldEV4dGVuc2lvbnMoKS0+aXNFbmFi bGVkKCJHTF9DSFJPTUlVTV9zdHJpY3RfYXR0cmlicyIpOwogICAgIG1faXNSZXNvdXJjZVNhZmUg PSBtX2NvbnRleHQtPmdldEV4dGVuc2lvbnMoKS0+aXNFbmFibGVkKCJHTF9DSFJPTUlVTV9yZXNv dXJjZV9zYWZlIik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1NldHRpbmdzLmNw cCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvU2V0dGluZ3MuY3BwCmluZGV4IDU5OWNiMzExMGVlOGRk NTNmMDdmYWJjMDMxMTA4OThkOGE3ZmE1YWYuLmYwZmNhZWVmZDk3NjIxOGE0YmZjYjE1YjkxMzdk ZDJlYWYwMjNiYmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvU2V0dGluZ3MuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvU2V0dGluZ3MuY3BwCkBAIC0xODksNiArMTg5LDcg QEAgU2V0dGluZ3M6OlNldHRpbmdzKFBhZ2UqIHBhZ2UpCiAgICAgLCBtX3Nob3dSZXBhaW50Q291 bnRlcihmYWxzZSkKICAgICAsIG1fZXhwZXJpbWVudGFsTm90aWZpY2F0aW9uc0VuYWJsZWQoZmFs c2UpCiAgICAgLCBtX3dlYkdMRW5hYmxlZChmYWxzZSkKKyAgICAsIG1fd2ViR0xFcnJvcnNUb0Nv bnNvbGVFbmFibGVkKGZhbHNlKQogICAgICwgbV9vcGVuR0xNdWx0aXNhbXBsaW5nRW5hYmxlZCh0 cnVlKQogICAgICwgbV9wcml2aWxlZ2VkV2ViR0xFeHRlbnNpb25zRW5hYmxlZChmYWxzZSkKICAg ICAsIG1fd2ViQXVkaW9FbmFibGVkKGZhbHNlKQpAQCAtODAzLDYgKzgwNCwxMSBAQCB2b2lkIFNl dHRpbmdzOjpzZXRXZWJHTEVuYWJsZWQoYm9vbCBlbmFibGVkKQogICAgIG1fd2ViR0xFbmFibGVk ID0gZW5hYmxlZDsKIH0KIAordm9pZCBTZXR0aW5nczo6c2V0V2ViR0xFcnJvcnNUb0NvbnNvbGVF bmFibGVkKGJvb2wgZW5hYmxlZCkKK3sKKyAgICBtX3dlYkdMRXJyb3JzVG9Db25zb2xlRW5hYmxl ZCA9IGVuYWJsZWQ7Cit9CisKIHZvaWQgU2V0dGluZ3M6OnNldE9wZW5HTE11bHRpc2FtcGxpbmdF bmFibGVkKGJvb2wgZW5hYmxlZCkKIHsKICAgICBtX29wZW5HTE11bHRpc2FtcGxpbmdFbmFibGVk ID0gZW5hYmxlZDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvU2V0dGluZ3MuaCBi L1NvdXJjZS9XZWJDb3JlL3BhZ2UvU2V0dGluZ3MuaAppbmRleCA1ZWY4ZWVhN2ZhMmQ3YTJhOTg2 MTRkMjM3MjM4MDg4ZmIxMDUwMTgzLi5hMjJmYzVlODAzYjc1YTY2NmI3MjZlOTg1OGE5MGQyMGYw ZTJmNDFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1NldHRpbmdzLmgKKysrIGIv U291cmNlL1dlYkNvcmUvcGFnZS9TZXR0aW5ncy5oCkBAIC0zNTcsNiArMzU3LDkgQEAgbmFtZXNw YWNlIFdlYkNvcmUgewogICAgICAgICB2b2lkIHNldFdlYkdMRW5hYmxlZChib29sKTsKICAgICAg ICAgYm9vbCB3ZWJHTEVuYWJsZWQoKSBjb25zdCB7IHJldHVybiBtX3dlYkdMRW5hYmxlZDsgfQog CisgICAgICAgIHZvaWQgc2V0V2ViR0xFcnJvcnNUb0NvbnNvbGVFbmFibGVkKGJvb2wpOworICAg ICAgICBib29sIHdlYkdMRXJyb3JzVG9Db25zb2xlRW5hYmxlZCgpIGNvbnN0IHsgcmV0dXJuIG1f d2ViR0xFcnJvcnNUb0NvbnNvbGVFbmFibGVkOyB9CisKICAgICAgICAgdm9pZCBzZXRPcGVuR0xN dWx0aXNhbXBsaW5nRW5hYmxlZChib29sKTsKICAgICAgICAgYm9vbCBvcGVuR0xNdWx0aXNhbXBs aW5nRW5hYmxlZCgpIGNvbnN0IHsgcmV0dXJuIG1fb3BlbkdMTXVsdGlzYW1wbGluZ0VuYWJsZWQ7 IH0KIApAQCAtNjE4LDYgKzYyMSw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgYm9v bCBtX3Nob3dSZXBhaW50Q291bnRlciA6IDE7CiAgICAgICAgIGJvb2wgbV9leHBlcmltZW50YWxO b3RpZmljYXRpb25zRW5hYmxlZCA6IDE7CiAgICAgICAgIGJvb2wgbV93ZWJHTEVuYWJsZWQgOiAx OworICAgICAgICBib29sIG1fd2ViR0xFcnJvcnNUb0NvbnNvbGVFbmFibGVkIDogMTsKICAgICAg ICAgYm9vbCBtX29wZW5HTE11bHRpc2FtcGxpbmdFbmFibGVkIDogMTsKICAgICAgICAgYm9vbCBt X3ByaXZpbGVnZWRXZWJHTEV4dGVuc2lvbnNFbmFibGVkIDogMTsKICAgICAgICAgYm9vbCBtX3dl YkF1ZGlvRW5hYmxlZCA6IDE7Cg==