77689 2012-02-02 15:44:36 -0800 [Qt] Implement ImageBuffer::copyImage(ImageBuffer::DontCopyBackingStore) 2012-02-06 06:18:34 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt P2 Normal --- 1 noam webkit-unassigned hausmann kenneth webkit.review.bot oldest_to_newest 548212 0 noam 2012-02-02 15:44:36 -0800 Right now Qt asserts when tring to do a shallow copy of ImageBuffer. We want to use that feature for TextureMapper (see https://bugs.webkit.org/show_bug.cgi?id=77148). 548234 1 125207 noam 2012-02-02 16:25:36 -0800 Created attachment 125207 Patch 548778 2 125347 noam 2012-02-03 09:07:11 -0800 Created attachment 125347 Patch 549943 3 125347 webkit.review.bot 2012-02-06 06:18:30 -0800 Comment on attachment 125347 Patch Clearing flags on attachment: 125347 Committed r106804: <http://trac.webkit.org/changeset/106804> 549944 4 webkit.review.bot 2012-02-06 06:18:34 -0800 All reviewed patches have been landed. Closing bug. 125207 2012-02-02 16:25:36 -0800 2012-02-03 09:07:11 -0800 Patch patch2.diff text/plain 1798 noam ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAwZjBjYjIzLi41MDNmZmYzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTkg QEAKIDIwMTItMDItMDIgIE5vJ2FtIFJvc2VudGhhbCAgPG5vYW0ucm9zZW50aGFsQG5va2lhLmNv bT4KIAorICAgICAgICBbUXRdIEltcGxlbWVudCBJbWFnZUJ1ZmZlcjo6Y29weUltYWdlKEltYWdl QnVmZmVyOjpEb250Q29weUJhY2tpbmdTdG9yZSkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTc3Njg5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgTWFrZSBzdXJlIHdlIGNhbiBjcmVhdGUgYW4gSW1hZ2UgY29w eSB3aXRob3V0IGRldGFjaGluZyB0aGUgdW5kZXJseWluZyBiYWNraW5nLXN0b3JlLgorCisgICAg ICAgIE5vIG5ldyBmdW5jdGlvbmFsaXR5IHNvIG5vIG5ldyB0ZXN0cy4KKworICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL3F0L0ltYWdlQnVmZmVyUXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 SW1hZ2VCdWZmZXI6OmNvcHlJbWFnZSk6CisKKzIwMTItMDItMDIgIE5vJ2FtIFJvc2VudGhhbCAg PG5vYW0ucm9zZW50aGFsQG5va2lhLmNvbT4KKwogICAgICAgICBbUXRdW1RleG1hcF0gUmVmYWN0 b3IgVGV4dHVyZU1hcHBlciBBUEkgdG8gdXNlIEltYWdlQnVmZmVycyB3aGVuIHBvc3NpYmxlLgog ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzcxNDgKIApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvSW1hZ2VCdWZm ZXJRdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9JbWFnZUJ1ZmZl clF0LmNwcAppbmRleCBlMzZmZjg1Li44YzU3N2UzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9JbWFnZUJ1ZmZlclF0LmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9JbWFnZUJ1ZmZlclF0LmNwcApAQCAtMTIzLDggKzEy MywxMSBAQCBHcmFwaGljc0NvbnRleHQqIEltYWdlQnVmZmVyOjpjb250ZXh0KCkgY29uc3QKIAog UGFzc1JlZlB0cjxJbWFnZT4gSW1hZ2VCdWZmZXI6OmNvcHlJbWFnZShCYWNraW5nU3RvcmVDb3B5 IGNvcHlCZWhhdmlvcikgY29uc3QKIHsKLSAgICBBU1NFUlQoY29weUJlaGF2aW9yID09IENvcHlC YWNraW5nU3RvcmUpOwotICAgIHJldHVybiBTdGlsbEltYWdlOjpjcmVhdGUobV9kYXRhLm1fcGl4 bWFwKTsKKyAgICBpZiAoY29weUJlaGF2aW9yID09IENvcHlCYWNraW5nU3RvcmUpCisgICAgICAg IHJldHVybiBTdGlsbEltYWdlOjpjcmVhdGUobV9kYXRhLm1fcGl4bWFwKTsKKworICAgIC8vIElt YWdlQnVmZmVyRGF0YTo6dG9RSW1hZ2UoKSBmb3JjZXMgYSBzaGFsbG93IGNvcHksIHdvcmtpbmcg YXJvdW5kIHRoZSBpbXBsaWNpdCBiZWhhdm9pciBvZiBRSW1hZ2UvUVBpeG1hcC4KKyAgICByZXR1 cm4gU3RpbGxJbWFnZTo6Y3JlYXRlKFFQaXhtYXA6OmZyb21JbWFnZShtX2RhdGEudG9RSW1hZ2Uo KSkpOwogfQogCiB2b2lkIEltYWdlQnVmZmVyOjpkcmF3KEdyYXBoaWNzQ29udGV4dCogZGVzdENv bnRleHQsIENvbG9yU3BhY2Ugc3R5bGVDb2xvclNwYWNlLCBjb25zdCBGbG9hdFJlY3QmIGRlc3RS ZWN0LCBjb25zdCBGbG9hdFJlY3QmIHNyY1JlY3QsCg== 125347 2012-02-03 09:07:11 -0800 2012-02-06 06:18:29 -0800 Patch patch.diff text/plain 3072 noam ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmZDA0ZmI0Li5hZDk4OWNlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMTItMDItMDMgIE5vJ2FtIFJvc2VudGhhbCAgPG5vYW0ucm9zZW50aGFsQG5va2lhLmNv bT4KKworICAgICAgICBbUXRdIEltcGxlbWVudCBJbWFnZUJ1ZmZlcjo6Y29weUltYWdlKEltYWdl QnVmZmVyOjpEb250Q29weUJhY2tpbmdTdG9yZSkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTc3Njg5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgVXNlIFN0aWxsSW1hZ2VRdDo6Y3JlYXRlRm9yUmVuZGVyaW5n IHdoZW4gdXNpbmcgRG9udENvcHlCYWNraW5nU3RvcmUuCisgICAgICAgIEVuYWJsZSBEb250Q29w eUJhY2tpbmdTdG9yZSBpbiBUZXh0dXJlTWFwcGVyTm9kZS4KKyAgICAgICAgVGhpcyByZW1vdmVz IGRlZXAgY29waWVzIHJlc3VsdGluZyBmcm9tIHRoZSB1c2Ugb2YgSW1hZ2VCdWZmZXIuCisKKyAg ICAgICAgSW5zdHJ1bWVudGF0aW9uIHNob3dzIHRoYXQgZGVlcCBpbWFnZSBjb3BpZXMgcmVzdWx0 ZWQgZnJvbSBJbWFnZUJ1ZmZlciBhcmUgZWxpbWluYXRlZC4KKworICAgICAgICAqIHBsYXRmb3Jt L2dyYXBoaWNzL3F0L0ltYWdlQnVmZmVyUXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW1hZ2VC dWZmZXI6OmNvcHlJbWFnZSk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1Rl eHR1cmVNYXBwZXJOb2RlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlRleHR1cmVNYXBwZXJOb2Rl OjpyZW5kZXJDb250ZW50KToKKwogMjAxMi0wMi0wMiAgTm8nYW0gUm9zZW50aGFsICA8bm9hbS5y b3NlbnRoYWxAbm9raWEuY29tPgogCiAgICAgICAgIFtRdF1bVGV4bWFwXSBSZWZhY3RvciBUZXh0 dXJlTWFwcGVyIEFQSSB0byB1c2UgSW1hZ2VCdWZmZXJzIHdoZW4gcG9zc2libGUuCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9JbWFnZUJ1ZmZlclF0LmNw cCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0ltYWdlQnVmZmVyUXQuY3Bw CmluZGV4IGUzNmZmODUuLmVhYmNlZjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL3F0L0ltYWdlQnVmZmVyUXQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL3F0L0ltYWdlQnVmZmVyUXQuY3BwCkBAIC0xMjMsOCArMTIzLDEwIEBA IEdyYXBoaWNzQ29udGV4dCogSW1hZ2VCdWZmZXI6OmNvbnRleHQoKSBjb25zdAogCiBQYXNzUmVm UHRyPEltYWdlPiBJbWFnZUJ1ZmZlcjo6Y29weUltYWdlKEJhY2tpbmdTdG9yZUNvcHkgY29weUJl aGF2aW9yKSBjb25zdAogewotICAgIEFTU0VSVChjb3B5QmVoYXZpb3IgPT0gQ29weUJhY2tpbmdT dG9yZSk7Ci0gICAgcmV0dXJuIFN0aWxsSW1hZ2U6OmNyZWF0ZShtX2RhdGEubV9waXhtYXApOwor ICAgIGlmIChjb3B5QmVoYXZpb3IgPT0gQ29weUJhY2tpbmdTdG9yZSkKKyAgICAgICAgcmV0dXJu IFN0aWxsSW1hZ2U6OmNyZWF0ZShtX2RhdGEubV9waXhtYXApOworCisgICAgcmV0dXJuIFN0aWxs SW1hZ2U6OmNyZWF0ZUZvclJlbmRlcmluZygmbV9kYXRhLm1fcGl4bWFwKTsKIH0KIAogdm9pZCBJ bWFnZUJ1ZmZlcjo6ZHJhdyhHcmFwaGljc0NvbnRleHQqIGRlc3RDb250ZXh0LCBDb2xvclNwYWNl IHN0eWxlQ29sb3JTcGFjZSwgY29uc3QgRmxvYXRSZWN0JiBkZXN0UmVjdCwgY29uc3QgRmxvYXRS ZWN0JiBzcmNSZWN0LApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvdGV4bWFwL1RleHR1cmVNYXBwZXJOb2RlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyTm9kZS5jcHAKaW5kZXggNjg2NmM0Ni4uNDVi OTRiZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFw L1RleHR1cmVNYXBwZXJOb2RlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlck5vZGUuY3BwCkBAIC0xODYsOSArMTg2LDE0IEBAIHZv aWQgVGV4dHVyZU1hcHBlck5vZGU6OnJlbmRlckNvbnRlbnQoVGV4dHVyZU1hcHBlciogdGV4dHVy ZU1hcHBlciwgR3JhcGhpY3NMYXllCiAgICAgaWYgKG1fY3VycmVudENvbnRlbnQuY29udGVudFR5 cGUgPT0gRGlyZWN0SW1hZ2VDb250ZW50VHlwZSkKICAgICAgICAgY29udGV4dC0+ZHJhd0ltYWdl KG1fY3VycmVudENvbnRlbnQuaW1hZ2UuZ2V0KCksIENvbG9yU3BhY2VEZXZpY2VSR0IsIG1fc3Rh dGUuY29udGVudHNSZWN0KTsKIAotICAgIC8vIEZJWE1FOiBJbXBsZW1lbnQgSW1hZ2VCdWZmZXI6 OkRvbnRDb3B5QmFja2luZ1N0b3JlIGluIFF0L0dUSyBwb3J0cywgYW5kIHRoZW4gY2hhbmdlIHRo aXMuCi0gICAgLy8gU2VlIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03 NzY4OQotICAgIFJlZlB0cjxJbWFnZT4gaW1hZ2UgPSBpbWFnZUJ1ZmZlci0+Y29weUltYWdlKENv cHlCYWNraW5nU3RvcmUpOworICAgIFJlZlB0cjxJbWFnZT4gaW1hZ2U7CisKKyNpZiBQTEFURk9S TShRVCkKKyAgICBpbWFnZSA9IGltYWdlQnVmZmVyLT5jb3B5SW1hZ2UoRG9udENvcHlCYWNraW5n U3RvcmUpOworI2Vsc2UKKyAgICAvLyBGSVhNRTogc3VwcG9ydCBEb250Q29weUJhY2tpbmdTdG9y ZSBpbiBub24tUXQgcG9ydHMgdGhhdCB1c2UgVGV4dHVyZU1hcHBlci4KKyAgICBpbWFnZSA9IGlt YWdlQnVmZmVyLT5jb3B5SW1hZ2UoQ29weUJhY2tpbmdTdG9yZSk7CisjZW5kaWYKIAogICAgIC8v IERpdmlkZSB0aGUgaW1hZ2UgdG8gdGlsZXMuCiAgICAgZm9yIChzaXplX3QgdGlsZUluZGV4ID0g MDsgdGlsZUluZGV4IDwgbV9vd25lZFRpbGVzLnNpemUoKTsgKyt0aWxlSW5kZXgpIHsK