<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>77688</bug_id>
          
          <creation_ts>2012-02-02 15:44:17 -0800</creation_ts>
          <short_desc>[chromium] add support for --makeargs to the ninja-based build</short_desc>
          <delta_ts>2012-02-03 23:50:30 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter>jochen</reporter>
          <assigned_to>jochen</assigned_to>
          <cc>abarth</cc>
    
    <cc>thakis</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>548210</commentid>
    <comment_count>0</comment_count>
    <who name="">jochen</who>
    <bug_when>2012-02-02 15:44:17 -0800</bug_when>
    <thetext>[chromium] add support for --makeargs to the ninja-based build</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>548213</commentid>
    <comment_count>1</comment_count>
      <attachid>125204</attachid>
    <who name="">jochen</who>
    <bug_when>2012-02-02 15:45:18 -0800</bug_when>
    <thetext>Created attachment 125204
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>548251</commentid>
    <comment_count>2</comment_count>
      <attachid>125209</attachid>
    <who name="">jochen</who>
    <bug_when>2012-02-02 16:45:14 -0800</bug_when>
    <thetext>Created attachment 125209
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>548252</commentid>
    <comment_count>3</comment_count>
      <attachid>125209</attachid>
    <who name="">jochen</who>
    <bug_when>2012-02-02 16:46:00 -0800</bug_when>
    <thetext>Comment on attachment 125209
Patch

Removed the default -j flag, as requested by Nico, as ninja has a sensible default</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>548360</commentid>
    <comment_count>4</comment_count>
      <attachid>125209</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-02-02 19:19:11 -0800</bug_when>
    <thetext>Comment on attachment 125209
Patch

Clearing flags on attachment: 125209

Committed r106617: &lt;http://trac.webkit.org/changeset/106617&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>548361</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-02-02 19:19:15 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>549158</commentid>
    <comment_count>6</comment_count>
    <who name="Nico Weber">thakis</who>
    <bug_when>2012-02-03 15:29:49 -0800</bug_when>
    <thetext>Thanks for the change, and for playing with ninja :-)

Out of curiosity, what do you use this for?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>549382</commentid>
    <comment_count>7</comment_count>
    <who name="">jochen</who>
    <bug_when>2012-02-03 23:50:30 -0800</bug_when>
    <thetext>To pass -j300 so ninja uses my incredible computing powah!</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>125204</attachid>
            <date>2012-02-02 15:45:18 -0800</date>
            <delta_ts>2012-02-02 16:45:08 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-77688-20120203004516.patch</filename>
            <type>text/plain</type>
            <size>1449</size>
            <attacher>jochen</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2NTk1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOWRjNzEyNDJhMWI3NzQ4MGQzY2I5ZTBmMDNmNjY3NDVl
YzNjMWNhMi4uMDk2YjdkNzU4MDMyZGE4YWVlNWE4ZTg5MDFhZDcyY2M0ZmZiM2QwZSAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz
IEBACisyMDEyLTAyLTAyICBKb2NoZW4gRWlzaW5nZXIgIDxqb2NoZW5AY2hyb21pdW0ub3JnPgor
CisgICAgICAgIFtjaHJvbWl1bV0gYWRkIHN1cHBvcnQgZm9yIC0tbWFrZWFyZ3MgdG8gdGhlIG5p
bmphLWJhc2VkIGJ1aWxkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn
LmNnaT9pZD03NzY4OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg
ICAgICAgICogU2NyaXB0cy93ZWJraXRkaXJzLnBtOgorICAgICAgICAoYnVpbGRDaHJvbWl1bU5p
bmphKToKKwogMjAxMi0wMi0wMiAgRGlyayBQcmFua2UgIDxkcHJhbmtlQGNocm9taXVtLm9yZz4K
IAogICAgICAgIG5yd3Qgc2hvdWxkbid0IGJsb3cgdXAgd2hlbiB0aGVyZSBhcmUgZXJyb3JzIGlu
IHRlc3RfZXhwZWN0YXRpb25zLnR4dApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRk
aXJzLnBtIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCmluZGV4IDkyMjcxMTk5ZDlkMDhh
MjhkNTc4YTg2MjY4MzBhZDg2MzlhZjJiODcuLjZmZjViYzBhM2Y2ZGNjMTdiOGNiMWEzMmUwZjZm
Zjk2MmJkZGM5NjUgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQorKysg
Yi9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KQEAgLTIzMDksOSArMjMwOSwxNSBAQCBzdWIg
YnVpbGRDaHJvbWl1bU5pbmphKCQkQCkKICAgICAjIHJtIC1yZiBvdXQgcmVxdWlyZXMgcmVydW5u
aW5nIGd5cCwgc28gZG9uJ3Qgc3VwcG9ydCAtLWNsZWFuIGZvciBub3cuCiAgICAgbXkgKCR0YXJn
ZXQsIEBvcHRpb25zKSA9IEBfOwogICAgIG15ICRjb25maWcgPSBjb25maWd1cmF0aW9uKCk7Cisg
ICAgbXkgJG51bUNwdXMgPSBudW1iZXJPZkNQVXMoKTsKKyAgICBteSAkbWFrZUFyZ3M7CisgICAg
Zm9yIChAb3B0aW9ucykgeworICAgICAgICAkbWFrZUFyZ3MgPSAkMSBpZiAvXi0tbWFrZWFyZ3M9
KC4qKS9pOworICAgIH0KKyAgICAkbWFrZUFyZ3MgPSAiLWokbnVtQ3B1cyIgaWYgbm90ICRtYWtl
QXJnczsKICAgICBteSAkY29tbWFuZCA9ICIiOwogCi0gICAgJGNvbW1hbmQgLj0gIm5pbmphIC1D
IG91dC8kY29uZmlnICR0YXJnZXQiOworICAgICRjb21tYW5kIC49ICJuaW5qYSAtQyBvdXQvJGNv
bmZpZyAkdGFyZ2V0ICRtYWtlQXJncyI7CiAKICAgICBwcmludCAiJGNvbW1hbmRcbiI7CiAgICAg
cmV0dXJuIHN5c3RlbSAkY29tbWFuZDsK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>125209</attachid>
            <date>2012-02-02 16:45:14 -0800</date>
            <delta_ts>2012-02-02 19:19:11 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-77688-20120203014512.patch</filename>
            <type>text/plain</type>
            <size>1362</size>
            <attacher>jochen</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2NTk1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOWRjNzEyNDJhMWI3NzQ4MGQzY2I5ZTBmMDNmNjY3NDVl
YzNjMWNhMi4uM2ZmYTM1ZTgxNWEyMDM3ZDMxZTVmMTY3ZTI0OGVkMWQ5OWFmNTc4NiAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz
IEBACisyMDEyLTAyLTAyICBKb2NoZW4gRWlzaW5nZXIgIDxqb2NoZW5AY2hyb21pdW0ub3JnPgor
CisgICAgICAgIFtjaHJvbWl1bV0gYWRkIHN1cHBvcnQgZm9yIC0tbWFrZWFyZ3MgdG8gdGhlIG5p
bmphLWJhc2VkIGJ1aWxkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn
LmNnaT9pZD03NzY4OAorCisgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCisKKyAgICAg
ICAgKiBTY3JpcHRzL3dlYmtpdGRpcnMucG06CisgICAgICAgIChidWlsZENocm9taXVtTmluamEp
OgorCiAyMDEyLTAyLTAyICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgogCiAg
ICAgICAgbnJ3dCBzaG91bGRuJ3QgYmxvdyB1cCB3aGVuIHRoZXJlIGFyZSBlcnJvcnMgaW4gdGVz
dF9leHBlY3RhdGlvbnMudHh0CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMu
cG0gYi9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KaW5kZXggOTIyNzExOTlkOWQwOGEyOGQ1
NzhhODYyNjgzMGFkODYzOWFmMmI4Ny4uZWIyMjUyMzQ4ZTNkM2M1ZGNjYWIxODJlYWU3YmU2NGZh
MDY4Yzk0NiAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCisrKyBiL1Rv
b2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQpAQCAtMjMwOSw5ICsyMzA5LDEzIEBAIHN1YiBidWls
ZENocm9taXVtTmluamEoJCRAKQogICAgICMgcm0gLXJmIG91dCByZXF1aXJlcyByZXJ1bm5pbmcg
Z3lwLCBzbyBkb24ndCBzdXBwb3J0IC0tY2xlYW4gZm9yIG5vdy4KICAgICBteSAoJHRhcmdldCwg
QG9wdGlvbnMpID0gQF87CiAgICAgbXkgJGNvbmZpZyA9IGNvbmZpZ3VyYXRpb24oKTsKKyAgICBt
eSAkbWFrZUFyZ3M7CisgICAgZm9yIChAb3B0aW9ucykgeworICAgICAgICAkbWFrZUFyZ3MgPSAk
MSBpZiAvXi0tbWFrZWFyZ3M9KC4qKS9pOworICAgIH0KICAgICBteSAkY29tbWFuZCA9ICIiOwog
Ci0gICAgJGNvbW1hbmQgLj0gIm5pbmphIC1DIG91dC8kY29uZmlnICR0YXJnZXQiOworICAgICRj
b21tYW5kIC49ICJuaW5qYSAtQyBvdXQvJGNvbmZpZyAkdGFyZ2V0ICRtYWtlQXJncyI7CiAKICAg
ICBwcmludCAiJGNvbW1hbmRcbiI7CiAgICAgcmV0dXJuIHN5c3RlbSAkY29tbWFuZDsK
</data>

          </attachment>
      

    </bug>

</bugzilla>