77682 2012-02-02 13:50:06 -0800 [Mac WK2] Use a minimally invasive way to fake plug-in process name 2012-02-03 15:48:19 -0800 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap webkit.review.bot oldest_to_newest 548140 0 ap 2012-02-02 13:50:06 -0800 We've been using setprogname to fix bug 51074, but that also changes KERN_PROCNAME, which may not be allowed in some environments. There is an easier way to change return value of getprogname. 548143 1 125182 ap 2012-02-02 13:53:50 -0800 Created attachment 125182 proposed patch 548147 2 125185 ap 2012-02-02 13:55:15 -0800 Created attachment 125185 with a better ChangeLog 548149 3 webkit.review.bot 2012-02-02 13:56:00 -0800 Attachment 125182 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 549071 4 125185 darin 2012-02-03 14:23:27 -0800 Comment on attachment 125185 with a better ChangeLog r=me 549181 5 125185 webkit.review.bot 2012-02-03 15:48:10 -0800 Comment on attachment 125185 with a better ChangeLog Clearing flags on attachment: 125185 Committed r106701: <http://trac.webkit.org/changeset/106701> 549182 6 webkit.review.bot 2012-02-03 15:48:19 -0800 All reviewed patches have been landed. Closing bug. 125182 2012-02-02 13:53:50 -0800 2012-02-02 13:55:15 -0800 proposed patch NoSetprogname.txt text/plain 2198 ap SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwNjU5MCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEyLTAyLTAyICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIE5lZWQgYSBzaG9ydCBkZXNj cmlwdGlvbiBhbmQgYnVnIFVSTCAoT09QUyEpCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBQbHVnaW5Qcm9jZXNzL1BsdWdpblByb2Nlc3MuY3BwOiAo V2ViS2l0OjpQbHVnaW5Qcm9jZXNzOjpuZXRzY2FwZVBsdWdpbk1vZHVsZSk6CisgICAgICAgIE9u bHkgY2hhbmdlIHRoZSBuYW1lIGFzIGl0J3Mgc2VlbiBmcm9tIHdpdGhpbiB0aGUgcHJvY2Vzcy4K KworICAgICAgICAqIFNoYXJlZC9QbHVnaW5zL1BsdWdpblF1aXJrcy5oOiBGaXhlZCBhIHR5cG8u CisKIDIwMTItMDItMDIgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAog ICAgICAgICBOUEFQSSB3aWxsIG5vdCBzZW5kIG1vdXNlIHVwIGV2ZW50cyB3aGVuIG1vdXNlIGlz IG91dHNpZGUgcGx1Z2luIGFyZWEKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1BsdWdpblByb2Nlc3Mv UGx1Z2luUHJvY2Vzcy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvUGx1Z2luUHJv Y2Vzcy9QbHVnaW5Qcm9jZXNzLmNwcAkocmV2aXNpb24gMTA2NDcxKQorKysgU291cmNlL1dlYktp dDIvUGx1Z2luUHJvY2Vzcy9QbHVnaW5Qcm9jZXNzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzgs NiArMzgsMTAgQEAKICNpbmNsdWRlIDxXZWJDb3JlL05vdEltcGxlbWVudGVkLmg+CiAjaW5jbHVk ZSA8V2ViQ29yZS9SdW5Mb29wLmg+CiAKKyNpZiBQTEFURk9STShNQUMpCisjaW5jbHVkZSA8Y3J0 X2V4dGVybnMuaD4KKyNlbmRpZgorCiAjaWYgVVNFKFVOSVhfRE9NQUlOX1NPQ0tFVFMpCiAjaW5j bHVkZSA8ZXJybm8uaD4KICNpbmNsdWRlIDxmY250bC5oPgpAQCAtMTE1LDcgKzExOSw3IEBAIE5l dHNjYXBlUGx1Z2luTW9kdWxlKiBQbHVnaW5Qcm9jZXNzOjpuZXQKICNpZiBQTEFURk9STShNQUMp CiAgICAgICAgIGlmIChtX3BsdWdpbk1vZHVsZSkgewogICAgICAgICAgICAgaWYgKG1fcGx1Z2lu TW9kdWxlLT5wbHVnaW5RdWlya3MoKS5jb250YWlucyhQbHVnaW5RdWlya3M6OlByb2duYW1lU2hv dWxkQmVXZWJLaXRQbHVnaW5Ib3N0KSkKLSAgICAgICAgICAgICAgICBzZXRwcm9nbmFtZSgiV2Vi S2l0UGx1Z2luSG9zdCIpOworICAgICAgICAgICAgICAgICpjb25zdF9jYXN0PGNvbnN0IGNoYXIq Kj4oX05TR2V0UHJvZ25hbWUoKSkgPSAiV2ViS2l0UGx1Z2luSG9zdCI7CiAgICAgICAgIH0KICNl bmRpZgogICAgIH0KSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9QbHVnaW5zL1BsdWdpblF1 aXJrcy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9QbHVnaW5zL1BsdWdp blF1aXJrcy5oCShyZXZpc2lvbiAxMDY0NzEpCisrKyBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvUGx1 Z2lucy9QbHVnaW5RdWlya3MuaAkod29ya2luZyBjb3B5KQpAQCAtMzMsNyArMzMsNyBAQCBwdWJs aWM6CiAgICAgZW51bSBQbHVnaW5RdWlyayB7CiAgICAgICAgIC8vIE1hYyBzcGVjaWZpYyBxdWly a3M6CiAjaWYgUExVR0lOX0FSQ0hJVEVDVFVSRShNQUMpCi0gICAgICAgIC8vIFRoZSBwbHVnLWlu IHdhbnRzIHRoZSBjYWxsIHRvIGdldHByb2dhbWUoKSB0byByZXR1cm4gIldlYktpdFBsdWdpbkhv c3QiLgorICAgICAgICAvLyBUaGUgcGx1Zy1pbiB3YW50cyB0aGUgY2FsbCB0byBnZXRwcm9nbmFt ZSgpIHRvIHJldHVybiAiV2ViS2l0UGx1Z2luSG9zdCIuCiAgICAgICAgIC8vIEFkb2JlIEZsYXNo IFdpbGwgbm90IGhhbmRsZSBrZXkgZG93biBldmVudHMgb3RoZXJ3aXNlLgogICAgICAgICBQcm9n bmFtZVNob3VsZEJlV2ViS2l0UGx1Z2luSG9zdCwKIAo= 125185 2012-02-02 13:55:15 -0800 2012-02-03 15:48:10 -0800 with a better ChangeLog NoSetprogname.txt text/plain 2276 ap SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwNjU5MCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTAyLTAyICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIFtNYWMgV0syXSBVc2UgYSBt aW5pbWFsbHkgaW52YXNpdmUgd2F5IHRvIGZha2UgcGx1Zy1pbiBwcm9jZXNzIG5hbWUKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc3NjgyCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBQbHVnaW5Qcm9jZXNz L1BsdWdpblByb2Nlc3MuY3BwOiAoV2ViS2l0OjpQbHVnaW5Qcm9jZXNzOjpuZXRzY2FwZVBsdWdp bk1vZHVsZSk6CisgICAgICAgIE9ubHkgY2hhbmdlIHRoZSBuYW1lIGFzIGl0J3Mgc2VlbiBmcm9t IHdpdGhpbiB0aGUgcHJvY2Vzcy4KKworICAgICAgICAqIFNoYXJlZC9QbHVnaW5zL1BsdWdpblF1 aXJrcy5oOiBGaXhlZCBhIHR5cG8uCisKIDIwMTItMDItMDIgIEFuZGVycyBDYXJsc3NvbiAgPGFu ZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBOUEFQSSB3aWxsIG5vdCBzZW5kIG1vdXNlIHVw IGV2ZW50cyB3aGVuIG1vdXNlIGlzIG91dHNpZGUgcGx1Z2luIGFyZWEKSW5kZXg6IFNvdXJjZS9X ZWJLaXQyL1BsdWdpblByb2Nlc3MvUGx1Z2luUHJvY2Vzcy5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYktpdDIvUGx1Z2luUHJvY2Vzcy9QbHVnaW5Qcm9jZXNzLmNwcAkocmV2aXNpb24gMTA2 NDcxKQorKysgU291cmNlL1dlYktpdDIvUGx1Z2luUHJvY2Vzcy9QbHVnaW5Qcm9jZXNzLmNwcAko d29ya2luZyBjb3B5KQpAQCAtMzgsNiArMzgsMTAgQEAKICNpbmNsdWRlIDxXZWJDb3JlL05vdElt cGxlbWVudGVkLmg+CiAjaW5jbHVkZSA8V2ViQ29yZS9SdW5Mb29wLmg+CiAKKyNpZiBQTEFURk9S TShNQUMpCisjaW5jbHVkZSA8Y3J0X2V4dGVybnMuaD4KKyNlbmRpZgorCiAjaWYgVVNFKFVOSVhf RE9NQUlOX1NPQ0tFVFMpCiAjaW5jbHVkZSA8ZXJybm8uaD4KICNpbmNsdWRlIDxmY250bC5oPgpA QCAtMTE1LDcgKzExOSw3IEBAIE5ldHNjYXBlUGx1Z2luTW9kdWxlKiBQbHVnaW5Qcm9jZXNzOjpu ZXQKICNpZiBQTEFURk9STShNQUMpCiAgICAgICAgIGlmIChtX3BsdWdpbk1vZHVsZSkgewogICAg ICAgICAgICAgaWYgKG1fcGx1Z2luTW9kdWxlLT5wbHVnaW5RdWlya3MoKS5jb250YWlucyhQbHVn aW5RdWlya3M6OlByb2duYW1lU2hvdWxkQmVXZWJLaXRQbHVnaW5Ib3N0KSkKLSAgICAgICAgICAg ICAgICBzZXRwcm9nbmFtZSgiV2ViS2l0UGx1Z2luSG9zdCIpOworICAgICAgICAgICAgICAgICpj b25zdF9jYXN0PGNvbnN0IGNoYXIqKj4oX05TR2V0UHJvZ25hbWUoKSkgPSAiV2ViS2l0UGx1Z2lu SG9zdCI7CiAgICAgICAgIH0KICNlbmRpZgogICAgIH0KSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1No YXJlZC9QbHVnaW5zL1BsdWdpblF1aXJrcy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQy L1NoYXJlZC9QbHVnaW5zL1BsdWdpblF1aXJrcy5oCShyZXZpc2lvbiAxMDY0NzEpCisrKyBTb3Vy Y2UvV2ViS2l0Mi9TaGFyZWQvUGx1Z2lucy9QbHVnaW5RdWlya3MuaAkod29ya2luZyBjb3B5KQpA QCAtMzMsNyArMzMsNyBAQCBwdWJsaWM6CiAgICAgZW51bSBQbHVnaW5RdWlyayB7CiAgICAgICAg IC8vIE1hYyBzcGVjaWZpYyBxdWlya3M6CiAjaWYgUExVR0lOX0FSQ0hJVEVDVFVSRShNQUMpCi0g ICAgICAgIC8vIFRoZSBwbHVnLWluIHdhbnRzIHRoZSBjYWxsIHRvIGdldHByb2dhbWUoKSB0byBy ZXR1cm4gIldlYktpdFBsdWdpbkhvc3QiLgorICAgICAgICAvLyBUaGUgcGx1Zy1pbiB3YW50cyB0 aGUgY2FsbCB0byBnZXRwcm9nbmFtZSgpIHRvIHJldHVybiAiV2ViS2l0UGx1Z2luSG9zdCIuCiAg ICAgICAgIC8vIEFkb2JlIEZsYXNoIFdpbGwgbm90IGhhbmRsZSBrZXkgZG93biBldmVudHMgb3Ro ZXJ3aXNlLgogICAgICAgICBQcm9nbmFtZVNob3VsZEJlV2ViS2l0UGx1Z2luSG9zdCwKIAo=