77677 2012-02-02 13:17:43 -0800 Implement current executable path finding for win32 2012-02-02 15:04:02 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 kalevlember webkit-unassigned webkit.review.bot oldest_to_newest 548115 0 kalevlember 2012-02-02 13:17:43 -0800 The WTF helper for getting the binary path that was added in r101710 left out the win32 implementation. Fix this. 548116 1 125173 kalevlember 2012-02-02 13:18:22 -0800 Created attachment 125173 Implement current executable path finding for win32 548123 2 webkit.review.bot 2012-02-02 13:22:08 -0800 Attachment 125173 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/wtf/gobject/GlibUtilities.cpp:25: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 548125 3 125173 mrobinson 2012-02-02 13:29:35 -0800 Comment on attachment 125173 Implement current executable path finding for win32 View in context: https://bugs.webkit.org/attachment.cgi?id=125173&action=review r- only because you are not a committer and cannot fix the style nit before landing. >> Source/JavaScriptCore/wtf/gobject/GlibUtilities.cpp:25 >> +#if OS(WINDOWS) >> +#include <wtf/text/WTFString.h> >> +#include <windows.h> > > Alphabetical sorting problem. [build/include_order] [4] Please fix this simple style nit. 548131 4 125179 kalevlember 2012-02-02 13:37:31 -0800 Created attachment 125179 ver 2: Updated patch with headers sorted Thanks for the review, this should hopefully pass the bot. 548183 5 125179 webkit.review.bot 2012-02-02 15:03:58 -0800 Comment on attachment 125179 ver 2: Updated patch with headers sorted Clearing flags on attachment: 125179 Committed r106595: <http://trac.webkit.org/changeset/106595> 548184 6 webkit.review.bot 2012-02-02 15:04:02 -0800 All reviewed patches have been landed. Closing bug. 125173 2012-02-02 13:18:22 -0800 2012-02-02 13:37:31 -0800 Implement current executable path finding for win32 0002-Implement-current-executable-path-finding-for-win32.patch text/plain 2156 kalevlember RnJvbSA4N2YwYTI1YWUwYjFlN2RhNjdmMzU0MmQ2YWM0MzkxMGVlM2Q1ZDYxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLYWxldiBMZW1iZXIgPGthbGV2bGVtYmVyQGdtYWlsLmNvbT4K RGF0ZTogVGh1LCAyIEZlYiAyMDEyIDIyOjUzOjEyICswMjAwClN1YmplY3Q6IFtQQVRDSCAyLzRd IEltcGxlbWVudCBjdXJyZW50IGV4ZWN1dGFibGUgcGF0aCBmaW5kaW5nIGZvciB3aW4zMgoKLS0t CiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICB8ICAg MTMgKysrKysrKysrKysrKwogLi4uL0phdmFTY3JpcHRDb3JlL3d0Zi9nb2JqZWN0L0dsaWJVdGls aXRpZXMuY3BwICAgfCAgIDE2ICsrKysrKysrKysrKysrKysKIDIgZmlsZXMgY2hhbmdlZCwgMjkg aW5zZXJ0aW9ucygrKSwgMCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRl eCAwNTg0NDcxLi4zMmViY2Q1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hh bmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx NiBAQAorMjAxMi0wMi0wMiAgS2FsZXYgTGVtYmVyICA8a2FsZXZsZW1iZXJAZ21haWwuY29tPgor CisgICAgICAgIFtHVEtdIEltcGxlbWVudCBjdXJyZW50IGV4ZWN1dGFibGUgcGF0aCBmaW5kaW5n IGZvciB3aW4zMgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9Nzc2NzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBUaGUgV1RGIGhlbHBlciBmb3IgZ2V0dGluZyB0aGUgYmluYXJ5IHBhdGggdGhhdCB3YXMgYWRk ZWQgaW4gcjEwMTcxMAorICAgICAgICBsZWZ0IG91dCB0aGUgd2luMzIgaW1wbGVtZW50YXRpb24u IEZpeCB0aGlzLgorCisgICAgICAgICogd3RmL2dvYmplY3QvR2xpYlV0aWxpdGllcy5jcHA6Cisg ICAgICAgIChnZXRDdXJyZW50RXhlY3V0YWJsZVBhdGgpOgorCiAyMDEyLTAyLTAxICBNaWNoYWVs IFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgogCiAgICAgICAgIFlhcnIgY3Jhc2ggd2l0aCBy ZWdleHAgcmVwbGFjZQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9nb2Jq ZWN0L0dsaWJVdGlsaXRpZXMuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9nb2JqZWN0 L0dsaWJVdGlsaXRpZXMuY3BwCmluZGV4IDZmY2Q4MDYuLmZmZDRmZTIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvZ29iamVjdC9HbGliVXRpbGl0aWVzLmNwcAorKysgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL2dvYmplY3QvR2xpYlV0aWxpdGllcy5jcHAKQEAgLTIw LDggKzIwLDEzIEBACiAjaW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiR2xpYlV0aWxpdGll cy5oIgogCisjaWYgT1MoV0lORE9XUykKKyNpbmNsdWRlIDx3dGYvdGV4dC9XVEZTdHJpbmcuaD4K KyNpbmNsdWRlIDx3aW5kb3dzLmg+CisjZWxzZQogI2luY2x1ZGUgPGxpbWl0cy5oPgogI2luY2x1 ZGUgPHVuaXN0ZC5oPgorI2VuZGlmCiAKICNpZiBPUyhMSU5VWCkKIENTdHJpbmcgZ2V0Q3VycmVu dEV4ZWN1dGFibGVQYXRoKCkKQEAgLTQxLDQgKzQ2LDE1IEBAIENTdHJpbmcgZ2V0Q3VycmVudEV4 ZWN1dGFibGVQYXRoKCkKICAgICAgICAgcmV0dXJuIENTdHJpbmcoKTsKICAgICByZXR1cm4gQ1N0 cmluZyhyZWFkTGlua0J1ZmZlciwgcmVzdWx0KTsKIH0KKyNlbGlmIE9TKFdJTkRPV1MpCitDU3Ry aW5nIGdldEN1cnJlbnRFeGVjdXRhYmxlUGF0aCgpCit7CisgICAgc3RhdGljIFdDSEFSIGJ1ZmZl cltNQVhfUEFUSF07CisgICAgRFdPUkQgbGVuZ3RoID0gR2V0TW9kdWxlRmlsZU5hbWVXKDAsIGJ1 ZmZlciwgTUFYX1BBVEgpOworICAgIGlmICghbGVuZ3RoIHx8IChsZW5ndGggPT0gTUFYX1BBVEgg JiYgR2V0TGFzdEVycm9yKCkgPT0gRVJST1JfSU5TVUZGSUNJRU5UX0JVRkZFUikpCisgICAgICAg IHJldHVybiBDU3RyaW5nKCk7CisKKyAgICBTdHJpbmcgcGF0aChidWZmZXIsIGxlbmd0aCk7Cisg ICAgcmV0dXJuIHBhdGgudXRmOCgpOworfQogI2VuZGlmCi0tIAoxLjcuNy42Cgo= 125179 2012-02-02 13:37:31 -0800 2012-02-02 15:03:58 -0800 ver 2: Updated patch with headers sorted 0002-Implement-current-executable-path-finding-for-win32.patch text/plain 2156 kalevlember RnJvbSA4N2YwYTI1YWUwYjFlN2RhNjdmMzU0MmQ2YWM0MzkxMGVlM2Q1ZDYxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLYWxldiBMZW1iZXIgPGthbGV2bGVtYmVyQGdtYWlsLmNvbT4K RGF0ZTogVGh1LCAyIEZlYiAyMDEyIDIyOjUzOjEyICswMjAwClN1YmplY3Q6IFtQQVRDSCAyLzRd IEltcGxlbWVudCBjdXJyZW50IGV4ZWN1dGFibGUgcGF0aCBmaW5kaW5nIGZvciB3aW4zMgoKLS0t CiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICB8ICAg MTMgKysrKysrKysrKysrKwogLi4uL0phdmFTY3JpcHRDb3JlL3d0Zi9nb2JqZWN0L0dsaWJVdGls aXRpZXMuY3BwICAgfCAgIDE2ICsrKysrKysrKysrKysrKysKIDIgZmlsZXMgY2hhbmdlZCwgMjkg aW5zZXJ0aW9ucygrKSwgMCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRl eCAwNTg0NDcxLi4zMmViY2Q1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hh bmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx NiBAQAorMjAxMi0wMi0wMiAgS2FsZXYgTGVtYmVyICA8a2FsZXZsZW1iZXJAZ21haWwuY29tPgor CisgICAgICAgIFtHVEtdIEltcGxlbWVudCBjdXJyZW50IGV4ZWN1dGFibGUgcGF0aCBmaW5kaW5n IGZvciB3aW4zMgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9Nzc2NzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBUaGUgV1RGIGhlbHBlciBmb3IgZ2V0dGluZyB0aGUgYmluYXJ5IHBhdGggdGhhdCB3YXMgYWRk ZWQgaW4gcjEwMTcxMAorICAgICAgICBsZWZ0IG91dCB0aGUgd2luMzIgaW1wbGVtZW50YXRpb24u IEZpeCB0aGlzLgorCisgICAgICAgICogd3RmL2dvYmplY3QvR2xpYlV0aWxpdGllcy5jcHA6Cisg ICAgICAgIChnZXRDdXJyZW50RXhlY3V0YWJsZVBhdGgpOgorCiAyMDEyLTAyLTAxICBNaWNoYWVs IFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgogCiAgICAgICAgIFlhcnIgY3Jhc2ggd2l0aCBy ZWdleHAgcmVwbGFjZQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9nb2Jq ZWN0L0dsaWJVdGlsaXRpZXMuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9nb2JqZWN0 L0dsaWJVdGlsaXRpZXMuY3BwCmluZGV4IDZmY2Q4MDYuLmZmZDRmZTIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvZ29iamVjdC9HbGliVXRpbGl0aWVzLmNwcAorKysgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL2dvYmplY3QvR2xpYlV0aWxpdGllcy5jcHAKQEAgLTIw LDggKzIwLDEzIEBACiAjaW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiR2xpYlV0aWxpdGll cy5oIgogCisjaWYgT1MoV0lORE9XUykKKyNpbmNsdWRlIDx3aW5kb3dzLmg+CisjaW5jbHVkZSA8 d3RmL3RleHQvV1RGU3RyaW5nLmg+CisjZWxzZQogI2luY2x1ZGUgPGxpbWl0cy5oPgogI2luY2x1 ZGUgPHVuaXN0ZC5oPgorI2VuZGlmCiAKICNpZiBPUyhMSU5VWCkKIENTdHJpbmcgZ2V0Q3VycmVu dEV4ZWN1dGFibGVQYXRoKCkKQEAgLTQxLDQgKzQ2LDE1IEBAIENTdHJpbmcgZ2V0Q3VycmVudEV4 ZWN1dGFibGVQYXRoKCkKICAgICAgICAgcmV0dXJuIENTdHJpbmcoKTsKICAgICByZXR1cm4gQ1N0 cmluZyhyZWFkTGlua0J1ZmZlciwgcmVzdWx0KTsKIH0KKyNlbGlmIE9TKFdJTkRPV1MpCitDU3Ry aW5nIGdldEN1cnJlbnRFeGVjdXRhYmxlUGF0aCgpCit7CisgICAgc3RhdGljIFdDSEFSIGJ1ZmZl cltNQVhfUEFUSF07CisgICAgRFdPUkQgbGVuZ3RoID0gR2V0TW9kdWxlRmlsZU5hbWVXKDAsIGJ1 ZmZlciwgTUFYX1BBVEgpOworICAgIGlmICghbGVuZ3RoIHx8IChsZW5ndGggPT0gTUFYX1BBVEgg JiYgR2V0TGFzdEVycm9yKCkgPT0gRVJST1JfSU5TVUZGSUNJRU5UX0JVRkZFUikpCisgICAgICAg IHJldHVybiBDU3RyaW5nKCk7CisKKyAgICBTdHJpbmcgcGF0aChidWZmZXIsIGxlbmd0aCk7Cisg ICAgcmV0dXJuIHBhdGgudXRmOCgpOworfQogI2VuZGlmCi0tIAoxLjcuNy42Cgo=