77667 2012-02-02 12:18:07 -0800 [chromium] NOT FOR REVIEW Mark scrollbars as opaque. 2012-02-10 11:38:48 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 77478 1 backer backer danakj enne jamesr oldest_to_newest 548051 0 backer 2012-02-02 12:18:07 -0800 [chromium] NOT FOR REVIEW Mark scrollbars as opaque. 548052 1 125160 backer 2012-02-02 12:19:27 -0800 Created attachment 125160 Patch 548055 2 backer 2012-02-02 12:23:42 -0800 When working on https://bugs.webkit.org/show_bug.cgi?id=77478 , I discovered that we're blending our scroll bars with the debug blue that we're clearing to in LayerRendererChromium.cpp I think that this is clearly an error. The attached patch fixes this. We should also fix it so that Skia gives us an opaque layer (alpha = 1.0). @danakj: How do we fix Skia? Is this a Skia error that I'm seeing? @enne: Is there a better way to mark scrollbars opaque? 548086 3 danakj 2012-02-02 12:55:22 -0800 Yes. If the background is painted then the scrollbar is painted with alpha over top (those AA corner pixels) skia loses 1 on the alpha channel. Then when its drawn with blending you get the compositor blue coming through. Theres a CL in the works but requires rebaselining the world and I havent worked on it since December. I'll post the bug url later. 548088 4 danakj 2012-02-02 12:57:02 -0800 Secondly I would like to make chromium paint the scrollbars thru the webkit GraphicsContext instead of directly to canvas. Then opaque paint tracking will know they are opaque automatically. 548104 5 danakj 2012-02-02 13:10:06 -0800 http://codereview.appspot.com/5494076/ 548226 6 jamesr 2012-02-02 16:14:41 -0800 To state the blindingly obvious, scrollbars are often not opaque so this won't work generally. 554224 7 backer 2012-02-10 11:09:22 -0800 Just rebaselined the Linux image expectations to bake in the 1 off error in scrollbar alpha. 554236 8 jamesr 2012-02-10 11:20:45 -0800 (In reply to comment #7) > Just rebaselined the Linux image expectations to bake in the 1 off error in scrollbar alpha. I switched us over to mock scrollbars - were you still seeing issues? 554251 9 backer 2012-02-10 11:38:48 -0800 (In reply to comment #8) > (In reply to comment #7) > > Just rebaselined the Linux image expectations to bake in the 1 off error in scrollbar alpha. > > I switched us over to mock scrollbars - were you still seeing issues? The baselines that I uploaded for the root clear patch were for the Release build (not root clear). I just ran DRT with a Debug build (still root clears to blue) and there is no error. So you must have fixed it. 125160 2012-02-02 12:19:27 -0800 2012-02-02 12:19:27 -0800 Patch bug-77667-20120202151926.patch text/plain 1936 backer U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2NTI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjU2MTc1Y2MwYWIxZWQ5 NGU2MmVlM2Y3YThjNDhlZWNmODE5YzljYS4uMGM5ZDc1MzM3NmJmNGY5NGRmZjA2NmUxOTAyZTY0 ZmRkMWJmMDhjYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTAyLTAyICBKb25h dGhhbiBCYWNrZXIgIDxiYWNrZXJAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0g Tk9UIEZPUiBSRVZJRVcgTWFyayBzY3JvbGxiYXJzIGFzIG9wYXF1ZS4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc3NjY3CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXJD b21wb3NpdG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyQ29tcG9zaXRvcjo6 dXBkYXRlT3ZlcmZsb3dDb250cm9sc0xheWVycyk6CisKIDIwMTItMDItMDEgIFNoZXJpZmYgQm90 ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJv bGxpbmcgb3V0IHIxMDY0MDguCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJMYXllckNvbXBvc2l0b3IuY3BwCmluZGV4IGI4NWI4MDdmMTE2ZjhjYWZhYjcxMjFmMTMwYmM5 Njk4MjBjZDlkYjkuLjM0NTY0OThjZWMyNTA1ZjQzZjc4ZjJiYmU4MjI2Y2Y1OGE2NTZhZDUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3Iu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3Iu Y3BwCkBAIC0xNzY2LDYgKzE3NjYsOSBAQCB2b2lkIFJlbmRlckxheWVyQ29tcG9zaXRvcjo6dXBk YXRlT3ZlcmZsb3dDb250cm9sc0xheWVycygpCiAgICAgaWYgKHJlcXVpcmVzSG9yaXpvbnRhbFNj cm9sbGJhckxheWVyKCkpIHsKICAgICAgICAgaWYgKCFtX2xheWVyRm9ySG9yaXpvbnRhbFNjcm9s bGJhcikgewogICAgICAgICAgICAgbV9sYXllckZvckhvcml6b250YWxTY3JvbGxiYXIgPSBHcmFw aGljc0xheWVyOjpjcmVhdGUodGhpcyk7CisjaWYgUExBVEZPUk0oQ0hST01JVU0pCisgICAgICAg ICAgICBtX2xheWVyRm9ySG9yaXpvbnRhbFNjcm9sbGJhci0+c2V0Q29udGVudHNPcGFxdWUodHJ1 ZSk7CisjZW5kaWYKICAgICAjaWZuZGVmIE5ERUJVRwogICAgICAgICAgICAgbV9sYXllckZvckhv cml6b250YWxTY3JvbGxiYXItPnNldE5hbWUoImhvcml6b250YWwgc2Nyb2xsYmFyIik7CiAgICAg I2VuZGlmCkBAIC0xNzg5LDYgKzE3OTIsOSBAQCB2b2lkIFJlbmRlckxheWVyQ29tcG9zaXRvcjo6 dXBkYXRlT3ZlcmZsb3dDb250cm9sc0xheWVycygpCiAgICAgaWYgKHJlcXVpcmVzVmVydGljYWxT Y3JvbGxiYXJMYXllcigpKSB7CiAgICAgICAgIGlmICghbV9sYXllckZvclZlcnRpY2FsU2Nyb2xs YmFyKSB7CiAgICAgICAgICAgICBtX2xheWVyRm9yVmVydGljYWxTY3JvbGxiYXIgPSBHcmFwaGlj c0xheWVyOjpjcmVhdGUodGhpcyk7CisjaWYgUExBVEZPUk0oQ0hST01JVU0pCisgICAgICAgICAg ICBtX2xheWVyRm9yVmVydGljYWxTY3JvbGxiYXItPnNldENvbnRlbnRzT3BhcXVlKHRydWUpOwor I2VuZGlmCiAgICAgI2lmbmRlZiBOREVCVUcKICAgICAgICAgICAgIG1fbGF5ZXJGb3JWZXJ0aWNh bFNjcm9sbGJhci0+c2V0TmFtZSgidmVydGljYWwgc2Nyb2xsYmFyIik7CiAgICAgI2VuZGlmCg==