77665 2012-02-02 12:01:09 -0800 createImpulseBuffer uses incorrect length 2012-02-07 12:16:28 -0800 1 1 1 Unclassified WebKit Web Audio 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rtoy rtoy crogers kbr webkit.review.bot oldest_to_newest 548038 0 rtoy 2012-02-02 12:01:09 -0800 In audio-testing.js, we have function createImpulseBuffer(context, sampleFrameLength) { var audioBuffer = context.createBuffer(1, 1000, context.sampleRate); That 1000 should be sampleFrameLength. 548145 1 125183 rtoy 2012-02-02 13:54:23 -0800 Created attachment 125183 Patch 548165 2 crogers 2012-02-02 14:25:59 -0800 Wow, you wrote a layout test to test another layout test function - very meta! Honestly, I would remove the test and just fix the existing layout test function in the .js file. 548175 3 rtoy 2012-02-02 14:42:31 -0800 (In reply to comment #2) > Wow, you wrote a layout test to test another layout test function - very meta! > > Honestly, I would remove the test and just fix the existing layout test function in the .js file. Yeah, I wasn't going to, but then thought if we had had a test, this wouldn't have happened. I'll remove it and upload a new version shortly. 548176 4 125193 rtoy 2012-02-02 14:46:25 -0800 Created attachment 125193 Patch 548185 5 crogers 2012-02-02 15:08:39 -0800 Looks good. 551155 6 rtoy 2012-02-07 11:19:52 -0800 Ken, can you take a quick look at this one line change? 551167 7 125193 kbr 2012-02-07 11:29:04 -0800 Comment on attachment 125193 Patch Looks fine. rs=me 551226 8 125193 webkit.review.bot 2012-02-07 12:16:24 -0800 Comment on attachment 125193 Patch Clearing flags on attachment: 125193 Committed r106974: <http://trac.webkit.org/changeset/106974> 551227 9 webkit.review.bot 2012-02-07 12:16:28 -0800 All reviewed patches have been landed. Closing bug. 125183 2012-02-02 13:54:23 -0800 2012-02-02 14:46:23 -0800 Patch bug-77665-20120202135422.patch text/plain 5176 rtoy U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2NTQ1CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZmM1NzRiMWFhMDFkOGMxYmY5MWRh Njc2MzRkMWRhN2YyNzNmYmQzYi4uNjg3YjZkNDk2YWU4ZDNkNzg1NDg1N2IxMDlkZWJiYmYyOWQw M2E0MyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTAyLTAyICBSYXltb25kIFRveSAgPHJ0 b3lAZ29vZ2xlLmNvbT4KKworICAgICAgICBjcmVhdGVJbXB1bHNlQnVmZmVyIHVzZXMgaW5jb3Jy ZWN0IGxlbmd0aAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9Nzc2NjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIHdlYmF1ZGlvL2NyZWF0ZS1pbXB1bHNlLWJ1ZmZlci1leHBlY3RlZC50eHQ6IEFkZGVkLgor ICAgICAgICAqIHdlYmF1ZGlvL2NyZWF0ZS1pbXB1bHNlLWJ1ZmZlci5odG1sOiBBZGRlZC4KKyAg ICAgICAgKiB3ZWJhdWRpby9yZXNvdXJjZXMvYXVkaW8tdGVzdGluZy5qczoKKyAgICAgICAgKGNy ZWF0ZUltcHVsc2VCdWZmZXIpOiAgRml4IGJ1ZyBzbyB0aGUgYnVmZmVyIGhhcyB0aGUgY29ycmVj dAorICAgICAgICBsZW5ndGguIAorCiAyMDEyLTAyLTAyICBSYXVsIEh1ZGVhICA8cmh1ZGVhQGFk b2JlLmNvbT4KIAogICAgICAgICBSZWdpb25zIHNob3VsZCBpZ25vcmUgdGhlIHNhdmVkIGN1cnJl bnRSZW5kZXJGbG93VGhyZWFkIGR1cmluZyByZXBhaW50aW5nCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy93ZWJhdWRpby9jcmVhdGUtaW1wdWxzZS1idWZmZXItZXhwZWN0ZWQudHh0IGIvTGF5b3V0 VGVzdHMvd2ViYXVkaW8vY3JlYXRlLWltcHVsc2UtYnVmZmVyLWV4cGVjdGVkLnR4dApuZXcgZmls ZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwLi43ZjZiYTk4MzFhZWJhYjhhYjYzYzcyYmM2MTQ4NTdmZGJiOWY1MTc4Ci0tLSAvZGV2L251 bGwKKysrIGIvTGF5b3V0VGVzdHMvd2ViYXVkaW8vY3JlYXRlLWltcHVsc2UtYnVmZmVyLWV4cGVj dGVkLnR4dApAQCAtMCwwICsxLDE0IEBACitUZXN0IGNyZWF0ZUltcHVsc2VCdWZmZXIuCisKK09u IHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxv d2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworUEFTUyBJbXB1bHNlIGJ1ZmZlciAwIGhhcyBleHBl Y3RlZCBsZW5ndGggKDEwMCkuCitQQVNTIEltcHVsc2UgYnVmZmVyIDAgaGFzIGNvcnJlY3QgZGF0 YS4KK1BBU1MgSW1wdWxzZSBidWZmZXIgMSBoYXMgZXhwZWN0ZWQgbGVuZ3RoICg5OTkpLgorUEFT UyBJbXB1bHNlIGJ1ZmZlciAxIGhhcyBjb3JyZWN0IGRhdGEuCitQQVNTIEltcHVsc2UgYnVmZmVy IDIgaGFzIGV4cGVjdGVkIGxlbmd0aCAoMjAwMCkuCitQQVNTIEltcHVsc2UgYnVmZmVyIDIgaGFz IGNvcnJlY3QgZGF0YS4KK1BBU1MgY3JlYXRlSW1wdWxzZUJ1ZmZlciB0ZXN0cyBwYXNzZWQuCitQ QVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL3dlYmF1ZGlvL2NyZWF0ZS1pbXB1bHNlLWJ1ZmZlci5odG1sIGIvTGF5 b3V0VGVzdHMvd2ViYXVkaW8vY3JlYXRlLWltcHVsc2UtYnVmZmVyLmh0bWwKbmV3IGZpbGUgbW9k ZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4u NjFmMDA0NzRjMTJjZDIzYzlmZjM5Y2QyY2M3MGM1Yzc2YzJhODJjZQotLS0gL2Rldi9udWxsCisr KyBiL0xheW91dFRlc3RzL3dlYmF1ZGlvL2NyZWF0ZS1pbXB1bHNlLWJ1ZmZlci5odG1sCkBAIC0w LDAgKzEsODUgQEAKKzwhRE9DVFlQRSBIVE1MIFBVQkxJQyAiLS8vVzNDLy9EVEQgSFRNTCA0LjAx IFRyYW5zaXRpb25hbC8vRU4iPgorPGh0bWw+CisgIDxoZWFkPgorICAgIDxsaW5rIHJlbD0ic3R5 bGVzaGVldCIgaHJlZj0iLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1zdHlsZS5jc3MiLz4K KyAgICA8c2NyaXB0IHNyYz0icmVzb3VyY2VzL2F1ZGlvLXRlc3RpbmcuanMiPjwvc2NyaXB0Pgor ICAgIDxzY3JpcHQgc3JjPSIuLi9mYXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9z Y3JpcHQ+CisgIDwvaGVhZD4KKworICA8Ym9keT4KKyAgICA8ZGl2IGlkPSJkZXNjcmlwdGlvbiI+ PC9kaXY+CisgICAgPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+CisKKyAgICA8c2NyaXB0PgorICAg ICAgZGVzY3JpcHRpb24oIlRlc3QgY3JlYXRlSW1wdWxzZUJ1ZmZlci4iKTsKKworICAgICAgLy8g Q3JlYXRlIHNvbWUgaW1wdWxzZSBidWZmZXJzIGFuZCB2ZXJpZnkgdGhleSBoYXZlIHRoZSBjb3Jy ZWN0CisgICAgICAvLyBsZW5ndGggYW5kIGRhdGEuCisgICAgICAKKyAgICAgIGZ1bmN0aW9uIHJ1 blRlc3QoKSB7CisgICAgICAgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgewor ICAgICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisgICAgICAg ICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLndhaXRVbnRpbERvbmUoKTsKKyAgICAgICAgICB9 CisKKyAgICAgICAgICB3aW5kb3cuanNUZXN0SXNBc3luYyA9IHRydWU7CisKKyAgICAgICAgICAv LyBBcnJheSBvZiBsZW5ndGhzIHRvIHRlc3QgdGhlIGltcHVsc2UgYnVmZmVyLgorICAgICAgICAg IHZhciBpbXB1bHNlTGVuZ3RocyA9IFsxMDAsIDk5OSwgMjAwMF07CisKKyAgICAgICAgICB2YXIg Y29udGV4dCA9IG5ldyB3ZWJraXRBdWRpb0NvbnRleHQoKTsKKworICAgICAgICAgIHZhciBzdWNj ZXNzID0gdHJ1ZTsKKyAgICAgIAorICAgICAgICAgIGZvciAodmFyIGsgPSAwOyBrIDwgaW1wdWxz ZUxlbmd0aHMubGVuZ3RoOyArK2spIHsKKyAgICAgICAgICAgICAgdmFyIGV4cGVjdGVkTGVuZ3Ro ID0gaW1wdWxzZUxlbmd0aHNba107CisgICAgICAgICAgICAgIHZhciBpbXB1bHNlQnVmZmVyID0g Y3JlYXRlSW1wdWxzZUJ1ZmZlcihjb250ZXh0LCBleHBlY3RlZExlbmd0aCk7CisKKyAgICAgICAg ICAgICAgLy8gQ2hlY2sgbGVuZ3RoIG9mIGltcHVsc2UKKwkgICAgICBpZiAoaW1wdWxzZUJ1ZmZl ci5sZW5ndGggPT0gZXhwZWN0ZWRMZW5ndGgpIHsKKwkJICB0ZXN0UGFzc2VkKCJJbXB1bHNlIGJ1 ZmZlciAiICsgayArICIgaGFzIGV4cGVjdGVkIGxlbmd0aCAoIiArIGV4cGVjdGVkTGVuZ3RoICsg IikuIik7CisJICAgICAgfSBlbHNlIHsKKwkJICB0ZXN0RmFpbGVkKCJJbXB1bHNlIGJ1ZmZlciAi ICsgayArICIgaGFzIGxlbmd0aCAiICsgaW1wdWxzZUJ1ZmZlci5sZW5ndGggKyAiIGJ1dCBleHBl Y3RlZCAiICsgZXhwZWN0ZWRMZW5ndGgpOworCQkgIHN1Y2Nlc3MgPSBmYWxzZTsKKwkgICAgICB9 CisKKyAgICAgICAgICAgICAgLy8gQ2hlY2sgdGhlIGltcHVsc2UgYnVmZmVyIGlzIHJlYWxseSBh biBpbXB1bHNlLgorCSAgICAgIHZhciBkYXRhID0gaW1wdWxzZUJ1ZmZlci5nZXRDaGFubmVsRGF0 YSgwKTsKKwkgICAgICB2YXIgZGF0YU9rID0gdHJ1ZTsKKworCSAgICAgIGlmIChkYXRhWzBdICE9 IDEpIHsKKwkJICBkYXRhT2sgPSBmYWxzZTsKKwkgICAgICB9IGVsc2UgeworCQkgIGZvciAodmFy IG4gPSAxOyBuIDwgaW1wdWxzZUJ1ZmZlci5sZW5ndGg7ICsrbikgeworCQkgICAgICBpZiAoZGF0 YVtuXSkgeworCQkJICBkYXRhT2sgPSBmYWxzZTsKKwkJCSAgYnJlYWs7CisJCSAgICAgIH0KKwkJ ICB9CisJICAgICAgfQorCisJICAgICAgaWYgKGRhdGFPaykgeworCQkgIHRlc3RQYXNzZWQoIklt cHVsc2UgYnVmZmVyICIgKyBrICsgIiBoYXMgY29ycmVjdCBkYXRhLiIpOworCSAgICAgIH0gZWxz ZSB7CisJCSAgdGVzdEZhaWxlZCgiSW1wdWxzZSBidWZmZXIgIiArIGsgKyAiIGhhcyBpbmNvcnJl Y3QgZGF0YS4iKTsKKwkJICBzdWNjZXNzID0gZmFsc2U7CisJICAgICAgfQorICAgICAgICAgIH0K KworICAgICAgICAgIGlmIChzdWNjZXNzKSB7CisgICAgICAgICAgICAgIHRlc3RQYXNzZWQoImNy ZWF0ZUltcHVsc2VCdWZmZXIgdGVzdHMgcGFzc2VkLiIpOworICAgICAgICAgIH0gZWxzZSB7Cisg ICAgICAgICAgICAgIHRlc3RGYWlsZWQoImNyZWF0ZUltcHVsc2VCdWZmZXIgdGVzdHMgZmFpbGVk LiIpOworICAgICAgICAgIH0KKyAgICAgIAorICAgICAgICAgIGZpbmlzaEpTVGVzdCgpOworICAg ICAgfQorCisgICAgICBydW5UZXN0KCk7CisgICAgICBzdWNjZXNzZnVsbHlQYXJzZWQgPSB0cnVl OworCisgICAgPC9zY3JpcHQ+CisKKyAgICA8c2NyaXB0IHNyYz0iLi4vZmFzdC9qcy9yZXNvdXJj ZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKyAgPC9ib2R5PgorPC9odG1sPgpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvd2ViYXVkaW8vcmVzb3VyY2VzL2F1ZGlvLXRlc3RpbmcuanMgYi9M YXlvdXRUZXN0cy93ZWJhdWRpby9yZXNvdXJjZXMvYXVkaW8tdGVzdGluZy5qcwppbmRleCBjNDI4 YWUwMTRlMGEwYTI3ZTE2NjhjZmIyZGIwOWUzZWE3ODc5NzUzLi4zOTU1NjAzNmMwZDhhNzNiY2Zm MDljNWQyZWVmMWQxOTliNWRmZDFjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy93ZWJhdWRpby9y ZXNvdXJjZXMvYXVkaW8tdGVzdGluZy5qcworKysgYi9MYXlvdXRUZXN0cy93ZWJhdWRpby9yZXNv dXJjZXMvYXVkaW8tdGVzdGluZy5qcwpAQCAtMTA4LDcgKzEwOCw3IEBAIGZ1bmN0aW9uIGZpbmlz aEF1ZGlvVGVzdChldmVudCkgewogCiAvLyBDcmVhdGUgYW4gaW1wdWxzZSBpbiBhIGJ1ZmZlciBv ZiBsZW5ndGggc2FtcGxlRnJhbWVMZW5ndGgKIGZ1bmN0aW9uIGNyZWF0ZUltcHVsc2VCdWZmZXIo Y29udGV4dCwgc2FtcGxlRnJhbWVMZW5ndGgpIHsKLSAgICB2YXIgYXVkaW9CdWZmZXIgPSBjb250 ZXh0LmNyZWF0ZUJ1ZmZlcigxLCAxMDAwLCBjb250ZXh0LnNhbXBsZVJhdGUpOworICAgIHZhciBh dWRpb0J1ZmZlciA9IGNvbnRleHQuY3JlYXRlQnVmZmVyKDEsIHNhbXBsZUZyYW1lTGVuZ3RoLCBj b250ZXh0LnNhbXBsZVJhdGUpOwogICAgIHZhciBuID0gYXVkaW9CdWZmZXIubGVuZ3RoOwogICAg IHZhciBkYXRhTCA9IGF1ZGlvQnVmZmVyLmdldENoYW5uZWxEYXRhKDApOwogCg== 125193 2012-02-02 14:46:25 -0800 2012-02-07 12:16:24 -0800 Patch bug-77665-20120202144624.patch text/plain 1454 rtoy U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2NTQ1CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZmM1NzRiMWFhMDFkOGMxYmY5MWRh Njc2MzRkMWRhN2YyNzNmYmQzYi4uZGNlZjZjY2NmNzZhMjVjODg0Y2IyMjUxOWViOThhY2UxNzMx ZTAwZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTAyLTAyICBSYXltb25kIFRveSAgPHJ0 b3lAZ29vZ2xlLmNvbT4KKworICAgICAgICBjcmVhdGVJbXB1bHNlQnVmZmVyIHVzZXMgaW5jb3Jy ZWN0IGxlbmd0aAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9Nzc2NjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIHdlYmF1ZGlvL3Jlc291cmNlcy9hdWRpby10ZXN0aW5nLmpzOgorICAgICAgICAoY3JlYXRl SW1wdWxzZUJ1ZmZlcik6ICBGaXggYnVnIHNvIHRoZSBidWZmZXIgaGFzIHRoZSBjb3JyZWN0Cisg ICAgICAgIGxlbmd0aC4gCisKIDIwMTItMDItMDIgIFJhdWwgSHVkZWEgIDxyaHVkZWFAYWRvYmUu Y29tPgogCiAgICAgICAgIFJlZ2lvbnMgc2hvdWxkIGlnbm9yZSB0aGUgc2F2ZWQgY3VycmVudFJl bmRlckZsb3dUaHJlYWQgZHVyaW5nIHJlcGFpbnRpbmcKZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L3dlYmF1ZGlvL3Jlc291cmNlcy9hdWRpby10ZXN0aW5nLmpzIGIvTGF5b3V0VGVzdHMvd2ViYXVk aW8vcmVzb3VyY2VzL2F1ZGlvLXRlc3RpbmcuanMKaW5kZXggYzQyOGFlMDE0ZTBhMGEyN2UxNjY4 Y2ZiMmRiMDllM2VhNzg3OTc1My4uMzk1NTYwMzZjMGQ4YTczYmNmZjA5YzVkMmVlZjFkMTk5YjVk ZmQxYyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvd2ViYXVkaW8vcmVzb3VyY2VzL2F1ZGlvLXRl c3RpbmcuanMKKysrIGIvTGF5b3V0VGVzdHMvd2ViYXVkaW8vcmVzb3VyY2VzL2F1ZGlvLXRlc3Rp bmcuanMKQEAgLTEwOCw3ICsxMDgsNyBAQCBmdW5jdGlvbiBmaW5pc2hBdWRpb1Rlc3QoZXZlbnQp IHsKIAogLy8gQ3JlYXRlIGFuIGltcHVsc2UgaW4gYSBidWZmZXIgb2YgbGVuZ3RoIHNhbXBsZUZy YW1lTGVuZ3RoCiBmdW5jdGlvbiBjcmVhdGVJbXB1bHNlQnVmZmVyKGNvbnRleHQsIHNhbXBsZUZy YW1lTGVuZ3RoKSB7Ci0gICAgdmFyIGF1ZGlvQnVmZmVyID0gY29udGV4dC5jcmVhdGVCdWZmZXIo MSwgMTAwMCwgY29udGV4dC5zYW1wbGVSYXRlKTsKKyAgICB2YXIgYXVkaW9CdWZmZXIgPSBjb250 ZXh0LmNyZWF0ZUJ1ZmZlcigxLCBzYW1wbGVGcmFtZUxlbmd0aCwgY29udGV4dC5zYW1wbGVSYXRl KTsKICAgICB2YXIgbiA9IGF1ZGlvQnVmZmVyLmxlbmd0aDsKICAgICB2YXIgZGF0YUwgPSBhdWRp b0J1ZmZlci5nZXRDaGFubmVsRGF0YSgwKTsKIAo=