77606 2012-02-01 23:18:17 -0800 The third argument of addEventListener/removeEventListener of PeerConnection should be optional 2012-02-02 00:24:24 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 77393 1 haraken haraken abarth darin ojan webkit.review.bot oldest_to_newest 547672 0 haraken 2012-02-01 23:18:17 -0800 We need to correct typo in PeerConnection.idl: Before: void addEventListener(in DOMString type, in EventListener listener, in [optional] boolean useCapture); void removeEventListener(in DOMString type, in EventListener listener, in [optional] boolean useCapture); After: void addEventListener(in DOMString type, in EventListener listener, in [Optional] boolean useCapture); void removeEventListener(in DOMString type, in EventListener listener, in [Optional] boolean useCapture); 547676 1 125082 haraken 2012-02-01 23:22:11 -0800 Created attachment 125082 Patch 547687 2 125082 abarth 2012-02-01 23:40:01 -0800 Comment on attachment 125082 Patch Thanks for the test. 547706 3 125082 webkit.review.bot 2012-02-02 00:24:17 -0800 Comment on attachment 125082 Patch Clearing flags on attachment: 125082 Committed r106539: <http://trac.webkit.org/changeset/106539> 547707 4 webkit.review.bot 2012-02-02 00:24:24 -0800 All reviewed patches have been landed. Closing bug. 125082 2012-02-01 23:22:11 -0800 2012-02-02 00:24:17 -0800 Patch bug-77606-20120202162210.patch text/plain 5210 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2NTMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWE0MTE2YzNmODIxODNi YjE4ZTgyZGY0MDdmMDMwY2Y0YWE1OTg3Ni4uOTllZjk1NDhkM2UyN2RmZWI2YWNkZGE4ZDE1MDcy ZWMzMzFjOTQzZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTAyLTAxICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBUaGUgdGhpcmQgYXJn dW1lbnQgb2YgYWRkRXZlbnRMaXN0ZW5lci9yZW1vdmVFdmVudExpc3RlbmVyIG9mIFBlZXJDb25u ZWN0aW9uIHNob3VsZCBiZSBvcHRpb25hbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9Nzc2MDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBUaGlzIHBhdGNoIGNvcnJlY3RzIGEgdHlwbyBpbiBQZWVyQ29ubmVj dGlvbi5pZGwsIGkuZS4gW29wdGlvbmFsXSA9PiBbT3B0aW9uYWxdLgorCisgICAgICAgIFRlc3Q6 IGZhc3QvbWVkaWFzdHJlYW0vcGVlcmNvbm5lY3Rpb24tZXZlbnRsaXN0ZW5lci1vcHRpb25hbC1h cmd1bWVudC5odG1sCisKKyAgICAgICAgKiBtZWRpYXN0cmVhbS9QZWVyQ29ubmVjdGlvbi5pZGw6 CisKIDIwMTItMDItMDEgIEhheWF0byBJdG8gIDxoYXlhdG9AY2hyb21pdW0ub3JnPgogCiAgICAg ICAgIENoYW5nZSBjbGFzcyBoaWVyYXJ5Y3kgc28gdGhhdCBTaGFkb3dSb290IGNhbiBpbmhlcml0 IERvY3VtZW50RnJhZ21lbnQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9tZWRpYXN0cmVh bS9QZWVyQ29ubmVjdGlvbi5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9tZWRpYXN0cmVhbS9QZWVyQ29u bmVjdGlvbi5pZGwKaW5kZXggZjllZTE5MmQxZTI2ZTYyZDhkZWJlNjFkNmY1ZTU1MjhjOWFjMzI4 Zi4uNTlkMzVlMzE2M2YyYjI0M2E1MzA5Mzg3OGFmODU1ZGZkYjRjMjBjNCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvbWVkaWFzdHJlYW0vUGVlckNvbm5lY3Rpb24uaWRsCisrKyBiL1NvdXJj ZS9XZWJDb3JlL21lZGlhc3RyZWFtL1BlZXJDb25uZWN0aW9uLmlkbApAQCAtNjQsMTAgKzY0LDEw IEBAIG1vZHVsZSBwMnAgewogICAgICAgICAvLyBFdmVudFRhcmdldCBpbnRlcmZhY2UKICAgICAg ICAgdm9pZCBhZGRFdmVudExpc3RlbmVyKGluIERPTVN0cmluZyB0eXBlLAogICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgaW4gRXZlbnRMaXN0ZW5lciBsaXN0ZW5lciwKLSAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIGluIFtvcHRpb25hbF0gYm9vbGVhbiB1c2VDYXB0dXJlKTsKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGluIFtPcHRpb25hbF0gYm9vbGVhbiB1c2VDYXB0 dXJlKTsKICAgICAgICAgdm9pZCByZW1vdmVFdmVudExpc3RlbmVyKGluIERPTVN0cmluZyB0eXBl LAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaW4gRXZlbnRMaXN0ZW5lciBsaXN0 ZW5lciwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGluIFtvcHRpb25hbF0gYm9v bGVhbiB1c2VDYXB0dXJlKTsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGluIFtP cHRpb25hbF0gYm9vbGVhbiB1c2VDYXB0dXJlKTsKICAgICAgICAgYm9vbGVhbiBkaXNwYXRjaEV2 ZW50KGluIEV2ZW50IGV2ZW50KQogICAgICAgICAgICAgcmFpc2VzKEV2ZW50RXhjZXB0aW9uKTsK ICAgICB9OwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCmluZGV4IGNhZjMxZTMzZTFkMDVmMDU5MmVkYjQ0OWJjMzI2NmU1YjczYzVjMDAu LmQzZDU1Y2JlOTQwMGMxNDE1YzEwYjM3NWM2ZDRiNzRmM2NmZjZkZTcgMTAwNjQ0Ci0tLSBhL0xh eW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxNiBAQAorMjAxMi0wMi0wMSAgS2VudGFybyBIYXJhICA8aGFyYWtlbkBjaHJvbWl1bS5vcmc+ CisKKyAgICAgICAgVGhlIHRoaXJkIGFyZ3VtZW50IG9mIGFkZEV2ZW50TGlzdGVuZXIvcmVtb3Zl RXZlbnRMaXN0ZW5lciBvZiBQZWVyQ29ubmVjdGlvbiBzaG91bGQgYmUgb3B0aW9uYWwKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc3NjA2CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGFkZGVkIHRlc3Qg Y29uZmlybXMgaWYgdGhlIHRoaXJkIGFyZ3VtZW50IG9mIGFkZEV2ZW50TGlzdGVuZXIoKSBhbmQK KyAgICAgICAgcmVtb3ZlRXZlbnRMaXN0ZW5lcigpIGlzIG9wdGlvbmFsLgorCisgICAgICAgICog ZmFzdC9tZWRpYXN0cmVhbS9wZWVyY29ubmVjdGlvbi1ldmVudGxpc3RlbmVyLW9wdGlvbmFsLWFy Z3VtZW50LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9tZWRpYXN0cmVhbS9w ZWVyY29ubmVjdGlvbi1ldmVudGxpc3RlbmVyLW9wdGlvbmFsLWFyZ3VtZW50Lmh0bWw6IEFkZGVk LgorCiAyMDEyLTAyLTAxICBTaGlueWEgS2F3YW5ha2EgIDxzaGlueWFrQGdvb2dsZS5jb20+CiAK ICAgICAgICAgU2VsZWN0IGF0dHJpYnV0ZSBvZiBIVE1MQ29udGVudEVsZW1lbnQgc2hvdWxkIGJl IGFibGUgYmUgY2hhbmdlZCBkeW5hbWljYWxseS4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zh c3QvbWVkaWFzdHJlYW0vcGVlcmNvbm5lY3Rpb24tZXZlbnRsaXN0ZW5lci1vcHRpb25hbC1hcmd1 bWVudC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L21lZGlhc3RyZWFtL3BlZXJjb25u ZWN0aW9uLWV2ZW50bGlzdGVuZXItb3B0aW9uYWwtYXJndW1lbnQtZXhwZWN0ZWQudHh0Cm5ldyBm aWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAuLjg0YWMxYWI4MDZjYWFkNTQ0ZmQ1YTJhZjg5MzFhNjY5OTY3ZmVlYTIKLS0tIC9kZXYv bnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L21lZGlhc3RyZWFtL3BlZXJjb25uZWN0aW9uLWV2 ZW50bGlzdGVuZXItb3B0aW9uYWwtYXJndW1lbnQtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMTUg QEAKK1RoaXMgdGVzdCBjb25maXJtcyBpZiB0aGUgdGhpcmQgYXJndW1lbnQgb2YgYWRkRXZlbnRM aXN0ZW5lcigpIGFuZCByZW1vdmVFdmVudExpc3RlbmVyKCkgaXMgb3B0aW9uYWwuCisKK09uIHN1 Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2Vk IGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitQQVNTIHBjLmFkZEV2ZW50TGlzdGVuZXIoImZvbyIs IGZ1bmN0aW9uKCkge30pIGlzIHVuZGVmaW5lZAorUEFTUyBwYy5hZGRFdmVudExpc3RlbmVyKCJm b28iLCBmdW5jdGlvbigpIHt9LCBmYWxzZSkgaXMgdW5kZWZpbmVkCitQQVNTIHBjLmFkZEV2ZW50 TGlzdGVuZXIoImZvbyIsIGZ1bmN0aW9uKCkge30sIHRydWUpIGlzIHVuZGVmaW5lZAorUEFTUyBw Yy5yZW1vdmVFdmVudExpc3RlbmVyKCJmb28iLCBmdW5jdGlvbigpIHt9KSBpcyB1bmRlZmluZWQK K1BBU1MgcGMucmVtb3ZlRXZlbnRMaXN0ZW5lcigiZm9vIiwgZnVuY3Rpb24oKSB7fSwgZmFsc2Up IGlzIHVuZGVmaW5lZAorUEFTUyBwYy5yZW1vdmVFdmVudExpc3RlbmVyKCJmb28iLCBmdW5jdGlv bigpIHt9LCB0cnVlKSBpcyB1bmRlZmluZWQKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRy dWUKKworVEVTVCBDT01QTEVURQorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L21lZGlh c3RyZWFtL3BlZXJjb25uZWN0aW9uLWV2ZW50bGlzdGVuZXItb3B0aW9uYWwtYXJndW1lbnQuaHRt bCBiL0xheW91dFRlc3RzL2Zhc3QvbWVkaWFzdHJlYW0vcGVlcmNvbm5lY3Rpb24tZXZlbnRsaXN0 ZW5lci1vcHRpb25hbC1hcmd1bWVudC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjYxNzVlZTcyOTQ4MGFkNjRm YWY3NzE0ZTRlZjdiYzNiY2NjNDYzYjcKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9m YXN0L21lZGlhc3RyZWFtL3BlZXJjb25uZWN0aW9uLWV2ZW50bGlzdGVuZXItb3B0aW9uYWwtYXJn dW1lbnQuaHRtbApAQCAtMCwwICsxLDI1IEBACis8IURPQ1RZUEUgSFRNTCBQVUJMSUMgIi0vL0lF VEYvL0RURCBIVE1MLy9FTiI+Cis8aHRtbD4KKzxoZWFkPgorPHNjcmlwdCBzcmM9Ii4uL2pzL3Jl c291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKzxwIGlk PSJkZXNjcmlwdGlvbiI+PC9wPgorPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+Cis8L2JvZHk+Cis8 c2NyaXB0PgorZGVzY3JpcHRpb24oIlRoaXMgdGVzdCBjb25maXJtcyBpZiB0aGUgdGhpcmQgYXJn dW1lbnQgb2YgYWRkRXZlbnRMaXN0ZW5lcigpIGFuZCByZW1vdmVFdmVudExpc3RlbmVyKCkgaXMg b3B0aW9uYWwuIik7CisKK3ZhciBwYyA9IG5ldyB3ZWJraXRQZWVyQ29ubmVjdGlvbigic29tZS5z ZXJ2ZXIuY29tIiwgZnVuY3Rpb24oKSB7fSk7CitzaG91bGRCZSgncGMuYWRkRXZlbnRMaXN0ZW5l cigiZm9vIiwgZnVuY3Rpb24oKSB7fSknLCAndW5kZWZpbmVkJyk7CitzaG91bGRCZSgncGMuYWRk RXZlbnRMaXN0ZW5lcigiZm9vIiwgZnVuY3Rpb24oKSB7fSwgZmFsc2UpJywgJ3VuZGVmaW5lZCcp Oworc2hvdWxkQmUoJ3BjLmFkZEV2ZW50TGlzdGVuZXIoImZvbyIsIGZ1bmN0aW9uKCkge30sIHRy dWUpJywgJ3VuZGVmaW5lZCcpOworc2hvdWxkQmUoJ3BjLnJlbW92ZUV2ZW50TGlzdGVuZXIoImZv byIsIGZ1bmN0aW9uKCkge30pJywgJ3VuZGVmaW5lZCcpOworc2hvdWxkQmUoJ3BjLnJlbW92ZUV2 ZW50TGlzdGVuZXIoImZvbyIsIGZ1bmN0aW9uKCkge30sIGZhbHNlKScsICd1bmRlZmluZWQnKTsK K3Nob3VsZEJlKCdwYy5yZW1vdmVFdmVudExpc3RlbmVyKCJmb28iLCBmdW5jdGlvbigpIHt9LCB0 cnVlKScsICd1bmRlZmluZWQnKTsKKword2luZG93LnN1Y2Nlc3NmdWxseVBhcnNlZCA9IHRydWU7 CisKKzwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXBvc3Qu anMiPjwvc2NyaXB0PgorPC9odG1sPgo=