77604 2012-02-01 22:36:30 -0800 [Qt] Inspector Disabled build breaks (if Javascript debugger is not disabled) 2012-02-03 04:02:51 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All Linux RESOLVED FIXED P3 Normal --- 0 sriram.neelakandan webkit-unassigned vestbo webkit.review.bot zoltan oldest_to_newest 547660 0 sriram.neelakandan 2012-02-01 22:36:30 -0800 I use the following command line to build-webkit-qt from Trunk (using Qt-4.8.0) ./Tools/Scripts/build-webkit --no-video --no-svg --no-mathml --no-inspector --no-3d-canvas --no-webkit2 --no-web-audio --debug --qt The Inspector disabled build breaks with the following error: ../../../../Source/WebCore/bindings/js/ScriptProfiler.h:56:23: error: ‘InspectorValue’ was not declared in this scope ../../../../Source/WebCore/bindings/js/ScriptProfiler.h:56:37: error: template argument 1 is invalid I think this may be due to http://trac.webkit.org/changeset/102366/trunk/Source/WebCore/bindings/js/ScriptProfiler.h Attaching a patch to disable Javascript Debugger if Inspector is disabled in features.prf 547661 1 125081 sriram.neelakandan 2012-02-01 22:37:46 -0800 Created attachment 125081 patch to disable JS Debugger if Inspector is disabled 548540 2 zoltan 2012-02-03 00:55:38 -0800 Looks reasonable for me. Please add changelog to the patch! 548562 3 125285 sriram.neelakandan 2012-02-03 01:22:58 -0800 Created attachment 125285 patch to disable JS Debugger if Inspector is disabled (with changeLog) 548608 4 125285 vestbo 2012-02-03 03:08:23 -0800 Comment on attachment 125285 patch to disable JS Debugger if Inspector is disabled (with changeLog) thanks 548626 5 125285 webkit.review.bot 2012-02-03 04:02:45 -0800 Comment on attachment 125285 patch to disable JS Debugger if Inspector is disabled (with changeLog) Clearing flags on attachment: 125285 Committed r106647: <http://trac.webkit.org/changeset/106647> 548627 6 webkit.review.bot 2012-02-03 04:02:51 -0800 All reviewed patches have been landed. Closing bug. 125081 2012-02-01 22:37:46 -0800 2012-02-03 01:22:58 -0800 patch to disable JS Debugger if Inspector is disabled no_inspector_build.patch text/plain 677 sriram.neelakandan ZGlmZiAtLWdpdCBhL1Rvb2xzL3FtYWtlL21rc3BlY3MvZmVhdHVyZXMvZmVhdHVyZXMucHJmIGIv VG9vbHMvcW1ha2UvbWtzcGVjcy9mZWF0dXJlcy9mZWF0dXJlcy5wcmYKaW5kZXggOGZkODJiNC4u ZTcxOTBjZSAxMDA2NDQKLS0tIGEvVG9vbHMvcW1ha2UvbWtzcGVjcy9mZWF0dXJlcy9mZWF0dXJl cy5wcmYKKysrIGIvVG9vbHMvcW1ha2UvbWtzcGVjcy9mZWF0dXJlcy9mZWF0dXJlcy5wcmYKQEAg LTIwNyw2ICsyMDcsMTEgQEAgY29udGFpbnMoTU9CSUxJVFlfQ09ORklHLCBzZW5zb3JzKSB7CiAK ICFjb250YWlucyhERUZJTkVTLCBFTkFCTEVfRlVMTFNDUkVFTl9BUEk9Lik6IERFRklORVMgKz0g RU5BQkxFX0ZVTExTQ1JFRU5fQVBJPTAKIAorY29udGFpbnMoREVGSU5FUywgRU5BQkxFX0lOU1BF Q1RPUj0wKSB7CisgICAgREVGSU5FUyAtPSBFTkFCTEVfSkFWQVNDUklQVF9ERUJVR0dFUj0xCisg ICAgREVGSU5FUyArPSBFTkFCTEVfSkFWQVNDUklQVF9ERUJVR0dFUj0wCit9CisKICMjIEZvcndh cmQgZW5hYmxlZCBmZWF0dXJlIG1hY3JvcyB0byBKYXZhU2NyaXB0IGVuYWJsZWQgZmVhdHVyZXMg bWFjcm9zCiBGRUFUVVJFX0RFRklORVNfSkFWQVNDUklQVCA9IExBTkdVQUdFX0pBVkFTQ1JJUFQ9 MQogdjg6IEZFQVRVUkVfREVGSU5FU19KQVZBU0NSSVBUICs9IFY4X0JJTkRJTkc9MQo= 125285 2012-02-03 01:22:58 -0800 2012-02-03 04:02:45 -0800 patch to disable JS Debugger if Inspector is disabled (with changeLog) bug_77604.patch text/plain 1200 sriram.neelakandan ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA1MTYz ZjFiLi4yZWFlZmNhIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTItMDItMDMgIFNyaXJhbSBOZWVsYWthbmRhbiAg PHNyaXJhbS5uZWVsYWthbmRhbkBnbWFpbC5jb20+CisKKyAgICAgICAgRW5zdXJlIHRoYXQgaW5z cGVjdG9yIGRpc2FibGVkIGJ1aWxkIHdvcmtzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD03NzYwNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogcW1ha2UvbWtzcGVjcy9mZWF0dXJlcy9mZWF0dXJlcy5wcmY6 CisKIDIwMTItMDItMDEgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAg ICBVcGRhdGUgdGhlIHRlc3RzIHRvIHNob3cgdGhhdCB0aGUgbWFjLWV3cyBwcm9jZXNzZXMgcGF0 Y2hlcyBmcm9tCmRpZmYgLS1naXQgYS9Ub29scy9xbWFrZS9ta3NwZWNzL2ZlYXR1cmVzL2ZlYXR1 cmVzLnByZiBiL1Rvb2xzL3FtYWtlL21rc3BlY3MvZmVhdHVyZXMvZmVhdHVyZXMucHJmCmluZGV4 IDhmZDgyYjQuLmU3MTkwY2UgMTAwNjQ0Ci0tLSBhL1Rvb2xzL3FtYWtlL21rc3BlY3MvZmVhdHVy ZXMvZmVhdHVyZXMucHJmCisrKyBiL1Rvb2xzL3FtYWtlL21rc3BlY3MvZmVhdHVyZXMvZmVhdHVy ZXMucHJmCkBAIC0yMDcsNiArMjA3LDExIEBAIGNvbnRhaW5zKE1PQklMSVRZX0NPTkZJRywgc2Vu c29ycykgewogCiAhY29udGFpbnMoREVGSU5FUywgRU5BQkxFX0ZVTExTQ1JFRU5fQVBJPS4pOiBE RUZJTkVTICs9IEVOQUJMRV9GVUxMU0NSRUVOX0FQST0wCiAKK2NvbnRhaW5zKERFRklORVMsIEVO QUJMRV9JTlNQRUNUT1I9MCkgeworICAgIERFRklORVMgLT0gRU5BQkxFX0pBVkFTQ1JJUFRfREVC VUdHRVI9MQorICAgIERFRklORVMgKz0gRU5BQkxFX0pBVkFTQ1JJUFRfREVCVUdHRVI9MAorfQor CiAjIyBGb3J3YXJkIGVuYWJsZWQgZmVhdHVyZSBtYWNyb3MgdG8gSmF2YVNjcmlwdCBlbmFibGVk IGZlYXR1cmVzIG1hY3JvcwogRkVBVFVSRV9ERUZJTkVTX0pBVkFTQ1JJUFQgPSBMQU5HVUFHRV9K QVZBU0NSSVBUPTEKIHY4OiBGRUFUVVJFX0RFRklORVNfSkFWQVNDUklQVCArPSBWOF9CSU5ESU5H PTEK