77599 2012-02-01 21:06:48 -0800 Rename [V8DisallowShadowing] to [V8Unforgeable] 2012-02-01 23:48:53 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 77393 1 haraken haraken abarth darin japhet ojan webkit.review.bot oldest_to_newest 547617 0 haraken 2012-02-01 21:06:48 -0800 We should rename [V8DisallowShadowing] to [V8Unforgeable], following the Web IDL spec (http://dev.w3.org/2006/webapi/WebIDL/#Unforgeable). 547621 1 125073 haraken 2012-02-01 21:08:43 -0800 Created attachment 125073 Patch 547689 2 125073 webkit.review.bot 2012-02-01 23:48:47 -0800 Comment on attachment 125073 Patch Clearing flags on attachment: 125073 Committed r106535: <http://trac.webkit.org/changeset/106535> 547690 3 webkit.review.bot 2012-02-01 23:48:53 -0800 All reviewed patches have been landed. Closing bug. 125073 2012-02-01 21:08:43 -0800 2012-02-01 23:48:47 -0800 Patch bug-77599-20120202140841.patch text/plain 5266 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2NTMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWE0MTE2YzNmODIxODNi YjE4ZTgyZGY0MDdmMDMwY2Y0YWE1OTg3Ni4uY2EzYTQ0NDFiODk5NzFkMjQzYzRhYmJlYWNlMmE5 MTJjMzU3ZDFlYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTAyLTAxICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZW5hbWUgW1Y4RGlz YWxsb3dTaGFkb3dpbmddIHRvIFtWOFVuZm9yZ2VhYmxlXQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Nzc1OTkKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHBhdGNoIHJlbmFtZXMgW1Y4RGlzYWxsb3dT aGFkb3dpbmddIHRvIFtWOFVuZm9yZ2VhYmxlXSwgZm9sbG93aW5nIHRoZSBXZWIgSURMCisgICAg ICAgIHNwZWMgKGh0dHA6Ly9kZXYudzMub3JnLzIwMDYvd2ViYXBpL1dlYklETC8jVW5mb3JnZWFi bGUpLgorCisgICAgICAgIE5vIHRlc3RzLiBObyBjaGFuZ2UgaW4gYmVoYXZpb3IuCisKKyAgICAg ICAgKiBiaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbToKKyAgICAgICAgKEdlbmVy YXRlTm9ybWFsQXR0ckdldHRlcik6CisgICAgICAgIChHZW5lcmF0ZVNpbmdsZUJhdGNoZWRBdHRy aWJ1dGUpOgorICAgICAgICAoR2VuZXJhdGVJbXBsZW1lbnRhdGlvbik6CisgICAgICAgICogcGFn ZS9ET01XaW5kb3cuaWRsOgorICAgICAgICAqIHBhZ2UvTG9jYXRpb24uaWRsOgorCiAyMDEyLTAy LTAxICBIYXlhdG8gSXRvICA8aGF5YXRvQGNocm9taXVtLm9yZz4KIAogICAgICAgICBDaGFuZ2Ug Y2xhc3MgaGllcmFyeWN5IHNvIHRoYXQgU2hhZG93Um9vdCBjYW4gaW5oZXJpdCBEb2N1bWVudEZy YWdtZW50LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2Rl R2VuZXJhdG9yVjgucG0gYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5l cmF0b3JWOC5wbQppbmRleCAwOGQ0NTVmMDA3Y2M3OGFlOGJmMTcyNTJiM2MyZDFkZGUyZmNkNzE3 Li5mMjJiMDg3MTExODA1OGYxYTI5NjMxZmE4ODNjZmFkNWMwYzAxYjhjIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQorKysgYi9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQpAQCAtODI5 LDcgKzgyOSw3IEBAIEVORAogRU5ECiAgICAgICAgICAgICB9CiAgICAgICAgIH0KLSAgICB9IGVs c2lmICgkYXR0ckV4dC0+eyJ2OE9uUHJvdG8ifSB8fCAkYXR0ckV4dC0+eyJWOERpc2FsbG93U2hh ZG93aW5nIn0pIHsKKyAgICB9IGVsc2lmICgkYXR0ckV4dC0+eyJ2OE9uUHJvdG8ifSB8fCAkYXR0 ckV4dC0+eyJWOFVuZm9yZ2VhYmxlIn0pIHsKICAgICAgICAgaWYgKCRpbnRlcmZhY2VOYW1lIGVx ICJET01XaW5kb3ciKSB7CiAgICAgICAgICAgICBwdXNoKEBpbXBsQ29udGVudERlY2xzLCA8PEVO RCk7CiAgICAgdjg6OkhhbmRsZTx2ODo6T2JqZWN0PiBob2xkZXIgPSBpbmZvLkhvbGRlcigpOwpA QCAtMTk0OCw3ICsxOTQ4LDcgQEAgc3ViIEdlbmVyYXRlU2luZ2xlQmF0Y2hlZEF0dHJpYnV0ZQog ICAgICAgICAgICAgJGFjY2Vzc0NvbnRyb2wgLj0gIiB8IHY4OjpBTExfQ0FOX1dSSVRFIjsKICAg ICAgICAgfQogICAgIH0KLSAgICBpZiAoJGF0dHJFeHQtPnsiVjhEaXNhbGxvd1NoYWRvd2luZyJ9 KSB7CisgICAgaWYgKCRhdHRyRXh0LT57IlY4VW5mb3JnZWFibGUifSkgewogICAgICAgICAkYWNj ZXNzQ29udHJvbCAuPSAiIHwgdjg6OlBST0hJQklUU19PVkVSV1JJVElORyI7CiAgICAgfQogICAg ICRhY2Nlc3NDb250cm9sID0gInN0YXRpY19jYXN0PHY4OjpBY2Nlc3NDb250cm9sPigiIC4gJGFj Y2Vzc0NvbnRyb2wgLiAiKSI7CkBAIC0xOTc1LDcgKzE5NzUsNyBAQCBzdWIgR2VuZXJhdGVTaW5n bGVCYXRjaGVkQXR0cmlidXRlCiAgICAgaWYgKCRhdHRyRXh0LT57IkRvbnRFbnVtIn0pIHsKICAg ICAgICAgJHByb3BBdHRyIC49ICIgfCB2ODo6RG9udEVudW0iOwogICAgIH0KLSAgICBpZiAoJGF0 dHJFeHQtPnsiVjhEaXNhbGxvd1NoYWRvd2luZyJ9KSB7CisgICAgaWYgKCRhdHRyRXh0LT57IlY4 VW5mb3JnZWFibGUifSkgewogICAgICAgICAkcHJvcEF0dHIgLj0gIiB8IHY4OjpEb250RGVsZXRl IjsKICAgICB9CiAKQEAgLTIzNjYsNyArMjM2Niw3IEBAIHN1YiBHZW5lcmF0ZUltcGxlbWVudGF0 aW9uCiAgICAgbXkgQG5vcm1hbDsKICAgICBmb3JlYWNoIG15ICRhdHRyaWJ1dGUgKEAkYXR0cmli dXRlcykgewogCi0gICAgICAgIGlmICgkaW50ZXJmYWNlTmFtZSBlcSAiRE9NV2luZG93IiAmJiAk YXR0cmlidXRlLT5zaWduYXR1cmUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJWOERpc2FsbG93U2hh ZG93aW5nIn0pIHsKKyAgICAgICAgaWYgKCRpbnRlcmZhY2VOYW1lIGVxICJET01XaW5kb3ciICYm ICRhdHRyaWJ1dGUtPnNpZ25hdHVyZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IlY4VW5mb3JnZWFi bGUifSkgewogICAgICAgICAgICAgcHVzaChAZGlzYWxsb3dzU2hhZG93aW5nLCAkYXR0cmlidXRl KTsKICAgICAgICAgfSBlbHNpZiAoJGF0dHJpYnV0ZS0+c2lnbmF0dXJlLT5leHRlbmRlZEF0dHJp YnV0ZXMtPnsiRW5hYmxlZEF0UnVudGltZSJ9KSB7CiAgICAgICAgICAgICBwdXNoKEBlbmFibGVk QXRSdW50aW1lLCAkYXR0cmlidXRlKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uv RE9NV2luZG93LmlkbCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NV2luZG93LmlkbAppbmRleCA2 OTkyOTg2ODc4MGQ5NDc0YWNmZDMzNDdlZDM0ZjgxYWEyMDk0NTI5Li5iNmE0YmI0MzcwODU5MTFh ZWMxZWMxZmIwNGViOWZlYjRlZTY5YTRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdl L0RPTVdpbmRvdy5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9ET01XaW5kb3cuaWRsCkBA IC01NCw3ICs1NCw3IEBAIG1vZHVsZSB3aW5kb3cgewogICAgICAgICBhdHRyaWJ1dGUgW1JlcGxh Y2VhYmxlXSBOYXZpZ2F0b3IgbmF2aWdhdG9yOwogICAgICAgICBhdHRyaWJ1dGUgW1JlcGxhY2Vh YmxlXSBOYXZpZ2F0b3IgY2xpZW50SW5mb3JtYXRpb247CiAgICAgICAgIHJlYWRvbmx5IGF0dHJp YnV0ZSBDcnlwdG8gY3J5cHRvOwotICAgICAgICBhdHRyaWJ1dGUgW0RvTm90Q2hlY2tEb21haW5T ZWN1cml0eSwgSlNDQ3VzdG9tLCBWOEN1c3RvbVNldHRlciwgVjhEaXNhbGxvd1NoYWRvd2luZywg Q1BQQ3VzdG9tXSBMb2NhdGlvbiBsb2NhdGlvbjsKKyAgICAgICAgYXR0cmlidXRlIFtEb05vdENo ZWNrRG9tYWluU2VjdXJpdHksIEpTQ0N1c3RvbSwgVjhDdXN0b21TZXR0ZXIsIFY4VW5mb3JnZWFi bGUsIENQUEN1c3RvbV0gTG9jYXRpb24gbG9jYXRpb247CiAKICAgICAgICAgYXR0cmlidXRlIFtS ZXBsYWNlYWJsZSwgQ3VzdG9tR2V0dGVyLCBWOEN1c3RvbVNldHRlcl0gRXZlbnQgZXZlbnQ7CiAK QEAgLTEyOSwxMiArMTI5LDEyIEBAIG1vZHVsZSB3aW5kb3cgewogCiAgICAgICAgIC8vIFNlbGYg cmVmZXJlbnRpYWwgYXR0cmlidXRlcwogICAgICAgICBhdHRyaWJ1dGUgW1JlcGxhY2VhYmxlLCBE b05vdENoZWNrRG9tYWluU2VjdXJpdHlPbkdldF0gRE9NV2luZG93IHNlbGY7Ci0gICAgICAgIHJl YWRvbmx5IGF0dHJpYnV0ZSBbRG9Ob3RDaGVja0RvbWFpblNlY3VyaXR5LCBWOERpc2FsbG93U2hh ZG93aW5nXSBET01XaW5kb3cgd2luZG93OworICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgW0Rv Tm90Q2hlY2tEb21haW5TZWN1cml0eSwgVjhVbmZvcmdlYWJsZV0gRE9NV2luZG93IHdpbmRvdzsK ICAgICAgICAgYXR0cmlidXRlIFtSZXBsYWNlYWJsZSwgRG9Ob3RDaGVja0RvbWFpblNlY3VyaXR5 T25HZXRdIERPTVdpbmRvdyBmcmFtZXM7CiAKICAgICAgICAgYXR0cmlidXRlIFtSZXBsYWNlYWJs ZSwgRG9Ob3RDaGVja0RvbWFpblNlY3VyaXR5T25HZXQsIFY4Q3VzdG9tU2V0dGVyXSBET01XaW5k b3cgb3BlbmVyOwogICAgICAgICBhdHRyaWJ1dGUgW1JlcGxhY2VhYmxlLCBEb05vdENoZWNrRG9t YWluU2VjdXJpdHlPbkdldF0gRE9NV2luZG93IHBhcmVudDsKLSAgICAgICAgYXR0cmlidXRlIFtS ZXBsYWNlYWJsZSwgRG9Ob3RDaGVja0RvbWFpblNlY3VyaXR5T25HZXQsIFY4RGlzYWxsb3dTaGFk b3dpbmcsIFY4UmVhZE9ubHldIERPTVdpbmRvdyB0b3A7CisgICAgICAgIGF0dHJpYnV0ZSBbUmVw bGFjZWFibGUsIERvTm90Q2hlY2tEb21haW5TZWN1cml0eU9uR2V0LCBWOFVuZm9yZ2VhYmxlLCBW OFJlYWRPbmx5XSBET01XaW5kb3cgdG9wOwogCiAgICAgICAgIC8vIERPTSBMZXZlbCAyIEFic3Ry YWN0VmlldyBJbnRlcmZhY2UKICAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIERvY3VtZW50IGRv Y3VtZW50OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9Mb2NhdGlvbi5pZGwgYi9T b3VyY2UvV2ViQ29yZS9wYWdlL0xvY2F0aW9uLmlkbAppbmRleCAxODZjNDE3YmIzMjUxNTIyYWZj NGU2MWY0OGViODg0YWRjMDhkM2VmLi5kNTEwMDUyYzMzOTc0YzU0M2UxZmIzMGI1OTFmZTk0N2Rl ZDRjMWI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0xvY2F0aW9uLmlkbAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0xvY2F0aW9uLmlkbApAQCAtNDMsNyArNDMsNyBAQCBtb2R1 bGUgd2luZG93IHsKICAgICAgICAgT21pdENvbnN0cnVjdG9yCiAgICAgXSBMb2NhdGlvbiB7CiAj aWYgIWRlZmluZWQoTEFOR1VBR0VfQ1BQKSB8fCAhTEFOR1VBR0VfQ1BQCi0gICAgICAgICAgICAg ICAgIGF0dHJpYnV0ZSBbRG9Ob3RDaGVja0RvbWFpblNlY3VyaXR5T25TZXQsIEN1c3RvbVNldHRl ciwgVjhEaXNhbGxvd1NoYWRvd2luZ10gRE9NU3RyaW5nIGhyZWY7CisgICAgICAgICAgICAgICAg IGF0dHJpYnV0ZSBbRG9Ob3RDaGVja0RvbWFpblNlY3VyaXR5T25TZXQsIEN1c3RvbVNldHRlciwg VjhVbmZvcmdlYWJsZV0gRE9NU3RyaW5nIGhyZWY7CiAjZW5kaWYKIAogICAgICAgICBbQ3VzdG9t LCBWOE9uSW5zdGFuY2VdIHZvaWQgYXNzaWduKGluIFtPcHRpb25hbD1DYWxsV2l0aERlZmF1bHRW YWx1ZV0gRE9NU3RyaW5nIHVybCk7Cg==