77598 2012-02-01 20:51:09 -0800 Remove [GenerateConstructor] from IDL files 2012-02-07 12:22:52 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 77393 1 haraken haraken abarth darin ojan webkit.review.bot oldest_to_newest 547610 0 haraken 2012-02-01 20:51:09 -0800 [GenerateConstructor] is used in some IDL files but it is not implemented in code generators. I could not find any history about [GenerateConstructor] in code generators. Now we can remove them from the following IDL files: ./html/DOMSettableTokenList.idl ./html/DOMTokenList.idl ./webaudio/AudioPannerNode.idl ./dom/DOMStringList.idl ./svg/SVGFEConvolveMatrixElement.idl Maybe we want to replace it with [Constructor] eventually, but currently no tests are written for their constructors (e.g. "new DOMTokenList()"). So simply removing them would make sense. 547611 1 125070 haraken 2012-02-01 20:57:34 -0800 Created attachment 125070 Patch 547620 2 125070 abarth 2012-02-01 21:08:36 -0800 Comment on attachment 125070 Patch Ok. It's too bad you didn't find any history here. I suspect this got cargo-cult copied, at least to AudioPannerNode. 547656 3 125070 webkit.review.bot 2012-02-01 22:24:43 -0800 Comment on attachment 125070 Patch Clearing flags on attachment: 125070 Committed r106532: <http://trac.webkit.org/changeset/106532> 547657 4 webkit.review.bot 2012-02-01 22:24:48 -0800 All reviewed patches have been landed. Closing bug. 548315 5 darin 2012-02-02 18:20:47 -0800 GenerateConstructor was made obsolete by r52534 and I found that revision just by doing a search for GenerateConstructor in ChangeLog files. A good technique for researching past history. 548316 6 darin 2012-02-02 18:21:00 -0800 I mean http://trac.webkit.org/changeset/52534 548319 7 haraken 2012-02-02 18:22:24 -0800 Darin: Thanks for the info! (I was just doing "git blame CodeGeneratorJS.pm" for several revisions.) 551234 8 darin 2012-02-07 12:22:52 -0800 (In reply to comment #7) > Darin: Thanks for the info! (I was just doing "git blame CodeGeneratorJS.pm" for several revisions.) I guess this is a great example to bring up when people say “ChangeLog is no good; svn/git history is all you need and is way better anyway”. 125070 2012-02-01 20:57:34 -0800 2012-02-01 22:24:43 -0800 Patch bug-77598-20120202135733.patch text/plain 3823 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2NTE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODFiZWExNGVhYzFkYTcz MTcwNmU3ZmFmNzEwMjE2MjIzZTQ2ZjhmMi4uNDAyMmQzMDRjYzFkNzgyNTc0ZTQ0YWMzZjU5Y2Ri OTE2ZWNlNmQyNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEyLTAyLTAxICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZW1vdmUgW0dlbmVy YXRlQ29uc3RydWN0b3JdIGZyb20gSURMIGZpbGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NzU5OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtHZW5lcmF0ZUNvbnN0cnVjdG9yXSBpcyB1c2VkIGluIHNv bWUgSURMIGZpbGVzIGJ1dCBpdCBpcyBub3QgaW1wbGVtZW50ZWQKKyAgICAgICAgaW4gY29kZSBn ZW5lcmF0b3JzLiBJIGNvdWxkIG5vdCBmaW5kIGFueSBoaXN0b3J5IGFib3V0IFtHZW5lcmF0ZUNv bnN0cnVjdG9yXQorICAgICAgICBpbiBjb2RlIGdlbmVyYXRvcnMuIFRoaXMgcGF0Y2ggcmVtb3Zl cyB0aGVtIGZyb20gSURMIGZpbGVzLgorCisgICAgICAgIE1heWJlIHdlIHdhbnQgdG8gcmVwbGFj ZSBbR2VuZXJhdGVDb25zdHJ1Y3Rvcl0gd2l0aCBbQ29uc3RydWN0b3JdIGV2ZW50dWFsbHksCisg ICAgICAgIGJ1dCBjdXJyZW50bHkgbm8gdGVzdHMgYXJlIHdyaXR0ZW4gZm9yIHRoZWlyIGNvbnN0 cnVjdG9ycyAoZS5nLiAibmV3IERPTVRva2VuTGlzdCgpIikuCisgICAgICAgIFNvIHNpbXBseSBy ZW1vdmluZyB0aGVtIHdvdWxkIG1ha2Ugc2Vuc2UuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBO byBjaGFuZ2UgaW4gYmVoYXZpb3IuCisKKyAgICAgICAgKiBkb20vRE9NU3RyaW5nTGlzdC5pZGw6 CisgICAgICAgICogaHRtbC9ET01TZXR0YWJsZVRva2VuTGlzdC5pZGw6CisgICAgICAgICogaHRt bC9ET01Ub2tlbkxpc3QuaWRsOgorICAgICAgICAqIHN2Zy9TVkdGRUNvbnZvbHZlTWF0cml4RWxl bWVudC5pZGw6CisgICAgICAgICogd2ViYXVkaW8vQXVkaW9QYW5uZXJOb2RlLmlkbDoKKwogMjAx Mi0wMi0wMSAgQ2FpbyBNYXJjZWxvIGRlIE9saXZlaXJhIEZpbGhvICA8Y2Fpby5vbGl2ZWlyYUBv cGVuYm9zc2Eub3JnPgogCiAgICAgICAgIEF2b2lkIGNyZWF0aW5nIE5hbWVkTm9kZU1hcCB1bm5l Y2Vzc2FyaWx5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRE9NU3RyaW5nTGlzdC5p ZGwgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRE9NU3RyaW5nTGlzdC5pZGwKaW5kZXggNDNhZjgyNTlm MGMwY2FkYTYwZDk1OTk0ZDM3NWViNzY0YzU3ZGE0NC4uOGIzN2FhYWViMWM0YTAzMzJhMjYyNjlm OWMzNjI1ZGFmODY2MjVlMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0RPTVN0cmlu Z0xpc3QuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9ET01TdHJpbmdMaXN0LmlkbApAQCAt MjYsNyArMjYsNiBAQAogbW9kdWxlIGNvcmUgewogCiAgICAgaW50ZXJmYWNlIFsKLSAgICAgICAg R2VuZXJhdGVDb25zdHJ1Y3RvciwKICAgICAgICAgSGFzSW5kZXhHZXR0ZXIKICAgICBdIERPTVN0 cmluZ0xpc3QgewogICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgdW5zaWduZWQgbG9uZyBsZW5n dGg7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0RPTVNldHRhYmxlVG9rZW5MaXN0 LmlkbCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvRE9NU2V0dGFibGVUb2tlbkxpc3QuaWRsCmluZGV4 IDYyNjA2MjNlZWI0NjNkN2MzMGQ5NmY5MDI4MTkxMDAxZjcxYTMzOTEuLjAyYzY1MDBiMGM0Yjkz YjJkZTUzZDlmZjJiYmY0MDhlOTc2OTMzZGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0 bWwvRE9NU2V0dGFibGVUb2tlbkxpc3QuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvRE9N U2V0dGFibGVUb2tlbkxpc3QuaWRsCkBAIC0yNSw3ICsyNSw2IEBACiBtb2R1bGUgY29yZSB7CiAK ICAgICBpbnRlcmZhY2UgWwotICAgICAgICBHZW5lcmF0ZUNvbnN0cnVjdG9yLAogICAgICAgICBI YXNJbmRleEdldHRlciwKICAgICAgICAgR2VuZXJhdGVUb0pTCiAgICAgXSBET01TZXR0YWJsZVRv a2VuTGlzdCA6IERPTVRva2VuTGlzdCB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1s L0RPTVRva2VuTGlzdC5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0RPTVRva2VuTGlzdC5pZGwK aW5kZXggZjk0NDkxY2JlZDc2YjNjYzcwZTRjNDMyODdlNjA4YjM3YmM3M2JmNy4uMGJjYzQ4ODlm NTE0OGJkMGE2ZDk5Y2RjY2IzMzNmZGU3YjM1MzQzYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvaHRtbC9ET01Ub2tlbkxpc3QuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvRE9NVG9r ZW5MaXN0LmlkbApAQCAtMjYsNyArMjYsNiBAQCBtb2R1bGUgY29yZSB7CiAKICAgICBpbnRlcmZh Y2UgWwogICAgICAgICBHZW5lcmF0ZUlzUmVhY2hhYmxlPUltcGxFbGVtZW50Um9vdCwKLSAgICAg ICAgR2VuZXJhdGVDb25zdHJ1Y3RvciwKICAgICAgICAgSGFzSW5kZXhHZXR0ZXIKICAgICBdIERP TVRva2VuTGlzdCB7CiAgICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSB1bnNpZ25lZCBsb25nIGxl bmd0aDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdGRUNvbnZvbHZlTWF0cml4 RWxlbWVudC5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHRkVDb252b2x2ZU1hdHJpeEVsZW1l bnQuaWRsCmluZGV4IDVmZGM1NWMxNjcxMDU3NTVkNjBjNzM4NTAyNTlhZTA3NmNlYjVmMDAuLmQ4 ODBhYTc3ZWE4Y2RlMzExYWIyOTI5YTQ4MDI1MWQyYjhjOGMxNmUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3N2Zy9TVkdGRUNvbnZvbHZlTWF0cml4RWxlbWVudC5pZGwKKysrIGIvU291cmNl L1dlYkNvcmUvc3ZnL1NWR0ZFQ29udm9sdmVNYXRyaXhFbGVtZW50LmlkbApAQCAtMjcsNyArMjcs NiBAQCBtb2R1bGUgc3ZnIHsKIAogICAgIGludGVyZmFjZSBbCiAgICAgICAgIENvbmRpdGlvbmFs PVNWRyZGSUxURVJTLAotICAgICAgICBHZW5lcmF0ZUNvbnN0cnVjdG9yLAogICAgICAgICBEb250 Q2hlY2tFbnVtcwogICAgIF0gU1ZHRkVDb252b2x2ZU1hdHJpeEVsZW1lbnQgOiBTVkdFbGVtZW50 LAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBTVkdGaWx0ZXJQcmltaXRpdmVT dGFuZGFyZEF0dHJpYnV0ZXMgewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvd2ViYXVkaW8v QXVkaW9QYW5uZXJOb2RlLmlkbCBiL1NvdXJjZS9XZWJDb3JlL3dlYmF1ZGlvL0F1ZGlvUGFubmVy Tm9kZS5pZGwKaW5kZXggMmRiMDkzZDdiNTAzYWExZTljYzQ1ZjY0YTcxN2EwYzE4NDRiYWRkNy4u MmFiZTUzYTA0MmViYTE1ZWFjNDMzZGU3NjhhZDYxOTZkZDU4NTY5MyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvd2ViYXVkaW8vQXVkaW9QYW5uZXJOb2RlLmlkbAorKysgYi9Tb3VyY2UvV2Vi Q29yZS93ZWJhdWRpby9BdWRpb1Bhbm5lck5vZGUuaWRsCkBAIC0yNSw3ICsyNSw2IEBACiBtb2R1 bGUgYXVkaW8gewogICAgIGludGVyZmFjZSBbCiAgICAgICAgIENvbmRpdGlvbmFsPVdFQl9BVURJ TywKLSAgICAgICAgR2VuZXJhdGVDb25zdHJ1Y3RvciwKICAgICAgICAgR2VuZXJhdGVUb0pTCiAg ICAgXSBBdWRpb1Bhbm5lck5vZGUgOiBBdWRpb05vZGUgewogICAgICAgICAvLyBQYW5uaW5nIG1v ZGVsCg==